http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJ-923 Clojure <p>In general Clojure's number types can be read prefixed with either a +<br/> or - and this seems to work correctly for reading integers and floats.<br/> In the case of ratios however things break down when ratios are<br/> prefixed with a +.</p> <p>The ratio pattern in LispReader.java does match on ratios starting<br/> with both + and - but matchNumber fails on ratios prefixed with +<br/> because it ends up calling "new BigInteger(m.group(1))" and it turns<br/> out the constructor for BigInteger has no problems with negative<br/> numbers but it doesn't like numbers prefixed by a +.</p> CLJ-923

Reading ratios prefixed by + is not working

Defect Major Closed Completed Unassigned Cosmin Stejerean Fri, 3 Feb 2012 18:06:54 -0600 Sat, 18 Aug 2012 07:12:53 -0500 Sat, 18 Aug 2012 07:12:52 -0500 Release 1.2 Release 1.3 Release 1.4 Release 1.5 0 1 <p>added patch with fix and tests</p> <p>changes to the reader tests on master cause 0001-added-tests-for-reading-ratios-and-fixed-reading-of-.patch to no longer apply cleanly</p> <p>clj-923-reading-ratios-prefixed-by-plus-patch.txt applies cleanly to latest as of Feb 24, 2012 (2:20 PM PST <img class="emoticon" src="http://dev.clojure.org/jira/images/icons/emoticons/smile.gif" height="20" width="20" align="absmiddle" alt="" border="0"/></p> <p>clj-923-reading-ratios-prefixed-by-plus-patch2.txt still semantically same as Cosmin's original patch, except it applies, builds, and tests cleanly on latest master as of Mar 23, 2012. Context lines around patch must have changed recently.</p> <p>Thanks for updating the patch. I've removed the original to make it clear which one we need.</p> <p>Patch applies cleanly against 4004d267e124f12b65b0d7fb6522f32a75e3c4fb. Submitter is a confirmed CA signer.</p> Approval Ok Global Rank Patch Code and Test