http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJ-931 Clojure <p>While clojure.test/are is a very useful macro, it has one major flaw. If the assertion is syntactically incorrect, the test succeeds. Take this testcase:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">(deftest broken-test (are [a b c] (= a b c) 1 1))</pre> </div></div> <p>See the error? The are form takes three values, but I have provided only two. The test simply passes.</p> <p>Latest patch checks the number of arguments to <tt>are</tt> and throws an exception if they don't match.</p> CLJ-931

Syntactically broken clojure.test/are tests succeed

Defect Minor Closed Completed Stuart Sierra Tassilo Horn Thu, 16 Feb 2012 10:40:15 -0600 Fri, 23 Mar 2012 08:40:35 -0500 Fri, 23 Mar 2012 08:40:35 -0500 Release 1.3 Release 1.4 1 2 <p>Is this the same issue as <a href="http://dev.clojure.org/jira/browse/CLJ-806" title="clojure.test/are does not fail with insufficient arguments"><del>CLJ-806</del></a>? If so, it might be nice to close one with a comment that it is a duplicate of the other. Given <a href="http://dev.clojure.org/jira/browse/CLJ-806" title="clojure.test/are does not fail with insufficient arguments"><del>CLJ-806</del></a> has no patch, and this one does, perhaps preferable to close <a href="http://dev.clojure.org/jira/browse/CLJ-806" title="clojure.test/are does not fail with insufficient arguments"><del>CLJ-806</del></a>?</p> <p>John, you are right. I didn't find it searching for "test are" earlier today; now I do.</p> <p>I did as you've suggested: closed <a href="http://dev.clojure.org/jira/browse/CLJ-806" title="clojure.test/are does not fail with insufficient arguments"><del>CLJ-806</del></a> in favour of this one.</p> <p>I've tested this patch by hand, and it seems to work fine, and the code looks correct. I have tried several ways to add a unit test to verify this fix, but haven't found the right way to do it, if there is one.</p> <p>I'm working on it... <img class="emoticon" src="http://dev.clojure.org/jira/images/icons/emoticons/smile.gif" height="20" width="20" align="absmiddle" alt="" border="0"/></p> <p>This patch obsoletes the former on (I'm gonna delete the old one). It includes:</p> <ul class="alternate" type="square"> <li>an extended fix that catches also the zero-arg given case</li> </ul> <ul class="alternate" type="square"> <li>a fix for a testcase in test/clojure/test_clojure/java_interop.clj which only passed because of the bug this issue is all about</li> </ul> <ul class="alternate" type="square"> <li>a currently #_-disabled test case for testing `are'. It is disabled, because it fails when run with "ant test". However, it works just fine when run inside some REPL. I presume that's because ant runs inside its own JVM instance and thus makes catching exceptions from macroexpand/eval forms impossible?!?</li> </ul> <p>Another minor update. Now (are [] true) is allowed (but meaningless). In the previous patch, you got a "divide by zero" in this case.</p> <p>Patch 0001-Fix-<a href="http://dev.clojure.org/jira/browse/CLJ-931" title="Syntactically broken clojure.test/are tests succeed"><del>CLJ-931</del></a>-Syntactically-broken-clojure.test-are-te.patch applies, builds, and tests cleanly as of March 9, 2012 latest master. One author Tassilo has signed CA.</p> <p>I can't make the test work either. The patch looks good. Just remove the broken test instead of leaving it commented out.</p> <p>clj-931-error-on-bad-are-syntax-patch2.txt same as previous one, except removes commented out test. Applies, builds, and tests cleanly to latest master.</p> <p>Screened.</p> Approval Ok Global Rank Patch Code Waiting On richhickey