http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJ-935 Clojure <p>clojure.string/triml and trimr use Character/isWhitespace to determine whether a character is whitespace, but trim uses some other definition of white space character. For example:</p> <p>user=&gt; (use 'clojure.string)<br/> nil<br/> user=&gt; (def s " \u2002 foo")<br/> #'user/s<br/> user=&gt; (trim s)<br/> "? foo"<br/> user=&gt; (triml s)<br/> "foo"</p> <p>The attached patch changes trim to use Character/isWhitespace. I suppose other possibilities are to change triml and trimr to use trim's notion of whitespace, whatever that is, or to just leave these functions inconsistent with each other. It does seem that it would be a nice property that (trim s) is equal to (triml (trimr s)) for all strings.</p> <p>The patch also changes triml to only call .length on s once.</p> CLJ-935

clojure.string/trim uses different defn of whitespace as triml, trimr

Defect Minor Open Unresolved Aaron Bedra Andy Fingerhut Tue, 21 Feb 2012 13:29:54 -0600 Thu, 11 Apr 2013 17:36:32 -0500 Release 1.6 Release 1.6 0 2 <p>Question for Rich: do we want to be consistent across the different trim fns (per this patch) or consistent with Java, which uses one definition of whitespace in Character/isWhitespace, and a different definition in String/trim?</p> <p>Question for Andy: why the (int ...) forms, when Clojure only works with primitive longs?</p> <p>Answer for Stuart: Looks like I was preserving the (int ...) form that was in triml before, perhaps somewhat mindlessly. Depending on Rich's answer, I can update the patch if desired.</p> <p>Bump on the discussion. This ticket seems blocked until we make a decision.</p> Global Rank Patch Code and Test