http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJ-960 Clojure <p>I've begun working on implementing SourceMaps for ClojureScript. For an overview of SourceMaps, see: <a href="http://www.html5rocks.com/en/tutorials/developertools/sourcemaps/">http://www.html5rocks.com/en/tutorials/developertools/sourcemaps/</a> For discussion of the feature in ClojureScript, see: <a href="https://groups.google.com/d/topic/clojure-dev/zgmXO2iM1JQ/discussion">https://groups.google.com/d/topic/clojure-dev/zgmXO2iM1JQ/discussion</a></p> <p>In order to produce accurate source maps, I need column information in addition to line information from the Clojure reader.</p> <p>I've made the necessary enhancement to LispReader, etc. but have some cleanup and testing left to do. I'd also like a sanity check from the core team before attaching a formal patch. You can find my work in progress here: <a href="https://github.com/brandonbloom/clojure/compare/columns">https://github.com/brandonbloom/clojure/compare/columns</a></p> CLJ-960

Capture :column metadata (needed for ClojureScript source maps)

Enhancement Major Closed Completed Unassigned Brandon Bloom patch Tue, 27 Mar 2012 00:56:10 -0500 Sat, 20 Oct 2012 09:53:42 -0500 Sat, 20 Oct 2012 09:53:42 -0500 Release 1.5 2 4 <p>You need to attach a patch so this can be assessed. Thanks!</p> <p>Sorry David! I added a patch a while ago but forgot to add the patch label(s?) as well as leave a comment.</p> <p>The patch may be out of date now, but I haven't checked. Hopefully the prescreening process will pick it up automatically run the tests.</p> <p>Yes, Brandon, your patch has been on the list of prescreened patches since April 15. It has always applied and built cleanly during that time. That patch label is nice to have for certain JIRA report filters, but isn't necessary for the prescreening process to pick it up.</p> <p>v2 now applies against the current master (191b05f1). The original patch seemed to be broken from a whitespace perspective, which was making it difficult to apply--even in a 3-way merge. The only real conflict was in Compiler.java where a "final int line" was added to CompilerException. All the tests passed.</p> <p>It looks like the line field was added to CompilerException in commit 89245c68, but that commit doesn't use it for anything. Maybe a later commit uses it? Also, if we want to keep that field, can we also add a column field for patch v3?</p> <p>This patch is an enhancement. In order for this one to make any movement I believe it will need a design page outlining the problem, what this solves / alternatives.</p> <p><a href="http://dev.clojure.org/display/design/Compiler+tracking+of+columns">http://dev.clojure.org/display/design/Compiler+tracking+of+columns</a></p> <p>I added a design page, but it seems like overkill. This is a straightforward enhancement...</p> <p>I've applied the v2 patch (thanks!), but before we close the ticket can we please get a patch comprising some tests?</p> <p>Attached <a href="http://dev.clojure.org/jira/browse/CLJ-960" title="Capture :column metadata (needed for ClojureScript source maps)"><del>CLJ-960</del></a>-tests.diff to verify <tt>:line</tt> and <tt>:column</tt> metadata as now provided by <tt>LineNumberingPushbackReader</tt>.</p> <p>The tests are a little fragile (exact map comparison) and so will break if the reader ever does more things. In library and app projects I write tests like this using core.match, but that isn't available as a build dependency here. </p> <p>Marking screened anyway.</p> Approval Ok Global Rank Patch Code and Test