Clojure JIRA http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 [CLJS-183] The pop function in PersistentVector is buggy http://dev.clojure.org/jira/browse/CLJS-183 ClojureScript <p>Example:</p> <p>(conj (pop <span class="error">&#91;1 2&#93;</span>) 3) =&gt; <span class="error">&#91;1 2&#93;</span></p> CLJS-183 The pop function in PersistentVector is buggy Defect Major Resolved Completed Unassigned Erik Ouchterlony Wed, 18 Apr 2012 09:47:53 -0500 Thu, 19 Apr 2012 22:31:57 -0500 Thu, 19 Apr 2012 22:31:57 -0500 0 1 <p>this patch fixes pop</p> <p>Hi,</p> <p>good catch, but why not simply:</p> <p>(PersistentVector. meta (dec cnt) shift root (.slice tail 0 -1))<br/> ;; you don't need to aclone and splice, .slice returns a new array</p> <p>right, using slice is even faster.<br/> patch updated</p> <p>Nice, thank you!</p> <p>Could you please add a test that covers the issue?</p> <p>e.g. </p> <p>(assert (= (vec (range 33))<br/> (-&gt; (vec (range 33))<br/> (pop)<br/> (pop)<br/> (conj 31)<br/> (conj 32))))</p> <p>sure, here it is</p> <p>Fixed, <a href="https://github.com/clojure/clojurescript/commit/053b7fd9cbb0a24617592f490893d6a746e54ec7">https://github.com/clojure/clojurescript/commit/053b7fd9cbb0a24617592f490893d6a746e54ec7</a></p> Global Rank