http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJS-204 ClojureScript <p>The sort function (and thus sort-by) do not seem to be behaving as they would in normal Clojure. For example, in my ClojureScript REPL I have:</p> <p>ClojureScript:cljs.user&gt; (def values (list <span class="error">&#91;-11 10&#93;</span> <span class="error">&#91;-8 12&#93;</span> <span class="error">&#91;-15 -4&#93;</span> <span class="error">&#91;4 5&#93;</span>))<br/> (<span class="error">&#91;-11 10&#93;</span> <span class="error">&#91;-8 12&#93;</span> <span class="error">&#91;-15 -4&#93;</span> <span class="error">&#91;4 5&#93;</span>)<br/> ClojureScript:cljs.user&gt; (sort values)<br/> (<span class="error">&#91;-11 10&#93;</span> <span class="error">&#91;-15 -4&#93;</span> <span class="error">&#91;-8 12&#93;</span> <span class="error">&#91;4 5&#93;</span>)</p> <p>But in the Clojure REPL, you get what one would expect:<br/> user=&gt; (def values (list <span class="error">&#91;-11 10&#93;</span> <span class="error">&#91;-8 12&#93;</span> <span class="error">&#91;-15 -4&#93;</span> <span class="error">&#91;4 5&#93;</span>))<br/> #'setback.core/values<br/> user=&gt; (sort values)<br/> (<span class="error">&#91;-15 -4&#93;</span> <span class="error">&#91;-11 10&#93;</span> <span class="error">&#91;-8 12&#93;</span> <span class="error">&#91;4 5&#93;</span>)</p> <p>I have only noticed this bug for sorting vectors, since in Clojure vectors are sorted position by position.</p> Mac OS X, recently cloned ClojureScript repository CLJS-204

Bug in sort

Defect Critical Resolved Completed Hubert Iwaniuk Sean Nilan clojure Wed, 25 Apr 2012 08:15:16 -0500 Fri, 18 May 2012 19:28:13 -0500 Fri, 18 May 2012 19:28:13 -0500 0 2 <p>The bug is actually in the compare function, which uses the google.array.defaultCompare as the compare function for vectors. A simple patch such as below could fix the problem:</p> <p>(defn vector-compare<br/> <span class="error">&#91;v1 v2&#93;</span><br/> (cond<br/> (and (empty? v1) (empty? v2))<br/> 0<br/> (empty? v1)<br/> -1<br/> (empty? v2)<br/> 1<br/> :default<br/> (let [cmp (apply compare (map first <span class="error">&#91;v1 v2&#93;</span>))]<br/> (if (zero? cmp)<br/> (vector-compare (rest v1) (rest v2))<br/> cmp))))</p> <p>(defn compare<br/> "Comparator. Returns a negative number, zero, or a positive number<br/> when x is logically 'less than', 'equal to', or 'greater than'<br/> y. Uses google.array.defaultCompare for objects of the same type<br/> and special-cases nil to be less than any other object."<br/> <span class="error">&#91;x y&#93;</span><br/> (cond<br/> (and (vector? x) (vector? y)) (vector-compare x y)<br/> (identical? (type x) (type y)) (garray/defaultCompare x y)<br/> (nil? x) -1<br/> (nil? y) 1<br/> :else (throw (js/Error. "compare on non-nil objects of different types"))))</p> <p>Thanks. We need a IComparable protocol.</p> <p>IComparable protocol, implementations and tests.</p> <p>Can we squash the commits here? Thanks!</p> <p>Commits squashed.</p> <p>Why do we need to extend IComparable to strings, arrays, boolean, and number?</p> <p>booleans - are supported in clj<br/> number - special case in clj, not sure if it brings any speed increase, will test with jsperf<br/> arrays - are supported in clj<br/> strings - to support symbols and keywords</p> <p>Simplified version, just to solve comparing vectors.</p> <p>fixed, <a href="http://github.com/clojure/clojurescript/commit/43ff1c4adea322e6edc1d368ff128f2ad47406a5">http://github.com/clojure/clojurescript/commit/43ff1c4adea322e6edc1d368ff128f2ad47406a5</a></p> Global Rank Patch Code and Test