http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJS-294 ClojureScript <p>All of the symbols in the abstract syntax tree are munged according for use in JavaScript. This is a problem because it means the AST is lossy and new compiler backends may have differing munging rules.</p> <p>The attached patch removes all munging from the analysis phase and moves it into the emit phase. The emit phase is backend specific, so it's an appropriate place for munging.</p> CLJS-294

AST contains munged symbols

Defect Major Resolved Completed Unassigned Brandon Bloom patch patch, Sat, 2 Jun 2012 18:20:49 -0500 Sun, 3 Jun 2012 17:12:28 -0500 Sun, 3 Jun 2012 17:12:28 -0500 0 2 <p>It may be better to formalize munging as there are some other bits different backend must do, Raphael Amiard has taken some notes on this here: <a href="http://github.com/raph-amiard/clojurescript/wiki/How-to-modularize-parse-analyze-phases-in-the-compiler">http://github.com/raph-amiard/clojurescript/wiki/How-to-modularize-parse-analyze-phases-in-the-compiler</a></p> <p>I agree that we'll eventually want to formalize munging. However, whenever that happens, it should still happen <b>after</b> the AST is constructed. Munging shouldn't happen at all if you're doing refactoring or the like, where you query the AST. Munging is code generation concern.</p> <p>Prior to my patch, the AST needs to support both :name and :name-sym keys to get around the fact that the :name key loses fidelity of the original symbol. This complects the Clojure-specific parse phase with target-specific needs. The patch renames :name-sym to replace :name.</p> <p>I read Raphael's notes and he and I have a email thread going on too. With that in mind, this is a step towards untangling the architectural layers of the compiler. By better segregating parse from emit, it will be easier to break the analyzer out from the code generation backend.</p> <p>fixed, <a href="http://github.com/clojure/clojurescript/commit/a9d1dc6a043e8a6367492a2cf8622f73f2a947f9">http://github.com/clojure/clojurescript/commit/a9d1dc6a043e8a6367492a2cf8622f73f2a947f9</a></p> Global Rank Patch Code