Clojure JIRA http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 [CLJS-300] RegExp objects print incorrectly http://dev.clojure.org/jira/browse/CLJS-300 ClojureScript <p>#"x" is currently printing as #&lt;/x/&gt;</p> <p>js/RegExp needs an IPrintable implementation: (-pr-seq <span class="error">&#91;re _&#93;</span> (list "#\"" (.-source re) "\""))</p> <p>Unfortunately, this is blocked by the same GClosure issue as <a href="http://dev.clojure.org/jira/browse/CLJS-68">http://dev.clojure.org/jira/browse/CLJS-68</a></p> CLJS-300 RegExp objects print incorrectly Defect Minor Resolved Completed Unassigned Brandon Bloom Mon, 4 Jun 2012 15:43:37 -0500 Mon, 4 Jun 2012 23:52:42 -0500 Mon, 4 Jun 2012 23:52:42 -0500 0 1 <p>The simplest solution is to add a RegExp case to pr-seq.</p> <p>That was surprisingly not that simple...</p> <p>(instance? js/RegExp obj) compiles to `cljs.core.instance_QMARK_.call(null, RegExp, obj)` which also triggers the GClosure warning. So I thought I could inline `instance?` with a macro, but the instanceof operator's operands are in reverse order of instance?'s arguments. To preserve evaluation order, the expansion would be `(let <a href="#~t">t# ~t</a> (<sub>'js* "(</sub>{} instanceof ~{})" ~o t#))) however even that triggers the warning because the output leaves RegExp as an expression by itself again. I wound up just special-casing simple instanceof checks against symbols in the macro.</p> <p>Attached patch fixes printing of RegExp objects and also enables calling (instance? js/RegExp X) without triggering the warning. Sadly, any more complex expression which evaluates to js/RegExp, or any higher order usage of instance? against that type will still trigger the warning.</p> <p>As discussed, will make a separate ticket for inlining 'instance? and will (defn regexp? <span class="error">&#91;o&#93;</span> (js* "~{o} instanceof RegExp"))</p> <p>Updated with simplified patch</p> <p>fixed, <a href="http://github.com/clojure/clojurescript/commit/63cd8ce9c7c9a8864deb676f2b855b8018698d57">http://github.com/clojure/clojurescript/commit/63cd8ce9c7c9a8864deb676f2b855b8018698d57</a></p> Global Rank Patch Code and Test