http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJS-321 ClojureScript <p>Attached patch implements with-out-str macro in terms of goog.string.StringBuffer and <b>print-fn</b> via .append</p> <p>The attached patch also fixes <a href="http://dev.clojure.org/jira/browse/CLJS-319" title="missing spaces when printing the same thing more than once"><del>CLJS-319</del></a></p> CLJS-321

Support with-out-str

Enhancement Major Resolved Completed Paul deGrandis Brandon Bloom patch patch, Mon, 18 Jun 2012 03:15:53 -0500 Mon, 22 Oct 2012 18:06:13 -0500 Mon, 22 Oct 2012 18:06:13 -0500 0 1 <p>Patch looks mostly OK. Did you do any basic benchmarking? It would be nice to know that this doesn't slow down printing of Clojure objects.</p> <p>Yes, I ran this:</p> <p>(time (dotimes <span class="error">&#91;i 5000&#93;</span> (prn-str {:foo <span class="error">&#91;1 &quot;two&quot; &#39;three&#93;</span>}))</p> <p>before patch: 29988 msecs<br/> after patch: 28751 msecs</p> <p>Effectively identical.</p> <p>on V8? JSC? SM?</p> <p>I had run it in a browser repl, but I forget which. I added a benchmark and re-ran it in all three. It was a tiny bit slower, so I went to investigate and discovered that I haven't the slightest clue how to predict or interpret Javascript engine performance numbers. Hell, Chrome's console seems to have completely random performance, where as the Node.js repl seems to be more consistent. I'll get my shit together and see if I can fix this up. Hopefully will have time to look at it tomorrow.</p> <p>jsperf.com was a great help to me when prototyping PersistentVector's first CLJS implementation</p> <p>it's very-very handy and easy to use and keep updated if necessary</p> <p>e.g.<br/> <a href="http://jsperf.com/persistentvector-norecur-js/12">http://jsperf.com/persistentvector-norecur-js/12</a></p> <p>Thanks Brandon, let's hold off on this one until we can resolve <a href="http://dev.clojure.org/jira/browse/CLJS-340" title="improve pr-str performance"><del>CLJS-340</del></a></p> <p>I attached an updated patch (that I'm using internally for a personal project) of just the with-out-str macro code.</p> <p>Thanks Paul. Could we get a patch with tests included?</p> <p>No problem - on it right now.</p> <p>Updated with one additional piece I needed to bring over from my branch (:dynamic on <b>print-fn</b>) and two tests: one using print and one using the raw <b>print-fn</b>.</p> <p>fixed, <a href="http://github.com/clojure/clojurescript/commit/eab6032e6ba22571e5c4f821707bf5de8075e757">http://github.com/clojure/clojurescript/commit/eab6032e6ba22571e5c4f821707bf5de8075e757</a></p> Global Rank Patch Code and Test