http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJS-400 ClojureScript <p>The contract of <tt>goog.string.quote</tt> is to produce a "valid JavaScript string", which can end up being quite different from what is expected by e.g. the Clojure reader and other edn-compatible readers. This has been discussed in a variety of threads/issues:</p> <ul> <li><a href="https://groups.google.com/forum/#!msg/clojure/Kl3WVtEE3FY/N1VEGHf8C3AJ">https://groups.google.com/forum/#!msg/clojure/Kl3WVtEE3FY/N1VEGHf8C3AJ</a></li> <li><a href="http://groups.google.com/group/clojure-dev/browse_thread/thread/3114566c2f13f520">http://groups.google.com/group/clojure-dev/browse_thread/thread/3114566c2f13f520</a></li> <li><a href="http://groups.google.com/group/clojure/browse_thread/thread/f05a78432e0084db">http://groups.google.com/group/clojure/browse_thread/thread/f05a78432e0084db</a></li> <li><a href="http://dev.clojure.org/jira/browse/CLJ-1025">http://dev.clojure.org/jira/browse/CLJ-1025</a></li> <li><a href="https://github.com/ibdknox/pinot/issues/16">https://github.com/ibdknox/pinot/issues/16</a></li> </ul> <p>The most significant issue is that characters &gt; 127 and &lt; 256 are outputted with an <tt>\x..</tt> escape sequence, which no other reader supports. Further, other Unicode characters are <em>always</em> escaped using the <tt>\u....</tt> notation; this is not a functional difference, but can be a stumbling block, e.g. when viewing data that had been <tt>pr-str</tt>'d that contains high codepoint characters.</p> <p>The most straightforward fix is to take control of printed string escaping to ensure the results conform first to the expectations of existing readers (primarily Clojure's and ClojureScript's), and to the formal <span class="error">&#91;edn specification&#93;</span>(<a href="https://github.com/edn-format/edn/">https://github.com/edn-format/edn/</a>) as that matures.</p> <p>This ticket supersedes <a href="http://dev.clojure.org/jira/browse/CLJ-1025">http://dev.clojure.org/jira/browse/CLJ-1025</a>.</p> CLJS-400

Stop using goog.string.quote to escape strings for printing

Defect Major Resolved Completed Unassigned Chas Emerick Fri, 19 Oct 2012 19:47:40 -0500 Mon, 22 Oct 2012 18:06:32 -0500 Mon, 22 Oct 2012 18:06:32 -0500 0 2 <p>Patch attached</p> <p>Thanks. Performance things - can we avoid instantiating the RegExp everytime, can we switch char-escapes to a JS object and use aget?</p> <p>Patch <a href="http://dev.clojure.org/jira/browse/CLJS-400" title="Stop using goog.string.quote to escape strings for printing"><del>CLJS-400</del></a>-fast.diff added with suggested perf tweaks. Please excuse my (still) absolutely shoddy cljs instincts.</p> <p>Using the let won't work here. That will be emit top-levels that are <b>not</b> namespaced. Edge case in the compiler that should be sorted out on another ticket. Just define top levels for these thanks.</p> <p>New patch attached with requested changes, <a href="http://dev.clojure.org/jira/browse/CLJS-400" title="Stop using goog.string.quote to escape strings for printing"><del>CLJS-400</del></a>.diff.</p> <p>fixed, <a href="http://github.com/clojure/clojurescript/commit/3b32345966a65f66e49563a3a40a2877d0435c5d">http://github.com/clojure/clojurescript/commit/3b32345966a65f66e49563a3a40a2877d0435c5d</a></p> Global Rank Patch Code and Test