http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJS-418 ClojureScript <p>Temporary fix to this issue: Add the G.Closure Library third-party extensions as a project dependency. </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">;; In :dependencies vector of Leiningen's project.clj [org.clojure/google-closure-library-third-party <span class="code-quote">"0.0-2029"</span>]</pre> </div></div> <hr /> <p>We currently distribute the Google Closure Library in two separate JARs: the main library and the third-party extensions. We do this because the third-party extensions are covered by different licenses.</p> <p>But, as it turns out, various classes in the main library have explicit dependencies on things in the third-party extensions. See See also this <a href="https://groups.google.com/d/msg/closure-library-discuss/4DG-XJn0s4E/i7nlq84V41kJ">G.Closure mailing list discussion</a>.</p> <p>As a result, the ClojureScript browser-connected REPL has a transitive dependency on the Google Closure Library third-party extensions. This manifests as an error in script/cljsc and a NullPointerException in lein-cljsbuild.</p> <p>See the <a href="https://groups.google.com/d/msg/clojure/kzzBoCZiAx0/W_wlfiSTMZgJ">initial Clojure-dev mailing list discussion</a> and <a href="https://groups.google.com/d/msg/clojure/SFX4m0h6Z0g/gLLGOJFhSwsJ">discussion of this ticket</a>.</p> <p>See also <a href="https://github.com/emezeske/lein-cljsbuild/issues/155">lein-cljsbuild issue #155</a>.</p> <p>It seems that the dependency on third-party extensions is unavoidable. There are several possible fixes:</p> <p>1. Release a new G.Closure Library JAR with a <b>declared dependency</b> on the third-party extensions JAR. This best reflects the <b>actual</b> dependency relationships.</p> <p>2. Release a new G.Closure Library JAR with the third-party extensions included in the JAR. This would make it harder to exclude the third-party-licensed code from projects which do not actually require it.</p> <p>3. Release a new version of ClojureScript with a declared dependency on the third-party extensions JAR. This makes the dependency more visible to ClojureScript developers.</p> <p>Regardless of the approach taken, developers can always use explicit dependencies/exclusions to choose which version of the G.Closure library to include in their projects.</p> CLJS-418

Unspecified dependency on google-closure-library-third-party

Defect Major Resolved Completed Stuart Sierra Stuart Sierra Fri, 16 Nov 2012 18:50:02 -0600 Sat, 16 Feb 2013 14:59:54 -0600 Sat, 16 Feb 2013 14:59:54 -0600 3 3 <p>Attached patch implements option 1</p> <p>The generated closure-library depends on the old clojure-library-third-party.<br/> Still, I would recommend releasing the -2 version of third-party too, in case someone includes third-party by c&amp;p the library version.</p> <p>I added a workaround for this so that I can release lein-cljsbuild without breaking every single project that uses it: <a href="https://github.com/emezeske/lein-cljsbuild/issues/163">https://github.com/emezeske/lein-cljsbuild/issues/163</a> .</p> <p>I would like to revert this workaround ASAP. I'm going to do a bad job of maintaining the right version of the third party libraries, and it will cause problems down the road.</p> <p>Option 1 is proper, 3 is acceptable. <b>Any</b> solution will do though; drove myself nuts with this today for longer than I'd like to admit before I discovered this ticket.</p> <p>Is everyone cool with option 1? It would be nice to resolve this one soon as people are running into non-working browser REPLs.</p> <p>+1 for option 1.</p> <p>Deployed new version of Google Closure library to Sonatype OSS today. Please try it out.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">[org.clojure/google-closure-library <span class="code-quote">"0.0-2029-2"</span>]</pre> </div></div> <p>This release declares an explicit dependency from google-closure-library on google-closure-library-third-party (Option 1 in the ticket description).</p> <p>It will be available in the Maven Central repository within 24 hours. Until then, you can get it from the Sonatype repository with these instructions:<br/> <a href="http://dev.clojure.org/display/doc/Maven+Settings+and+Repositories">http://dev.clojure.org/display/doc/Maven+Settings+and+Repositories</a></p> <p>If it works, we can update the ClojureScript POM to depend on it.</p> <p>-S</p> <p>pom.template updated in commit <a href="https://github.com/clojure/clojurescript/commit/f2e0d9050a1b3244b23d2be16ec34af60061121f">f2e0d9050a1b</a></p> Global Rank