Clojure JIRA

Clojure JIRA http://dev.clojure.org/jira This file is an XML representation of an issue en-us

4.4

649

25-07-2011

[CLJS-464] `get-in` not behaving like Clojure when accessing non-existing inner maps http://dev.clojure.org/jira/browse/CLJS-464 ClojureScript <p>In Clojurescript:<br/> (get-in {:a {:b 1}} <span class="error">[:a :b :c]</span>)<br/> => Error: 1 is not an instance of ILookup</p> <p>In Clojure:<br/> (get-in {:a {:b 1}} <span class="error">[:a :b :c]</span>)<br/> => nil</p> Gentoo 64, oracle-jvm CLJS-464

`get-in` not behaving like Clojure when accessing non-existing inner maps

Defect Major Resolved Completed Unassigned Roman Gonzalez bug Sat, 26 Jan 2013 22:58:15 -0600 Mon, 28 Jan 2013 22:39:13 -0600 Mon, 28 Jan 2013 22:39:13 -0600 0 1 <p>Code and Test patch v1</p> <p>Isn't this a duplicate of <a href="http://dev.clojure.org/jira/browse/CLJS-458" title="get-in throws exception when key-list contains key that doesn't satisfy ILookup"><del>CLJS-458</del></a>? That's been fixed in master.</p> <p>Hey David, </p> <p>Thanks for your prompt reply, I tested latest version of github's master with the test-case I added and got this error.</p> <p>```shell<br/> Testing with V8 <br/> out/core-advanced-test.js:1: Error: No protocol method ILookup.-lookup defined for type number: 2 <br/> function d(a){throw a;}var e=void 0,f=!0,g=null,h=!1;function aa(){return func <br/> ^ <br/> Error: No protocol method ILookup.-lookup defined for type number: 2 <br/> at Error (<anonymous>) <br/> at t (out/core-advanced-test.js:5:962) <br/> at Function.ab <span class="error">[as c]</span> (out/core-advanced-test.js:11:239) <br/> at Function.wd <span class="error">[as c]</span> (out/core-advanced-test.js:49:60) <br/> at Function.Dc <span class="error">[as h]</span> (out/core-advanced-test.js:36:58) <br/> at Nk.l.Da (out/core-advanced-test.js:176:128) <br/> at Function.Bb <span class="error">[as h]</span> (out/core-advanced-test.js:16:342) <br/> at Function.Ye <span class="error">[as h]</span> (out/core-advanced-test.js:65:210) <br/> at Function.Lj <span class="error">[as c]</span> (out/core-advanced-test.js:164:27) <br/> at Eu (out/core-advanced-test.js:602:398) </p> <p>SPIDERMONKEY_HOME not set, skipping SpiderMonkey tests <br/> JSC_HOME not set, skipping JavaScriptCore tests <br/> Tested with 1 out of 3 possible js targets<br/> ```</p> <p>The test case is:</p> <p>```gitdiff<br/> diff --git a/test/cljs/cljs/core_test.cljs b/test/cljs/cljs/core_test.cljs <br/> index 2d1d2f3..bf3f7bb 100644 <br/> — a/test/cljs/cljs/core_test.cljs <br/> +++ b/test/cljs/cljs/core_test.cljs <br/> @@ -656,6 +656,7 @@ <br/> (assert (= 1 (get-in <span class="error">[{:foo 1}, {:foo 2}]</span> <span class="error">[0 :foo]</span>))) <br/> (assert (= 4 (get-in [{:foo 1 :bar <span class="error">[{:baz 1}, {:buzz 2}]</span>}, {:foo 3 :bar <span class="error">[{:baz 3}, {:buzz 4}]</span>}] <br/> <span class="error">[1 :bar 1 :buzz]</span>))) <br/> + (assert (nil? (get-in {:foo {:bar 2}} <span class="error">[:foo :bar :baz]</span>))) </p> <p> ;; arrays <br/> (let [a (to-array <span class="error">[1 2 3]</span>)] <br/> ```</p> <p>In case github's master is not the latest one, and test works on master, please discard this message.</p> <p>Cheers.</p> <p>fixed, <a href="http://github.com/clojure/clojurescript/commit/2b21e9d5b09cdd09f2831d11810fa2c5ae4f14b1">http://github.com/clojure/clojurescript/commit/2b21e9d5b09cdd09f2831d11810fa2c5ae4f14b1</a></p> Global Rank