http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CONTRIB-55 Clojure-Contrib <p>The problem is that c.c.sql.internal calls `.println` on a "stream" to print update counts and errors. That method only exists on a `PrintWriter`. This isn't true within Slime, where it's a `StringWriter`.</p> <p>The attached patch binds `<b>out</b>` and uses `println` instead, which does the right thing. I've augmented the docstrings to request a `Writer` as the value of `stream`, which aligns with the docstring for `print`.</p> CONTRIB-55

clojure.contrib.sql expects *err* to be a PrintWriter

Defect In Progress Unresolved Stephen C. Gilardi None Thu, 31 Dec 2009 18:21:00 -0600 Sun, 24 Apr 2011 22:49:44 -0500 0 0 <p>Converted from <a href="http://www.assembla.com/spaces/clojure/tickets/55">http://www.assembla.com/spaces/clojure/tickets/55</a><br/> Attachments:<br/> sql-internal.diff - <a href="https://www.assembla.com/spaces/clojure/documents/btl6lW9Mmr3OPceJe5aVNr/download/btl6lW9Mmr3OPceJe5aVNr">https://www.assembla.com/spaces/clojure/documents/btl6lW9Mmr3OPceJe5aVNr/download/btl6lW9Mmr3OPceJe5aVNr</a></p> <p>rnewman said: [<a href="file:btl6lW9Mmr3OPceJe5aVNr">file:btl6lW9Mmr3OPceJe5aVNr</a>]: Diff against current head.</p> <p>stuart.sierra said: Updating tickets (#1, #2, #3, #4, #6, #20, #23, #25, #30, #31, #33, #34, #35, #37, #38, #52, #55, #58, #59, #60, #61, #62, #63, #64)</p> <p>scgilardi said: Following the discussion in the developer group and as suggested by Stuart Halloway, I'm planning to make these changes:</p> <p><span class="error">&#91;1&#93;</span> adopt the substance of Richard Newman's patch, changes to sql.internal's print-sql-exception, print-sql-exception-chain, print-update-counts functions<br/> <span class="error">&#91;2&#93;</span> remove the automatic printing to <b>err</b> on exceptions. It will be up to the caller to handle the exceptions as he desires: eating, logging, or printing, etc.<br/> <span class="error">&#91;3&#93;</span> move the print* functions to c.c.sql proper as they will now be "public".</p> <p>This will be addressed in clojure.java.jdbc and needs to be migrated to the new JIRA project for it once that is created (I don't have permission to do anything beyond comment / clone this issue).</p> Global Rank