http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/JDBC-26 java.jdbc <p>sqlite3 has some problems:</p> <p>1) PreparedStatements.addBatch does not do anything without some parameters, so executeBatch doesn't do anything.<br/> 2) Transaction support appears to require closing the ResultSet object from generatedKeys.</p> <p>I've only tested the included patch with the default test dbs and sqlite3.</p> JDBC-26

Add sqlite3 support

Enhancement Minor Resolved Completed Sean Corfield Nelson Morris Mon, 13 Feb 2012 23:46:14 -0600 Mon, 23 Apr 2012 03:35:50 -0500 Mon, 23 Apr 2012 03:35:02 -0500 0 0 <p>This will break things - see <a href="http://dev.clojure.org/jira/browse/JDBC-16" title="do-prepared doesn&#39;t throw on invalid SQL"><del>JDBC-16</del></a> which required that .addBatch be called when there are no param-groups. I'm not going to reject this out of hand but patches for new database support need testing against MySQL, PostgreSQL and MS SQL Server.</p> <p>Test suite runs correctly for TEST_DBS=mysql,postgres,derby,hsqldb,sqlite3 and TEST_DBS=mysql-str,postgres-str. This just leaves MS SQL server, which I do not have the ability to run.</p> <p>Regarding <a href="http://dev.clojure.org/jira/browse/JDBC-16" title="do-prepared doesn&#39;t throw on invalid SQL"><del>JDBC-16</del></a>, when I revert to just using .executeBatch for the no param-groups case I can see the errors produced in the test-suite. Using .executeUpdate for the no params-group case continues to fix these errors (note MS SQL server untested). I do not see any other information in the ticket that would explain why using .executeUpdate instead of .addBatch/.executeBatch for the no params-group case would break <a href="http://dev.clojure.org/jira/browse/JDBC-16" title="do-prepared doesn&#39;t throw on invalid SQL"><del>JDBC-16</del></a>. Is there a reason I am missing?</p> <p>I ran the test suite against an ec2 instance with MS SQL server 2008 R2. Current test suite on master fails with attached mssql-error.log. Using patch produces the same output.</p> <p>Please let me know if there is anything that you would like changed.</p> <p>Thanx Nelson. I've been a bit busy with work this week but I'll try to look at this at the weekend. I appreciate your thoroughness on testing this!</p> <p>Integrated parts of the patch. SQLite 3 is now supported. Thanx!</p> <p>I still get the transaction issue (part 2 from original description) when clojure.java.jdbc tries to return the generated keys, in a transaction, using sqlite. <a href="https://gist.github.com/1947746">https://gist.github.com/1947746</a></p> <p>I believe this is because the ResultSet from .getGeneratedKeys never gets .close called, so sqlite keeps the db locked and can't rollback. Would you like me to make a new issue?</p> <p>The tests pass locally (Mac OS X) and on the Clojure build server (Linux) but you're right that I didn't include the close call on the record set.</p> <p>I didn't include your additional test which I'm guessing is the key to highlighting the errant behavior for SQLite?</p> <p>(I couldn't actually apply your patch because I'd spent some time getting all the tests passing for MS SQL Server with both the Microsoft and jTDS drivers)</p> <p>Attached patch that fails with `mvn test`. </p> <p>I believe this was fixed in 0.1.3 (at the end of February). As far as I can tell, all of the patch components are applied. Specifically, your transaction test is included in the test suite and passes.</p> Global Rank Patch Code and Test