http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/JDBC-47 java.jdbc <p><tt>transaction*</tt> currently catches Exceptions for its rollback logic. This means Throwables subclassing <tt>java.lang.Error</tt> are not caught, and indeed the transaction seems to be immediately committed in this case (at least if the connection has autocommit set to true).</p> <p>This happened to me in the case of an <tt>OutOfMemoryError</tt>. Another example is that the following code commits:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>(transaction (insert-records "table" {:foo 12}) (assert false)) </pre> </div></div> <p>Presumably this can be fixed by catching <tt>Throwable</tt> instead of <tt>Exception</tt>. I'll prepare a patch to that effect.</p> 0.2.3 JDBC-47

Transactions do not rollback on non-Exception Throwables

Defect Major Resolved Completed Sean Corfield Gary Fredericks Tue, 26 Feb 2013 16:31:31 -0600 Tue, 26 Feb 2013 20:08:45 -0600 Tue, 26 Feb 2013 20:08:45 -0600 0 0 <p>Thanx Gary. In the latest source there may be two pieces of transaction logic so please check for anywhere else that Exception is mentioned!</p> <p>This patch changes <tt>Exception</tt> to <tt>Throwable</tt> in two places &#8211; <tt>transaction*</tt> and <tt>db-transaction*</tt>. The tests pass.</p> <p>Patch applied.</p> Global Rank