http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/LOGIC-55 core.logic <p>Considering this behavior:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">user&gt; (run* [out] (== 3 out) (== #{3 out} #{3 out})) (3)</pre> </div></div> <p>There are other more convoluted cases involving multiple lvars but I think the above is enough for discussion. I think the above behavior is at least unexpected (desiring documentation) if not actually incorrect behavior.</p> <p>A possible solution would be to apply <tt>distincto</tt> (or some equivalent) to the members of each incoming set before the body of unify-with-set (extending <tt>IUnifyWithSet</tt> to <tt>clojure.lang.IPersistentSet</tt>). Naturally this makes set unification even more expensive than it currently is but I'm currently inclined to think that this additional cost is unavoidable, at least with the current approach.</p> LOGIC-55

Unification of sets allows for duplicate values leading to non-set-like behavior

Defect Major Resolved Completed David Nolen Aaron Brooks Fri, 21 Sep 2012 15:03:18 -0500 Thu, 27 Sep 2012 21:38:47 -0500 Thu, 27 Sep 2012 21:38:47 -0500 0 1 <p>I probably should held off on implementing unification with sets. Oh well. The distincto approach sounds reasonable to me - would gladly take a patch.</p> <p>I'll look in to that. Would you be against declaring <tt>distincto</tt> so I can use it earlier in the file? I don't recall off the top of my head but I think <tt>distincto</tt> can't be moved that early in the file and probably wants to stay where it is anyways.</p> <p>fixed, <a href="http://github.com/clojure/core.logic/commit/cdc4bf8563e9f566cc6e3e0e4f8a7735cd92b88e">http://github.com/clojure/core.logic/commit/cdc4bf8563e9f566cc6e3e0e4f8a7735cd92b88e</a></p> Global Rank