http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/LOGIC-80 core.logic LOGIC-80

add fne, anonymous version of defne

Enhancement Minor Open Unresolved David Nolen David Nolen Tue, 18 Dec 2012 10:13:04 -0600 Fri, 17 May 2013 00:53:27 -0500 0 2 <p>The macros 'fnm' (and fn<span class="error">&#91;eau&#93;</span>) use the optional argument :tabled after the argument list. Is it ok? </p> <p>tabling passed as an option is OK with me.</p> <p>Also could we get tests? Thanks much!</p> <p>I've used the existing pm tests to test the fne macro. you find it in the logic-80-2.patch. Is it what you had in mind?</p> <p>It is not clear how I can test for tabled anonymous functions as the :tabled metadata is of the defn<span class="error">&#91;x&#93;</span> vars.<br/> Possibilities would be:</p> <ul> <li>add meta-data to the function produced by the macro 'tabled';</li> <li>let the function produced by tabled implement some interface/protocol.</li> </ul> <p>what do you think?</p> <p>This looks good. Two things:</p> <ul> <li>squashed patch</li> <li>tabled anonymous goal patch</li> </ul> <p>we're almost there <img class="emoticon" src="http://dev.clojure.org/jira/images/icons/emoticons/smile.gif" height="20" width="20" align="absmiddle" alt="" border="0"/></p> <p>i do not understand what you mean. you prefer a separate patch for tabled anonymous goal?</p> <p>Sorry typo, I meant a test for the tabled anonymous goal. Thanks!</p> <p>thanks, i'll do it asap.</p> <p>Squashed Patch with tests for the fn<span class="error">&#91;e&#93;</span> macros, normal and tabled.</p> <p>so i finally got some time to look at it again. the patch is squashed and contains a test for the tabled anonymous goals; it just tests whether the macro code actually works.</p> <p>Thanks will take a look!</p> Global Rank