http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/MATCH-30 core.match MATCH-30

throw if binding name reused in the same pattern row

Defect Major Resolved Completed David Nolen David Nolen Mon, 10 Oct 2011 14:08:27 -0500 Wed, 19 Oct 2011 09:57:31 -0500 Wed, 19 Oct 2011 09:57:29 -0500 0 1 <p>Checks for duplicate wildcard names in a pattern row.</p> <p>You should be able to reuse bindings as is done in the red black tree pattern as there is no ambiguity there. If we can get that enhancement in I'll gladly accept this. Thanks for taking this on!</p> <p>The new patch allows OR patterns to reuse wildcards, but still complains if there are other ambiguities. I added a couple of tests to illustrate.</p> <p>This looks good. It looks like you created this patch before I added your match-let. Mind creating a new version of this patch against HEAD? Thanks much.</p> <p>Updated patch for latest HEAD</p> <p>I'm trying to apply with patch with git am, but I keep getting:</p> <p>Applying: * src/main/clojure/clojure/core/match.clj: Add Stephen Miner's match-let<br/> error: patch failed: src/main/clojure/clojure/core/match.clj:1532<br/> error: src/main/clojure/clojure/core/match.clj: patch does not apply<br/> Patch failed at 0001 * src/main/clojure/clojure/core/match.clj: Add Stephen Miner's match-let</p> <p>It looks like the previous commit of my pasting of your match-let patch is mixed up into your latest patch.</p> <p>Sorry, I made a git mistake with dup3.patch. I made a fresh patch called dup4.patch that should fix the problem.</p> <p>Fixed <a href="https://github.com/clojure/core.match/commit/819f7f7d874f63b74ba634a9bebc95da574d80eb">https://github.com/clojure/core.match/commit/819f7f7d874f63b74ba634a9bebc95da574d80eb</a></p> Approval Ok Global Rank Patch Accepted