http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/MATCH-44 core.match <p>I contributed the regroup-keywords function to allow 'flattened' match syntax for :when and :as. It used gensym to make a marker to simplify the algorithm. After seeing how other people had done similar things with sentinel values, I realized that (Object.) is a better unique value. Theoretically, an evil user could use the same symbol that the gensym had created. Also, it's better to test with identical? rather than = since the sentinel is unique. I will attach a patch with a slight refactoring.</p> MATCH-44

regroup-keywords should not use gensym

Enhancement Minor Resolved Completed David Nolen Steve Miner Mon, 12 Dec 2011 09:54:52 -0600 Mon, 12 Dec 2011 21:30:07 -0600 Mon, 12 Dec 2011 21:30:07 -0600 0 0 <p>Fixed, <a href="https://github.com/clojure/core.match/commit/6d0f3fe33c4a85a12366d447e82cab59e299f94a">https://github.com/clojure/core.match/commit/6d0f3fe33c4a85a12366d447e82cab59e299f94a</a></p> Global Rank Patch Code