http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/TLOG-4 tools.logging <p>Example of error when trying to call a Logger protocol function:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>java.lang.IllegalArgumentException: No implementation of method: :enabled? of protocol: #'clojure.tools.logging.impl/Logger found for class: org.apache.log4j.Logger </pre> </div></div> <p>The bug is the result of combining syntax-quoting with <tt>extend-type</tt>, e.g.:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>`(do (extend-type org.apache.commons.logging.Log Logger (enabled? [logger# level#] ... ))) </pre> </div></div> <p>The syntax-quote turns the above <tt>enabled?</tt> into <tt>clojure.tools.logging/enabled?</tt> protocol function name, and then the <tt>extend-type</tt> turns that into the keyword <tt>:clojure.tools.logging/enabled?</tt>, which does not match the expected <tt>:enabled?</tt>.</p> <p>Attached patch fixes this by using <tt>extend</tt> maps rather than <tt>extend-type</tt>. Also adds some tests.</p> TLOG-4

Provided implementations of logging protocols fail.

Defect Blocker Resolved Completed Alexander Taggart Alexander Taggart Thu, 29 Sep 2011 14:58:12 -0500 Thu, 29 Sep 2011 15:36:11 -0500 Thu, 29 Sep 2011 15:36:11 -0500 0 0 <p>Committed:</p> <p><a href="https://github.com/clojure/tools.logging/commit/f9cb0a7232d3a11cb7e74e4c13c3adc054e7e7a2">https://github.com/clojure/tools.logging/commit/f9cb0a7232d3a11cb7e74e4c13c3adc054e7e7a2</a></p> Global Rank Patch Code and Test