[UNIFY-3] Enhance documentation Created: 03/Feb/12 Updated: 03/Feb/12 |
|
| Status: | Open |
| Project: | core.unify |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major |
| Reporter: | Fogus | Assignee: | Fogus |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | docs | ||
| Description |
|
The current unify docs are spartan and "just the facts". It would be useful to have a set of docs that:
|
[JDBC-50] insert-rows (incorrectly) patches incomplete records Created: 21/Mar/13 Updated: 06/Apr/13 Resolved: 06/Apr/13 |
|
| Status: | Resolved |
| Project: | java.jdbc |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Defect | Priority: | Major |
| Reporter: | Cees van Kemenade | Assignee: | Sean Corfield |
| Resolution: | Completed | Votes: | 0 |
| Labels: | bug, docs | ||
| Environment: |
Postgres database on Debian machine |
||
| Attachments: |
|
| Description |
|
When using sql/insert-rows with a dataset that contains incomplete rows the rows will be patched with values from the preceding rows. The behaviour to be expected is not documented. I would expect insert-rows either only accepts complete rows. When accepting incomplete rows I would expect patching with nil-values instead of values from other rows. Attached you find an example and the output when running in comments. |
| Comments |
| Comment by Sean Corfield [ 06/Apr/13 3:10 PM ] |
|
This looks like an old / long-standing bug that no one has run into before. In the new (soon-to-be 0.3.0) release, (clojure.java.jdbc.sql/insert :table [1 1] [2] []) would throw an exception: IllegalArgumentException insert called with inconsistent number of columns / values clojure.java.jdbc.sql/insert-multi-row (sql.clj:116) I will update clojure.java.jdbc/insert-rows to throw a similar exception. |
| Comment by Sean Corfield [ 06/Apr/13 3:38 PM ] |
|
Fixed in 0.3.0-SNAPSHOT by throwing an exception if the value-groups are not all the same length. Currently relies on the DB to trap column names not matching value groups (which is known not to work on SQLite but does work on other DBs as far as I know). insert-rows is deprecated in 0.3.0 - use insert! instead going forward (which does more validation). |
[DCSV-3] Some minor documentation typos Created: 14/Jun/12 Updated: 15/Jun/12 Resolved: 15/Jun/12 |
|
| Status: | Resolved |
| Project: | data.csv |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Defect | Priority: | Trivial |
| Reporter: | Trent Ogren | Assignee: | Jonas Enlund |
| Resolution: | Completed | Votes: | 0 |
| Labels: | docs, documentation, typo | ||
| Attachments: |
|
| Patch: | Code |
| Description |
|
I found a couple minor typos: one in the README, one in a docstring. I've included a patch. |
[CLJS-511] The quick start guide should be written to use lein-cljsbuild Created: 29/May/13 Updated: 29/May/13 |
|
| Status: | Open |
| Project: | ClojureScript |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Enhancement | Priority: | Minor |
| Reporter: | Daniel Kaplan | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | docs, documentation | ||
| Description |
|
The first line of the quick start guide ( https://github.com/clojure/clojurescript/wiki/Quick-Start ) says: "NOTE: The following instructions are useful if for some reason you need to use the ClojureScript compiler directly. For a more integrated workflow, Leiningen with lein-cljsbuild is recommended." This being the case, my first impression of the page is that this isn't really a quick start guide, but a way to do things in an obsolete way. It should be updated to show the right way to get started instead of outsourcing the guide to the lein-cljsbuild page ( https://github.com/emezeske/lein-cljsbuild ) or, perhaps the quick start guide link on https://github.com/clojure/clojurescript should directly link to the lein-cljsbuild page |
[CLJS-392] Documentation says CLJS can open connections to the REPL server from a "file://" source, and you can't Created: 09/Oct/12 Updated: 24/Oct/12 Resolved: 24/Oct/12 |
|
| Status: | Resolved |
| Project: | ClojureScript |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Defect | Priority: | Trivial |
| Reporter: | Nahuel Greco | Assignee: | Unassigned |
| Resolution: | Completed | Votes: | 0 |
| Labels: | bug, docs, documentation | ||
| Environment: |
ClojureScript 0.0-1450 |
||
| Description |
|
At https://github.com/clojure/clojurescript/wiki/The-REPL-and-Evaluation-Environments there is the following paragraph: "This is a problem for the browser-connected REPL because FireFox and Chrome both view opening a file from the file system and connecting to localhost:9000 as different domains. From what I tested, you CANT connect to the REPL server at "http://localhost:9000/repl" if you initially loaded the page using the "file://" protocol. But you can if you loaded it from the same hostname on another port using "http://". The documentation is wrong, and also it needs to be clarified on what you really can change from the initial domain, like the port, without broking the REPL connection (or link to a CrossPageChannel documentation page with the details on what same-origin policy checks it can overcome). |
| Comments |
| Comment by David Nolen [ 23/Oct/12 7:00 PM ] |
|
Are you unable to edit the wiki? |
| Comment by Nahuel Greco [ 24/Oct/12 9:27 AM ] |
|
I didn't know the wiki had public write permissions. Also I don't know the exact CrossPageChannel limitations. |
| Comment by David Nolen [ 24/Oct/12 10:37 AM ] |
|
The limitation is that it won't work with file://. We now provide a simple webserver that will serve the files present in the directory where you started browser REPL. If you goto http://localhost:9000/ we will serve index.html if it is present. |
| Comment by Nahuel Greco [ 24/Oct/12 10:47 AM ] |
|
So CrossPageChannel overcomes the "same origin policy" for different ports, but not for different protocols. Thanks for the clarification. |
| Comment by David Nolen [ 24/Oct/12 2:48 PM ] |
|
No problem, closing this one. |
[CLJS-387] Add docstring from def and ns definitions to @namespaces metadata map, and make reflect functions make use of that Created: 07/Oct/12 Updated: 17/Oct/12 Resolved: 17/Oct/12 |
|
| Status: | Resolved |
| Project: | ClojureScript |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Enhancement | Priority: | Minor |
| Reporter: | Frank Siebenlist | Assignee: | Unassigned |
| Resolution: | Completed | Votes: | 0 |
| Labels: | docs, enhancement, patch,, reflection | ||
| Environment: |
clojure/clojurescript "0.0-1450" |
||
| Attachments: |
|
| Patch: | Code |
| Description |
|
The docstrings were parsed from the definitions-forms for def and ns, but not added to the @namespaces metadata map. |
| Comments |
| Comment by David Nolen [ 15/Oct/12 11:06 PM ] |
|
This patch no longer applies, mind updating it? |
| Comment by Frank Siebenlist [ 16/Oct/12 12:10 AM ] |
|
This patch should apply to master version on Mon, 15 Oct 2012 22:03:19 -0700 (4defcbcf19112b9be6a4a27b5d8855552bf94948) |
| Comment by David Nolen [ 17/Oct/12 10:57 AM ] |
|
Excellent, fixed http://github.com/clojure/clojurescript/commit/bef56a74f2eeecabfe0c0a28d89b455dce576ea3 Please at the ticket # to the commit message though, thanks! |
[CLJ-1027] Outdated documentation for gen-class's :exposes-methods option Created: 18/Jul/12 Updated: 18/Jul/12 |
|
| Status: | Open |
| Project: | Clojure |
| Component/s: | None |
| Affects Version/s: | Release 1.4 |
| Fix Version/s: | None |
| Type: | Defect | Priority: | Trivial |
| Reporter: | Dan Lidral-Porter | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | docs, documentation | ||
| Description |
|
The docstring for gen-class says the following regarding the :exposes-methods option: "It is sometimes necessary to call the superclass' implementation of an To me, this suggests that supplying something like `{foo fooSuper}` allows me to use the symbol `fooSuper` in my new method implementation. Doing this actually results in an error while compiling because `fooSuper` cannot be resolved. It seems that what actually happens is that a `fooSuper` instance method is defined, which calls the superclass's implementation. The docstring should be updated to reflect this. |
[CLJ-999] Wrong link in gh-pages index (api-index.html) Created: 18/May/12 Updated: 20/May/13 Resolved: 20/May/13 |
|
| Status: | Resolved |
| Project: | Clojure |
| Component/s: | None |
| Affects Version/s: | Release 1.3 |
| Fix Version/s: | None |
| Type: | Defect | Priority: | Trivial |
| Reporter: | Bogdan Popescu | Assignee: | Tom Faulhaber |
| Resolution: | Completed | Votes: | 0 |
| Labels: | docs, documentation | ||
| Patch: | None |
| Description |
|
The api-index.html includes wrong links for the following:
The links point to pages that do not exist. The problem is that the documentation for those entries is on a "parent" page, for example, the link clojure.core.protocols-api.html#clojure.core.protocols/internal-reduce should have been clojure.core-api.html#clojure.core.protocols/internal-reduce Not a huge bug for me, but you might want to get it fixed. And please give my huge thanks to whoever is in charge of the documentation, I'm the developer behind Dash, a Mac OS X documentation browser, and I was in the process of creating a documentation set for Clojure, and because you guys have an index, you made my work 1000 times easier. |
| Comments |
| Comment by Andy Fingerhut [ 11/Mar/13 3:01 PM ] |
|
Is this fixed now? Tom Faulhaber has regenerated the docs after the recent Clojure 1.5 release, and I think updated other things besides, so it might be. |
| Comment by Tom Faulhaber [ 11/Mar/13 4:43 PM ] |
|
Nope, not fixed. This one either slipped by me or came in right when I was changing jobs so didn't stick in my brain. I'll take a look now. Thanks for the report, Bogdan, and thanks for the bump, Andy to get it on my radar. |
| Comment by Gabriel Horner [ 10/May/13 4:00 PM ] |
|
Tom, I'm happy to help if you need it. Could you document on a wiki page how autodoc is run here? I couldn't find such a page. |
| Comment by Tom Faulhaber [ 20/May/13 4:18 PM ] |
|
This is fixed with gh-pages commit 919143e (autodoc doesn't follow the regular Clojure release path since it's a website built off the source checkins). |
| Comment by Tom Faulhaber [ 20/May/13 4:24 PM ] |
|
Gabriel, Thanks for the offer. I fixed this one, but may take you up on it if more come up. There is currently no wiki page about the autodoc process but it's an excellent suggestion. I'll put it on my list to write something up. In the meantime source on the autodoc program itself is at https://github.com/tomfaulhaber/autodoc and a description of how it works is at http://tomfaulhaber.github.io/autodoc. Two caveats: (1) autodoc is currently undergoing a bunch of work (thus this bug fix) in preparation for a new release and (2) the documentation doesn't talk much about how it's used for documenting Clojure itself. |