[LOGIC-25] Allow retraction of previously stated facts in a relation Created: 11/Jan/12 Updated: 18/Jan/12 Resolved: 18/Jan/12 |
|
| Status: | Resolved |
| Project: | core.logic |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Enhancement | Priority: | Minor |
| Reporter: | Michael Nygard | Assignee: | David Nolen |
| Resolution: | Completed | Votes: | 0 |
| Labels: | new-feature | ||
| Attachments: |
relational-retraction.patch
relational-retraction.patch
relational-retraction.patch
|
| Patch: | Code and Test |
| Description |
|
For long-running or interactive programs, it is useful to allow facts to become "no longer" true at a point in time. |
| Comments |
| Comment by Michael Nygard [ 13/Jan/12 12:49 PM ] |
|
I've found a bug in this patch. It doesn't handle indexes correctly. New patch coming soon. |
| Comment by Michael Nygard [ 13/Jan/12 1:42 PM ] |
|
New patch that correctly updates indexes when retracting facts. |
| Comment by David Nolen [ 14/Jan/12 7:49 PM ] |
|
This looks good but could we get a properly formatted patch w/ attribution information? Thanks! |
| Comment by Michael Nygard [ 15/Jan/12 11:24 AM ] |
|
Happy to. What needs to be different for the patch to work? Also, what attribution are you looking for? Author info in the function? |
| Comment by David Nolen [ 16/Jan/12 4:26 PM ] |
|
Did you make the patch with git? Git should add that information. |
| Comment by Michael Nygard [ 16/Jan/12 8:14 PM ] |
|
I did make the patch with git. |
| Comment by David Nolen [ 18/Jan/12 11:26 AM ] |
|
Normally git patches I've applied have a header like the following: From 8a44aec861c91a9652f3d60093d3d556a490067e Mon Sep 17 00:00:00 2001
From: Bobby Calderwood <bobby_calderwood@mac.com>
Date: Fri, 13 Jan 2012 09:24:29 -0500
Subject: [PATCH] MultiFn implements IHash
How exactly are you creating the patch with git? |
| Comment by Michael Nygard [ 18/Jan/12 12:42 PM ] |
|
I had been using git diff. New patch file attached using git format-patch. I think this is what you're looking for. |
| Comment by David Nolen [ 18/Jan/12 5:45 PM ] |
|
Fixed, https://github.com/clojure/core.logic/compare/2e4bd26201...89005b726f |