Converted from http://www.assembla.com/spaces/clojure/tickets/229
Attachments:
fixchanges-1.patch - https://www.assembla.com/spaces/clojure/documents/djOatA6-8r3RgSeJe5aVNr/download/djOatA6-8r3RgSeJe5aVNr
fixchanges-2.patch - https://www.assembla.com/spaces/clojure/documents/bc3HYG6_yr3RgSeJe5aVNr/download/bc3HYG6_yr3RgSeJe5aVNr

stuart.sierra said: [file:djOatA6-8r3RgSeJe5aVNr]: Patch

stuart.sierra said: [file:bc3HYG6_yr3RgSeJe5aVNr]: Patch from 1.1.x

richhickey said: Updating tickets (#229, #227, #228)

Converted from http://www.assembla.com/spaces/clojure/tickets/228

richhickey said: Updating tickets (#229, #227, #228)

Converted from http://www.assembla.com/spaces/clojure/tickets/227

richhickey said: Updating tickets (#229, #227, #228)

Converted from http://www.assembla.com/spaces/clojure/tickets/226
Attachments:
docstr-format.diff - https://www.assembla.com/spaces/clojure/documents/b_3dw46ZOr3RLoeJe5afGb/download/b_3dw46ZOr3RLoeJe5afGb

Converted from http://www.assembla.com/spaces/clojure/tickets/225

richhickey said: (In [[r:3d8c97a939e5779553c53f47696f7445cf378583]]) fix name conflict - bound-fn. fixes #225

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/224
Attachments:
fix224-1.patch - https://www.assembla.com/spaces/clojure/documents/cuk2I06E8r3O4veJe5aVNr/download/cuk2I06E8r3O4veJe5aVNr

stuart.sierra said: [file:cuk2I06E8r3O4veJe5aVNr]: Patch to build

stuart.sierra said: (In [[r:0f6e9932b2770a670630862853d14feeab3b105b]]) Add "dist" Ant target to build distribution ZIP; refs #224

Signed-off-by: Rich Hickey <richhickey@gmail.com>

Branch: master

stuart.sierra said: (In [[r:3e813629e70d7b8e0e602adf553c0f5a516aa61f]]) Add "dist" dir and "*.zip" to .gitignore for build; refs #224

Signed-off-by: Rich Hickey <richhickey@gmail.com>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/223

stuart.sierra said: The Ant build script defines a "ci-build" target that can take the place of "mvn install".

To use it, you need to download the Maven Ant Tasks jar from http://maven.apache.org/ant-tasks/

Then run Ant like this:

ant -lib maven-ant-tasks-2.1.0.jar ci-build

This is an acceptable alternative to a build that works with "mvn install", in my opinion.

Converted from http://www.assembla.com/spaces/clojure/tickets/221

stuart.sierra said: Pre/Post Documentation added to "Changes in 1.1" document at http://docs.google.com/Doc?docid=0AeEMlyQZQkUMZGhxM2hyOV8zNXBucjNmeGc1&hl=en

oranenj said: I have patches to document this in fn's docstring (it's almost the same text as in the changes document), but it feels like the wrong place for it. First of all, it applies to defn and defmacro as well of course, since they expand to fn... but that's not obvious, and it would have to be explained in defn's docstring. Secondly, think it simply makes the documentation for fn too long.

So, how about adding some dummy vars for documenting "general" features and then just point people to them in fn/defn/defmacro/whatever? Something like (def #^{:doc "whatever"} feature-function-conditions)

We could also have similar dummy vars for feature-transients etc. They would stand out in the API doc, making the features easier to discover, too.

richhickey said: I put doc for pre/post in http://clojure.org/special_forms

Converted from http://www.assembla.com/spaces/clojure/tickets/219
Attachments:
filter-doc.diff - https://www.assembla.com/spaces/clojure/documents/d4d-t848ur3OjYeJe5afGb/download/d4d-t848ur3OjYeJe5afGb

tomfaulhaber said: [file:d4d-t848ur3OjYeJe5afGb]

Converted from http://www.assembla.com/spaces/clojure/tickets/218
Attachments:
fix218-1.patch - https://www.assembla.com/spaces/clojure/documents/d-nbCa6Far3QNNeJe5afGb/download/d-nbCa6Far3QNNeJe5afGb
fix218-2.patch - https://www.assembla.com/spaces/clojure/documents/cE4I0S6Zer3PcSeJe5aVNr/download/cE4I0S6Zer3PcSeJe5aVNr

stuart.sierra said: [file:d-nbCa6Far3QNNeJe5afGb]: Patch

stuart.sierra said: Patch fix218-1 prints a deprecation warning in legacy-repl and legacy-script.

richhickey said: Should those warnings tell people how to call clojure.main in order to get the same effect?

stuart.sierra said: [file:cE4I0S6Zer3PcSeJe5aVNr]: Patch

stuart.sierra said: (In [[r:2cc710e7aeaab08e0739debe21e2cc6b7020e1b1]]) main.clj: deprecation warning w/ usage for legacy repl/script; refs #218

Signed-off-by: Rich Hickey <richhickey@gmail.com>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/217
Attachments:
fix217-1.diff - https://www.assembla.com/spaces/clojure/documents/cP92vk4dKr3Qa0eJe5afGb/download/cP92vk4dKr3Qa0eJe5afGb

stuart.sierra said: [file:cP92vk4dKr3Qa0eJe5afGb]: patch

stuart.sierra said: Patch fix217-1.diff also notes "DEPRECATED" in clojure.parallel docstring, refs #217

stuart.sierra said: I mean refs #216

stuart.sierra said: (In [[r:76e7c4317dc3eac80c4908ac5e5fb885e302b2a4]]) Add :doc and :author metadata to core namespaces; fixes #216, fixes #217

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/216

stuart.sierra said: Note added to doc string in patch for #217

stuart.sierra said: (In [[r:76e7c4317dc3eac80c4908ac5e5fb885e302b2a4]]) Add :doc and :author metadata to core namespaces; fixes #216, fixes #217

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/215
Attachments:
fix215-1.diff - https://www.assembla.com/spaces/clojure/documents/aqtxy64eOr3Qa0eJe5afGb/download/aqtxy64eOr3Qa0eJe5afGb
fix215-2.diff - https://www.assembla.com/spaces/clojure/documents/bsUjGu4eSr3RlweJe5aVNr/download/bsUjGu4eSr3RlweJe5aVNr
fix215-3.diff - https://www.assembla.com/spaces/clojure/documents/buJlye4e4r3Qa0eJe5afGb/download/buJlye4e4r3Qa0eJe5afGb

stuart.sierra said: [file:aqtxy64eOr3Qa0eJe5afGb]: patch

stuart.sierra said: Patch fix215-1.diff prints deprecation warning whenever ^ is used and removes all uses of ^ in core.

stuart.sierra said: [file:bsUjGu4eSr3RlweJe5aVNr]: Better patch

stuart.sierra said: [file:buJlye4e4r3Qa0eJe5afGb]: Best patch

stuart.sierra said: (In [[r:20e4e45f18b8cd9833846aa8cf441ceebd98cca8]]) Remove deprecated ^ reader macro from core sources; refs #215

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

chouser@n01se.net said: (In [[r:b3b1fa5081172d9931d7dffac4e12a535871cfde]]) Print deprecation warning for ^ reader macro; refs #215

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

stuart.sierra said: (In [[r:f047dc4acc69350d3513b4e69e093690cdb92e40]]) Remove deprecated ^ reader macro from tests; fixes #215

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/214
Attachments:
fix214-1.diff - https://www.assembla.com/spaces/clojure/documents/aNTaNW4dCr3Qa0eJe5afGb/download/aNTaNW4dCr3Qa0eJe5afGb

stuart.sierra said: [file:aNTaNW4dCr3Qa0eJe5afGb]: patch

stuart.sierra said: (In [[r:c5abcf6751c0fed34b72eab49ec9989458651bbf]]) deprecate add-classpath in docstring, print warning; fixes #214

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/210
Attachments:
sorted-set-by.diff - https://www.assembla.com/spaces/clojure/documents/cCsdcIZ_Wr3QwreJe5aVNr/download/cCsdcIZ_Wr3QwreJe5aVNr
ssb2.diff - https://www.assembla.com/spaces/clojure/documents/bHx3hk2Her3QkseJe5aVNr/download/bHx3hk2Her3QkseJe5aVNr

timothypratley said: [file:cCsdcIZ_Wr3QwreJe5aVNr]: removed bad initializers, added tests

timothypratley said: public static PersistentTreeSet create(Comparator comp, Object... init)
was shadowing
public static PersistentTreeSet create(Comparator comp, List init)

I can't see any reason why Object... init should be there (it is only for sorted-set-by but not needed) so I've simply removed it and added test coverage. Please advise if this is valid or if there is any reason Object... init is useful.

richhickey said: FYI - please don't assign things to me - thanks

richhickey said: 'ant test' fails for clojure, with:
[java] ERROR in (test-sorted-set-by) (test_clojure.clj:77)
[java] expected: (set? (sorted-set-by <))
[java] actual: java.lang.NullPointerException: null
[java] at clojure.lang.PersistentTreeSet.create (PersistentTreeSet.java:33)

timothypratley said: Hi Rich,

Ok thanks.

I tried from a fresh branch, for some reason 'ant test' does not recompile the java code (which has changed very slightly to fix the bug). However if you first run 'ant' then run 'ant test' it works fine and all tests pass. This seems to show that the build.xml isn't finding the dependency, but that is unrelated to this patch I believe.

Can you please try again with a clean build before ant test?

Regards,
Tim.

richhickey said: I did ant + ant test. Just tried again, same problem. Perhaps some important change didn't make it into your patch? Please pull down master and apply your patch to it in order to reproduce/diff. Thanks.

timothypratley said: Short answer - I am pretty sure the next attachment will fix it!

Long answer -

Hmmmm very odd! I can't reproduce any error here so it must be related to my environment somehow.

git clone git://github.com/richhickey/clojure.git
cd clojure
ant
ant test
works fine.... of course
git am -s < sorted-set-by.diff
ant
[java] ERROR in (test-sorted-set-by) (test_clojure.clj:77)
[java] expected: (set? (sorted-set-by <))
[java] actual: java.lang.NullPointerException: null
[java] at clojure.lang.PersistentTreeSet.create (PersistentTreeSet.java:50)
expected, line number 50 is different from 33, again that's expected
ant
ant test
works fine for me but errors on line 33 PersistentTreeSet for you
PersistentTreeSet line 33:
for(Object key : init)
init is clearly null
I added some printouts - it never gets called for me - but does for you
Summary - must be shadowing again!!! Argghhhh...

Uploading patch now which should resolve.

timothypratley said: [file:bHx3hk2Her3QkseJe5aVNr]: new patch

Converted from http://www.assembla.com/spaces/clojure/tickets/209
Attachments:
arrays.diff - https://www.assembla.com/spaces/clojure/documents/ab7__AZOur3RCOeJe5afGb/download/ab7__AZOur3RCOeJe5afGb
arrays.diff - https://www.assembla.com/spaces/clojure/documents/d30jsYZOWr3QYEeJe5aVNr/download/d30jsYZOWr3QYEeJe5aVNr

timothypratley said: [file:ab7__AZOur3RCOeJe5afGb]: copy+paste solution

timothypratley said: Straightforward approach of adding boolean/byte/char/short in similar fashion to existing. I've marked this as (part 1) as it adds the missing features but there still might be some thinking required on how to 'unify' and/or reduce boilerplate. Happy to work on further if any suggestions.

Please note, have added tests as part of patch.

timothypratley said: Re-assigning to you Rich as I'm not sure what the process is from here.

timothypratley said: [file:d30jsYZOWr3QYEeJe5aVNr]: added some more tests

chouser@n01se.net said: That last patch looks good to me. Not much can be done to reduce boilerplate in the Java. I suppose a private macro could be used for the repetition in Clojure, but I don't know if that's necessary. The . forms could be switched to a more "modern" format, if you're looking for extra ways to clean it up.

As for process, unless you want to make above changes, you're done. Next up Rich comments on or approves the patch.

timothypratley said: Ok I'll add those changes

Converted from http://www.assembla.com/spaces/clojure/tickets/208
Attachments:
clojure-build.patch - https://www.assembla.com/spaces/clojure/documents/aNaDJ4YlCr3PeJeJe5aVNr/download/aNaDJ4YlCr3PeJeJe5aVNr
contrib-build.patch - https://www.assembla.com/spaces/clojure/documents/aNaGuWYlCr3PeJeJe5aVNr/download/aNaGuWYlCr3PeJeJe5aVNr

technomancy said: [file:aNaDJ4YlCr3PeJeJe5aVNr]

technomancy said: [file:aNaGuWYlCr3PeJeJe5aVNr]

stuart.sierra said: Why is this assigned to me?

technomancy said: Stuart: I assumed you were the commiter most familiar with Maven; sorry if that was presumptuous.

stuart.sierra said: Well, I'm moderately familiar with Maven, but I don't have commit privileges on core; that's the only reason why I was confused by the assignment.

technomancy said: Ah, I didn't realize there are was a separate set of committers for contrib.

dysinger said: (In [[r:5f96d1cb7eeac29b3894e63ce9e17f29d062d15d]]) changed the pom to match whats been pushed on public maven repos Fixes #208

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/206
Attachments:
0001-make-and-metadata-aware.patch - https://www.assembla.com/spaces/clojure/documents/dVsuqiWaCr3PaHeJe5afGb/download/dVsuqiWaCr3PaHeJe5afGb

cgrand said: [file:dVsuqiWaCr3PaHeJe5afGb]: patch

meikelbrandmeyer said: Isn't it sufficient to hint inside the parens?

Clojure
user=> (set! *warn-on-reflection* true)
true
user=> (-> "foo" identity .length)
Reflection warning, NO_SOURCE_PATH:2 - reference to field length can't be resolved.
3
user=> (-> "foo" #^String identity .length)
3
user=> (-> "foo" #^String (identity) .length)
Reflection warning, NO_SOURCE_PATH:4 - reference to field length can't be resolved.
3
user=> (-> "foo" (#^String identity) .length)
3

cgrand said: The first time I had to hint a -> form, I found that hinting inside the parens wasn't obvious. It feels more regular to me like this
I should maybe rework #205 to also preserve tags on the first item of the list and make both ways (inside and outside) works with inlined and interop form.

cgrand said: (In [[r:749a0ad8b66c781d8176833f0ad26cfe6b9b24e3]]) make -> and ->> metadata-aware Fixes #206

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/205
Attachments:
0001-Preserve-type-hints-set-on-inlined-or-interop-forms-.patch - https://www.assembla.com/spaces/clojure/documents/aqWBuKWaqr3OFEeJe5aVNr/download/aqWBuKWaqr3OFEeJe5aVNr

cgrand said: [file:aqWBuKWaqr3OFEeJe5aVNr]: patch

cgrand said: I have a related patch now that this point is fixed which make -> and ->> preserve metadata when splicing a list. Should I open another ticket for that? see http://github.com/cgrand/clojure/commit/a027636d9ef857ee80cb13190731a2801684fe9c

cgrand said: (In [[r:4115b53938c56e282b9de9701a2db474324092bd]]) Preserve type hints set on inlined or interop forms, fixes #205

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/203
Attachments:
nbproject-ignore.diff - https://www.assembla.com/spaces/clojure/documents/dk0z6KVAOr3OGKeJe5afGb/download/dk0z6KVAOr3OGKeJe5afGb

cemerick said: [file:dk0z6KVAOr3OGKeJe5afGb]

Converted from http://www.assembla.com/spaces/clojure/tickets/202
Attachments:
defmethod-type-hint.diff - https://www.assembla.com/spaces/clojure/documents/c_VwQqVAGr3QYWeJe5afGb/download/c_VwQqVAGr3QYWeJe5afGb

cemerick said: [file:c_VwQqVAGr3QYWeJe5afGb]

Converted from http://www.assembla.com/spaces/clojure/tickets/201
Attachments:
0001-Add-test-for-metadata-carrying-deftest.patch - https://www.assembla.com/spaces/clojure/documents/dFcI08Vg8r3P7CeJe5aVNr/download/dFcI08Vg8r3P7CeJe5aVNr
0002-Preserve-test-var-metadata-within-deftest.-Fixes-20.patch - https://www.assembla.com/spaces/clojure/documents/dFkVS0Vg8r3P7CeJe5aVNr/download/dFkVS0Vg8r3P7CeJe5aVNr

technomancy said: [file:dFcI08Vg8r3P7CeJe5aVNr]: Tests

technomancy said: [file:dFkVS0Vg8r3P7CeJe5aVNr]: Implementation

technomancy said: (In [[r:7779c99699f29118ee9fc66201c7afdd1a5dd300]]) Preserve test var metadata within deftest. Fixes #201.

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

technomancy said: (In [[r:9bde10da7b13dd24b5666260d231d79792a34305]]) Add test for metadata-carrying deftest. Refs #201

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/194
Attachments:
0001-Don-t-repeatedly-compose-on-calls-to-use-fixtures.-F.patch - https://www.assembla.com/spaces/clojure/documents/cU7IgoS2Or3PCKeJe5aVNr/download/cU7IgoS2Or3PCKeJe5aVNr
0001-Don-t-repeatedly-compose-on-calls-to-use-fixtures.-F.patch - https://www.assembla.com/spaces/clojure/documents/a51RI-S2Wr3PxveJe5aVNr/download/a51RI-S2Wr3PxveJe5aVNr

technomancy said: [file:cU7IgoS2Or3PCKeJe5aVNr]: Patch with a fix.

technomancy said: Fix attached.

technomancy said: [file:a51RI-S2Wr3PxveJe5aVNr]: Fixed patch

technomancy said: Ignore that first patch; the implementation worked, but the test was silly.

mikehinchey said: Backport for contrib clojure-1.0-compatibility

technomancy said: (In [[r:f5f2943dfd0128744227c3f42a630ea10dd40b24]]) Don't repeatedly compose on calls to use-fixtures. Fixes #194.

Updated tests and added a docstring to use-fixtures.

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/193
Attachments:
test-ideas-summary.patch - https://www.assembla.com/spaces/clojure/documents/dDYqFAQsKr3RHfeJe5aVNr/download/dDYqFAQsKr3RHfeJe5aVNr
fix193-1.patch - https://www.assembla.com/spaces/clojure/documents/cdsoTU3Pmr3Q3BeJe5aVNr/download/cdsoTU3Pmr3Q3BeJe5aVNr

stuart.sierra said: [file:dDYqFAQsKr3RHfeJe5aVNr]: patch to run-tests and successful?

stuart.sierra said: Checked against commit 3e60eff602652e753a54ba88b25dbdd2615c3b2e and still applies ok.

richhickey said: Not a valid patch format, needs git format-patch

digash said: I've ran into the same issue as a work around. Just bind the function to the patched one.

(defn patched-run-tests
  "Runs all tests in the given namespaces; prints results.
  Defaults to current namespace if none given."
  ([] (run-tests *ns*))
  ([& namespaces]
     (let [summary (assoc (apply merge-with + (map test-ns namespaces))
                     :type :summary)]
       (report summary)
       summary)))

(defn successful?
  "Returns true if the given test summary indicates all tests
  were successful, false otherwise."
  [summary]
  (and (zero? (:fail summary))
       (zero? (:error summary))))

(binding [clojure.test/run-tests patched-run-tests]
  (when-not (successful? (run-all-tests #".*test.*"))
    (System/exit 1)))

stuart.sierra said: [file:cdsoTU3Pmr3Q3BeJe5aVNr]: Correctly-formatted patch

stuart.sierra said: (In [[r:607389029cfec50f32b73c00a6f66d0a1dbcda23]]) clojure.test/run-tests: return summary, add successful?; refs #193

Reformatted patch.

Signed-off-by: Rich Hickey <richhickey@gmail.com>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/192
Attachments:
count-assoc-dissoc.patch - https://www.assembla.com/spaces/clojure/documents/bOBpRYO1ar3PEPeJe5aVNr/download/bOBpRYO1ar3PEPeJe5aVNr

cgrand said: [file:bOBpRYO1ar3PEPeJe5aVNr]: patch

fsodomka said: Concerning the test: In the past we were adding tests directly to the other tests for the given function. I would just add it in the test-count in data_structures.clj.

; associng/dissocing a nil key - ticket #192
(is (= 30 (count (reduce conj (hash-map) (for [i (range 30)] [i nil])))))

Converted from http://www.assembla.com/spaces/clojure/tickets/189
Attachments:
compare-doc-defect.diff - https://www.assembla.com/spaces/clojure/documents/bpEPXANUmr3QLPeJe5aVNr/download/bpEPXANUmr3QLPeJe5aVNr

liwp said: [file:bpEPXANUmr3QLPeJe5aVNr]

importer said: (In [[r:a2d986693592e321e7978f914c3ba4f563da6af3]]) Fix compare doc defect - fixes #189

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/186
Attachments:
186-StringSeq-count.patch - https://www.assembla.com/spaces/clojure/documents/bDd_4MLWyr3Rb-eJe5afGb/download/bDd_4MLWyr3Rb-eJe5afGb

cgrand said: [file:bDd_4MLWyr3Rb-eJe5afGb]: patch

chouser@n01se.net said: Child association with ticket #187 was added

cgrand said: (In [[r:2474dad2a56b32527bb6ee10545ee3de476bc583]]) Add missing specialized implementation for Counted/count on StringSeq. Fixes #186

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/185
Attachments:
zip-down-bug.diff - https://www.assembla.com/spaces/clojure/documents/bR_nykKWWr3P7IeJe5aVNr/download/bR_nykKWWr3P7IeJe5aVNr

achimpassen said: [file:bR_nykKWWr3P7IeJe5aVNr]

richhickey said: This seems to conflict with the policy of #135, which is to throw if non-branch

achimpassen said: Why not have children throw and down return nil? The attached patch doesn't rely on one particular behaviour of children. IMHO, if down is supposed to throw, the doc string should be fixed, and for the sake of consistency, left/right/up should also throw on leftmost/rightmost/root nodes.

achimpassen said: (In [[r:146f3614d100e9bce421afdcceee67aa0b956bb8]]) fixed zip/down on leaves, refs #185

Signed-off-by: Rich Hickey <richhickey@gmail.com>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/183
Attachments:
leafless.patch - https://www.assembla.com/spaces/clojure/documents/afd0l2KLqr3PFneJe5aVNr/download/afd0l2KLqr3PFneJe5aVNr

cgrand said: [file:afd0l2KLqr3PFneJe5aVNr]

richhickey said: Patch applied - thanks!

Converted from http://www.assembla.com/spaces/clojure/tickets/181
Attachments:
181-proxy.patch - https://www.assembla.com/spaces/clojure/documents/au3qQmLWur3Rb-eJe5afGb/download/au3qQmLWur3Rb-eJe5afGb

meikelbrandmeyer said: I'd like to add, that it would be nice, if the current namespace could also be included in the class generated by proxy. In it's current form it is very difficult to create several jars from one compilation tree, since it is difficult to find out which namespace defines which proxy.

The current solution requires to set up different compilation trees for different jars. Especially for simple setups this is a lot of unnecessary work.

Having the namespace encoded in the class name would make it easy to select the correct proxy classes.

Also, it would avoid clashes with third party libraries, which happen to define similar proxies.

cgrand said: Attached patch:
proxy now caches generated classes per namespace and include a hash to distinguish proxy classes implementing homonymous interfaces. See #181

richhickey said: I don't see the patch file

cgrand said: [file:au3qQmLWur3Rb-eJe5afGb]: missing patch

cgrand said: (In [[r:e73abece1ebf3a4aba22104ae9452b2b816ab0d7]]) proxy now caches generated classes per namespace and include a hash to distinguish proxy classes implementing homonymous interfaces. Fixes #181

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/179
Attachments:
0001-Fix-namespace-for-symbol.patch - https://www.assembla.com/spaces/clojure/documents/a7PS5GKm4r3PbreJe5aVNr/download/a7PS5GKm4r3PbreJe5aVNr

oranenj said: [file:a7PS5GKm4r3PbreJe5aVNr]

oranenj said: Child association with ticket #180 was added

oranenj said: (In [[r:2f3d7d336122ca4f0c3961d92bbe0d05a4ec8316]]) Fix namespace for (symbol "/")

Fixes #179

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/177

Converted from http://www.assembla.com/spaces/clojure/tickets/175
Attachments:
def-error-message-fix.diff - https://www.assembla.com/spaces/clojure/documents/cu_tWuRS8r3RVoeJe5aVNr/download/cu_tWuRS8r3RVoeJe5aVNr

liwp said: [file:cu_tWuRS8r3RVoeJe5aVNr]: change the def exception message

liwp said: (In [[r:6aab0f20e6bcc897b86a77b728af6fa0df93a2d8]]) Fix incorrect exception message when first argument to def is not a symbol - fix #175

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/174
Attachments:
keyword-serializable.diff - https://www.assembla.com/spaces/clojure/documents/dIqXxcIher3RSfeJe5aVNr/download/dIqXxcIher3RSfeJe5aVNr

cemerick said: [file:dIqXxcIher3RSfeJe5aVNr]

cemerick said: (In [[r:b6cf1963af6e4e6aa35446aff15d77dcef305855]]) make clojure.lang.Keyword Serializable, fixes #174

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/173
Attachments:
0001-implemented-TransientHashSet.patch - https://www.assembla.com/spaces/clojure/documents/cVyxpwHLWr3O4JeJe5aVNr/download/cVyxpwHLWr3O4JeJe5aVNr

cgrand said: [file:cVyxpwHLWr3O4JeJe5aVNr]: patch

chouser@n01se.net said: I know 'disj' uses a params named 'set' and 'key', and old-style interop calls, but would it be worth fixing those for 'disj!'?

cgrand said: (In [[r:a780e1d096f6a99cb974568a0a6d76d4e996e585]]) implemented TransientHashSet Fixes #173

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/172
Attachments:
0001-add-objects-as-a-valid-type-hint.patch - https://www.assembla.com/spaces/clojure/documents/cuB7MaHLSr3Pg2eJe5aVNr/download/cuB7MaHLSr3Pg2eJe5aVNr

cgrand said: [file:cuB7MaHLSr3Pg2eJe5aVNr]: patch

cgrand said: (In [[r:cc78418e773517d1c3427818cbee2254689fc0d8]]) add #^objects as a valid type hint Fixes #172

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/171
Attachments:
clojure-171-ns-reflection.patch - https://www.assembla.com/spaces/clojure/documents/aKgc0WHx4r3Rt1eJe5aVNr/download/aKgc0WHx4r3Rt1eJe5aVNr
clojure-171-ns-reflection-v2.patch - https://www.assembla.com/spaces/clojure/documents/cfBliAJGur3RGweJe5afGb/download/cfBliAJGur3RGweJe5afGb

mikehinchey said: [file:aKgc0WHx4r3Rt1eJe5aVNr]: fix reflection warnings

mikehinchey said: Attachement fixes the reflection warnings for ns and others in clojure that are easy, which always resolve to a single class. I didn't try to fix the warnings which can resolve to more than one class or method.

chouser@n01se.net said: Without this patch, the reflection generated by 'ns' breaks unsigned applets. The other changes look good too. The build.xml patch doesn't apply anymore – I'll attach a new version that applies cleanly.

chouser@n01se.net said: [file:cfBliAJGur3RGweJe5afGb]: rebased from original

mikehinchey said: (In [[r:040f083efc16dd830a4508a35a04465e3e5677d3]]) fix #171: ns reflection warnings, and others that are easy

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/170
Attachments:
0002-Added-bound-fn-to-define-thread-local-binding-aware.patch - https://www.assembla.com/spaces/clojure/documents/btVJwSHgyr3QpHeJe5afGb/download/btVJwSHgyr3QpHeJe5afGb

meikelbrandmeyer said: [file:btVJwSHgyr3QpHeJe5afGb]: Patch adding bound-fn helper macro

meikelbrandmeyer said: Another implementation I considered is this:

(defmacro bound-fn
  [args & body]
  (let [fn-name (when (symbol? args) args)
        args    (if fn-name (first body) args)
        body    (if fn-name (next body) body)]
    `(let [bindings# (get-thread-bindings)]
       (fn ~@(if fn-name
               (list fn-name args)
               (list args))
         (push-thread-bindings bindings#)
         (try
           ~@body
           (finally
             (pop-thread-bindings)))))))
</code></pre>

This would allow for lazy-seq functions:

<pre><code>
(defn some-seq
  [x]
  (let [step (bound-fn step [s]
               (lazy-seq
                 (when-let [s (seq s)]
                   (cons (first s) (step (rest s))))))]
    (step x)))

I found this second solution quite ugly, because I have to know how a fntail looks like and fiddle around with. But when Jon Harrop mentioned the lazy-seq in the discussion on the list, I noticed that the current solution (as in the patch at the moment), does not allow such recursion.

meikelbrandmeyer said: After some feedback from Laurent, we arrived with the new attached patch. The seq example might then look like this:

(defn my-hypothetical-seq
  [coll]
  (let [bindings (get-thread-bindings)
        step     (fn step [s]
                   (lazy-seq
                     (with-bindings bindings
                       (generate-seq-here-calling-step))))]
    (step coll)))

This is should allow for such a use without to many hassles.

meikelbrandmeyer said: Hmmm.. Would it be worthwile to also allow an optional map to specify a subset of the bindings? Currently, all bindings are stored in the map, while maybe only a few are actually needed. Would this be pre-mature optimisation?

chouser@n01se.net said: I think this API is solid. In particular, I think having with-bindings means that bound-fn can stay simple – if someone wants to tweak the map of Vars, they can use get-thread-bindings, select-keys and with-bindings with an appropriate amount of hassle (ie, not much).

I wonder if the macros would be better implemented with code repeated from the * functions. As it is, only a little repetition in core is avoided, at the cost of more fn classes, more fn objects, and extra entries in stack traces.

meikelbrandmeyer said: I'm not sure, that it is only repetition which is saved. bound-fn would be more elaborate (can't just take a fntail) or more restricted (if only takes a body).

However what does "restricted" mean here? What's the use of allowing to name a bound-fn (ie. something like {{(bound-fn this [x y z] ....))}} in face of missing TCO? Should we hope for soon TCO support and take care for it already?

But even without TCO considerations: what about {{(bound-fn ([x] ...) ([x y] ...))}}? Supporting such forms (we have to go into each branch setting up the bindings or we get another wrapping fn, which doesn't save much to the original proposal...) would make the bound-fn macro really more complicated. And here naming would again make sense to allow for default invocations dispatch to another arity. Would this be used often enough for it to be worthwhile to support the full fn syntax?

If yes to the above, that leaves only with-bindings as a candidate for repetitive implementation. Since the macro is only small, the code repetition imposed by a fatter macro is still smaller than the generated class file for a thunk. So maybe voting for repetition in this case is a valid point.

Should I modify the patch?

meikelbrandmeyer said: (In [[r:fbacc4a5751fa5c15baa599b5a058cd81b05a247]]) Added bound-fn to define thread-local binding aware functions

bound-fn captures the thread-local bindings in effect where the
function is defined. Installs these bindings before executing the
body. This is useful for helper functions running in a different
thread.

Excluded with-bindings from clojure/main.clj to prevent name clash.

Fixes #170

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/169
Attachments:
0001-Added-public-thread-local-bindings-interface.patch - https://www.assembla.com/spaces/clojure/documents/ahljteHgqr3PfqeJe5afGb/download/ahljteHgqr3PfqeJe5afGb

meikelbrandmeyer said: [file:ahljteHgqr3PfqeJe5afGb]: Patch adding thread-local bindings interface

meikelbrandmeyer said: You may want to consider the concerns Vincent Toups (jvt) raised in the above mentioned thread about possible runtime issues with invalid built maps. Obviously Common Lisp and Scheme do not allow such a behaviour.

oranenj said: This is just a style nitpick, but IIRC Rich mentioned that new code in core should use the "modern" syntactic sugar for . forms, instead of . directly. I certainly would like to see . marginalised as much as possible.

Also, do you think the operations have destructive semantics? Should the names contain a '!'?

Other than that, the patch is so simple there isn't much to review, and I'm definitely in favour of adding this.

meikelbrandmeyer said: Ah. Ok. I asked Rich why he was still using .. while ��� is much more general. He said, that it is a classic. So I thought I'd stick to the current style in core.

I'm not sure about the 'Unable to render embedded object: File ('. On the one hand a push should always have a corresponding pop and vice versa. For example a pop without push will throw. So for now I would not add the ') not found.'.

I'll also add the modifications as discussed in:
http://groups.google.com/group/clojure-dev/browse_frm/thread/962c19c40dd93f24

richhickey said: I think the docs for push-thread-bindings should state that it is essential to have a matching call to pop-thread-bindings that will be properly called in all scenarios (i.e. in a finally clause), and that this is a special purpose function, and 'bindings' or other high-level macros should be preferred when suitable.

meikelbrandmeyer said: (In [[r:110b9c2eb8a128d837e6e620efc7e1c4e33feb82]]) Added public thread-local bindings interface

Added push-thread-bindings, pop-thread-bindings and get-thread-bindings
to interface with clojure.lang.Var for thread-local bindings.

Modified binding to use the new interface.

Fixes #169

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/168
Attachments:
clojure-168-ant.patch - https://www.assembla.com/spaces/clojure/documents/dXurvSG-Sr3OZ9eJe5aVNr/download/dXurvSG-Sr3OZ9eJe5aVNr

mikehinchey said: [file:dXurvSG-Sr3OZ9eJe5aVNr]: patch to fix ant

mikehinchey said: Fixed by setting java failonerror to true for both compile and test. Most ant tasks fail by default, but not java.

Also, wrote a special function for running tests to be used by ant, so it would print properly and throw on test failures. It wasn't printing properly when run in the same ant process as the compile because out and test-out are bound during compile, so the report was printed to nowhere.

mikehinchey said: (In [[r:abca86ea023080fd4ceed24b9887a653a56722eb]]) fix #168, ant targets should fail on error, also test print report correctly

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/167
Attachments:
clojure-167-tests.patch - https://www.assembla.com/spaces/clojure/documents/cPbtSiG-yr3P0FeJe5aVNr/download/cPbtSiG-yr3P0FeJe5aVNr

mikehinchey said: [file:cPbtSiG-yr3P0FeJe5aVNr]: patch containing tests

mikehinchey said: Ready to test.

mikehinchey said: (In [[r:f4294d876cfc5b72650a2d5eab73757709d92b85]]) fix #167, tests for sequences, control, and numbers

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/166
Attachments:
TransientMap.patch - https://www.assembla.com/spaces/clojure/documents/aDYi8CGBWr3PhueJe5afGb/download/aDYi8CGBWr3PhueJe5afGb
TransientMap2.patch - https://www.assembla.com/spaces/clojure/documents/bNyIbwGB0r3R_OeJe5aVNr/download/bNyIbwGB0r3R_OeJe5aVNr
TransientMap3.patch - https://www.assembla.com/spaces/clojure/documents/dzRHNWGC8r3PwqeJe5afGb/download/dzRHNWGC8r3PwqeJe5afGb

cgrand said: [file:aDYi8CGBWr3PhueJe5afGb]: first cut

cgrand said: [file:bNyIbwGB0r3R_OeJe5aVNr]: previous page contained one unrelated commit

cgrand said: [file:dzRHNWGC8r3PwqeJe5afGb]: include bufix for count on dissoc

richhickey said: I've applied patch3, thanks!
Leaving as new for any bugfixes

cgrand said: See #183

Converted from http://www.assembla.com/spaces/clojure/tickets/165
Attachments:
0001-Adds-missing-array-seqs-for-char-byte-and-boolean-pl.patch - https://www.assembla.com/spaces/clojure/documents/bMnH8IGnar3R9geJe5aVNr/download/bMnH8IGnar3R9geJe5aVNr
0001-Adds-missing-array-seqs-for-char-byte-and-boolean-pl.patch - https://www.assembla.com/spaces/clojure/documents/bWmQJUGnGr3R9geJe5aVNr/download/bWmQJUGnGr3R9geJe5aVNr

cgrand said: [file:bMnH8IGnar3R9geJe5aVNr]: patch

cgrand said: [file:bWmQJUGnGr3R9geJe5aVNr]: better patch

cgrand said: (In [[r:51f4180eca6a09dbad52d4bcb6c48ab05fe16cad]]) Enhancements to array seqs

Adds missing array seqs for char[], byte[] and boolean[]
plus specialized .indexOf and .lastIndexOf for all array seqs, fixes #165

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/164
Attachments:
0001-embedded-constants.patch - https://www.assembla.com/spaces/clojure/documents/bWpR2kFXmr3RkXeJe5aVNr/download/bWpR2kFXmr3RkXeJe5aVNr
prim.clj - https://www.assembla.com/spaces/clojure/documents/cwL30uFXmr3ORSeJe5afGb/download/cwL30uFXmr3ORSeJe5afGb
embedded-constants-tests.diff - https://www.assembla.com/spaces/clojure/documents/cm6M6gRi4r3RdbeJe5afGb/download/cm6M6gRi4r3RdbeJe5afGb
embedded-constants-tests2.diff - https://www.assembla.com/spaces/clojure/documents/aV1YJARjyr3RdbeJe5afGb/download/aV1YJARjyr3RdbeJe5afGb
embedded-constants-tests3.diff - https://www.assembla.com/spaces/clojure/documents/a2gi08RpSr3PSLeJe5afGb/download/a2gi08RpSr3PSLeJe5afGb
embedded-constants-tests4.diff - https://www.assembla.com/spaces/clojure/documents/b5AX0uRUir3OwbeJe5aVNr/download/b5AX0uRUir3OwbeJe5aVNr
embedded-constants-tests5.diff - https://www.assembla.com/spaces/clojure/documents/dngmRARUur3OwbeJe5aVNr/download/dngmRARUur3OwbeJe5aVNr

timothypratley said: [file:bWpR2kFXmr3RkXeJe5aVNr]

timothypratley said: [file:cwL30uFXmr3ORSeJe5afGb]: tests

timothypratley said: Hi Rich,

Just curious if you've had a chance to look at this patch yet - please be honest if it has shortfallings so I can improve. I suspect that my vim setup might have formatting differences - if that is the case I'm happy to use Aquamacs or whatever is preferred.

Also I get the feeling this is only a small part of the change required, and I don't grok what the other part is (some print-dup change?)... so some guidance would be appreciated.

Regards,
Tim.

chouser@n01se.net said: Tim,

Would you be willing to reformat the tests you wrote as a patch to clojure.test-clojure? That way they'll be included in the regression runs done for future patches.

timothypratley said: [file:cm6M6gRi4r3RdbeJe5afGb]: patch to clojure-test

timothypratley said: [file:aV1YJARjyr3RdbeJe5afGb]: Here is a better test, shorter and stronger

timothypratley said: Hi Chris

Good idea, I've uploaded a patch to clojure-tests/compilation.clj
Please use the last file attached:
embedded-constants-tests2.diff

Regards,
Tim.

timothypratley said: (In [[r:86d8a952daee73bf7b7b0c5a41c7ad3faf27c038]]) embedded constants, refs #164

Primitive Class objects are now handled explicitly
eg: (eval `(make-array ~Byte/TYPE 2))

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

timothypratley said: (In [[r:b044959a42f5f58a37c4151f4d7b6652e17348ab]]) added tests, fixes #164

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

chouser@n01se.net said: I think I must have been in the process of checking and submitting the first test patch when you attached the second. I'll swap them later.

timothypratley said: [file:a2gi08RpSr3PSLeJe5afGb]: Might be easier to apply - based to current head

timothypratley said: No worries, this is really great for me - getting used to the whole process - thanks. I've uploaded a diff from the current head to save you some minor headaches I hope.

timothypratley said: (In [[r:1ca9c8b9322882a0d84db9007047d223d11f2c3f]]) shorter, stronger embedded-constants tests. fixes #164

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

timothypratley said: [file:b5AX0uRUir3OwbeJe5aVNr]: Ok this time for sure! How embarassing - the last patch didn't actually test anything due to misplaced parenthesis

timothypratley said: How embarrassing - I had a misplaced parenthesis in my patch which meant the test didn't do anything

timothypratley said: [file:dngmRARUur3OwbeJe5aVNr]: Based to current git HEAD

richhickey said: Isn't this in already? Or is the discussion now about the tests?

timothypratley said: (In [[r:5f9df70163bd9c7a168c1ef8cd2be67651401f29]]) Fixed broken test-embedded-constants. Fixes #164

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

timothypratley said: Yes that's right there was just that test issue but its all sorted out now thanks very much.

Converted from http://www.assembla.com/spaces/clojure/tickets/160
Attachments:
junit-xml-output.diff - https://www.assembla.com/spaces/clojure/documents/duKR1iEgWr3Q4keJe5afGb/download/duKR1iEgWr3Q4keJe5afGb
junit-xml-output2.diff - https://www.assembla.com/spaces/clojure/documents/aMA1aKX9qr3Q_UeJe5afGb/download/aMA1aKX9qr3Q_UeJe5afGb

stuart.sierra said: [file:duKR1iEgWr3Q4keJe5afGb]: Patch adding test/junit.clj

richhickey said: New files for Clojure itself need to have the standard header (Copyright (c) Rich Hickey...) and no emails or urls ( by Jason Sankey is fine)

stuart.sierra said: [file:aMA1aKX9qr3Q_UeJe5afGb]

stuart.sierra said: New patch junit-xml-output2.diff removes external dependencies and adds default copyright header.

stuart.sierra said: (In [[r:81e19ddd9973841894767d89465979195242afed]]) Add clojure.test.junit; refs #160

Signed-off-by: Rich Hickey <richhickey@gmail.com>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/159
Attachments:
drewr-char-p.patch - https://www.assembla.com/spaces/clojure/documents/dTXUBaDUmr3RRZeJe5afGb/download/dTXUBaDUmr3RRZeJe5afGb
drewr-char-p.2.patch - https://www.assembla.com/spaces/clojure/documents/d7bzX-EeOr3P2weJe5afGb/download/d7bzX-EeOr3P2weJe5afGb

drewr said: [file:dTXUBaDUmr3RRZeJe5afGb]: patch adding char?

richhickey said: Please use git format-patch as described here:

http://clojure.org/patches

Thanks!

drewr said: [file:d7bzX-EeOr3P2weJe5afGb]: Created with git format-patch

Converted from http://www.assembla.com/spaces/clojure/tickets/158
Attachments:
ticket_158_update_tests.diff - https://www.assembla.com/spaces/clojure/documents/aGPMCuDxCr3QaHeJe5afGb/download/aGPMCuDxCr3QaHeJe5afGb

fsodomka said: Parent association with ticket #131 was added

fsodomka said: [file:aGPMCuDxCr3QaHeJe5afGb]: update tests

fsodomka said: See attached patch.

chouser@n01se.net said: This patch looks good to me.

fsodomka said: (In [[r:16af3b1d04db6978d552b4440690d00a9e64a423]]) updated remaining tests, closes #158

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/155
Attachments:
ticket-155.diff - https://www.assembla.com/spaces/clojure/documents/bvQRQmB_Or3OXZeJe5aVNr/download/bvQRQmB_Or3OXZeJe5aVNr

chouser@n01se.net said: [file:bvQRQmB_Or3OXZeJe5aVNr]: Resolve classnames in modern-syntax static calls at syntaxQuote time.

chouser@n01se.net said: Attached patch as discussed in IRC.

chouser@n01se.net said: Child association with ticket #156 was added

chouser@n01se.net said: (In [[r:994f118c56bb3139f87093a6ec44eb8c04acbdaf]]) Resolve classnames in modern-syntax static calls at syntaxQuote time. Fixes #155

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/154
Attachments:
fix-154.patch - https://www.assembla.com/spaces/clojure/documents/aGf_3wB8Cr3PfNeJe5afGb/download/aGf_3wB8Cr3PfNeJe5afGb

scgilardi said: [file:aGf_3wB8Cr3PfNeJe5afGb]

scgilardi said: Description of fix-154.patch:

• added intern(String nsname) to Keyword.java
• changed clojure.core/keyword to call it
• updated clojure.core/symbol and clojure.core/keyword to new static call syntax
• added tests to reader.clj using corrected keyword, duplicating similar tests for symbol, and adding tests of keyword constructed from a symbol

importer said: (In [[r:a1b4a33bb8ccf739c481754fc563117ed3604c75]]) fixed keyword ctor, added tests, fix #154

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/152
Attachments:
152-binding-docstring.diff - https://www.assembla.com/spaces/clojure/documents/bGPkGOMkir3OYweJe5aVNr/download/bGPkGOMkir3OYweJe5aVNr

stuart.sierra said: [file:bGPkGOMkir3OYweJe5aVNr]: Patch, very similar to Stephen's docstring

stuart.sierra said: (In [[r:ff116fb3a986334e77bc0521167fe89c8e27313d]]) core.clj: binding doc string now says it's parallel, fixes #152

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/151
Attachments:
last-n.diff - https://www.assembla.com/spaces/clojure/documents/cgeCSqBO4r3PxueJe5afGb/download/cgeCSqBO4r3PxueJe5afGb
last-n-v2.diff - https://www.assembla.com/spaces/clojure/documents/cqqgugEomr3ONjeJe5aVNr/download/cqqgugEomr3ONjeJe5aVNr
take-last.diff - https://www.assembla.com/spaces/clojure/documents/b9iKQQUMir3OzreJe5aVNr/download/b9iKQQUMir3OzreJe5aVNr

chouser@n01se.net said: [file:cgeCSqBO4r3PxueJe5afGb]: last with one arg is unchanged. last with an extra count arg returns a seq

chouser@n01se.net said: Attached a patch that defined 'last' with one arg as it has been. 'last' with an extra count arg returns a seq.

chouser@n01se.net said: [file:cqqgugEomr3ONjeJe5aVNr]: bail early if end of seq found while setting up lead

chouser@n01se.net said: I've attached an improved patch [file:last-n-v2.diff]

Both the old and new patches avoid retaining the head, as demonstrated by the first expr blowing the heap, but second not:

(last 3 (map count (doall (take 1e5 (iterate #(str % 'x) "y")))))
(last 3 (map count (take 1e5 (iterate #(str % 'x) "y"))))t

However, the v2 patch also gives up walking the 'lead' seq forward as soon as it reaches the end of the input seq (this is how 'drop' behaves). You can observe the differnce by seeing that with v2 this returns immediately:

(last 1e10 [1 2 3 4 5])

chouser@n01se.net said: For small n's and large collections implementing IPersistentStack, 'last' could be much efficient by using 'pop' and 'reverse', though this would mean it wouldn't always use the seq of the collection.

richhickey said: I'm not sure I get the reverse bit - reverse is fast for stacks? Certainly we could do better for colls implementing Indexed or RandomAccess. I guess all that means is that the doc shouldn't dictate linear time, and should instead say maybe in best time complexity supported by the data structure.

richhickey said: faster for last 1 I should say. Seems more and more like last 1 and last N shouldn't be combined.

chouser@n01se.net said: [file:b9iKQQUMir3OzreJe5aVNr]: implement take-last as its own function

chouser@n01se.net said: (In [[r:0ba40a260162330836b97f6d1bf3466404a63b55]]) Implement take-last Fixes #151

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/146
Attachments:
fix_and_test_146.diff - https://www.assembla.com/spaces/clojure/documents/b0V98YAUWr3Qj6eJe5afGb/download/b0V98YAUWr3Qj6eJe5afGb
fix_and_test_146_v2.diff - https://www.assembla.com/spaces/clojure/documents/aa7RF6AVOr3PFkeJe5afGb/download/aa7RF6AVOr3PFkeJe5afGb
fix_and_test_146_v3.diff - https://www.assembla.com/spaces/clojure/documents/bNDk58GSGr3OJWeJe5aVNr/download/bNDk58GSGr3OJWeJe5aVNr

fsodomka said: [file:b0V98YAUWr3Qj6eJe5afGb]: fix errors and add tests

fsodomka said: See patch fix_and_test_146.diff. Fixes Java code and adds tests. It is my first patch for the Java code of Clojure, so be careful

fsodomka said: [file:aa7RF6AVOr3PFkeJe5afGb]: fix errors and add tests

richhickey said: A better fix is to use RT.count(s) rather than s.count(). Then there is no special handling.

fsodomka said: [file:bNDk58GSGr3OJWeJe5aVNr]: fix errors and add tests

fsodomka said: New version of patch uploaded. See if this works.

richhickey said: Patch v3 is ok, thanks

chouser@n01se.net said: Child association with ticket #188 was added

fsodomka said: (In [[r:270185aba54cef1d8ce59ec347b5623f2e502afe]]) fixed NPE when creating an empty array of ints, longs, floats or doubles, fixes #146

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/144
Attachments:
test_clojure_are.diff - https://www.assembla.com/spaces/clojure/documents/dvCpAkANar3QdBeJe5afGb/download/dvCpAkANar3QdBeJe5afGb
test_clojure_are_v2.diff - https://www.assembla.com/spaces/clojure/documents/damCkoAVKr3PdgeJe5afGb/download/damCkoAVKr3PdgeJe5afGb

fsodomka said: [file:dvCpAkANar3QdBeJe5afGb]: fixes test_clojure/numbers.clj

fsodomka said: [file:damCkoAVKr3PdgeJe5afGb]: fixes test_clojure/numbers.clj

fsodomka said: Parent association with ticket #131 was added

richhickey said: I don't understand this.

fsodomka said: Old 'are' had syntax (are condition expr1 expr2 ...), but new 'are' has (are params-vector condition expr1 expr2 ...). Tests in numbers.clj were updated with params-vector [x], but no condition were given.

user=> (macroexpand-1 '(are [x] true false nil))
(clojure.template/do-template [x] (clojure.test/is true) false nil)

Clearly, test (are [x] true false nil) will never fail, because first value is logically true and false and nil will never be considered.

See more explanation in:
http://groups.google.com/group/clojure-dev/browse_frm/thread/d0fd9d717db1e1db

fsodomka said: (In [[r:6e29153854c799cb46abc23382059d6ee20e755e]]) fixed test-clojure, refs #144

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/143

richhickey said: (In [[r:961743446562b6fa7be25f96de02aacd626169da]]) support overlapping ensures with no retry, refs #143

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/142

richhickey said: (In [[r:c4a5cd208aef54ae5b292fa41c4880017315e553]]) fix compile-time NPE on set! of non-existent field, fixes #142

Branch: master

chouser@n01se.net said: Child association with ticket #147 was added

Converted from http://www.assembla.com/spaces/clojure/tickets/138

richhickey said: (In [[r:6201f5e2ddd52f1b483d75563b0380deba59777c]]) added ref min/max history control - refs #138

Branch: master