<< Back to previous view

[CLJ-229] Clean up changes.txt formatting Created: 18/Dec/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Stuart Sierra
Resolution: Completed Votes: 0
Labels: None


 Description   

E.g., limit lines to 70 characters, normalize spacing between sections



 Comments   
Comment by Assembla Importer [ 24/Aug/10 5:37 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/229
Attachments:
fixchanges-1.patch - https://www.assembla.com/spaces/clojure/documents/djOatA6-8r3RgSeJe5aVNr/download/djOatA6-8r3RgSeJe5aVNr
fixchanges-2.patch - https://www.assembla.com/spaces/clojure/documents/bc3HYG6_yr3RgSeJe5aVNr/download/bc3HYG6_yr3RgSeJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 5:37 AM ]

stuart.sierra said: [file:djOatA6-8r3RgSeJe5aVNr]: Patch

Comment by Assembla Importer [ 24/Aug/10 5:37 AM ]

stuart.sierra said: [file:bc3HYG6_yr3RgSeJe5aVNr]: Patch from 1.1.x

Comment by Assembla Importer [ 24/Aug/10 5:37 AM ]

richhickey said: Updating tickets (#229, #227, #228)





[CLJ-228] Note old launcher deprecation in changes.txt Created: 18/Dec/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Stuart Sierra
Resolution: Completed Votes: 0
Labels: None


 Comments   
Comment by Assembla Importer [ 24/Aug/10 5:37 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/228

Comment by Assembla Importer [ 24/Aug/10 5:37 AM ]

richhickey said: Updating tickets (#229, #227, #228)





[CLJ-227] rc0: changes.txt missing deprecations of legacy entry points Created: 17/Dec/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Stuart Sierra
Resolution: Completed Votes: 0
Labels: None


 Description   

changes.txt should mention the deprecation of clojure.lang.Repl and clojure.lang.Script



 Comments   
Comment by Assembla Importer [ 24/Aug/10 8:37 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/227

Comment by Assembla Importer [ 24/Aug/10 8:37 AM ]

richhickey said: Updating tickets (#229, #227, #228)





[CLJ-226] Formatting fixes for doc strings Created: 17/Dec/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Tom Faulhaber
Resolution: Completed Votes: 0
Labels: None


 Description   

Looking at the automatically generated API documentation, I noticed that some doc strings were running off the right margin because of very long lines. Also, remove-method had a tab in the middle of the doc string.

I've made a patch that contains only updates to the doc strings and no logic strings and recommend it for a 1.1 "cleanup" style fix.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 2:36 PM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/226
Attachments:
docstr-format.diff - https://www.assembla.com/spaces/clojure/documents/b_3dw46ZOr3RLoeJe5afGb/download/b_3dw46ZOr3RLoeJe5afGb





[CLJ-225] Unintentional redef of bound-fn in clojure.core Created: 16/Dec/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Rich Hickey
Resolution: Completed Votes: 0
Labels: None


 Description   

Found an unintentional redefinition in core.clj:

On line 1285:

(defmacro bound-fn
"Returns a function defined by the given fntail, which will install the
same bindings in effect as in the thread at the time bound-fn was called.
This may be used to define a helper function which runs on a different
thread, but needs the same bindings in place."
[& fntail]
`(bound-fn* (fn ~@fntail)))

On line 3433:

(defn bound-fn
{:private true}
[#^clojure.lang.Sorted sc test key]
(fn [e]
(test (.. sc comparator (compare (. sc entryKey e) key)) 0)))

My initial guess is that the second one should be called bound?-fn as long as it's kosher to put a ? in the middle of an identifier.

I can whip up a patch if a good name is agreed upon.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 2:36 PM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/225

Comment by Assembla Importer [ 24/Aug/10 2:36 PM ]

richhickey said: (In [[r:3d8c97a939e5779553c53f47696f7445cf378583]]) fix name conflict - bound-fn. fixes #225

Branch: master





[CLJ-224] Create ZIP distribution from build Created: 16/Dec/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Enhancement
Reporter: Anonymous Assignee: Stuart Sierra
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

Need a way to generate a complete clojure-{VERSION}.zip file from the Ant build.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 2:35 PM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/224
Attachments:
fix224-1.patch - https://www.assembla.com/spaces/clojure/documents/cuk2I06E8r3O4veJe5aVNr/download/cuk2I06E8r3O4veJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 2:35 PM ]

stuart.sierra said: [file:cuk2I06E8r3O4veJe5aVNr]: Patch to build

Comment by Assembla Importer [ 24/Aug/10 2:35 PM ]

stuart.sierra said: (In [[r:0f6e9932b2770a670630862853d14feeab3b105b]]) Add "dist" Ant target to build distribution ZIP; refs #224

Signed-off-by: Rich Hickey <richhickey@gmail.com>

Branch: master

Comment by Assembla Importer [ 24/Aug/10 2:35 PM ]

stuart.sierra said: (In [[r:3e813629e70d7b8e0e602adf553c0f5a516aa61f]]) Add "dist" dir and "*.zip" to .gitignore for build; refs #224

Signed-off-by: Rich Hickey <richhickey@gmail.com>

Branch: master





[CLJ-223] Maven build produces empty JAR Created: 15/Dec/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Unassigned
Resolution: Declined Votes: 0
Labels: None


 Description   

Currently, "ant" generates a valid pom.xml. but "mvn install" doesn't work – the target JAR is empty.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 2:34 PM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/223

Comment by Assembla Importer [ 24/Aug/10 2:34 PM ]

stuart.sierra said: The Ant build script defines a "ci-build" target that can take the place of "mvn install".

To use it, you need to download the Maven Ant Tasks jar from http://maven.apache.org/ant-tasks/

Then run Ant like this:

ant -lib maven-ant-tasks-2.1.0.jar ci-build

This is an acceptable alternative to a build that works with "mvn install", in my opinion.





[CLJ-221] document :pre and :post Created: 12/Dec/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Enhancement
Reporter: Anonymous Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None


 Description   

http://github.com/richhickey/clojure/commit/0ac482878a1dd520cbee2faa0f5f6ab1082ffa76 is only documentation.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 8:32 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/221

Comment by Assembla Importer [ 24/Aug/10 8:32 AM ]

stuart.sierra said: Pre/Post Documentation added to "Changes in 1.1" document at http://docs.google.com/Doc?docid=0AeEMlyQZQkUMZGhxM2hyOV8zNXBucjNmeGc1&hl=en

Comment by Assembla Importer [ 24/Aug/10 8:32 AM ]

oranenj said: I have patches to document this in fn's docstring (it's almost the same text as in the changes document), but it feels like the wrong place for it. First of all, it applies to defn and defmacro as well of course, since they expand to fn... but that's not obvious, and it would have to be explained in defn's docstring. Secondly, think it simply makes the documentation for fn too long.

So, how about adding some dummy vars for documenting "general" features and then just point people to them in fn/defn/defmacro/whatever? Something like (def #^{:doc "whatever"} feature-function-conditions)

We could also have similar dummy vars for feature-transients etc. They would stand out in the API doc, making the features easier to discover, too.

Comment by Assembla Importer [ 24/Aug/10 8:32 AM ]

richhickey said: I put doc for pre/post in http://clojure.org/special_forms





[CLJ-219] filter doesn't have a doc string Created: 08/Dec/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Rich Hickey
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

In commit cf3b547e7d8f95d6e4234881f8122bb823ff46cd ("made filter chunk-aware" on Jun 20, 2009), the doc string for filter was dropped.

I have included a patch that adds back the original doc string. I don't know if there was a reason Rich dropped that doc string or if it was just a finger fumble.

In any case, filter is a significant enough function and this is a small enough change that I recommend that we fix it for 1.1.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 8:29 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/219
Attachments:
filter-doc.diff - https://www.assembla.com/spaces/clojure/documents/d4d-t848ur3OjYeJe5afGb/download/d4d-t848ur3OjYeJe5afGb

Comment by Assembla Importer [ 24/Aug/10 8:29 AM ]

tomfaulhaber said: [file:d4d-t848ur3OjYeJe5afGb]





[CLJ-218] Deprecate old launch Classes Created: 06/Dec/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Stuart Sierra
Resolution: Completed Votes: 0
Labels: None


 Description   

Deprecate clojure.lang.Repl and clojure.lang.Script and their implementations legacy-repl and legacy-script in clojure.main.

Discussed here:
http://groups.google.com/group/clojure-dev/browse_thread/thread/5d51d6540b08da55



 Comments   
Comment by Assembla Importer [ 24/Aug/10 5:27 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/218
Attachments:
fix218-1.patch - https://www.assembla.com/spaces/clojure/documents/d-nbCa6Far3QNNeJe5afGb/download/d-nbCa6Far3QNNeJe5afGb
fix218-2.patch - https://www.assembla.com/spaces/clojure/documents/cE4I0S6Zer3PcSeJe5aVNr/download/cE4I0S6Zer3PcSeJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 5:27 AM ]

stuart.sierra said: [file:d-nbCa6Far3QNNeJe5afGb]: Patch

Comment by Assembla Importer [ 24/Aug/10 5:27 AM ]

stuart.sierra said: Patch fix218-1 prints a deprecation warning in legacy-repl and legacy-script.

Comment by Assembla Importer [ 24/Aug/10 5:27 AM ]

richhickey said: Should those warnings tell people how to call clojure.main in order to get the same effect?

Comment by Assembla Importer [ 24/Aug/10 5:27 AM ]

stuart.sierra said: [file:cE4I0S6Zer3PcSeJe5aVNr]: Patch

Comment by Assembla Importer [ 24/Aug/10 5:27 AM ]

stuart.sierra said: (In [[r:2cc710e7aeaab08e0739debe21e2cc6b7020e1b1]]) main.clj: deprecation warning w/ usage for legacy repl/script; refs #218

Signed-off-by: Rich Hickey <richhickey@gmail.com>

Branch: master





[CLJ-217] Add :doc and :author strings to all core namespaces Created: 03/Dec/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Stuart Sierra
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Comments   
Comment by Assembla Importer [ 24/Aug/10 8:25 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/217
Attachments:
fix217-1.diff - https://www.assembla.com/spaces/clojure/documents/cP92vk4dKr3Qa0eJe5afGb/download/cP92vk4dKr3Qa0eJe5afGb

Comment by Assembla Importer [ 24/Aug/10 8:25 AM ]

stuart.sierra said: [file:cP92vk4dKr3Qa0eJe5afGb]: patch

Comment by Assembla Importer [ 24/Aug/10 8:25 AM ]

stuart.sierra said: Patch fix217-1.diff also notes "DEPRECATED" in clojure.parallel docstring, refs #217

Comment by Assembla Importer [ 24/Aug/10 8:25 AM ]

stuart.sierra said: I mean refs #216

Comment by Assembla Importer [ 24/Aug/10 8:25 AM ]

stuart.sierra said: (In [[r:76e7c4317dc3eac80c4908ac5e5fb885e302b2a4]]) Add :doc and :author metadata to core namespaces; fixes #216, fixes #217

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-216] Deprecate clojure.parallel Created: 01/Dec/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Stuart Sierra
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

parallel.clj won't work with jdk7. Move to FJ work in par branch



 Comments   
Comment by Assembla Importer [ 24/Aug/10 5:24 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/216

Comment by Assembla Importer [ 24/Aug/10 5:24 AM ]

stuart.sierra said: Note added to doc string in patch for #217

Comment by Assembla Importer [ 24/Aug/10 5:24 AM ]

stuart.sierra said: (In [[r:76e7c4317dc3eac80c4908ac5e5fb885e302b2a4]]) Add :doc and :author metadata to core namespaces; fixes #216, fixes #217

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-215] Deprecate ^ reader macro Created: 01/Dec/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Stuart Sierra
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

Deprecate ^ reader macro, so eventually ^ can replace #^



 Comments   
Comment by Assembla Importer [ 24/Aug/10 5:24 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/215
Attachments:
fix215-1.diff - https://www.assembla.com/spaces/clojure/documents/aqtxy64eOr3Qa0eJe5afGb/download/aqtxy64eOr3Qa0eJe5afGb
fix215-2.diff - https://www.assembla.com/spaces/clojure/documents/bsUjGu4eSr3RlweJe5aVNr/download/bsUjGu4eSr3RlweJe5aVNr
fix215-3.diff - https://www.assembla.com/spaces/clojure/documents/buJlye4e4r3Qa0eJe5afGb/download/buJlye4e4r3Qa0eJe5afGb

Comment by Assembla Importer [ 24/Aug/10 5:24 AM ]

stuart.sierra said: [file:aqtxy64eOr3Qa0eJe5afGb]: patch

Comment by Assembla Importer [ 24/Aug/10 5:24 AM ]

stuart.sierra said: Patch fix215-1.diff prints deprecation warning whenever ^ is used and removes all uses of ^ in core.

Comment by Assembla Importer [ 24/Aug/10 5:24 AM ]

stuart.sierra said: [file:bsUjGu4eSr3RlweJe5aVNr]: Better patch

Comment by Assembla Importer [ 24/Aug/10 5:24 AM ]

stuart.sierra said: [file:buJlye4e4r3Qa0eJe5afGb]: Best patch

Comment by Assembla Importer [ 24/Aug/10 5:24 AM ]

stuart.sierra said: (In [[r:20e4e45f18b8cd9833846aa8cf441ceebd98cca8]]) Remove deprecated ^ reader macro from core sources; refs #215

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Comment by Assembla Importer [ 24/Aug/10 5:24 AM ]

chouser@n01se.net said: (In [[r:b3b1fa5081172d9931d7dffac4e12a535871cfde]]) Print deprecation warning for ^ reader macro; refs #215

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Comment by Assembla Importer [ 24/Aug/10 5:24 AM ]

stuart.sierra said: (In [[r:f047dc4acc69350d3513b4e69e093690cdb92e40]]) Remove deprecated ^ reader macro from tests; fixes #215

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-214] Deprecate add-classpath Created: 01/Dec/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Stuart Sierra
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

Deprecate add-classpath



 Comments   
Comment by Assembla Importer [ 24/Aug/10 5:24 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/214
Attachments:
fix214-1.diff - https://www.assembla.com/spaces/clojure/documents/aNTaNW4dCr3Qa0eJe5afGb/download/aNTaNW4dCr3Qa0eJe5afGb

Comment by Assembla Importer [ 24/Aug/10 5:24 AM ]

stuart.sierra said: [file:aNTaNW4dCr3Qa0eJe5afGb]: patch

Comment by Assembla Importer [ 24/Aug/10 5:24 AM ]

stuart.sierra said: (In [[r:c5abcf6751c0fed34b72eab49ec9989458651bbf]]) deprecate add-classpath in docstring, print warning; fixes #214

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-210] sorted-set-by fails when given no values Created: 13/Nov/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Timothy Pratley
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

As described here: http://groups.google.com/group/clojure/browse_thread/thread/1e9c368245800695
(sorted-set-by >) throws a null pointer exception.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 2:10 PM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/210
Attachments:
sorted-set-by.diff - https://www.assembla.com/spaces/clojure/documents/cCsdcIZ_Wr3QwreJe5aVNr/download/cCsdcIZ_Wr3QwreJe5aVNr
ssb2.diff - https://www.assembla.com/spaces/clojure/documents/bHx3hk2Her3QkseJe5aVNr/download/bHx3hk2Her3QkseJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 2:10 PM ]

timothypratley said: [file:cCsdcIZ_Wr3QwreJe5aVNr]: removed bad initializers, added tests

Comment by Assembla Importer [ 24/Aug/10 2:10 PM ]

timothypratley said: public static PersistentTreeSet create(Comparator comp, Object... init)
was shadowing
public static PersistentTreeSet create(Comparator comp, List init)

I can't see any reason why Object... init should be there (it is only for sorted-set-by but not needed) so I've simply removed it and added test coverage. Please advise if this is valid or if there is any reason Object... init is useful.

Comment by Assembla Importer [ 24/Aug/10 2:10 PM ]

richhickey said: FYI - please don't assign things to me - thanks

Comment by Assembla Importer [ 24/Aug/10 2:10 PM ]

richhickey said: 'ant test' fails for clojure, with:
[java] ERROR in (test-sorted-set-by) (test_clojure.clj:77)
[java] expected: (set? (sorted-set-by <))
[java] actual: java.lang.NullPointerException: null
[java] at clojure.lang.PersistentTreeSet.create (PersistentTreeSet.java:33)

Comment by Assembla Importer [ 24/Aug/10 2:10 PM ]

timothypratley said: Hi Rich,

Ok thanks.

I tried from a fresh branch, for some reason 'ant test' does not recompile the java code (which has changed very slightly to fix the bug). However if you first run 'ant' then run 'ant test' it works fine and all tests pass. This seems to show that the build.xml isn't finding the dependency, but that is unrelated to this patch I believe.

Can you please try again with a clean build before ant test?

Regards,
Tim.

Comment by Assembla Importer [ 24/Aug/10 2:10 PM ]

richhickey said: I did ant + ant test. Just tried again, same problem. Perhaps some important change didn't make it into your patch? Please pull down master and apply your patch to it in order to reproduce/diff. Thanks.

Comment by Assembla Importer [ 24/Aug/10 2:10 PM ]

timothypratley said: Short answer - I am pretty sure the next attachment will fix it!

Long answer -

Hmmmm very odd! I can't reproduce any error here so it must be related to my environment somehow.

git clone git://github.com/richhickey/clojure.git
cd clojure
ant
ant test
works fine.... of course
git am -s < sorted-set-by.diff
ant
[java] ERROR in (test-sorted-set-by) (test_clojure.clj:77)
[java] expected: (set? (sorted-set-by <))
[java] actual: java.lang.NullPointerException: null
[java] at clojure.lang.PersistentTreeSet.create (PersistentTreeSet.java:50)
expected, line number 50 is different from 33, again that's expected
ant
ant test
works fine for me but errors on line 33 PersistentTreeSet for you
PersistentTreeSet line 33:
for(Object key : init)
init is clearly null
I added some printouts - it never gets called for me - but does for you
Summary - must be shadowing again!!! Argghhhh...

Uploading patch now which should resolve.

Comment by Assembla Importer [ 24/Aug/10 2:10 PM ]

timothypratley said: [file:bHx3hk2Her3QkseJe5aVNr]: new patch





[CLJ-209] Unifying the array support for primitives (part 1) Created: 10/Nov/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Enhancement
Reporter: Anonymous Assignee: Timothy Pratley
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

As discussed here:
http://groups.google.com/group/clojure/browse_thread/thread/9a276a1709a88eeb

Simply adding X-array, Xs



 Comments   
Comment by Assembla Importer [ 24/Aug/10 5:08 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/209
Attachments:
arrays.diff - https://www.assembla.com/spaces/clojure/documents/ab7__AZOur3RCOeJe5afGb/download/ab7__AZOur3RCOeJe5afGb
arrays.diff - https://www.assembla.com/spaces/clojure/documents/d30jsYZOWr3QYEeJe5aVNr/download/d30jsYZOWr3QYEeJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 5:08 AM ]

timothypratley said: [file:ab7__AZOur3RCOeJe5afGb]: copy+paste solution

Comment by Assembla Importer [ 24/Aug/10 5:08 AM ]

timothypratley said: Straightforward approach of adding boolean/byte/char/short in similar fashion to existing. I've marked this as (part 1) as it adds the missing features but there still might be some thinking required on how to 'unify' and/or reduce boilerplate. Happy to work on further if any suggestions.

Please note, have added tests as part of patch.

Comment by Assembla Importer [ 24/Aug/10 5:08 AM ]

timothypratley said: Re-assigning to you Rich as I'm not sure what the process is from here.

Comment by Assembla Importer [ 24/Aug/10 5:08 AM ]

timothypratley said: [file:d30jsYZOWr3QYEeJe5aVNr]: added some more tests

Comment by Assembla Importer [ 24/Aug/10 5:08 AM ]

chouser@n01se.net said: That last patch looks good to me. Not much can be done to reduce boilerplate in the Java. I suppose a private macro could be used for the repetition in Clojure, but I don't know if that's necessary. The . forms could be switched to a more "modern" format, if you're looking for extra ways to clean it up.

As for process, unless you want to make above changes, you're done. Next up Rich comments on or approves the patch.

Comment by Assembla Importer [ 24/Aug/10 5:08 AM ]

timothypratley said: Ok I'll add those changes





[CLJ-208] pom uses old artifactId Created: 03/Nov/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Tim Dysinger
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

The pom generated by the build process uses the old "clojure-lang" artifact ID. Since the official repositories host a build with just plain "clojure", we should update to be consistent.

I believe this was discussed a while ago on the mailing list, but the fix never made it into git.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 5:02 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/208
Attachments:
clojure-build.patch - https://www.assembla.com/spaces/clojure/documents/aNaDJ4YlCr3PeJeJe5aVNr/download/aNaDJ4YlCr3PeJeJe5aVNr
contrib-build.patch - https://www.assembla.com/spaces/clojure/documents/aNaGuWYlCr3PeJeJe5aVNr/download/aNaGuWYlCr3PeJeJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 5:02 AM ]

technomancy said: [file:aNaDJ4YlCr3PeJeJe5aVNr]

Comment by Assembla Importer [ 24/Aug/10 5:02 AM ]

technomancy said: [file:aNaGuWYlCr3PeJeJe5aVNr]

Comment by Assembla Importer [ 24/Aug/10 5:02 AM ]

stuart.sierra said: Why is this assigned to me?

Comment by Assembla Importer [ 24/Aug/10 5:02 AM ]

technomancy said: Stuart: I assumed you were the commiter most familiar with Maven; sorry if that was presumptuous.

Comment by Assembla Importer [ 24/Aug/10 5:02 AM ]

stuart.sierra said: Well, I'm moderately familiar with Maven, but I don't have commit privileges on core; that's the only reason why I was confused by the assignment.

Comment by Assembla Importer [ 24/Aug/10 5:02 AM ]

technomancy said: Ah, I didn't realize there are was a separate set of committers for contrib.

Comment by Assembla Importer [ 24/Aug/10 5:02 AM ]

dysinger said: (In [[r:5f96d1cb7eeac29b3894e63ce9e17f29d062d15d]]) changed the pom to match whats been pushed on public maven repos Fixes #208

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-206] make -> and ->> metadata-aware Created: 23/Oct/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Enhancement
Reporter: Anonymous Assignee: Christophe Grand
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

Macros ></code> and <code>>> are currently hard to hint because metadata aren't preserved on lists.
Together with #205, it would allow to write:
(-> #^objects dd #^doubles (aget i) (aget j))
(instead of {{(let [#^doubles a (aget #^objects dd i)] (aget a j))}})



 Comments   
Comment by Assembla Importer [ 24/Aug/10 7:55 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/206
Attachments:
0001-make-and-metadata-aware.patch - https://www.assembla.com/spaces/clojure/documents/dVsuqiWaCr3PaHeJe5afGb/download/dVsuqiWaCr3PaHeJe5afGb

Comment by Assembla Importer [ 24/Aug/10 7:55 AM ]

cgrand said: [file:dVsuqiWaCr3PaHeJe5afGb]: patch

Comment by Assembla Importer [ 24/Aug/10 7:55 AM ]

meikelbrandmeyer said: Isn't it sufficient to hint inside the parens?

Clojure
user=> (set! *warn-on-reflection* true)
true
user=> (-> "foo" identity .length)
Reflection warning, NO_SOURCE_PATH:2 - reference to field length can't be resolved.
3
user=> (-> "foo" #^String identity .length)
3
user=> (-> "foo" #^String (identity) .length)
Reflection warning, NO_SOURCE_PATH:4 - reference to field length can't be resolved.
3
user=> (-> "foo" (#^String identity) .length)
3
Comment by Assembla Importer [ 24/Aug/10 7:55 AM ]

cgrand said: The first time I had to hint a -> form, I found that hinting inside the parens wasn't obvious. It feels more regular to me like this
I should maybe rework #205 to also preserve tags on the first item of the list and make both ways (inside and outside) works with inlined and interop form.

Comment by Assembla Importer [ 24/Aug/10 7:55 AM ]

cgrand said: (In [[r:749a0ad8b66c781d8176833f0ad26cfe6b9b24e3]]) make -> and ->> metadata-aware Fixes #206

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-205] Preserve type hints set on inlined or interop forms Created: 23/Oct/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Enhancement
Reporter: Anonymous Assignee: Christophe Grand
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

Currently one can't hint forms which are expanded by the compiler (interop sugar and inlines):

  • on instance methods:
    user=> (.size #^java.util.ArrayList (.clone (java.util.ArrayList.)))
    Reflection warning, NO_SOURCE_PATH:2 - reference to field size can't be resolved.
  • on static methods:
    user=> (.nth #^clojure.lang.Indexed (clojure.lang.RT/conj [] 2) (int 0))
    Reflection warning, NO_SOURCE_PATH:21 - call to nth can't be resolved.
  • on instance fields:
    user=> (.count #^clojure.lang.Counted (.val (clojure.lang.Box. [])))
    Reflection warning, NO_SOURCE_PATH:23 - reference to field count can't be resolved.
  • on static fields:
    user=> #(.withMeta #^clojure.lang.AFn clojure.lang.RT/EMPTY_GEN nil)
    Reflection warning, NO_SOURCE_PATH:18 - call to withMeta can't be resolved.
  • on inlines;
    user=> (.count #^clojure.lang.Counted (aget (into-array [[]]) 0))
    Reflection warning, NO_SOURCE_PATH:33 - reference to field count can't be resolved.

Discussed on #clojure http://clojure-log.n01se.net/date/2009-10-22.html#08:18



 Comments   
Comment by Assembla Importer [ 24/Aug/10 5:55 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/205
Attachments:
0001-Preserve-type-hints-set-on-inlined-or-interop-forms-.patch - https://www.assembla.com/spaces/clojure/documents/aqWBuKWaqr3OFEeJe5aVNr/download/aqWBuKWaqr3OFEeJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 5:55 AM ]

cgrand said: [file:aqWBuKWaqr3OFEeJe5aVNr]: patch

Comment by Assembla Importer [ 24/Aug/10 5:55 AM ]

cgrand said: I have a related patch now that this point is fixed which make -> and ->> preserve metadata when splicing a list. Should I open another ticket for that? see http://github.com/cgrand/clojure/commit/a027636d9ef857ee80cb13190731a2801684fe9c

Comment by Assembla Importer [ 24/Aug/10 5:55 AM ]

cgrand said: (In [[r:4115b53938c56e282b9de9701a2db474324092bd]]) Preserve type hints set on inlined or interop forms, fixes #205

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-203] Add line to .gitignore for local netbeans project directory Created: 20/Oct/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Enhancement
Reporter: Anonymous Assignee: Chas Emerick
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

Oddly, git always fails to cleanly merge an altered .gitignore we keep that contains a line for the local netbeans project directory. It would be very convenient if that line were to be added to .gitignore upstream...



 Comments   
Comment by Assembla Importer [ 24/Aug/10 1:53 PM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/203
Attachments:
nbproject-ignore.diff - https://www.assembla.com/spaces/clojure/documents/dk0z6KVAOr3OGKeJe5afGb/download/dk0z6KVAOr3OGKeJe5afGb

Comment by Assembla Importer [ 24/Aug/10 1:53 PM ]

cemerick said: [file:dk0z6KVAOr3OGKeJe5afGb]





[CLJ-202] defmethod impl causes reflection warnings Created: 20/Oct/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Enhancement
Reporter: Anonymous Assignee: Chas Emerick
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

...because the addMethod invocation isn't hinted. Doesn't impact runtime perf, but does litter one's compilation output with reflection warnings.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 5:53 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/202
Attachments:
defmethod-type-hint.diff - https://www.assembla.com/spaces/clojure/documents/c_VwQqVAGr3QYWeJe5afGb/download/c_VwQqVAGr3QYWeJe5afGb

Comment by Assembla Importer [ 24/Aug/10 5:53 AM ]

cemerick said: [file:c_VwQqVAGr3QYWeJe5afGb]





[CLJ-201] Make deftest keep var metadata Created: 19/Oct/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Stuart Halloway
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

Currently deftest discards metadata from the symbol passed in to it.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 7:51 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/201
Attachments:
0001-Add-test-for-metadata-carrying-deftest.patch - https://www.assembla.com/spaces/clojure/documents/dFcI08Vg8r3P7CeJe5aVNr/download/dFcI08Vg8r3P7CeJe5aVNr
0002-Preserve-test-var-metadata-within-deftest.-Fixes-20.patch - https://www.assembla.com/spaces/clojure/documents/dFkVS0Vg8r3P7CeJe5aVNr/download/dFkVS0Vg8r3P7CeJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 7:51 AM ]

technomancy said: [file:dFcI08Vg8r3P7CeJe5aVNr]: Tests

Comment by Assembla Importer [ 24/Aug/10 7:51 AM ]

technomancy said: [file:dFkVS0Vg8r3P7CeJe5aVNr]: Implementation

Comment by Assembla Importer [ 24/Aug/10 7:51 AM ]

technomancy said: (In [[r:7779c99699f29118ee9fc66201c7afdd1a5dd300]]) Preserve test var metadata within deftest. Fixes #201.

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Comment by Assembla Importer [ 24/Aug/10 7:51 AM ]

technomancy said: (In [[r:9bde10da7b13dd24b5666260d231d79792a34305]]) Add test for metadata-carrying deftest. Refs #201

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-194] clojure.test use-fixtures function composes fixture functions repeatedly Created: 07/Oct/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Stuart Sierra
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

If you call use-fixtures over and over again, it will simply compose the test deeper and deeper into a nesting of the fixture function.

�� (use-fixtures :each my-cleanup)
�� (deftest my-messy-test [...])

Load that a few times and you end up running the equivalent of:
(my-cleanup (my-cleanup (my-cleanup my-messy-test))).



 Comments   
Comment by Assembla Importer [ 24/Aug/10 4:45 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/194
Attachments:
0001-Don-t-repeatedly-compose-on-calls-to-use-fixtures.-F.patch - https://www.assembla.com/spaces/clojure/documents/cU7IgoS2Or3PCKeJe5aVNr/download/cU7IgoS2Or3PCKeJe5aVNr
0001-Don-t-repeatedly-compose-on-calls-to-use-fixtures.-F.patch - https://www.assembla.com/spaces/clojure/documents/a51RI-S2Wr3PxveJe5aVNr/download/a51RI-S2Wr3PxveJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 4:45 AM ]

technomancy said: [file:cU7IgoS2Or3PCKeJe5aVNr]: Patch with a fix.

Comment by Assembla Importer [ 24/Aug/10 4:45 AM ]

technomancy said: Fix attached.

Comment by Assembla Importer [ 24/Aug/10 4:45 AM ]

technomancy said: [file:a51RI-S2Wr3PxveJe5aVNr]: Fixed patch

Comment by Assembla Importer [ 24/Aug/10 4:45 AM ]

technomancy said: Ignore that first patch; the implementation worked, but the test was silly.

Comment by Assembla Importer [ 24/Aug/10 4:45 AM ]

mikehinchey said: Backport for contrib clojure-1.0-compatibility

Comment by Assembla Importer [ 24/Aug/10 4:45 AM ]

technomancy said: (In [[r:f5f2943dfd0128744227c3f42a630ea10dd40b24]]) Don't repeatedly compose on calls to use-fixtures. Fixes #194.

Updated tests and added a docstring to use-fixtures.

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-193] Return summary & successful? for clojure.test Created: 24/Sep/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Enhancement
Reporter: Anonymous Assignee: Stuart Sierra
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

clojure.test/run-tests does not return a value, making it difficult to integrate with build frameworks such as Ant and Maven.

This patch was written by Jason Sankey, who is a registered contributor.

The patch modifies run-tests to return the test summary results (the same map sent to the report function).

The patch also adds a new function, "successful?", which returns true if the summary indicates that there were no failures or errors.

A test script or main program can call (successful? (run-tests ...)) and then indicate success or failure in System/exit.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 7:37 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/193
Attachments:
test-ideas-summary.patch - https://www.assembla.com/spaces/clojure/documents/dDYqFAQsKr3RHfeJe5aVNr/download/dDYqFAQsKr3RHfeJe5aVNr
fix193-1.patch - https://www.assembla.com/spaces/clojure/documents/cdsoTU3Pmr3Q3BeJe5aVNr/download/cdsoTU3Pmr3Q3BeJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 7:37 AM ]

stuart.sierra said: [file:dDYqFAQsKr3RHfeJe5aVNr]: patch to run-tests and successful?

Comment by Assembla Importer [ 24/Aug/10 7:37 AM ]

stuart.sierra said: Checked against commit 3e60eff602652e753a54ba88b25dbdd2615c3b2e and still applies ok.

Comment by Assembla Importer [ 24/Aug/10 7:37 AM ]

richhickey said: Not a valid patch format, needs git format-patch

Comment by Assembla Importer [ 24/Aug/10 7:37 AM ]

digash said: I've ran into the same issue as a work around. Just bind the function to the patched one.

(defn patched-run-tests
  "Runs all tests in the given namespaces; prints results.
  Defaults to current namespace if none given."
  ([] (run-tests *ns*))
  ([& namespaces]
     (let [summary (assoc (apply merge-with + (map test-ns namespaces))
                     :type :summary)]
       (report summary)
       summary)))

(defn successful?
  "Returns true if the given test summary indicates all tests
  were successful, false otherwise."
  [summary]
  (and (zero? (:fail summary))
       (zero? (:error summary))))

(binding [clojure.test/run-tests patched-run-tests]
  (when-not (successful? (run-all-tests #".*test.*"))
    (System/exit 1)))
Comment by Assembla Importer [ 24/Aug/10 7:37 AM ]

stuart.sierra said: [file:cdsoTU3Pmr3Q3BeJe5aVNr]: Correctly-formatted patch

Comment by Assembla Importer [ 24/Aug/10 7:37 AM ]

stuart.sierra said: (In [[r:607389029cfec50f32b73c00a6f66d0a1dbcda23]]) clojure.test/run-tests: return summary, add successful?; refs #193

Reformatted patch.

Signed-off-by: Rich Hickey <richhickey@gmail.com>

Branch: master





[CLJ-192] hashmaps: count is not always updated when associng/dissocing a nil key Created: 17/Sep/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Christophe Grand
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

user=> (count (reduce conj (hash-map) (for [i (range 30)] [i nil])))
0

Patch attached.

(thanks to danlarkin for reporting it http://clojure-log.n01se.net/date/2009-09-16.html#13:12 )

BTW, what's the best way to add specific tests such as this one to the test suite?



 Comments   
Comment by Assembla Importer [ 24/Aug/10 7:32 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/192
Attachments:
count-assoc-dissoc.patch - https://www.assembla.com/spaces/clojure/documents/bOBpRYO1ar3PEPeJe5aVNr/download/bOBpRYO1ar3PEPeJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 7:32 AM ]

cgrand said: [file:bOBpRYO1ar3PEPeJe5aVNr]: patch

Comment by Assembla Importer [ 24/Aug/10 7:32 AM ]

fsodomka said: Concerning the test: In the past we were adding tests directly to the other tests for the given function. I would just add it in the test-count in data_structures.clj.

; associng/dissocing a nil key - ticket #192
(is (= 30 (count (reduce conj (hash-map) (for [i (range 30)] [i nil])))))





[CLJ-189] Doc for compare does not match implementation Created: 11/Sep/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Lauri Pesonen
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

(compare x y) returns a negative number, zero, or a positive number when x is logically 'less than', 'equal to', or 'greater than' y. The doc implies that it returns -1, 0, 1, respectively. We should fix the doc.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 4:29 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/189
Attachments:
compare-doc-defect.diff - https://www.assembla.com/spaces/clojure/documents/bpEPXANUmr3QLPeJe5aVNr/download/bpEPXANUmr3QLPeJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 4:29 AM ]

liwp said: [file:bpEPXANUmr3QLPeJe5aVNr]

Comment by Assembla Importer [ 24/Aug/10 4:29 AM ]

importer said: (In [[r:a2d986693592e321e7978f914c3ba4f563da6af3]]) Fix compare doc defect - fixes #189

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-186] StringSeq implements Counted but doesn't provide a specialized impl for count() Created: 27/Aug/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Christophe Grand
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

(count (seq (apply str (repeat 100000 "hello")))) throws a StackOverflowError



 Comments   
Comment by Assembla Importer [ 24/Aug/10 1:20 PM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/186
Attachments:
186-StringSeq-count.patch - https://www.assembla.com/spaces/clojure/documents/bDd_4MLWyr3Rb-eJe5afGb/download/bDd_4MLWyr3Rb-eJe5afGb

Comment by Assembla Importer [ 24/Aug/10 1:20 PM ]

cgrand said: [file:bDd_4MLWyr3Rb-eJe5afGb]: patch

Comment by Assembla Importer [ 24/Aug/10 1:20 PM ]

chouser@n01se.net said: Child association with ticket #187 was added

Comment by Assembla Importer [ 24/Aug/10 1:20 PM ]

cgrand said: (In [[r:2474dad2a56b32527bb6ee10545ee3de476bc583]]) Add missing specialized implementation for Counted/count on StringSeq. Fixes #186

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-185] clojure.zip/down doesn't always return nil when called on leaf Created: 27/Aug/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Achim Passen
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

The docs for zip/down state: "Returns the loc of the leftmost child of the node at this loc, or nil if no children", but in fact, down will always try to call the zipper's children function, even if branch? is false, i.e. on leaves. This behaviour is inconsistent with the doc string and with the behaviour of up, left and right, which always return nil.

(-> [1] clojure.zip/vector-zip clojure.zip/down clojure.zip/down)
; => java.lang.IllegalArgumentException: Don't know how to create ISeq from: Integer

Related, but not identical to #135



 Comments   
Comment by Assembla Importer [ 24/Aug/10 4:19 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/185
Attachments:
zip-down-bug.diff - https://www.assembla.com/spaces/clojure/documents/bR_nykKWWr3P7IeJe5aVNr/download/bR_nykKWWr3P7IeJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 4:19 AM ]

achimpassen said: [file:bR_nykKWWr3P7IeJe5aVNr]

Comment by Assembla Importer [ 24/Aug/10 4:19 AM ]

richhickey said: This seems to conflict with the policy of #135, which is to throw if non-branch

Comment by Assembla Importer [ 24/Aug/10 4:19 AM ]

achimpassen said: Why not have children throw and down return nil? The attached patch doesn't rely on one particular behaviour of children. IMHO, if down is supposed to throw, the doc string should be fixed, and for the sake of consistency, left/right/up should also throw on leftmost/rightmost/root nodes.

Comment by Assembla Importer [ 24/Aug/10 4:19 AM ]

achimpassen said: (In [[r:146f3614d100e9bce421afdcceee67aa0b956bb8]]) fixed zip/down on leaves, refs #185

Signed-off-by: Rich Hickey <richhickey@gmail.com>

Branch: master





[CLJ-183] leafless PersistentHashMap Created: 26/Aug/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Christophe Grand
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

see http://groups.google.com/group/clojure-dev/browse_thread/thread/4ab5a2a00e82c566



 Comments   
Comment by Assembla Importer [ 24/Aug/10 6:19 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/183
Attachments:
leafless.patch - https://www.assembla.com/spaces/clojure/documents/afd0l2KLqr3PFneJe5aVNr/download/afd0l2KLqr3PFneJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 6:19 AM ]

cgrand said: [file:afd0l2KLqr3PFneJe5aVNr]

Comment by Assembla Importer [ 24/Aug/10 6:19 AM ]

richhickey said: Patch applied - thanks!





[CLJ-181] proxy-name does not produce unique names Created: 24/Aug/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

be.nsa.server=> (proxy-name Object [Signal$Listener])
"clojure.proxy.java.lang.Object$Listener"
be.nsa.server=> (proxy-name Object [Signal1$Listener])
"clojure.proxy.java.lang.Object$Listener"

Proposed solution: include more than the simple name of interfaces (up to the last dot) and a hash of the full names.

eg : (proxy-name Object [Signal1$Listener])
"clojure.proxy.java.lang.Object$Signal1$Listener$af458"
(proxy-name Object [Signal1$Listener])
"clojure.proxy.java.lang.Object$Signal$Listener$4d54e"

Wouldn't the hash suffice?



 Comments   
Comment by Assembla Importer [ 24/Aug/10 6:17 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/181
Attachments:
181-proxy.patch - https://www.assembla.com/spaces/clojure/documents/au3qQmLWur3Rb-eJe5afGb/download/au3qQmLWur3Rb-eJe5afGb

Comment by Assembla Importer [ 24/Aug/10 6:17 AM ]

meikelbrandmeyer said: I'd like to add, that it would be nice, if the current namespace could also be included in the class generated by proxy. In it's current form it is very difficult to create several jars from one compilation tree, since it is difficult to find out which namespace defines which proxy.

The current solution requires to set up different compilation trees for different jars. Especially for simple setups this is a lot of unnecessary work.

Having the namespace encoded in the class name would make it easy to select the correct proxy classes.

Also, it would avoid clashes with third party libraries, which happen to define similar proxies.

Comment by Assembla Importer [ 24/Aug/10 6:17 AM ]

cgrand said: Attached patch:
proxy now caches generated classes per namespace and include a hash to distinguish proxy classes implementing homonymous interfaces. See #181

Comment by Assembla Importer [ 24/Aug/10 6:17 AM ]

richhickey said: I don't see the patch file

Comment by Assembla Importer [ 24/Aug/10 6:17 AM ]

cgrand said: [file:au3qQmLWur3Rb-eJe5afGb]: missing patch

Comment by Assembla Importer [ 24/Aug/10 6:17 AM ]

cgrand said: (In [[r:e73abece1ebf3a4aba22104ae9452b2b816ab0d7]]) proxy now caches generated classes per namespace and include a hash to distinguish proxy classes implementing homonymous interfaces. Fixes #181

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-179] (namespace (symbol "/")) returns "" instead of nil Created: 24/Aug/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

(namespace (symbol "/")) returns "", but
(namespace '/) returns nil, which is the expected behaviour.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 6:17 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/179
Attachments:
0001-Fix-namespace-for-symbol.patch - https://www.assembla.com/spaces/clojure/documents/a7PS5GKm4r3PbreJe5aVNr/download/a7PS5GKm4r3PbreJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 6:17 AM ]

oranenj said: [file:a7PS5GKm4r3PbreJe5aVNr]

Comment by Assembla Importer [ 24/Aug/10 6:17 AM ]

oranenj said: Child association with ticket #180 was added

Comment by Assembla Importer [ 24/Aug/10 6:17 AM ]

oranenj said: (In [[r:2f3d7d336122ca4f0c3961d92bbe0d05a4ec8316]]) Fix namespace for (symbol "/")

Fixes #179

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-177] Try latches instead of wait/notify in STM Created: 23/Aug/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None


 Description   

wait/notify might not have best throughput, try CountdownLatch instead



 Comments   
Comment by Assembla Importer [ 24/Aug/10 1:16 PM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/177





[CLJ-175] "Second argument to def must be a Symbol" should say 'First argument' Created: 17/Aug/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Lauri Pesonen
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

See clojure/lang/Compiler.java, line 354 (in static class Parser, method parse())

> (def "hi" "there")
java.lang.Exception: Second argument to def must be a Symbol (NO_SOURCE_FILE:15)

The real problem the compiler means to say, is that "hi" is not a symbol, and that is the first argument to def.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 6:14 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/175
Attachments:
def-error-message-fix.diff - https://www.assembla.com/spaces/clojure/documents/cu_tWuRS8r3RVoeJe5aVNr/download/cu_tWuRS8r3RVoeJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 6:14 AM ]

liwp said: [file:cu_tWuRS8r3RVoeJe5aVNr]: change the def exception message

Comment by Assembla Importer [ 24/Aug/10 6:14 AM ]

liwp said: (In [[r:6aab0f20e6bcc897b86a77b728af6fa0df93a2d8]]) Fix incorrect exception message when first argument to def is not a symbol - fix #175

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-174] Make c.l.Keyword Serializable Created: 13/Aug/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Chas Emerick
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

As mentioned in ticket #64, keywords are not currently Serializable, which is problem in many application contexts.

I'm treating this separately from the broader question of making clojure data structures Serializable because keywords not being Serializable is the one thing in the way of making idiomatic structs Serializable (e.g. maps using keyword keys, with values including other maps, sets, vectors, strings, numerics, symbols, other keywords, etc; these other structures are already Serializable).

Beyond that, cons and PersistentList aren't widely used, and I don't want to wade into that when they may be getting replaced soon enough with newnew/reify implementations.

Patch (based on 1.0.x branch) attached.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 6:12 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/174
Attachments:
keyword-serializable.diff - https://www.assembla.com/spaces/clojure/documents/dIqXxcIher3RSfeJe5aVNr/download/dIqXxcIher3RSfeJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 6:12 AM ]

cemerick said: [file:dIqXxcIher3RSfeJe5aVNr]

Comment by Assembla Importer [ 24/Aug/10 6:12 AM ]

cemerick said: (In [[r:b6cf1963af6e4e6aa35446aff15d77dcef305855]]) make clojure.lang.Keyword Serializable, fixes #174

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-173] Make PersistentHashSet implements IEditable Created: 11/Aug/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Christophe Grand
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

http://github.com/cgrand/clojure/commit/de2b2f9bc39ee2bb2758608c0a837a8a5333ff08



 Comments   
Comment by Assembla Importer [ 24/Aug/10 1:10 PM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/173
Attachments:
0001-implemented-TransientHashSet.patch - https://www.assembla.com/spaces/clojure/documents/cVyxpwHLWr3O4JeJe5aVNr/download/cVyxpwHLWr3O4JeJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 1:10 PM ]

cgrand said: [file:cVyxpwHLWr3O4JeJe5aVNr]: patch

Comment by Assembla Importer [ 24/Aug/10 1:10 PM ]

chouser@n01se.net said: I know 'disj' uses a params named 'set' and 'key', and old-style interop calls, but would it be worth fixing those for 'disj!'?

Comment by Assembla Importer [ 24/Aug/10 1:10 PM ]

cgrand said: (In [[r:a780e1d096f6a99cb974568a0a6d76d4e996e585]]) implemented TransientHashSet Fixes #173

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-172] #^objects type hint shortcut Created: 11/Aug/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Christophe Grand
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

instead of the ugly and tiresome #^"[Ljava.lang.Object;"

http://github.com/cgrand/clojure/commit/15ac69ce25adeb3992a001596cd2c2ff11b2770f



 Comments   
Comment by Assembla Importer [ 24/Aug/10 6:10 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/172
Attachments:
0001-add-objects-as-a-valid-type-hint.patch - https://www.assembla.com/spaces/clojure/documents/cuB7MaHLSr3Pg2eJe5aVNr/download/cuB7MaHLSr3Pg2eJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 6:10 AM ]

cgrand said: [file:cuB7MaHLSr3Pg2eJe5aVNr]: patch

Comment by Assembla Importer [ 24/Aug/10 6:10 AM ]

cgrand said: (In [[r:cc78418e773517d1c3427818cbee2254689fc0d8]]) add #^objects as a valid type hint Fixes #172

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-171] reflection warning from ns Created: 10/Aug/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

This happens in the master branch, but not in 1.0. Reported on http://groups.google.com/group/clojure/browse_thread/thread/3f7989b0297e0a59/59c94c1b161a6693

user=> (set! warn-on-reflection true)
true
user=> (ns foo.bar)
Reflection warning, NO_SOURCE_PATH:2 - reference to field getClass can't be resolved.
Reflection warning, NO_SOURCE_PATH:2 - reference to field getClassLoader can't be resolved.
nil
foo.bar=>



 Comments   
Comment by Assembla Importer [ 24/Aug/10 3:10 PM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/171
Attachments:
clojure-171-ns-reflection.patch - https://www.assembla.com/spaces/clojure/documents/aKgc0WHx4r3Rt1eJe5aVNr/download/aKgc0WHx4r3Rt1eJe5aVNr
clojure-171-ns-reflection-v2.patch - https://www.assembla.com/spaces/clojure/documents/cfBliAJGur3RGweJe5afGb/download/cfBliAJGur3RGweJe5afGb

Comment by Assembla Importer [ 24/Aug/10 3:10 PM ]

mikehinchey said: [file:aKgc0WHx4r3Rt1eJe5aVNr]: fix reflection warnings

Comment by Assembla Importer [ 24/Aug/10 3:10 PM ]

mikehinchey said: Attachement fixes the reflection warnings for ns and others in clojure that are easy, which always resolve to a single class. I didn't try to fix the warnings which can resolve to more than one class or method.

Comment by Assembla Importer [ 24/Aug/10 3:10 PM ]

chouser@n01se.net said: Without this patch, the reflection generated by 'ns' breaks unsigned applets. The other changes look good too. The build.xml patch doesn't apply anymore – I'll attach a new version that applies cleanly.

Comment by Assembla Importer [ 24/Aug/10 3:10 PM ]

chouser@n01se.net said: [file:cfBliAJGur3RGweJe5afGb]: rebased from original

Comment by Assembla Importer [ 24/Aug/10 3:10 PM ]

mikehinchey said: (In [[r:040f083efc16dd830a4508a35a04465e3e5677d3]]) fix #171: ns reflection warnings, and others that are easy

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-170] bound-fn macro Created: 08/Aug/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Meikel Brandmeyer
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

Added bound-fn macro to define a function, which saves away the current thread-local bindings. Before executing the body these bindings are restored. Useful for helper functions running on a different thread but requiring the same thread-local bindings.

For discussion see:
http://groups.google.com/group/clojure/browse_frm/thread/69367d3981de81d1

Needs patch from ticket:
https://www.assembla.com/spaces/clojure/tickets/169-thread-local-bindings-interface

Currently two fns are created. One wrapping the other into the necessary code. I also added the binding* helper function, because I missed it several times in my projects. So it may also be useful to others.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 1:09 PM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/170
Attachments:
0002-Added-bound-fn-to-define-thread-local-binding-aware.patch - https://www.assembla.com/spaces/clojure/documents/btVJwSHgyr3QpHeJe5afGb/download/btVJwSHgyr3QpHeJe5afGb

Comment by Assembla Importer [ 24/Aug/10 1:09 PM ]

meikelbrandmeyer said: [file:btVJwSHgyr3QpHeJe5afGb]: Patch adding bound-fn helper macro

Comment by Assembla Importer [ 24/Aug/10 1:09 PM ]

meikelbrandmeyer said: Another implementation I considered is this:

(defmacro bound-fn
  [args & body]
  (let [fn-name (when (symbol? args) args)
        args    (if fn-name (first body) args)
        body    (if fn-name (next body) body)]
    `(let [bindings# (get-thread-bindings)]
       (fn ~@(if fn-name
               (list fn-name args)
               (list args))
         (push-thread-bindings bindings#)
         (try
           ~@body
           (finally
             (pop-thread-bindings)))))))
</code></pre>

This would allow for lazy-seq functions:

<pre><code>
(defn some-seq
  [x]
  (let [step (bound-fn step [s]
               (lazy-seq
                 (when-let [s (seq s)]
                   (cons (first s) (step (rest s))))))]
    (step x)))

I found this second solution quite ugly, because I have to know how a fntail looks like and fiddle around with. But when Jon Harrop mentioned the lazy-seq in the discussion on the list, I noticed that the current solution (as in the patch at the moment), does not allow such recursion.

Comment by Assembla Importer [ 24/Aug/10 1:09 PM ]

meikelbrandmeyer said: After some feedback from Laurent, we arrived with the new attached patch. The seq example might then look like this:

(defn my-hypothetical-seq
  [coll]
  (let [bindings (get-thread-bindings)
        step     (fn step [s]
                   (lazy-seq
                     (with-bindings bindings
                       (generate-seq-here-calling-step))))]
    (step coll)))

This is should allow for such a use without to many hassles.

Comment by Assembla Importer [ 24/Aug/10 1:09 PM ]

meikelbrandmeyer said: Hmmm.. Would it be worthwile to also allow an optional map to specify a subset of the bindings? Currently, all bindings are stored in the map, while maybe only a few are actually needed. Would this be pre-mature optimisation?

Comment by Assembla Importer [ 24/Aug/10 1:09 PM ]

chouser@n01se.net said: I think this API is solid. In particular, I think having with-bindings means that bound-fn can stay simple – if someone wants to tweak the map of Vars, they can use get-thread-bindings, select-keys and with-bindings with an appropriate amount of hassle (ie, not much).

I wonder if the macros would be better implemented with code repeated from the * functions. As it is, only a little repetition in core is avoided, at the cost of more fn classes, more fn objects, and extra entries in stack traces.

Comment by Assembla Importer [ 24/Aug/10 1:09 PM ]

meikelbrandmeyer said: I'm not sure, that it is only repetition which is saved. bound-fn would be more elaborate (can't just take a fntail) or more restricted (if only takes a body).

However what does "restricted" mean here? What's the use of allowing to name a bound-fn (ie. something like {{(bound-fn this [x y z] ....))}} in face of missing TCO? Should we hope for soon TCO support and take care for it already?

But even without TCO considerations: what about {{(bound-fn ([x] ...) ([x y] ...))}}? Supporting such forms (we have to go into each branch setting up the bindings or we get another wrapping fn, which doesn't save much to the original proposal...) would make the bound-fn macro really more complicated. And here naming would again make sense to allow for default invocations dispatch to another arity. Would this be used often enough for it to be worthwhile to support the full fn syntax?

If yes to the above, that leaves only with-bindings as a candidate for repetitive implementation. Since the macro is only small, the code repetition imposed by a fatter macro is still smaller than the generated class file for a thunk. So maybe voting for repetition in this case is a valid point.

Should I modify the patch?

Comment by Assembla Importer [ 24/Aug/10 1:09 PM ]

meikelbrandmeyer said: (In [[r:fbacc4a5751fa5c15baa599b5a058cd81b05a247]]) Added bound-fn to define thread-local binding aware functions

bound-fn captures the thread-local bindings in effect where the
function is defined. Installs these bindings before executing the
body. This is useful for helper functions running in a different
thread.

Excluded with-bindings from clojure/main.clj to prevent name clash.

Fixes #170

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-169] thread-local bindings interface Created: 08/Aug/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

The attached patch provides a clojure side interface to clojure.lang.Var get/push/popThreadBindings. Also modified binding to use these new functions.

Discussion here:
http://groups.google.com/group/clojure/browse_frm/thread/69367d3981de81d1



 Comments   
Comment by Assembla Importer [ 24/Aug/10 1:09 PM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/169
Attachments:
0001-Added-public-thread-local-bindings-interface.patch - https://www.assembla.com/spaces/clojure/documents/ahljteHgqr3PfqeJe5afGb/download/ahljteHgqr3PfqeJe5afGb

Comment by Assembla Importer [ 24/Aug/10 1:09 PM ]

meikelbrandmeyer said: [file:ahljteHgqr3PfqeJe5afGb]: Patch adding thread-local bindings interface

Comment by Assembla Importer [ 24/Aug/10 1:09 PM ]

meikelbrandmeyer said: You may want to consider the concerns Vincent Toups (jvt) raised in the above mentioned thread about possible runtime issues with invalid built maps. Obviously Common Lisp and Scheme do not allow such a behaviour.

Comment by Assembla Importer [ 24/Aug/10 1:09 PM ]

oranenj said: This is just a style nitpick, but IIRC Rich mentioned that new code in core should use the "modern" syntactic sugar for . forms, instead of . directly. I certainly would like to see . marginalised as much as possible.

Also, do you think the operations have destructive semantics? Should the names contain a '!'?

Other than that, the patch is so simple there isn't much to review, and I'm definitely in favour of adding this.

Comment by Assembla Importer [ 24/Aug/10 1:09 PM ]

meikelbrandmeyer said: Ah. Ok. I asked Rich why he was still using .. while ��� is much more general. He said, that it is a classic. So I thought I'd stick to the current style in core.

I'm not sure about the 'Unable to render embedded object: File ('. On the one hand a push should always have a corresponding pop and vice versa. For example a pop without push will throw. So for now I would not add the ') not found.'.

I'll also add the modifications as discussed in:
http://groups.google.com/group/clojure-dev/browse_frm/thread/962c19c40dd93f24

Comment by Assembla Importer [ 24/Aug/10 1:09 PM ]

richhickey said: I think the docs for push-thread-bindings should state that it is essential to have a matching call to pop-thread-bindings that will be properly called in all scenarios (i.e. in a finally clause), and that this is a special purpose function, and 'bindings' or other high-level macros should be preferred when suitable.

Comment by Assembla Importer [ 24/Aug/10 1:09 PM ]

meikelbrandmeyer said: (In [[r:110b9c2eb8a128d837e6e620efc7e1c4e33feb82]]) Added public thread-local bindings interface

Added push-thread-bindings, pop-thread-bindings and get-thread-bindings
to interface with clojure.lang.Var for thread-local bindings.

Modified binding to use the new interface.

Fixes #169

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-168] ant targets should fail on error, also test print report correctly Created: 08/Aug/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

I found and fixed 3 problems with the ant task for running tests:

  1. compile-clojure target should fail when the compilation fails so more targets aren't run and ant process returns error
  2. test target should fail when the tests fail, not just print the report.
  3. when the test target is used with compile (eg, ant all test), the report is not printed at all


 Comments   
Comment by Assembla Importer [ 24/Aug/10 1:09 PM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/168
Attachments:
clojure-168-ant.patch - https://www.assembla.com/spaces/clojure/documents/dXurvSG-Sr3OZ9eJe5aVNr/download/dXurvSG-Sr3OZ9eJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 1:09 PM ]

mikehinchey said: [file:dXurvSG-Sr3OZ9eJe5aVNr]: patch to fix ant

Comment by Assembla Importer [ 24/Aug/10 1:09 PM ]

mikehinchey said: Fixed by setting java failonerror to true for both compile and test. Most ant tasks fail by default, but not java.

Also, wrote a special function for running tests to be used by ant, so it would print properly and throw on test failures. It wasn't printing properly when run in the same ant process as the compile because out and test-out are bound during compile, so the report was printed to nowhere.

Comment by Assembla Importer [ 24/Aug/10 1:09 PM ]

mikehinchey said: (In [[r:abca86ea023080fd4ceed24b9887a653a56722eb]]) fix #168, ant targets should fail on error, also test print report correctly

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-167] tests for sequences, control, and numbers Created: 08/Aug/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

I've written tests for various core functions: some, condp, loop, when, when-not, if-not, when-let, if-let, when-first, dotimes, while, bit-shift-left, bit-shift-right.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 8:09 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/167
Attachments:
clojure-167-tests.patch - https://www.assembla.com/spaces/clojure/documents/cPbtSiG-yr3P0FeJe5aVNr/download/cPbtSiG-yr3P0FeJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 8:09 AM ]

mikehinchey said: [file:cPbtSiG-yr3P0FeJe5aVNr]: patch containing tests

Comment by Assembla Importer [ 24/Aug/10 8:09 AM ]

mikehinchey said: Ready to test.

Comment by Assembla Importer [ 24/Aug/10 8:09 AM ]

mikehinchey said: (In [[r:f4294d876cfc5b72650a2d5eab73757709d92b85]]) fix #167, tests for sequences, control, and numbers

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-166] TransientHashMap Created: 05/Aug/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Enhancement
Reporter: Anonymous Assignee: Christophe Grand
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

Implement TransientHashMap



 Comments   
Comment by Assembla Importer [ 24/Aug/10 1:07 PM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/166
Attachments:
TransientMap.patch - https://www.assembla.com/spaces/clojure/documents/aDYi8CGBWr3PhueJe5afGb/download/aDYi8CGBWr3PhueJe5afGb
TransientMap2.patch - https://www.assembla.com/spaces/clojure/documents/bNyIbwGB0r3R_OeJe5aVNr/download/bNyIbwGB0r3R_OeJe5aVNr
TransientMap3.patch - https://www.assembla.com/spaces/clojure/documents/dzRHNWGC8r3PwqeJe5afGb/download/dzRHNWGC8r3PwqeJe5afGb

Comment by Assembla Importer [ 24/Aug/10 1:07 PM ]

cgrand said: [file:aDYi8CGBWr3PhueJe5afGb]: first cut

Comment by Assembla Importer [ 24/Aug/10 1:07 PM ]

cgrand said: [file:bNyIbwGB0r3R_OeJe5aVNr]: previous page contained one unrelated commit

Comment by Assembla Importer [ 24/Aug/10 1:07 PM ]

cgrand said: [file:dzRHNWGC8r3PwqeJe5afGb]: include bufix for count on dissoc

Comment by Assembla Importer [ 24/Aug/10 1:07 PM ]

richhickey said: I've applied patch3, thanks!
Leaving as new for any bugfixes

Comment by Assembla Importer [ 24/Aug/10 1:07 PM ]

cgrand said: See #183





[CLJ-165] Enhancements to array seqs Created: 04/Aug/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Christophe Grand
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   
  • Implement missing array seqs for byte[], char[] and boolean[].
  • Specialize .indexOf and .lastIndexOf (from java.util.List which array seqs implement via ASeq) to be more efficient. It would relax the need to depend on org.apache.commons.lang.ArrayUtils for such a mundane task: (-> a-byte-array #^List seq (.indexOf (byte 10)))


 Comments   
Comment by Assembla Importer [ 24/Aug/10 1:06 PM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/165
Attachments:
0001-Adds-missing-array-seqs-for-char-byte-and-boolean-pl.patch - https://www.assembla.com/spaces/clojure/documents/bMnH8IGnar3R9geJe5aVNr/download/bMnH8IGnar3R9geJe5aVNr
0001-Adds-missing-array-seqs-for-char-byte-and-boolean-pl.patch - https://www.assembla.com/spaces/clojure/documents/bWmQJUGnGr3R9geJe5aVNr/download/bWmQJUGnGr3R9geJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 1:06 PM ]

cgrand said: [file:bMnH8IGnar3R9geJe5aVNr]: patch

Comment by Assembla Importer [ 24/Aug/10 1:06 PM ]

cgrand said: [file:bWmQJUGnGr3R9geJe5aVNr]: better patch

Comment by Assembla Importer [ 24/Aug/10 1:06 PM ]

cgrand said: (In [[r:51f4180eca6a09dbad52d4bcb6c48ab05fe16cad]]) Enhancements to array seqs

Adds missing array seqs for char[], byte[] and boolean[]
plus specialized .indexOf and .lastIndexOf for all array seqs, fixes #165

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-164] [PATCH] embedded constants Created: 02/Aug/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Enhancement
Reporter: Anonymous Assignee: Chouser
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

clojure.lang.Compiler.FnExpr now handles primitives



 Comments   
Comment by Assembla Importer [ 24/Aug/10 1:05 PM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/164
Attachments:
0001-embedded-constants.patch - https://www.assembla.com/spaces/clojure/documents/bWpR2kFXmr3RkXeJe5aVNr/download/bWpR2kFXmr3RkXeJe5aVNr
prim.clj - https://www.assembla.com/spaces/clojure/documents/cwL30uFXmr3ORSeJe5afGb/download/cwL30uFXmr3ORSeJe5afGb
embedded-constants-tests.diff - https://www.assembla.com/spaces/clojure/documents/cm6M6gRi4r3RdbeJe5afGb/download/cm6M6gRi4r3RdbeJe5afGb
embedded-constants-tests2.diff - https://www.assembla.com/spaces/clojure/documents/aV1YJARjyr3RdbeJe5afGb/download/aV1YJARjyr3RdbeJe5afGb
embedded-constants-tests3.diff - https://www.assembla.com/spaces/clojure/documents/a2gi08RpSr3PSLeJe5afGb/download/a2gi08RpSr3PSLeJe5afGb
embedded-constants-tests4.diff - https://www.assembla.com/spaces/clojure/documents/b5AX0uRUir3OwbeJe5aVNr/download/b5AX0uRUir3OwbeJe5aVNr
embedded-constants-tests5.diff - https://www.assembla.com/spaces/clojure/documents/dngmRARUur3OwbeJe5aVNr/download/dngmRARUur3OwbeJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 1:05 PM ]

timothypratley said: [file:bWpR2kFXmr3RkXeJe5aVNr]

Comment by Assembla Importer [ 24/Aug/10 1:05 PM ]

timothypratley said: [file:cwL30uFXmr3ORSeJe5afGb]: tests

Comment by Assembla Importer [ 24/Aug/10 1:05 PM ]

timothypratley said: Hi Rich,

Just curious if you've had a chance to look at this patch yet - please be honest if it has shortfallings so I can improve. I suspect that my vim setup might have formatting differences - if that is the case I'm happy to use Aquamacs or whatever is preferred.

Also I get the feeling this is only a small part of the change required, and I don't grok what the other part is (some print-dup change?)... so some guidance would be appreciated.

Regards,
Tim.

Comment by Assembla Importer [ 24/Aug/10 1:05 PM ]

chouser@n01se.net said: Tim,

Would you be willing to reformat the tests you wrote as a patch to clojure.test-clojure? That way they'll be included in the regression runs done for future patches.

Comment by Assembla Importer [ 24/Aug/10 1:05 PM ]

timothypratley said: [file:cm6M6gRi4r3RdbeJe5afGb]: patch to clojure-test

Comment by Assembla Importer [ 24/Aug/10 1:05 PM ]

timothypratley said: [file:aV1YJARjyr3RdbeJe5afGb]: Here is a better test, shorter and stronger

Comment by Assembla Importer [ 24/Aug/10 1:05 PM ]

timothypratley said: Hi Chris

Good idea, I've uploaded a patch to clojure-tests/compilation.clj
Please use the last file attached:
embedded-constants-tests2.diff

Regards,
Tim.

Comment by Assembla Importer [ 24/Aug/10 1:05 PM ]

timothypratley said: (In [[r:86d8a952daee73bf7b7b0c5a41c7ad3faf27c038]]) embedded constants, refs #164

Primitive Class objects are now handled explicitly
eg: (eval `(make-array ~Byte/TYPE 2))

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Comment by Assembla Importer [ 24/Aug/10 1:05 PM ]

timothypratley said: (In [[r:b044959a42f5f58a37c4151f4d7b6652e17348ab]]) added tests, fixes #164

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Comment by Assembla Importer [ 24/Aug/10 1:05 PM ]

chouser@n01se.net said: I think I must have been in the process of checking and submitting the first test patch when you attached the second. I'll swap them later.

Comment by Assembla Importer [ 24/Aug/10 1:05 PM ]

timothypratley said: [file:a2gi08RpSr3PSLeJe5afGb]: Might be easier to apply - based to current head

Comment by Assembla Importer [ 24/Aug/10 1:05 PM ]

timothypratley said: No worries, this is really great for me - getting used to the whole process - thanks. I've uploaded a diff from the current head to save you some minor headaches I hope.

Comment by Assembla Importer [ 24/Aug/10 1:05 PM ]

timothypratley said: (In [[r:1ca9c8b9322882a0d84db9007047d223d11f2c3f]]) shorter, stronger embedded-constants tests. fixes #164

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Comment by Assembla Importer [ 24/Aug/10 1:05 PM ]

timothypratley said: [file:b5AX0uRUir3OwbeJe5aVNr]: Ok this time for sure! How embarassing - the last patch didn't actually test anything due to misplaced parenthesis

Comment by Assembla Importer [ 24/Aug/10 1:05 PM ]

timothypratley said: How embarrassing - I had a misplaced parenthesis in my patch which meant the test didn't do anything

Comment by Assembla Importer [ 24/Aug/10 1:05 PM ]

timothypratley said: [file:dngmRARUur3OwbeJe5aVNr]: Based to current git HEAD

Comment by Assembla Importer [ 24/Aug/10 1:05 PM ]

richhickey said: Isn't this in already? Or is the discussion now about the tests?

Comment by Assembla Importer [ 24/Aug/10 1:05 PM ]

timothypratley said: (In [[r:5f9df70163bd9c7a168c1ef8cd2be67651401f29]]) Fixed broken test-embedded-constants. Fixes #164

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Comment by Assembla Importer [ 24/Aug/10 1:05 PM ]

timothypratley said: Yes that's right there was just that test issue but its all sorted out now thanks very much.





[CLJ-160] JUnit XML output for clojure.test Created: 24/Jul/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Enhancement
Reporter: Anonymous Assignee: Stuart Sierra
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

Sent in by Jason Sankey as clojure.contrib.test.junit

I have renamed it to clojure.test.junit, in the same style as clojure.test.tap



 Comments   
Comment by Assembla Importer [ 24/Aug/10 4:01 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/160
Attachments:
junit-xml-output.diff - https://www.assembla.com/spaces/clojure/documents/duKR1iEgWr3Q4keJe5afGb/download/duKR1iEgWr3Q4keJe5afGb
junit-xml-output2.diff - https://www.assembla.com/spaces/clojure/documents/aMA1aKX9qr3Q_UeJe5afGb/download/aMA1aKX9qr3Q_UeJe5afGb

Comment by Assembla Importer [ 24/Aug/10 4:01 AM ]

stuart.sierra said: [file:duKR1iEgWr3Q4keJe5afGb]: Patch adding test/junit.clj

Comment by Assembla Importer [ 24/Aug/10 4:01 AM ]

richhickey said: New files for Clojure itself need to have the standard header (Copyright (c) Rich Hickey...) and no emails or urls ( by Jason Sankey is fine)

Comment by Assembla Importer [ 24/Aug/10 4:01 AM ]

stuart.sierra said: [file:aMA1aKX9qr3Q_UeJe5afGb]

Comment by Assembla Importer [ 24/Aug/10 4:01 AM ]

stuart.sierra said: New patch junit-xml-output2.diff removes external dependencies and adds default copyright header.

Comment by Assembla Importer [ 24/Aug/10 4:01 AM ]

stuart.sierra said: (In [[r:81e19ddd9973841894767d89465979195242afed]]) Add clojure.test.junit; refs #160

Signed-off-by: Rich Hickey <richhickey@gmail.com>

Branch: master





[CLJ-159] Add char? fn Created: 22/Jul/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Enhancement
Reporter: Anonymous Assignee: Drew Raines
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

Add a char? fn to test for java.lang.Character.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 1:00 PM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/159
Attachments:
drewr-char-p.patch - https://www.assembla.com/spaces/clojure/documents/dTXUBaDUmr3RRZeJe5afGb/download/dTXUBaDUmr3RRZeJe5afGb
drewr-char-p.2.patch - https://www.assembla.com/spaces/clojure/documents/d7bzX-EeOr3P2weJe5afGb/download/d7bzX-EeOr3P2weJe5afGb

Comment by Assembla Importer [ 24/Aug/10 1:00 PM ]

drewr said: [file:dTXUBaDUmr3RRZeJe5afGb]: patch adding char?

Comment by Assembla Importer [ 24/Aug/10 1:00 PM ]

richhickey said: Please use git format-patch as described here:

http://clojure.org/patches

Thanks!

Comment by Assembla Importer [ 24/Aug/10 1:00 PM ]

drewr said: [file:d7bzX-EeOr3P2weJe5afGb]: Created with git format-patch





[CLJ-158] Update tests to reflect new template syntax Created: 20/Jul/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Frantisek Sodomka
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

There are still some tests (and comments) not updated correctly - predicates, reader, vars.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 12:59 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/158
Attachments:
ticket_158_update_tests.diff - https://www.assembla.com/spaces/clojure/documents/aGPMCuDxCr3QaHeJe5afGb/download/aGPMCuDxCr3QaHeJe5afGb

Comment by Assembla Importer [ 24/Aug/10 12:59 AM ]

fsodomka said: Parent association with ticket #131 was added

Comment by Assembla Importer [ 24/Aug/10 12:59 AM ]

fsodomka said: [file:aGPMCuDxCr3QaHeJe5afGb]: update tests

Comment by Assembla Importer [ 24/Aug/10 12:59 AM ]

fsodomka said: See attached patch.

Comment by Assembla Importer [ 24/Aug/10 12:59 AM ]

chouser@n01se.net said: This patch looks good to me.

Comment by Assembla Importer [ 24/Aug/10 12:59 AM ]

fsodomka said: (In [[r:16af3b1d04db6978d552b4440690d00a9e64a423]]) updated remaining tests, closes #158

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-155] Classname/staticThing leaves Classname unresolved at syntaxQuote time Created: 14/Jul/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Chouser
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

Class names for static field and method references are resolved differently for modern vs. old syntax:

user=> `(Integer/foo)
(Integer/foo)
user=> `(. Integer foo)
(. java.lang.Integer user/foo)

This means that using an imported class in a defmacro via modern syntax will break if the macro is expanded in a namespace that doesn't have that class imported, or worse could attempt to a same-named class from a different package.

Reported by technomancy in IRC



 Comments   
Comment by Assembla Importer [ 24/Aug/10 12:55 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/155
Attachments:
ticket-155.diff - https://www.assembla.com/spaces/clojure/documents/bvQRQmB_Or3OXZeJe5aVNr/download/bvQRQmB_Or3OXZeJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 12:55 AM ]

chouser@n01se.net said: [file:bvQRQmB_Or3OXZeJe5aVNr]: Resolve classnames in modern-syntax static calls at syntaxQuote time.

Comment by Assembla Importer [ 24/Aug/10 12:55 AM ]

chouser@n01se.net said: Attached patch as discussed in IRC.

Comment by Assembla Importer [ 24/Aug/10 12:55 AM ]

chouser@n01se.net said: Child association with ticket #156 was added

Comment by Assembla Importer [ 24/Aug/10 12:55 AM ]

chouser@n01se.net said: (In [[r:994f118c56bb3139f87093a6ec44eb8c04acbdaf]]) Resolve classnames in modern-syntax static calls at syntaxQuote time. Fixes #155

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-154] (keyword "a/b") => ns nil, name a/b; should be ns a, name b Created: 13/Jul/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Stephen C. Gilardi
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

From: http://groups.google.com/group/clojure/browse_thread/thread/c792fd218bedea1f

for generated keywords, seems dodgy
(keyword "aaaaa/bbbbb") => :aaaaa/bbbbb
(name (keyword "aaaaa/bbbbb")) => "aaaaa/bbbbb"
(namespace (keyword "aaaaa/bbbbb")) => nil

It would seem cleaner if the java Keyword.intern() and Symbol.intern()
methods were symmetrical and used the same way in core.clj.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 6:55 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/154
Attachments:
fix-154.patch - https://www.assembla.com/spaces/clojure/documents/aGf_3wB8Cr3PfNeJe5afGb/download/aGf_3wB8Cr3PfNeJe5afGb

Comment by Assembla Importer [ 24/Aug/10 6:55 AM ]

scgilardi said: [file:aGf_3wB8Cr3PfNeJe5afGb]

Comment by Assembla Importer [ 24/Aug/10 6:55 AM ]

scgilardi said: Description of fix-154.patch:

  • added intern(String nsname) to Keyword.java
  • changed clojure.core/keyword to call it
  • updated clojure.core/symbol and clojure.core/keyword to new static call syntax
  • added tests to reader.clj using corrected keyword, duplicating similar tests for symbol, and adding tests of keyword constructed from a symbol
Comment by Assembla Importer [ 24/Aug/10 6:55 AM ]

importer said: (In [[r:a1b4a33bb8ccf739c481754fc563117ed3604c75]]) fixed keyword ctor, added tests, fix #154

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-152] Doc string for "binding" should be explicit about binding in parallel Created: 12/Jul/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

As Tom mentions here: http://groups.google.com/group/clojure/browse_frm/thread/81fc236d3436d72b
the parallel nature of the bindings created by "binding" does not appear to be documented either in its doc string or at clojure.org.
The doc string for binding should mention it.

A proposal for discussion/approval:

clojure.core/binding
([bindings & body])
Macro
binding => var-symbol init-expr

Creates new bindings for the (already-existing) vars, with the
supplied initial values, executes the exprs in an implicit do, then
re-establishes the bindings that existed before. The new bindings
are made in parallel: all init-exprs are evaluated before the
vars are bound as a group to their new values.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 12:55 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/152
Attachments:
152-binding-docstring.diff - https://www.assembla.com/spaces/clojure/documents/bGPkGOMkir3OYweJe5aVNr/download/bGPkGOMkir3OYweJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 12:55 AM ]

stuart.sierra said: [file:bGPkGOMkir3OYweJe5aVNr]: Patch, very similar to Stephen's docstring

Comment by Assembla Importer [ 24/Aug/10 12:55 AM ]

stuart.sierra said: (In [[r:ff116fb3a986334e77bc0521167fe89c8e27313d]]) core.clj: binding doc string now says it's parallel, fixes #152

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-151] Function to return last n items of a seq Created: 11/Jul/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

My fork on github of clojure had a last-n branch that is an unacceptable breaking change by returning a seq even for just a single item. A different solution is needed.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 3:55 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/151
Attachments:
last-n.diff - https://www.assembla.com/spaces/clojure/documents/cgeCSqBO4r3PxueJe5afGb/download/cgeCSqBO4r3PxueJe5afGb
last-n-v2.diff - https://www.assembla.com/spaces/clojure/documents/cqqgugEomr3ONjeJe5aVNr/download/cqqgugEomr3ONjeJe5aVNr
take-last.diff - https://www.assembla.com/spaces/clojure/documents/b9iKQQUMir3OzreJe5aVNr/download/b9iKQQUMir3OzreJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 3:55 AM ]

chouser@n01se.net said: [file:cgeCSqBO4r3PxueJe5afGb]: last with one arg is unchanged. last with an extra count arg returns a seq

Comment by Assembla Importer [ 24/Aug/10 3:55 AM ]

chouser@n01se.net said: Attached a patch that defined 'last' with one arg as it has been. 'last' with an extra count arg returns a seq.

Comment by Assembla Importer [ 24/Aug/10 3:55 AM ]

chouser@n01se.net said: [file:cqqgugEomr3ONjeJe5aVNr]: bail early if end of seq found while setting up lead

Comment by Assembla Importer [ 24/Aug/10 3:55 AM ]

chouser@n01se.net said: I've attached an improved patch [file:last-n-v2.diff]

Both the old and new patches avoid retaining the head, as demonstrated by the first expr blowing the heap, but second not:

(last 3 (map count (doall (take 1e5 (iterate #(str % 'x) "y")))))
(last 3 (map count (take 1e5 (iterate #(str % 'x) "y"))))t

However, the v2 patch also gives up walking the 'lead' seq forward as soon as it reaches the end of the input seq (this is how 'drop' behaves). You can observe the differnce by seeing that with v2 this returns immediately:

(last 1e10 [1 2 3 4 5])

Comment by Assembla Importer [ 24/Aug/10 3:55 AM ]

chouser@n01se.net said: For small n's and large collections implementing IPersistentStack, 'last' could be much efficient by using 'pop' and 'reverse', though this would mean it wouldn't always use the seq of the collection.

Comment by Assembla Importer [ 24/Aug/10 3:55 AM ]

richhickey said: I'm not sure I get the reverse bit - reverse is fast for stacks? Certainly we could do better for colls implementing Indexed or RandomAccess. I guess all that means is that the doc shouldn't dictate linear time, and should instead say maybe in best time complexity supported by the data structure.

Comment by Assembla Importer [ 24/Aug/10 3:55 AM ]

richhickey said: faster for last 1 I should say. Seems more and more like last 1 and last N shouldn't be combined.

Comment by Assembla Importer [ 24/Aug/10 3:55 AM ]

chouser@n01se.net said: [file:b9iKQQUMir3OzreJe5aVNr]: implement take-last as its own function

Comment by Assembla Importer [ 24/Aug/10 3:55 AM ]

chouser@n01se.net said: (In [[r:0ba40a260162330836b97f6d1bf3466404a63b55]]) Implement take-last Fixes #151

Branch: master





[CLJ-146] NPE when creating an empty array of ints, longs, floats or doubles Created: 07/Jul/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Frantisek Sodomka
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

(int-array []) should return an empty array - the same as (int-array 0). Also true for long-array, float-array and double-array.

user=> (doc int-array)
-------------------------
clojure.core/int-array
([size-or-seq] [size init-val-or-seq])
Creates an array of ints

OK:
user=> (int-array [1 2])
#<int[] [I@1342ba4>
user=> (vec (int-array [1 2]))
[1 2]

NPE:
user=> (int-array [])
java.lang.NullPointerException (NO_SOURCE_FILE:0)

OK:
user=> (int-array 2)
#<int[] [I@18d9850>
user=> (vec (int-array 2))
[0 0]
user=> (int-array 0)
#<int[] [I@1e97f9f>
user=> (vec (int-array 0))
[]

NPE:
user=> (long-array [])
java.lang.NullPointerException (NO_SOURCE_FILE:0)
user=> (float-array [])
java.lang.NullPointerException (NO_SOURCE_FILE:0)
user=> (double-array [])
java.lang.NullPointerException (NO_SOURCE_FILE:0)

user=> (int-array ())
java.lang.NullPointerException (NO_SOURCE_FILE:0)
user=> (int-array {})
java.lang.NullPointerException (NO_SOURCE_FILE:0)
user=> (int-array #{})
java.lang.NullPointerException (NO_SOURCE_FILE:0)



 Comments   
Comment by Assembla Importer [ 24/Aug/10 6:53 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/146
Attachments:
fix_and_test_146.diff - https://www.assembla.com/spaces/clojure/documents/b0V98YAUWr3Qj6eJe5afGb/download/b0V98YAUWr3Qj6eJe5afGb
fix_and_test_146_v2.diff - https://www.assembla.com/spaces/clojure/documents/aa7RF6AVOr3PFkeJe5afGb/download/aa7RF6AVOr3PFkeJe5afGb
fix_and_test_146_v3.diff - https://www.assembla.com/spaces/clojure/documents/bNDk58GSGr3OJWeJe5aVNr/download/bNDk58GSGr3OJWeJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 6:53 AM ]

fsodomka said: [file:b0V98YAUWr3Qj6eJe5afGb]: fix errors and add tests

Comment by Assembla Importer [ 24/Aug/10 6:53 AM ]

fsodomka said: See patch fix_and_test_146.diff. Fixes Java code and adds tests. It is my first patch for the Java code of Clojure, so be careful

Comment by Assembla Importer [ 24/Aug/10 6:53 AM ]

fsodomka said: [file:aa7RF6AVOr3PFkeJe5afGb]: fix errors and add tests

Comment by Assembla Importer [ 24/Aug/10 6:53 AM ]

richhickey said: A better fix is to use RT.count(s) rather than s.count(). Then there is no special handling.

Comment by Assembla Importer [ 24/Aug/10 6:53 AM ]

fsodomka said: [file:bNDk58GSGr3OJWeJe5aVNr]: fix errors and add tests

Comment by Assembla Importer [ 24/Aug/10 6:53 AM ]

fsodomka said: New version of patch uploaded. See if this works.

Comment by Assembla Importer [ 24/Aug/10 6:53 AM ]

richhickey said: Patch v3 is ok, thanks

Comment by Assembla Importer [ 24/Aug/10 6:53 AM ]

chouser@n01se.net said: Child association with ticket #188 was added

Comment by Assembla Importer [ 24/Aug/10 6:53 AM ]

fsodomka said: (In [[r:270185aba54cef1d8ce59ec347b5623f2e502afe]]) fixed NPE when creating an empty array of ints, longs, floats or doubles, fixes #146

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-144] test-clojure: change (are _ ...) to (are [x] (true? x) ...) Created: 06/Jul/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

Old clojure.contrib.test-is framework used (are _ value1 value2 ...) syntax for testing if all values are logically true. New clojure.test uses (are [x] (true? x) value1 value2 ...) or (are [x] (if x true false) value1 value2 ...) and this change needs to be reflected in test_clojure/numbers.clj.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 4:52 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/144
Attachments:
test_clojure_are.diff - https://www.assembla.com/spaces/clojure/documents/dvCpAkANar3QdBeJe5afGb/download/dvCpAkANar3QdBeJe5afGb
test_clojure_are_v2.diff - https://www.assembla.com/spaces/clojure/documents/damCkoAVKr3PdgeJe5afGb/download/damCkoAVKr3PdgeJe5afGb

Comment by Assembla Importer [ 24/Aug/10 4:52 AM ]

fsodomka said: [file:dvCpAkANar3QdBeJe5afGb]: fixes test_clojure/numbers.clj

Comment by Assembla Importer [ 24/Aug/10 4:52 AM ]

fsodomka said: [file:damCkoAVKr3PdgeJe5afGb]: fixes test_clojure/numbers.clj

Comment by Assembla Importer [ 24/Aug/10 4:52 AM ]

fsodomka said: Parent association with ticket #131 was added

Comment by Assembla Importer [ 24/Aug/10 4:52 AM ]

richhickey said: I don't understand this.

Comment by Assembla Importer [ 24/Aug/10 4:52 AM ]

fsodomka said: Old 'are' had syntax (are condition expr1 expr2 ...), but new 'are' has (are params-vector condition expr1 expr2 ...). Tests in numbers.clj were updated with params-vector [x], but no condition were given.

user=> (macroexpand-1 '(are [x] true false nil))
(clojure.template/do-template [x] (clojure.test/is true) false nil)

Clearly, test (are [x] true false nil) will never fail, because first value is logically true and false and nil will never be considered.

See more explanation in:
http://groups.google.com/group/clojure-dev/browse_frm/thread/d0fd9d717db1e1db

Comment by Assembla Importer [ 24/Aug/10 4:52 AM ]

fsodomka said: (In [[r:6e29153854c799cb46abc23382059d6ee20e755e]]) fixed test-clojure, refs #144

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-143] support overlapping ensures with no retry Created: 03/Jul/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Enhancement
Reporter: Anonymous Assignee: Rich Hickey
Resolution: Completed Votes: 0
Labels: None


 Description   

Currently ref ensures have same retry effects as set/alters. Allow overlapping ensures to succeed without retry

Discussed here:

http://groups.google.com/group/clojure/browse_frm/thread/f7b4365b1c71b665/717e1a18c2f84daf?#717e1a18c2f84daf



 Comments   
Comment by Assembla Importer [ 24/Aug/10 4:52 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/143

Comment by Assembla Importer [ 24/Aug/10 4:52 AM ]

richhickey said: (In [[r:961743446562b6fa7be25f96de02aacd626169da]]) support overlapping ensures with no retry, refs #143

Branch: master





[CLJ-142] Bug: Compile-time NPE on set! of non-existent field Created: 03/Jul/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None


 Description   

(set! (.foo "fred") 47)



 Comments   
Comment by Assembla Importer [ 24/Aug/10 3:51 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/142

Comment by Assembla Importer [ 24/Aug/10 3:51 AM ]

richhickey said: (In [[r:c4a5cd208aef54ae5b292fa41c4880017315e553]]) fix compile-time NPE on set! of non-existent field, fixes #142

Branch: master

Comment by Assembla Importer [ 24/Aug/10 3:51 AM ]

chouser@n01se.net said: Child association with ticket #147 was added





[CLJ-138] min and max history for refs Created: 30/Jun/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Rich Hickey
Resolution: Completed Votes: 0
Labels: None


 Description   

knobs for history control. With positive min-history, will keep history even in absence of detected conflict. max history will limit dynamic history accumulation.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 12:50 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/138

Comment by Assembla Importer [ 24/Aug/10 12:50 AM ]

richhickey said: (In [[r:6201f5e2ddd52f1b483d75563b0380deba59777c]]) added ref min/max history control - refs #138

Branch: master





[CLJ-137] Add *math-context* to with-bindings so it's set!-able at REPL Created: 29/Jun/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

Add math-context</code> to <code>clojure.main/with-bindings so it's set!-able at REPL.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 12:50 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/137
Attachments:
settable-math-context.patch - https://www.assembla.com/spaces/clojure/documents/bYiaYCznur3QWleJe5aVNr/download/bYiaYCznur3QWleJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 12:50 AM ]

scgilardi said: [file:bYiaYCznur3QWleJe5aVNr]: patches clojure.main/with-bindings to include math-context

Comment by Assembla Importer [ 24/Aug/10 12:50 AM ]

richhickey said: Please mark as "ready to test" when you add a patch, thanks

Comment by Assembla Importer [ 24/Aug/10 12:50 AM ]

richhickey said: Also please submit patches as produced by git format-patch, they retain authorship and other commit information.

See:
http://clojure.org/patches

Thanks

Comment by Assembla Importer [ 24/Aug/10 12:50 AM ]

scgilardi said: Updated patch using git format-patch, ready to test. Thanks.

Comment by Assembla Importer [ 24/Aug/10 12:50 AM ]

chouser@n01se.net said: This patch works fine with git for me – attribution and all. It does contain two commits, which threw me for a moment, but I think multi-commit patches are acceptable.

This patch looks fine to me.

Comment by Assembla Importer [ 24/Aug/10 12:50 AM ]

importer said: (In [[r:ab7947e68a5b435f243790e197cfdb781d47986f]]) Refs #137: make math-context settable, with test + tests of with-precision

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Comment by Assembla Importer [ 24/Aug/10 12:50 AM ]

importer said: (In [[r:12888faab8f5c7bc13da5a8f506c2a594c48500c]]) move with-precision tests to that section of vars.clj Fixes #137

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Comment by Assembla Importer [ 24/Aug/10 12:50 AM ]

scgilardi said: Given Rich's post today about math-context not being part of Clojure's public API, should we add to this ticket implementation of a function like "set-precision!" (a sibling of with-precision) to make this capability usable in Clojure code?

I like math-context not being public. I hadn't thought of it before, but having it be public would be an unnecessary Java-ism--inappropriate for the Clojure-in-Clojure future.

(I'm leaving this ticket as fixed. We can either reopen it, open another ticket for set-precision!, or do nothing based on any futher discussions.)

Comment by Assembla Importer [ 24/Aug/10 12:50 AM ]

chouser@n01se.net said: I didn't know (or had forgotten) about with-precision.

I'd personally be happy to see a 'set-precision!' and maybe a docstring for math-context that points to 'with-precision' and 'set-precision!'.

I'd also think that should be a new ticket, since the problem described in this ticket is indeed fixed by the patch in this ticket.





[CLJ-136] Enhancement: give meaningful names to inline expanders Created: 26/Jun/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Enhancement
Reporter: Anonymous Assignee: Mike Hinchey
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

Currently inline expander fns are anonymous, so the errors they report have no context:

user=>  (pos? 3 4)
java.lang.IllegalArgumentException: Wrong number of args passed to: core$fn (NO_SOURCE_FILE:114)
</code></pre>

Could be fixed by supplying a name to expander:

<pre><code>:inline (fn pos? [x] ...)


 Comments   
Comment by Assembla Importer [ 24/Aug/10 12:48 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/136
Attachments:
0001-core-add-names-for-inline-expansions.patch - https://www.assembla.com/spaces/clojure/documents/aOOXAsy_ir3RQ_eJe5afGb/download/aOOXAsy_ir3RQ_eJe5afGb
clojure-136-inline.patch - https://www.assembla.com/spaces/clojure/documents/baIkEkGDOr3P4FeJe5aVNr/download/baIkEkGDOr3P4FeJe5aVNr
clojure-136-inline2.patch - https://www.assembla.com/spaces/clojure/documents/aMYigUHWer3RyjeJe5afGb/download/aMYigUHWer3RyjeJe5afGb

Comment by Assembla Importer [ 24/Aug/10 12:48 AM ]

oranenj said: [file:aOOXAsy_ir3RQ_eJe5afGb]

Comment by Assembla Importer [ 24/Aug/10 12:48 AM ]

oranenj said: Took about five minutes. It seems only clojure.core creates inline functions.

Behaviour with the patch applied:

user=> (pos? 3 4)
java.lang.IllegalArgumentException: Wrong number of args passed to: core$pos-QMARK- (NO_SOURCE_FILE:1)

Perhaps demangling for function names in error messages is next... I suspect it will require touching the java side, though.

Comment by Assembla Importer [ 24/Aug/10 12:48 AM ]

chouser@n01se.net said: Thanks for the patch! Unfortunately it doesn't apply cleanly anymore – looks like some function definitions have moved around. Also doesn't appear to address functions produced by definline which have the same problem:

user=> (floats 1 2)
java.lang.IllegalArgumentException: Wrong number of args passed to: core$fn (NO_SOURCE_FILE:1)

Comment by Assembla Importer [ 24/Aug/10 12:48 AM ]

mikehinchey said: [file:baIkEkGDOr3P4FeJe5aVNr]: patch to automatically give inline fn names

Comment by Assembla Importer [ 24/Aug/10 12:48 AM ]

mikehinchey said: The new patch I uploaded (clojure-136-inline.patch) has a different solution. defn will automatically add the same fn name to the :inline value if it doesn't have one.

Comment by Assembla Importer [ 24/Aug/10 12:48 AM ]

chouser@n01se.net said: Mike, I like your approach – would you bring the closing bracket up to the previous line? It's hard to know what good style is when you don't have 'and' or 'when', but I think we can do that much. Mark it as 'test' again when you've got that attached.

This still needs Rich's approval, so I'm bumping it back to Unapproved.

Comment by Assembla Importer [ 24/Aug/10 12:48 AM ]

mikehinchey said: [file:aMYigUHWer3RyjeJe5afGb]: revised patch to automatically give inline fn names

Comment by Assembla Importer [ 24/Aug/10 12:48 AM ]

mikehinchey said: Okay. clojure-136-inline2.patch fixes the bracket and cleans it up more, plus comments.

Comment by Assembla Importer [ 24/Aug/10 12:48 AM ]

chouser@n01se.net said: Mike, looks good to me.

Comment by Assembla Importer [ 24/Aug/10 12:48 AM ]

technomancy said: Looks like this still cleanly applies to master and does what it says on the box.

Comment by Assembla Importer [ 24/Aug/10 12:48 AM ]

mikehinchey said: (In [[r:1b4852fdbd5ca8df86e783e417f01c8db226d428]]) give meaningful names to inline expanders, fix #136

Signed-off-by: Rich Hickey <richhickey@gmail.com>

Branch: master





[CLJ-135] zipper: children does not check node type Created: 23/Jun/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

children does not check the node type.

Reported by Justin Balthrop on #clojure.

To reproduce:

(-> (clojure.core/vector-zip '[(1 2) (3 4)]) clojure.zip/down clojure.zip/down) descends into the list, where it should not.

Proposed fix:

children should check branch? and throw an exception if the node is actually a leaf.

Patch attached.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 12:47 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/135
Attachments:
zip-children-bug.diff - https://www.assembla.com/spaces/clojure/documents/cqC9AaydWr3PjFeJe5afGb/download/cqC9AaydWr3PjFeJe5afGb

Comment by Assembla Importer [ 24/Aug/10 12:47 AM ]

meikelbrandmeyer said: [file:cqC9AaydWr3PjFeJe5afGb]: Patch for the children bug in the zipper





[CLJ-134] *-zip lose metadata Created: 23/Jun/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

vector-zip and seq-zip do not transport metadata on the nodes.

Reported by Justin Balthrop on #clojure.

To reproduce:

1. Create a vector with metadata.
2. Create a vector zipper.
3. Move in the tree.
4. Recreate the root.

Now the metadata is lost.

Proposed fix:

Move the metadata in the make-node function of the vector zipper.

Patch attached.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 3:47 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/134
Attachments:
zip-metadata-bug.diff - https://www.assembla.com/spaces/clojure/documents/c1enmoydyr3RpYeJe5afGb/download/c1enmoydyr3RpYeJe5afGb

Comment by Assembla Importer [ 24/Aug/10 3:47 AM ]

meikelbrandmeyer said: [file:c1enmoydyr3RpYeJe5afGb]: Patch for metadata bug in zipper

Comment by Assembla Importer [ 24/Aug/10 3:47 AM ]

meikelbrandmeyer said: (In [[r:dc5b4e60b88b9183e40a2427ef91b64c45c42ac3]]) Move metadata in vector-zip and seq-zip

Fixes #134
Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Comment by Assembla Importer [ 24/Aug/10 3:47 AM ]

chouser@n01se.net said: Child association with ticket #161 was added





[CLJ-131] Move Clojure tests from contrib into Clojure Created: 19/Jun/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   

See this page in the wiki:

http://www.assembla.com/wiki/show/clojure/Getting_Tests_Into_Clojure



 Comments   
Comment by Assembla Importer [ 24/Aug/10 6:46 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/131

Comment by Assembla Importer [ 24/Aug/10 6:46 AM ]

fsodomka said: Child association with ticket #144 was added

Comment by Assembla Importer [ 24/Aug/10 6:46 AM ]

fsodomka said: Child association with ticket #158 was added





[CLJ-128] Ensure that PersistentTreeMap.empty() (and therefore PersistentTreeSet.empty()) retain the callee's comparator Created: 18/Jun/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Chas Emerick
Resolution: Completed Votes: 0
Labels: None


 Description   

Currently:

user=> (-> (sorted-set-by (comparator >) 1 2 3) empty (into [1 2 3]))
#{1 2 3}

The above should evaluate to #{3 2 1} (the provided comparator is being dropped by the 'empty' call).



 Comments   
Comment by Assembla Importer [ 24/Aug/10 7:45 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/128
Attachments:
fix-128.diff - https://www.assembla.com/spaces/clojure/documents/aaAsAO7eer3R_eeJe5afGb/download/aaAsAO7eer3R_eeJe5afGb
fix-128-b.diff - https://www.assembla.com/spaces/clojure/documents/bkb7eW7nWr3RUheJe5aVNr/download/bkb7eW7nWr3RUheJe5aVNr
fix-128-c.diff - https://www.assembla.com/spaces/clojure/documents/camOJA7oOr3QIWeJe5aVNr/download/camOJA7oOr3QIWeJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 7:45 AM ]

richhickey said: Updating tickets (#127, #128, #129, #130)

Comment by Assembla Importer [ 24/Aug/10 7:45 AM ]

devlinsf said: [file:aaAsAO7eer3R_eeJe5afGb]: This fixes empty to preserve a comparator

Comment by Assembla Importer [ 24/Aug/10 7:45 AM ]

devlinsf said: I had add a new arity for withMeta to PersistentTreeSet and PersistentTreeMap. This new form takes a comparator when creating a new value.

Comment by Assembla Importer [ 24/Aug/10 7:45 AM ]

chouser@n01se.net said: Sean, both the map and set already have constructors that include meta and comparator (via impl in the set case). I think you can just use those in the empty() methods.

Comment by Assembla Importer [ 24/Aug/10 7:45 AM ]

devlinsf said: Rewrote empty per Chouser's suggestion. Removed new arity to withMeta. Added tests to test_clojure/sequences.clj Should be better now.

Comment by Assembla Importer [ 24/Aug/10 7:45 AM ]

chouser@n01se.net said: Sean, I don't see a new patch attached.

Comment by Assembla Importer [ 24/Aug/10 7:45 AM ]

chouser@n01se.net said: [file:bkb7eW7nWr3RUheJe5aVNr]: Simplified patch to fix sorted empty() methods

Comment by Assembla Importer [ 24/Aug/10 7:45 AM ]

chouser@n01se.net said: [file:camOJA7oOr3QIWeJe5aVNr]: patch against 1.1.0-rc1 that includes fix and tests

Comment by Assembla Importer [ 24/Aug/10 7:45 AM ]

chouser@n01se.net said: (In [[r:89ad4ab4265299327001e2717aa73c8f87f11346]]) empty for sorted-map and sorted-set now maintain comparator. Fixes #128

Signed-off-by: Rich Hickey <richhickey@gmail.com>

Branch: master

Comment by Assembla Importer [ 24/Aug/10 7:45 AM ]

importer said: (In [[r:a3a1b3aa3523608f0b69e0d8655d519767246c79]]) Added sorted tests to test-empty in test_clojure/sequences.clj Refs #128

Signed-off-by: Rich Hickey <richhickey@gmail.com>

Branch: master

Comment by Assembla Importer [ 24/Aug/10 7:45 AM ]

importer said: (In [[r:855f394d6895cebfcee307dbccea9bdeffe792f5]]) Added test-empty-sorted to test_clojure/sequences.clj Refs #128

Signed-off-by: Rich Hickey <richhickey@gmail.com>

Branch: master





[CLJ-125] GC Issue 121: slurp should accept an encoding name Created: 17/Jun/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   
Reported by cemer...@snowtide.com, Jun 09, 2009

clojure.core/slurp currently does not accept an encoding to use when
reading the content from the provided path.  Using the system-default
encoding is a very common failure pattern.

Attached is a patch which adds an encoding argument to slurp (while
retaining the existing behaviour of falling back on the system-default
encoding when one is not specified).


 Comments   
Comment by Assembla Importer [ 24/Aug/10 3:45 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/125
Attachments:
slurp-encoding.patch - https://www.assembla.com/spaces/clojure/documents/byFSiOw4ur3Od2eJe5aVNr/download/byFSiOw4ur3Od2eJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 3:45 AM ]

oranenj said: [file:byFSiOw4ur3Od2eJe5aVNr]

Comment by Assembla Importer [ 24/Aug/10 3:45 AM ]

cemerick said: (In [[r:d97dfc8791e87dbd7727eb3b76d3b62f11de9089]]) add an optional encoding argument to slurp. Fixes #125

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-123] GC Issue 119: require doc out of date Created: 17/Jun/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   
Reported by hlship, May 20, 2009

The following doc for the (require) form seems to be out of date:

  'require loads a lib by loading its root resource. The root resource path
  is derived from the root directory path by repeating its last component
  and appending '.clj'. For example, the lib 'x.y.z has root directory
  <classpath>/x/y/z; root resource <classpath>/x/y/z/z.clj. The root
  resource should contain code to create the lib's namespace and load any
  additional lib resources.

Unless I'm missing something big, the root resource is
<classpath>/x/y/z.clj.  I'm not sure how the root directory feeds into
things now. If I remember back about 6 months, an older version of Clojure
did it this way.


 Comments   
Comment by Assembla Importer [ 24/Aug/10 3:45 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/123
Attachments:
0001-Bring-documentation-for-require-up-to-date.patch - https://www.assembla.com/spaces/clojure/documents/cX-0jCw4Cr3RbzeJe5afGb/download/cX-0jCw4Cr3RbzeJe5afGb

Comment by Assembla Importer [ 24/Aug/10 3:45 AM ]

oranenj said: [file:cX-0jCw4Cr3RbzeJe5afGb]: Bring 'require doc up to date and add an usage example

Comment by Assembla Importer [ 24/Aug/10 3:45 AM ]

oranenj said: Added a patch that improves the documentation

Comment by Assembla Importer [ 24/Aug/10 3:45 AM ]

chouser@n01se.net said: Please include "Refs #123" in your git commit message, so that the ticket will be updated automatically on push, like this:

(In 31825fe1991baa3fc9375556ec6f6c595c175f4e) Bring documentation for 'require up to date

This seems to me to be a bug that should be fixed in 1.0 as well. Since we don't have a process in place for that yet, for now I'll just leave this ticket open.

Comment by Assembla Importer [ 24/Aug/10 3:45 AM ]

chouser@n01se.net said: Created ticket #141 to track this issue against branch 1.0.

Comment by Assembla Importer [ 24/Aug/10 3:45 AM ]

chouser@n01se.net said: Child association with ticket #141 was added





[CLJ-117] GC Issue 113: Incorrect handling of trailing decimal points in numbers Created: 17/Jun/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   
Reported by scgilardi, May 04, 2009

What (small set of) steps will reproduce the problem?

        user=> (class 123.)
        java.lang.Integer

In contrast, Java reads such a number as a double.

        % javac Foo.java
        Foo.java:5: possible loss of precision
        found   : double
        required: int
                    int a = 123.;
                            ^
        1 error

Another place this comes up is with a number formatted as 123.e4.  
Currently that's an invalid number in Clojure:

        user=> (class 123.e4)
        java.lang.NumberFormatException: Invalid number: 123.e4
        java.lang.Exception: Unmatched delimiter: )
        user=>

Java reads it as 1230000.0

What version are you using?

1.0.0

Was this discussed on the group? If so, please provide a link to the
discussion:

http://groups.google.com/group/clojure/browse_thread/thread/c0db774b78171b9b/c57e878f11f2f199?lnk=gst&q=number#c57e878f11f2f199

Please provide any additional information below.

I've enclosed a patch to LispReader.java that fixes the problem. The patch
contains two changes, one necessary, one optional:

necessary: change the regular expressions intPat and floatPat so that "1."
is not considered an "int" and "1.e3" is accepted as a legal float.

optional: change the handling of the "M" suffix in matchNumber to make the
float handling code use matcher groups like the int and bigint handling
code does rather than using string manipulations.

I recommend both changes.

Comment 1  by scgilardi, May 04, 2009

I've attached a patch to clojure-contrib/src/clojure/contrib/test_clojure/reader.clj
to provide additional tests for reading Doubles and BigDecimals that pass with the
fixed Clojure LispReader.


 Comments   
Comment by Assembla Importer [ 24/Aug/10 12:45 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/117
Attachments:
number-trailing-dot.patch - https://www.assembla.com/spaces/clojure/documents/drAVxMw4mr3Ou4eJe5aVNr/download/drAVxMw4mr3Ou4eJe5aVNr
number-trailing-dot-tests.patch - https://www.assembla.com/spaces/clojure/documents/drAYtUw4mr3Ou4eJe5aVNr/download/drAYtUw4mr3Ou4eJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 12:45 AM ]

oranenj said: [file:drAVxMw4mr3Ou4eJe5aVNr]

Comment by Assembla Importer [ 24/Aug/10 12:45 AM ]

oranenj said: [file:drAYtUw4mr3Ou4eJe5aVNr]: on comment 1

Comment by Assembla Importer [ 24/Aug/10 12:45 AM ]

importer said: (In [[r:f1d13b8f1fbda376352caf85857cc0585717bcd9]]) parse "1." and "1.e3" as legal floats. Refs #117

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Comment by Assembla Importer [ 24/Aug/10 12:45 AM ]

chouser@n01se.net said: Leaving this open until the location of clojure-tests are settled so that the attached test patch can be committed as well.

Comment by Assembla Importer [ 24/Aug/10 12:45 AM ]

importer said: (In [[r:5e34989a7098a55ca014030d7446d2dc20ebc33b]]) Test reading of numbers like "1." and "1.e3". Fixes #117

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-91] GC Issue 87: *-seq should return seq/nil Created: 17/Jun/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Drew Raines
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   
Reported by aaraines, Feb 26, 2009

This patch alters line-seq, resultset-seq, re-seq, and tree-seq to return
nil if the LazySeq is empty, as discussed in #clojure.

http://clojure-log.n01se.net/date/2009-02-26.html#14:05

Comment 1  by aaraines, Feb 26, 2009

Patch against SVN 1309.

Comment 2 by aaraines, Feb 27, 2009

This patch uses (seq s) for its test rather than (first s).


 Comments   
Comment by Assembla Importer [ 24/Aug/10 12:45 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/91
Attachments:
aar-star-seq-nil.patch - https://www.assembla.com/spaces/clojure/documents/acJw44w38r3Ou4eJe5aVNr/download/acJw44w38r3Ou4eJe5aVNr
aar-star-seq-nil-2.patch - https://www.assembla.com/spaces/clojure/documents/acJzTGw38r3Ou4eJe5aVNr/download/acJzTGw38r3Ou4eJe5aVNr
issue-91-star-seq-nil.diff - https://www.assembla.com/spaces/clojure/documents/aXOzTMJNer3QCTeJe5aVNr/download/aXOzTMJNer3QCTeJe5aVNr

Comment by Assembla Importer [ 24/Aug/10 12:45 AM ]

oranenj said: [file:acJw44w38r3Ou4eJe5aVNr]

Comment by Assembla Importer [ 24/Aug/10 12:45 AM ]

oranenj said: [file:acJzTGw38r3Ou4eJe5aVNr]: on comment 3

Comment by Assembla Importer [ 24/Aug/10 12:45 AM ]

richhickey said: As of patch aar-star-seq-nil-2.patch this is still not quite right. The logic should be, do the read/whatever, if something, return (cons something (lazy-seq again)), else return nil. aar-star-seq-nil-2.patch is creating a lazy seq then immediately forcing it.

Comment by Assembla Importer [ 24/Aug/10 12:45 AM ]

drewr said: [file:aXOzTMJNer3QCTeJe5aVNr]: *-seq returns lazy-seq or nil

Comment by Assembla Importer [ 24/Aug/10 12:45 AM ]

drewr said: Since tree-seq always returns a seq with at least one element, I did not include it in this ticket. I hope that's correct.

Comment by Assembla Importer [ 24/Aug/10 12:45 AM ]

technomancy said: +1; this looks good to me.

Comment by Assembla Importer [ 24/Aug/10 12:45 AM ]

richhickey said: issue-91-star-seq-nil.diff ok





[CLJ-79] GC Issue 76: adding sorted-set-by Created: 18/Jun/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Chouser
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   
Reported by timothypratley, Feb 11, 2009

http://groups.google.com/group/clojure/browse_thread/thread/9d280b6229aef38
4/0e5a2e1f80cb3810

user=> (sorted-set-by #(> (:hat %1) (:hat %2)) {:hat 2} {:hat 3} {:hat 1})
#{{:hat 3} {:hat 2} {:hat 1}}

Printed+signed CA is in the snail mail


 Comments   
Comment by Assembla Importer [ 24/Aug/10 2:45 PM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/79
Attachments:
sorted-set-by.patch - https://www.assembla.com/spaces/clojure/documents/bOIR-4w3Wr3Qr1eJe5aVNr/download/bOIR-4w3Wr3Qr1eJe5aVNr
sorted-set-by.diff - https://www.assembla.com/spaces/clojure/documents/alPuT-xbCr3OXTeJe5aVNr/download/alPuT-xbCr3OXTeJe5aVNr
sorted-set-by2.diff - https://www.assembla.com/spaces/clojure/documents/aFa77SVAGr3QYWeJe5afGb/download/aFa77SVAGr3QYWeJe5afGb

Comment by Assembla Importer [ 24/Aug/10 2:45 PM ]

oranenj said: [file:bOIR-4w3Wr3Qr1eJe5aVNr]

Comment by Assembla Importer [ 24/Aug/10 2:45 PM ]

richhickey said: Updating tickets (#8, #19, #30, #31, #126, #17, #42, #47, #50, #61, #64, #69, #71, #77, #79, #84, #87, #89, #96, #99, #103, #107, #112, #113, #114, #115, #118, #119, #121, #122, #124)

Comment by Assembla Importer [ 24/Aug/10 2:45 PM ]

cemerick said: [file:alPuT-xbCr3OXTeJe5aVNr]: patch rebased to current github master

Comment by Assembla Importer [ 24/Aug/10 2:45 PM ]

chouser@n01se.net said: Chas, would you mind changing sorted-set-by (and I guess sorted-set too, since this touches it) to use the new-style (Foo/static arg) syntax? It's my understanding Rich wants to move core toward that as we go.

Comment by Assembla Importer [ 24/Aug/10 2:45 PM ]

cemerick said: Yeah, that's fine. I'm also going to take a whack at 129 in the process.

Comment by Assembla Importer [ 24/Aug/10 2:45 PM ]

cemerick said: [file:aFa77SVAGr3QYWeJe5afGb]: revised patch with / static method invocations

Comment by Assembla Importer [ 24/Aug/10 2:45 PM ]

cemerick said: Revised patch attached, based off of today's rhickey/master.

Comment by Assembla Importer [ 24/Aug/10 2:45 PM ]

cemerick said: (In [[r:9e810bf17700982eb1a3a5cf21c0fcba6bc0eea5]]) added sorted-set-by, adapted from timothypratley's patch, fixes #79

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master





[CLJ-71] GC Issue 68: every? returns nil instead of false Created: 17/Jun/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Defect
Reporter: Anonymous Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   
Reported by pedro.dhb, Feb 07, 2009


What (small set of) steps will reproduce the problem?

(every? #{\space} "dam") #=> nil


What is the expected output? What do you see instead?
The expected output is false according to the API docs for every?. Currently nil is returned.

What version are you using?
SVN revision 1252

Was this discussed on the group? If so, please provide a link to the discussion:
It was mentioned on the IRC but not in the groups.

Please provide any additional information below.
_END _INFO



Comment 1 by slash2314, Feb 24, 2009

If need needs to return false in this case, I propose the following patch.


 Comments   
Comment by Assembla Importer [ 24/Aug/10 4:45 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/71
Attachments:
every-false.patch - https://www.assembla.com/spaces/clojure/documents/bjODraw3Kr3O2PeJe5afGb/download/bjODraw3Kr3O2PeJe5afGb
0001-core-make-every-return-false-instead-of-nil.patch - https://www.assembla.com/spaces/clojure/documents/bZMX5WxNqr3P5SeJe5afGb/download/bZMX5WxNqr3P5SeJe5afGb

Comment by Assembla Importer [ 24/Aug/10 4:45 AM ]

oranenj said: [file:bjODraw3Kr3O2PeJe5afGb]: on comment 1

Comment by Assembla Importer [ 24/Aug/10 4:45 AM ]

richhickey said: Updating tickets (#8, #19, #30, #31, #126, #17, #42, #47, #50, #61, #64, #69, #71, #77, #79, #84, #87, #89, #96, #99, #103, #107, #112, #113, #114, #115, #118, #119, #121, #122, #124)

Comment by Assembla Importer [ 24/Aug/10 4:45 AM ]

richhickey said: No CA from original submitter - fresh patch welcome

Comment by Assembla Importer [ 24/Aug/10 4:45 AM ]

richhickey said: Updating tickets (#42, #71)

Comment by Assembla Importer [ 24/Aug/10 4:45 AM ]

oranenj said: [file:drpB3kxNar3PzkeJe5afGb]

Comment by Assembla Importer [ 24/Aug/10 4:45 AM ]

oranenj said: [file:bZMX5WxNqr3P5SeJe5afGb]

Comment by Assembla Importer [ 24/Aug/10 4:45 AM ]

oranenj said: Sorry for the "double post".
This new patch compiles fine for me and passes all the tests in contrib, so it doesn't look like anything depends on every? returning nil.

Comment by Assembla Importer [ 24/Aug/10 4:45 AM ]

oranenj said: (In [[r:b03e19aa341fea01c1279a74f4184f6538d0f72e]]) core: make every? return false instead of nil

Refs #71

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Comment by Assembla Importer [ 24/Aug/10 4:45 AM ]

chouser@n01se.net said: Created ticket #133 to track this fix against Clojure 1.0. That allows this ticket to be closed.

Dup'ing a ticket like this is a bit of work, but if we like the results it can probably be automated pretty easily.





[CLJ-1] Add chunk support to map filter et al Created: 13/Jun/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.1

Type: Enhancement
Reporter: Anonymous Assignee: Rich Hickey
Resolution: Completed Votes: 0
Labels: None


 Description   

add conditional logic to test for chunked seq and handle specially



 Comments   
Comment by Assembla Importer [ 24/Aug/10 6:43 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/1
Attachments:
chunked-doseq.diff - https://www.assembla.com/spaces/clojure/documents/dyQbLWIiCr3RSfeJe5aVNr/download/dyQbLWIiCr3RSfeJe5aVNr
chunked-doseq-v2.diff - https://www.assembla.com/spaces/clojure/documents/ayZsEAIHer3OuReJe5afGb/download/ayZsEAIHer3OuReJe5afGb
chunked-concat.diff - https://www.assembla.com/spaces/clojure/documents/ddNltiJ1Gr3Q4TeJe5aVNr/download/ddNltiJ1Gr3Q4TeJe5aVNr
chunked-for.diff - https://www.assembla.com/spaces/clojure/documents/d1Zsv2Ke4r3QR8eJe5afGb/download/d1Zsv2Ke4r3QR8eJe5afGb

Comment by Assembla Importer [ 24/Aug/10 6:43 AM ]

chouser@n01se.net said: [file:dyQbLWIiCr3RSfeJe5aVNr]: doseq with chunked seq support

Comment by Assembla Importer [ 24/Aug/10 6:43 AM ]

chouser@n01se.net said: Is it ok to call chunk-rest before chunk-first is consumed?

Anyway, I must have done something terribly wrong. The doseq in chunked-doseq.diff passes all existing tests, but runs dramatically slower than the old doseq on both chunked and non-chunked seqs.

I didn't test performance until after I'd attached the patch, otherwise I would have kept it to myself.

Comment by Assembla Importer [ 24/Aug/10 6:43 AM ]

chouser@n01se.net said: [file:ayZsEAIHer3OuReJe5afGb]: Add chunked seq support to doseq, v2

Comment by Assembla Importer [ 24/Aug/10 6:43 AM ]

chouser@n01se.net said: file:chunked-doseq-v2.diff should be good to go. It's in the same performance ballpark as the pre-chunk doseq for unchunked seqs, and noticeably faster for chunked seqs. It passes all existing tests.

Comment by Assembla Importer [ 24/Aug/10 6:43 AM ]

chouser@n01se.net said: (In [[r:1abb7a56de1678321054af7fce183184f06974dd]]) Add chunked seq support to doseq, v2. Refs #1

Branch: master

Comment by Assembla Importer [ 24/Aug/10 6:43 AM ]

chouser@n01se.net said: set approval back to 'none', awaiting patches for more functions.

Comment by Assembla Importer [ 24/Aug/10 6:43 AM ]

chouser@n01se.net said: [file:ddNltiJ1Gr3Q4TeJe5aVNr]: Add chunked seq support to concat

Comment by Assembla Importer [ 24/Aug/10 6:43 AM ]

chouser@n01se.net said: [file:aIu4XoJ1Kr3OYMeJe5afGb]: Add chunked seq support to concat

Comment by Assembla Importer [ 24/Aug/10 6:43 AM ]

chouser@n01se.net said: Added chunked seq support to concat: file:chunked-concat.diff

Because concat had been defined before any of the chunk fns, I moved the the chunk fns to much earlier in core.clj than they were. This also required changing 'chunk-cons' to use static methods directly instead of core fns.

This patch includes a commit to fix an issue in the chunked doseq, where seq was called on chunk-rest too early. When combinded with chunked concat this caused some laziness tests to fail.

Comment by Assembla Importer [ 24/Aug/10 6:43 AM ]

chouser@n01se.net said: [file:d1Zsv2Ke4r3QR8eJe5afGb]: Add support for chunked seqs to 'for'

Comment by Assembla Importer [ 24/Aug/10 6:43 AM ]

chouser@n01se.net said: (In [[r:dbe1710652618c842e513760e985c2219d71926b]]) delay seq on chunk-rest in doseq

doseq was calling seq on chunk-rest too early. When combinded with chunked
concat this caused some laziness tests to fail. Refs #1

Branch: master

Comment by Assembla Importer [ 24/Aug/10 6:43 AM ]

chouser@n01se.net said: (In [[r:4af9fcf218c04db9b38fb4ce35591f1ff17a4f15]]) Add chunked seq support to concat

concat is defined early, so I moved the the chunk fns up which required
changing 'chunk-cons' to use static methods directly instead of core fns.
Refs #1

Branch: master

Comment by Assembla Importer [ 24/Aug/10 6:43 AM ]

chouser@n01se.net said: (In [[r:14316ae2110a779ffc8ac9c3da3f1c41852c4289]]) Add support for chunked seqs to 'for'. Refs #1

Branch: master





Generated at Sun Sep 14 23:16:44 CDT 2014 using JIRA 4.4#649-r158309.