[CLJ-999] Wrong link in gh-pages index (api-index.html) Created: 18/May/12 Updated: 20/May/13 Resolved: 20/May/13 |
|
| Status: | Resolved |
| Project: | Clojure |
| Component/s: | None |
| Affects Version/s: | Release 1.3 |
| Fix Version/s: | None |
| Type: | Defect | Priority: | Trivial |
| Reporter: | Bogdan Popescu | Assignee: | Tom Faulhaber |
| Resolution: | Completed | Votes: | 0 |
| Labels: | docs, documentation | ||
| Patch: | None |
| Description |
|
The api-index.html includes wrong links for the following:
The links point to pages that do not exist. The problem is that the documentation for those entries is on a "parent" page, for example, the link clojure.core.protocols-api.html#clojure.core.protocols/internal-reduce should have been clojure.core-api.html#clojure.core.protocols/internal-reduce Not a huge bug for me, but you might want to get it fixed. And please give my huge thanks to whoever is in charge of the documentation, I'm the developer behind Dash, a Mac OS X documentation browser, and I was in the process of creating a documentation set for Clojure, and because you guys have an index, you made my work 1000 times easier. |
| Comments |
| Comment by Andy Fingerhut [ 11/Mar/13 3:01 PM ] |
|
Is this fixed now? Tom Faulhaber has regenerated the docs after the recent Clojure 1.5 release, and I think updated other things besides, so it might be. |
| Comment by Tom Faulhaber [ 11/Mar/13 4:43 PM ] |
|
Nope, not fixed. This one either slipped by me or came in right when I was changing jobs so didn't stick in my brain. I'll take a look now. Thanks for the report, Bogdan, and thanks for the bump, Andy to get it on my radar. |
| Comment by Gabriel Horner [ 10/May/13 4:00 PM ] |
|
Tom, I'm happy to help if you need it. Could you document on a wiki page how autodoc is run here? I couldn't find such a page. |
| Comment by Tom Faulhaber [ 20/May/13 4:18 PM ] |
|
This is fixed with gh-pages commit 919143e (autodoc doesn't follow the regular Clojure release path since it's a website built off the source checkins). |
| Comment by Tom Faulhaber [ 20/May/13 4:24 PM ] |
|
Gabriel, Thanks for the offer. I fixed this one, but may take you up on it if more come up. There is currently no wiki page about the autodoc process but it's an excellent suggestion. I'll put it on my list to write something up. In the meantime source on the autodoc program itself is at https://github.com/tomfaulhaber/autodoc and a description of how it works is at http://tomfaulhaber.github.io/autodoc. Two caveats: (1) autodoc is currently undergoing a bunch of work (thus this bug fix) in preparation for a new release and (2) the documentation doesn't talk much about how it's used for documenting Clojure itself. |
[CLJ-1173] One-arg protocol functions whose name begins in a dash generates a call to a wrong field in the emitted code Created: 01/Mar/13 Updated: 17/May/13 Resolved: 17/May/13 |
|
| Status: | Closed |
| Project: | Clojure |
| Component/s: | None |
| Affects Version/s: | Release 1.4 |
| Fix Version/s: | None |
| Type: | Defect | Priority: | Major |
| Reporter: | Meikel Brandmeyer | Assignee: | Unassigned |
| Resolution: | Duplicate | Votes: | 0 |
| Labels: | None | ||
| Environment: |
Clojure 1.4 |
||
| Description |
(defprotocol P (-foo [this]))
This code generates a reflective call to a non-existing foo field instead of the correct -foo method. I was told by Christophe Grand that changing the line 557 in core_deftype.clj from: (. ~(with-meta target {:tag on-interface}) ~(or on-method method) ~@(rest gargs))
to (. ~(with-meta target {:tag on-interface}) (~(or on-method method) ~@(rest gargs)))
is a quick fix. However I don't know too much about the compilation specifics of . to judge whether this is the correct fix. Issue reproduction: Clojure user=> (set! *warn-on-reflection* true) true user=> (defprotocol P (-foo [this])) P Reflection warning, REPL:4 - reference to field foo can't be resolved. |
| Comments |
| Comment by Gabriel Horner [ 17/May/13 1:36 PM ] |
|
CLJ-1202 addresses this exact issue with the same fix and includes tests |