<< Back to previous view

[CLJS-1208] local deps.cljs should take precedence over upstream libs when containing the same :provides Created: 15/Apr/15  Updated: 16/Apr/15  Resolved: 16/Apr/15

Status: Closed
Project: ClojureScript
Component/s: None
Affects Version/s: 0.0-3196
Fix Version/s: Next

Type: Defect Priority: Minor
Reporter: Kevin Webster Assignee: Unassigned
Resolution: Declined Votes: 0
Labels: None

Attachments: Text File rabidpraxis-reversed-deps.patch    
Patch: Code

 Description   

Creating a deps.cljs in attempt to override :foreign-libs from an upstream dependency (ex. cljsjs) does not work when the :provides are the same.

https://github.com/clojure/clojurescript/blob/master/src/clj/cljs/closure.clj#L1251

It looks as though getResources returns a sequence of deps.cljs where the upstream versions are ordered at the end of the seq. Because of this, when this gets built into the index, the upstream version always takes precedence.

Reversing the sequence seems to fix the problem.



 Comments   
Comment by David Nolen [ 16/Apr/15 1:53 PM ]

This is not how overriding works, overriding is done by supplying overrides via compiler options.





[CLJS-1205] Support conditional reading in REPLs Created: 14/Apr/15  Updated: 14/Apr/15  Resolved: 14/Apr/15

Status: Closed
Project: ClojureScript
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Major
Reporter: David Nolen Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None


 Description   

Same as CLJ-1700



 Comments   
Comment by David Nolen [ 14/Apr/15 6:33 PM ]

fixed https://github.com/clojure/clojurescript/commit/78c882f1f61023c0b0a75b87bd8e8bcb7058ed04





[CLJS-1204] cljs.closure/watch cannot take cljs.closure/Compilable Created: 14/Apr/15  Updated: 14/Apr/15  Resolved: 14/Apr/15

Status: Closed
Project: ClojureScript
Component/s: None
Affects Version/s: 0.0-3196
Fix Version/s: Next

Type: Defect Priority: Major
Reporter: David Nolen Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None


 Description   

Blocker for exporting an official cljs.build.api/watch.



 Comments   
Comment by David Nolen [ 14/Apr/15 6:10 PM ]

fixed https://github.com/clojure/clojurescript/commit/e8a4ad9db140ba47179850b32e9b757c9193d3f8





[CLJS-1203] official way to supply multiple files/directories to cljs.closure/build and cljs.closure/watch Created: 14/Apr/15  Updated: 14/Apr/15  Resolved: 14/Apr/15

Status: Closed
Project: ClojureScript
Component/s: None
Affects Version/s: 0.0-3196
Fix Version/s: Next

Type: Defect Priority: Major
Reporter: David Nolen Assignee: David Nolen
Resolution: Completed Votes: 0
Labels: None


 Comments   
Comment by David Nolen [ 14/Apr/15 9:02 AM ]

https://github.com/clojure/clojurescript/commit/5353489fe3beda9a6e9d044e89da3bd0d2accce7





Generated at Tue Apr 21 08:15:08 CDT 2015 using JIRA 4.4#649-r158309.