<< Back to previous view

[CLJS-1247] Split out error printing from regular printing Created: 04/May/15  Updated: 15/Jul/15  Resolved: 15/Jul/15

Status: Resolved
Project: ClojureScript
Component/s: None
Affects Version/s: 0.0-3269
Fix Version/s: 1.7.28

Type: Defect Priority: Major
Reporter: David Nolen Assignee: David Nolen
Resolution: Completed Votes: 0
Labels: bootstrap


 Comments   
Comment by David Nolen [ 06/May/15 9:02 AM ]

See CLJS-710

Comment by David Nolen [ 15/Jul/15 4:19 PM ]

fixed https://github.com/clojure/clojurescript/commit/074445f5c8eccd5a4ff6d075b9d4b3d96bc367ee





[CLJS-1336] Create bootstrapping namespace Created: 12/Jul/15  Updated: 31/Jul/15  Resolved: 31/Jul/15

Status: Resolved
Project: ClojureScript
Component/s: None
Affects Version/s: 0.0-3308
Fix Version/s: 1.7.28

Type: Enhancement Priority: Major
Reporter: David Nolen Assignee: David Nolen
Resolution: Completed Votes: 0
Labels: None


 Description   

This namespace should provide basic analyze, emit, eval functionality along with necessary helpers for establishing the compilation environment. *load-file* or something similar must be bound by the user. One open question is how to handle async versus sync file loading. In the browser context only the former is really realistic, while in Node.js/iOS/Android we have considerably more flexibility.



 Comments   
Comment by David Nolen [ 12/Jul/15 2:05 PM ]

CLJS-1337 must be addressed first.

Comment by David Nolen [ 31/Jul/15 8:12 PM ]

fixed in master





[CLJS-1388] Stacktrace element handling for :output-dir w/o file/line/column Created: 02/Aug/15  Updated: 03/Aug/15  Resolved: 03/Aug/15

Status: Resolved
Project: ClojureScript
Component/s: None
Affects Version/s: 1.7.28
Fix Version/s: None

Type: Defect Priority: Major
Reporter: Mike Fikes Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None


 Description   

If parsing stacktraces when :host and :port are supplied, elements that have no file/line/column are properly accommodated.

For example:

https://github.com/clojure/clojurescript/blob/v1.7/src/main/cljs/cljs/stacktrace.cljc#L266

But, an attempt to process a similar stacktrace when :output-dir is being used, an error will be thrown. (This can occur when using :output-dir for embedded JavaScriptCore.)

Here is a simple repro:

(parse-stacktrace {}
"cljs$core$seq@out/cljs/core.js:3999:17
cljs$core$first@out/core.js:4018:22
cljs$core$ffirst@out/cljs/core.js:5161:39
global code"
{:ua-product :safari} 
{:output-dir "out"})


 Comments   
Comment by David Nolen [ 03/Aug/15 5:50 AM ]

fixed https://github.com/clojure/clojurescript/commit/49f3ea9c1e5064bacb3e13d29f5f3f18af1f4bc1





[CLJS-1409] Allow type checking of protocols Created: 09/Aug/15  Updated: 09/Aug/15  Resolved: 09/Aug/15

Status: Resolved
Project: ClojureScript
Component/s: None
Affects Version/s: 1.7.48
Fix Version/s: Next

Type: Enhancement Priority: Major
Reporter: David Nolen Assignee: David Nolen
Resolution: Completed Votes: 0
Labels: None


 Comments   
Comment by David Nolen [ 09/Aug/15 10:27 AM ]

fixed https://github.com/clojure/clojurescript/commit/27af25a3e43e4b61ba924f77ed5068717613e026





[CLJS-1017] Support :main for :advanced & :simple builds Created: 06/Feb/15  Updated: 10/Aug/15  Resolved: 10/Aug/15

Status: Resolved
Project: ClojureScript
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Enhancement Priority: Major
Reporter: David Nolen Assignee: David Nolen
Resolution: Completed Votes: 1
Labels: None

Attachments: Text File 0001-Allow-main-entry-point-for-advanced-optimization.patch    

 Description   

This would use the supplied entry point to compute the build instead of looking at everything in the source directory.



 Comments   
Comment by Jonathon McKitrick [ 10/Jul/15 9:14 AM ]

Initial effort to solve the issue, but will need some cleanup.

Comment by Jonathon McKitrick [ 10/Jul/15 9:18 AM ]

Initial efforts with a simple fix resulted in the constants table merged in the wrong order, after the application code. After more detective work, I ran the initial file through the analyzer and then the dependency order sort, and this solved this issue.

Not all tests pass on master as of this writing, but this patch does not create additional breakage. After this patch is reviewed and cleaned up, I would expect to move on to writing the test case as well.

Comment by David Nolen [ 10/Jul/15 4:39 PM ]

Patch mostly looks good except for the ugliness around :output-file. I've changed cljs.closure/compile-file to also allow :output-to. Please change the logic to avoid specifying :output-file.

Also I see no failing tests on master. Can you clarify about that?

Comment by Jonathon McKitrick [ 10/Jul/15 7:47 PM ]

Updated patch

Comment by David Nolen [ 13/Jul/15 2:56 PM ]

So are you saying applying the patch causes the test to fail? If you've identified the issue modify the patch to solve the issue.

Comment by David Nolen [ 13/Jul/15 3:27 PM ]

Jonathan let's please stop talking about the unrelated failing tests. It's cluttering up this issue. I cannot reproduce these failures at all nor have I heard of problems from other developers testing and building from master.

Comment by Jonathon McKitrick [ 10/Aug/15 8:33 AM ]

David, do you need anything else from me on this ticket?

Comment by David Nolen [ 10/Aug/15 8:48 AM ]

Nope will take a look today.

Comment by David Nolen [ 10/Aug/15 4:39 PM ]

fixed https://github.com/clojure/clojurescript/commit/c90f4c169812ad35624493a10b2e3b919fe0a022

Comment by David Nolen [ 10/Aug/15 4:41 PM ]

Jonathan the patch included various unnecessary calls and didn't handle the :simple case. We could have gone back and forth another round but it was just faster for me to fix it in this case. Thanks for the bump and pushing this to get done.





[CLJS-1305] Node.js REPL load-file regression Created: 09/Jun/15  Updated: 10/Aug/15  Resolved: 10/Aug/15

Status: Resolved
Project: ClojureScript
Component/s: None
Affects Version/s: 1.7.48
Fix Version/s: Next

Type: Defect Priority: Major
Reporter: David Nolen Assignee: Unassigned
Resolution: Not Reproducible Votes: 0
Labels: None


 Description   

Appears to be the same as the one we encountered in browser REPL due to the Closure Library dep bump.



 Comments   
Comment by David Nolen [ 10/Aug/15 10:19 PM ]

cannot reproduce.





[CLJS-428] Using */ inside of a docstring causes compiler to produce invalid JavaScript Created: 25/Nov/12  Updated: 13/Jul/15  Resolved: 13/Jul/15

Status: Resolved
Project: ClojureScript
Component/s: None
Affects Version/s: 0.0-3269
Fix Version/s: 1.7.28

Type: Defect Priority: Minor
Reporter: Murphy McMahon Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None
Environment:

Linux, lein-cljsbuild


Attachments: Text File cljs_428.patch     Text File cljs_428_v01.patch    

 Description   

Due to how function docstrings are output by the ClojureScript compiler, the use of

*/
within a docstring causes the compiler to produce invalid JavaScript, breaking compilation, since '*/' will close the docstring's JavaScript comment block and the remaining docstring text will be uncommented as a result.



 Comments   
Comment by Murphy McMahon [ 25/Nov/12 12:32 PM ]

I didn't realize JIRA treats asterisks as markup, so just for clarification: the characters that produce the defect are slash asterisk, ie JavaScript's block comment closing syntax.

Comment by David Nolen [ 22/Dec/12 3:30 PM ]

Do you have a suggested fix for this?

Comment by Sebastian Bensusan [ 18/May/15 7:23 AM ]

I added one extra step in cljs.compiler/emit-comment to replace all occurrences of "*/" into "* /" and it worked for V8, Spidermonkey, and Nashorn.

Notes:

  • The patch includes a test.
  • I couldn't find a standard way to escape */ on JavaScript. If there are other suggestions, like *\/, I wouldn't mind resubmitting the patch.
Comment by Sebastian Bensusan [ 13/Jul/15 5:18 PM ]

Rebased patch.

Comment by David Nolen [ 13/Jul/15 5:45 PM ]

fixed https://github.com/clojure/clojurescript/commit/a660d8f882e6d9ec6578034336eaa87d1b8c478b





[CLJS-1309] get-expander declared twice in analyzer impl Created: 14/Jun/15  Updated: 14/Jul/15  Resolved: 14/Jul/15

Status: Resolved
Project: ClojureScript
Component/s: None
Affects Version/s: 0.0-3308
Fix Version/s: None

Type: Enhancement Priority: Minor
Reporter: Mike Fikes Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None
Environment:

N/A


Attachments: Text File CLJS-1309.patch    

 Description   

(declare get-expander) appears twice in analyzer.cljc. Second declare can be removed.



 Comments   
Comment by David Nolen [ 14/Jul/15 5:44 AM ]

fixed https://github.com/clojure/clojurescript/commit/dd6ee009d7e24e4176f18d659bbb19c12914dd64





Generated at Fri Aug 28 12:22:21 CDT 2015 using JIRA 4.4#649-r158309.