<< Back to previous view

[CLJS-990] Clojurescript records do not have same equality semantics as Clojure records Created: 27/Jan/15  Updated: 30/Jan/15  Resolved: 30/Jan/15

Status: Resolved
Project: ClojureScript
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Major
Reporter: Richard Davies Assignee: Unassigned
Resolution: Not Reproducible Votes: 0
Labels: None
Environment:

[org.clojure/clojurescript "0.0-2665"]



 Description   

(defrecord Pot [a])

(= (Pot. 1) (Pot. 1)) ; returns false

This arose when I was trying to get some code to cross-compile between Clojure and ClojureScript and the Clojure code was using records as map keys.

Workaround:

(extend-type Pot
IEquiv
(-equiv [this that] (and (instance? Pot that) (= (into {} this) (into {} that)))))

Can this behaviour be baked into ClojureScript records by default?



 Comments   
Comment by Richard Davies [ 27/Jan/15 11:27 PM ]

I tried with the latest version of ClojureScript and this works (in isolation). However, when I compile it along with the rest of my code, the equality test still fails without extend-type. I will try to isolate the root case.

Comment by David Nolen [ 30/Jan/15 3:07 PM ]

Cannot reproduce. Please do not reopen this ticket until a minimal case can be supplied thanks.





[CLJS-986] Add :target to the list of build options that should trigger recompilation Created: 21/Jan/15  Updated: 30/Jan/15  Resolved: 30/Jan/15

Status: Resolved
Project: ClojureScript
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Major
Reporter: David Nolen Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None


 Comments   
Comment by David Nolen [ 30/Jan/15 3:11 PM ]

fixed https://github.com/clojure/clojurescript/commit/1611bdc7fa7ef21ed2e8543afaefd81b516bacec





[CLJS-1051] :modules validation, :output-to should be unique Created: 20/Feb/15  Updated: 20/Feb/15  Resolved: 20/Feb/15

Status: Resolved
Project: ClojureScript
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Major
Reporter: David Nolen Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None


 Comments   
Comment by David Nolen [ 20/Feb/15 8:26 PM ]

fixed https://github.com/clojure/clojurescript/commit/f6d46c46068b52f741d237f72a447f4de6c58ad3





[CLJS-939] Quit noderepljs with EOF Created: 31/Dec/14  Updated: 09/Feb/15  Resolved: 09/Feb/15

Status: Resolved
Project: ClojureScript
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Minor
Reporter: Dusan Maliarik Assignee: Unassigned
Resolution: Duplicate Votes: 0
Labels: None


 Description   

As is common in every other REPL out there, Ctrl+D on a new line should quit the REPL



 Comments   
Comment by David Nolen [ 09/Feb/15 6:30 PM ]

CLJS-989





[CLJS-1031] Download Closure over https: in ./script/bootstrap Created: 12/Feb/15  Updated: 12/Feb/15  Resolved: 12/Feb/15

Status: Resolved
Project: ClojureScript
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Enhancement Priority: Trivial
Reporter: Chris Cowan Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None


 Description   

Line 69 of ./script/bootstrap downloads Google's Closure Compiler from http://dl.google.com/closure-compiler/compiler-$CLOSURE_RELEASE.zip, though the URL may be accessed securely over HTTPS too. Could the script be changed to do so?



 Comments   
Comment by David Nolen [ 12/Feb/15 5:58 AM ]

fixed https://github.com/clojure/clojurescript/commit/8b30ecb2327d7942aae1485865fa9540f2eab9e1





Generated at Fri Mar 06 18:14:06 CST 2015 using JIRA 4.4#649-r158309.