<< Back to previous view

[CLJS-1247] Split out error printing from regular printing Created: 04/May/15  Updated: 15/Jul/15  Resolved: 15/Jul/15

Status: Resolved
Project: ClojureScript
Component/s: None
Affects Version/s: 0.0-3269
Fix Version/s: 1.7.28

Type: Defect Priority: Major
Reporter: David Nolen Assignee: David Nolen
Resolution: Completed Votes: 0
Labels: bootstrap


 Comments   
Comment by David Nolen [ 06/May/15 9:02 AM ]

See CLJS-710

Comment by David Nolen [ 15/Jul/15 4:19 PM ]

fixed https://github.com/clojure/clojurescript/commit/074445f5c8eccd5a4ff6d075b9d4b3d96bc367ee





[CLJS-1336] Create bootstrapping namespace Created: 12/Jul/15  Updated: 31/Jul/15  Resolved: 31/Jul/15

Status: Resolved
Project: ClojureScript
Component/s: None
Affects Version/s: 0.0-3308
Fix Version/s: 1.7.28

Type: Enhancement Priority: Major
Reporter: David Nolen Assignee: David Nolen
Resolution: Completed Votes: 0
Labels: None


 Description   

This namespace should provide basic analyze, emit, eval functionality along with necessary helpers for establishing the compilation environment. *load-file* or something similar must be bound by the user. One open question is how to handle async versus sync file loading. In the browser context only the former is really realistic, while in Node.js/iOS/Android we have considerably more flexibility.



 Comments   
Comment by David Nolen [ 12/Jul/15 2:05 PM ]

CLJS-1337 must be addressed first.

Comment by David Nolen [ 31/Jul/15 8:12 PM ]

fixed in master





[CLJS-428] Using */ inside of a docstring causes compiler to produce invalid JavaScript Created: 25/Nov/12  Updated: 13/Jul/15  Resolved: 13/Jul/15

Status: Resolved
Project: ClojureScript
Component/s: None
Affects Version/s: 0.0-3269
Fix Version/s: 1.7.28

Type: Defect Priority: Minor
Reporter: Murphy McMahon Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None
Environment:

Linux, lein-cljsbuild


Attachments: Text File cljs_428.patch     Text File cljs_428_v01.patch    

 Description   

Due to how function docstrings are output by the ClojureScript compiler, the use of

*/
within a docstring causes the compiler to produce invalid JavaScript, breaking compilation, since '*/' will close the docstring's JavaScript comment block and the remaining docstring text will be uncommented as a result.



 Comments   
Comment by Murphy McMahon [ 25/Nov/12 12:32 PM ]

I didn't realize JIRA treats asterisks as markup, so just for clarification: the characters that produce the defect are slash asterisk, ie JavaScript's block comment closing syntax.

Comment by David Nolen [ 22/Dec/12 3:30 PM ]

Do you have a suggested fix for this?

Comment by Sebastian Bensusan [ 18/May/15 7:23 AM ]

I added one extra step in cljs.compiler/emit-comment to replace all occurrences of "*/" into "* /" and it worked for V8, Spidermonkey, and Nashorn.

Notes:

  • The patch includes a test.
  • I couldn't find a standard way to escape */ on JavaScript. If there are other suggestions, like *\/, I wouldn't mind resubmitting the patch.
Comment by Sebastian Bensusan [ 13/Jul/15 5:18 PM ]

Rebased patch.

Comment by David Nolen [ 13/Jul/15 5:45 PM ]

fixed https://github.com/clojure/clojurescript/commit/a660d8f882e6d9ec6578034336eaa87d1b8c478b





[CLJS-1309] get-expander declared twice in analyzer impl Created: 14/Jun/15  Updated: 14/Jul/15  Resolved: 14/Jul/15

Status: Resolved
Project: ClojureScript
Component/s: None
Affects Version/s: 0.0-3308
Fix Version/s: None

Type: Enhancement Priority: Minor
Reporter: Mike Fikes Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None
Environment:

N/A


Attachments: Text File CLJS-1309.patch    

 Description   

(declare get-expander) appears twice in analyzer.cljc. Second declare can be removed.



 Comments   
Comment by David Nolen [ 14/Jul/15 5:44 AM ]

fixed https://github.com/clojure/clojurescript/commit/dd6ee009d7e24e4176f18d659bbb19c12914dd64





Generated at Sat Aug 01 23:21:29 CDT 2015 using JIRA 4.4#649-r158309.