Mac OS X Lion, Maven 3.0.3, JDK 1.6.0_26

Please disregard. Stale <repositories> in my own ~/.m2/settings.xml appear to have been the cause.

Here is an updated patch with a fix for the system-classpath docstring as well.

Any update on this?

There is now a ticket in the CLASSPATH project for this (http://dev.clojure.org/jira/browse/CLASSPATH-1).

CLASSPATH-1

clojure tip - commit 66a88de9408e93cf2b0d73382e662624a54c6c86
clojure-contrib tip - commit 4b562d9d110f169ea37c320edf96ad78c2fb2618

Clojure 1.2.1 and Clojure contrib 1.2.0 on Windows 7 with Sun JVM 1.6.0_22-b04

Now uses clojure.string.trim-newline.

https://github.com/clojure/clojure-contrib/commit/c4810ab19657bd82ad94efe5551db1d338aad23c
https://github.com/clojure/tools.logging/commit/623c6df079835f15ae8b1e885eda397c2e32a5e6

All

There is a pending pull request to fix logging and trace.

I posted this after observing the broken build and not realising clojure-contrib was recently deprecated.
Apologies. I would close this, but my perms don't allow it?

1.3.0-SNAPSHOT

Fix committed:
https://github.com/clojure/clojure-contrib/commit/1a88c88daa87cd61aa7c1c08d538487b55efd97d

The special tag :raw! is available for unescaped output.

Special tags are not considered for attribute value (prxml-attribute fn), just for xml tags (print-xml-tag multimethod), and when used string "[:raw! ...]" is printed as attribute value.

Yes. You must put the actual XML tag inside a [:raw! ...] block if you want to use XML entities in attributes.

I'll be more specific...
I made entity declaration in DOCTYPE like this:

<!DOCTYPE rdf:RDF [
<!ENTITY owl "http://www.w3.org/2002/07/owl#">
]>

so I would be able to use reference to content of this named entity, using "&owl;" (XML syntax), for example:

<owl:onDatatype rdf:resource="&xsd;string">

I don't see a way to achieve this. My first thought was to use:

[:owl:onDatatype {:rdf:resource [:raw! "&xsd;string"]}]

Am I missing something?

Ah, ok, I can use:
[:raw! "<owl:onDatatype rdf:resource=\"&xsd;string\">"]
That seems a bit like a workaround.. I think more idiomatic way isn't so hard to achieve, but no need obviously..

1.2 and 1.3

Root cause is in clojure.contrib.core/defnilsafe, so similar functions like .?. will have the same problem. I futzed around for a while to try and figure it out, but defnilsafe is a little too meta for me. The problem is, predictably enough once you've glanced at the code, with ~'~nil-safe-name.

The general solution ought to look like
(let [qname (symbol (name (ns-name *ns*)) (str nil-safe-name))]
`(existing body...
(more stuff using ~qname instead of ~'~nil-safe-name...)))

But I couldn't make it quite work.

Patch added.

Simple patch where I specifically use fully qualified names when calling defnilsafe.

What about this patch instead? It makes sure to resolve the symbols supplied to defnilsafe while still within the c.c.core namespace.

I also made the arglists a bit less ugly.

1.2 on Snow Leopard

You're using an old repository. This has been fixed. https://github.com/clojure/clojure-contrib

References old github.com/richhickey repository; this has already been fixed.

Or you can merge from my clojure-contrib repo from 'unquoted-json' branch - http://github.com/alexott/clojure-contrib/commit/c22da330f1f5b64a5789bde2bbb958cd9fdc31fa

I'm happy with the idea. Not sure about the implementation.

For other configuration options (keywordizing object fields) I used local arguments, assuming it would be faster than Var lookups. With recent enhancements to Var lookup, that may no longer be true. Need to investigate.

Patch file submitted 31/Oct/10 does not work. "git am -s" returns "Patch does not have a valid e-mail address." http://clojure.org/patches

Alternate implementation committed

Enhancement committed.

Converted from http://www.assembla.com/spaces/clojure/tickets/99

This appears to no longer be applicable.

Clojure 1.3.0-master-SNAPSHOT
user=> (require 'clojure.contrib.json)
nil
user=> (clojure.contrib.json/read-json "")
EOFException JSON error (end-of-file) clojure.contrib.json/read-json-reader (json.clj:115)

Could this be a duplicate of http://dev.clojure.org/jira/browse/CONTRIB-91 ?

Converted from http://www.assembla.com/spaces/clojure/tickets/98

The enclosed patch escapes object keys. It passes all tests. I've added a test that fails without the fix and passes with it.

I've been told that issues are marked as "resolved" only after the patch gets applied. I'm reopening the issue, then, hoping that someone will pick it up from here.

Patch does not apply, appears to be formatted for contrib pre-modularization.

Rewrote patch to work with modularized contrib; applied in d6f6ccfaeac03e35b1f9dbfa04424866cd9b2a41

Is this going to be backported to 1.2 branch? It would be greatly appreciated.

Converted from http://www.assembla.com/spaces/clojure/tickets/97
Attachments:
comp0.diff - https://www.assembla.com/spaces/clojure/documents/aoMbWYYXmr37tPeJe5cbLr/download/aoMbWYYXmr37tPeJe5cbLr

fogus said: Sigh. I posted this in contrib when it should have been in core. I apologize.

Converted from http://www.assembla.com/spaces/clojure/tickets/96

stuart.sierra said: (In revision:499b9c02d1932ba0c0651e04b627c25f7f04f0c8) cartesian-product nil-arg fix; refs #96

Branch: master

Fixed in repository commit 499b9c02d1932ba0c0651e04b627c25f7f04f0c8

Converted from http://www.assembla.com/spaces/clojure/tickets/95

stuart.sierra said: (In revision:11852b988be61bbf661ca80ef7a78d17e3ee2325) Fix broken with-ns tests; refs #95

• broken by Clojure commit 1c0468dbe5228bb8c228e1370133bbe1d018e058
• Clojure's compiler exceptions changed their format

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/94

chouser@n01se.net said: (In revision:4083a0695087d34d13dbbe5a9b49d7c7b30ef2c4) Fix broken repl-utils/show

Was broken since fe4ed311166677cd571d23774171af1d830f7fc5
Fixes #94
Also add a bit more type info in class component maps.

Branch: master

chouser@n01se.net said: Thanks for the report, Ben.

Converted from http://www.assembla.com/spaces/clojure/tickets/93
Attachments:
0001-remove-derecated-clojure.contrib.apply-macro.patch - https://www.assembla.com/spaces/clojure/documents/dFW7nWR6ir34gmeJe5cbLA/download/dFW7nWR6ir34gmeJe5cbLA
0002-remove-deprecated-clojure.contrib.http-agent.patch - https://www.assembla.com/spaces/clojure/documents/dFW9QaR6ir34gmeJe5cbLA/download/dFW9QaR6ir34gmeJe5cbLA
0003-remove-deprecated-clojure.contrib.http-connection.patch - https://www.assembla.com/spaces/clojure/documents/dFXab4R6ir34gmeJe5cbLA/download/dFXab4R6ir34gmeJe5cbLA
0004-remove-deprecated-clojure.contrib.properties.patch - https://www.assembla.com/spaces/clojure/documents/dFXcqIR6ir34gmeJe5cbLA/download/dFXcqIR6ir34gmeJe5cbLA
0005-remove-deprecated-clojure.contrib.javadoc.patch - https://www.assembla.com/spaces/clojure/documents/dFXeH2R6ir34gmeJe5cbLA/download/dFXeH2R6ir34gmeJe5cbLA
0007-remove-deprecated-clojure.contrib.test-is.patch - https://www.assembla.com/spaces/clojure/documents/dFXg04R6ir34gmeJe5cbLA/download/dFXg04R6ir34gmeJe5cbLA
0008-removed-c.c.shell-and-c.c.shell-out.patch - https://www.assembla.com/spaces/clojure/documents/ahtcAoR60r34W9eJe5cbCb/download/ahtcAoR60r34W9eJe5cbCb
remove-deprecated-clojure.contrib.io.patch - https://www.assembla.com/spaces/clojure/documents/bR5RKOSu0r36XVeJe5cbLA/download/bR5RKOSu0r36XVeJe5cbLA
0010-create-clojure.contrib.io-convenience-module.patch - https://www.assembla.com/spaces/clojure/documents/dxyjsaSHar37S6eJe5cbCb/download/dxyjsaSHar37S6eJe5cbCb
0011-remove-deprecated-clojure.contrib.str-utils.patch - https://www.assembla.com/spaces/clojure/documents/dEtFMSSRir35x5eJe5cbCb/download/dEtFMSSRir35x5eJe5cbCb
0013-remove-deprecated-clojure.contrib.string.patch - https://www.assembla.com/spaces/clojure/documents/dSD8sqSRir35nTeJe5cbLr/download/dSD8sqSRir35nTeJe5cbLr
0012-remove-deprecated-clojure.contrib.str-utils2.patch - https://www.assembla.com/spaces/clojure/documents/dSzxyYSRir35nTeJe5cbLr/download/dSzxyYSRir35nTeJe5cbLr
0014-removed-deprecated-clojure.contrib.duck-streams.patch - https://www.assembla.com/spaces/clojure/documents/cJIVlaSTur34OJeJe5cbLr/download/cJIVlaSTur34OJeJe5cbLr
0015-removed-deprecated-clojure.contrib.java-utils.patch - https://www.assembla.com/spaces/clojure/documents/cJNkS8STur34OJeJe5cbLr/download/cJNkS8STur34OJeJe5cbLr
0016-removed-deprecated-clojure.contrib.pprint.patch - https://www.assembla.com/spaces/clojure/documents/cJQGkcSTur34OJeJe5cbLr/download/cJQGkcSTur34OJeJe5cbLr
0017-removed-deprecated-source-get-source-apropos-from-cl.patch - https://www.assembla.com/spaces/clojure/documents/cJ5Kd4STur34OJeJe5cbLr/download/cJ5Kd4STur34OJeJe5cbLr
0018-removed-deprecated-clojure.contrib.seq-utils.patch - https://www.assembla.com/spaces/clojure/documents/cJ8-lqSTur34OJeJe5cbLr/download/cJ8-lqSTur34OJeJe5cbLr
0020-removed-deprecated-subset-superset-from-clojure.cont.patch - https://www.assembla.com/spaces/clojure/documents/da5unsSTur34OJeJe5cbLr/download/da5unsSTur34OJeJe5cbLr
0019-removed-9-deprecated-functions-from-clojure.contrib..patch - https://www.assembla.com/spaces/clojure/documents/daZ0rSSTur34OJeJe5cbLr/download/daZ0rSSTur34OJeJe5cbLr

bpsm said: [file:ahtcAoR60r34W9eJe5cbCb]

bpsm said: I'll submit further patches as I have time. Not being "in the loop", I can't be certain that we really want all the namespaces marked as deprecated gone before 1.3, but that's my operating assumption. (I'm attaching one patch per namespace so that the comitters can be selective.)

bpsm said: [file:bR5RKOSu0r36XVeJe5cbLA]

bpsm said: [file:dxyjsaSHar37S6eJe5cbCb]: proposed new c.c.io providing only what was not migrated to Clojure proper

bpsm said: Proposal: when a namespace is partially promoted to Clojure proper, it might be good to provide a reduced version of the old namespace, providing just the functionality that was not promoted as an alternative to complete removal.

I've sketched out this idea as a patch: 0010-create-clojure.contrib.io-convenience-module.

I'm imagining something like:

• most of clojure.contrib.io is promoted to clojure 1.2
• clojure-contrib 1.2 deprecates, but does not remove clojure.contrib.io
• clojure-contrib 1.3 provides a reduced version of clojure.contrib.io containing only non-deprecatd functionality not available elsewhere (i.e. in Clojure ��� 1.2).

This new clojure.contrib.io is not a strict subset of the old clojure.contrib.io, as some changes seemed sensible to harmonize with clojure.java.io's conventions. This means, it's not a drop-in replacement, but at least provides equivalents for anyone trying to get off the deprecated clojure.contrib.io.

One problem that's apparent with this proposal is that, since the 'new' io only becomes available in 1.3, there would be something of a "flag day" when switching from 1.2 to 1.3, but then there would be if 1.3 completely eliminated c.c.io as well – only it would be worse.

stuart.sierra said: clojure.contrib.io is deprecated, period. It will be removed in the next release.

bpsm said: Fine, so ignore patch 0010. That's why it's a "proposal".

Those moving their code off of c.c.io to c.j.io will just have to write their own versions of a subset of {file-str, write-lines, read-lines, pwd, with-out, with-in, to-byte-array, relative-path-string and delete-file-recursively}, or get these from a library outside of clojure-contrib. Am I understanding correctly?

Patch 0010 contains (in the comments) some tips for porting from deprecated c.c.io to c.j.io. It would make sense to gather that kind of information in some kind of a guide/faq about how to replace uses of deprecated c.c. namespaces promotion to core was not 1-to-1.

bpsm said: ���replace uses of deprecated c.c. namespaces where promotion to core was not 1-to-1.

bpsm said: [file:dEtFMSSRir35x5eJe5cbCb]

bpsm said: [file:dSzxyYSRir35nTeJe5cbLr]

bpsm said: [file:dSD8sqSRir35nTeJe5cbLr]

bpsm said: [file:cJIVlaSTur34OJeJe5cbLr]

bpsm said: [file:cJNkS8STur34OJeJe5cbLr]

bpsm said: [file:cJQGkcSTur34OJeJe5cbLr]

bpsm said: [file:cJ5Kd4STur34OJeJe5cbLr]

bpsm said: [file:cJ8-lqSTur34OJeJe5cbLr]

bpsm said: [file:daZ0rSSTur34OJeJe5cbLr]

bpsm said: [file:da5unsSTur34OJeJe5cbLr]

bpsm said: This task looks done to me. I can nothing further in clojure-contrib that's been deprecated. I've placed these patches on a branch on github for easy browsing.

Converted from http://www.assembla.com/spaces/clojure/tickets/92
Attachments:
0001-gen_html_docs.clj-no-longer-uses-clojure.contrib.def.patch - https://www.assembla.com/spaces/clojure/documents/a8fqHcR6er37N2eJe5cbLr/download/a8fqHcR6er37N2eJe5cbLr

Converted from http://www.assembla.com/spaces/clojure/tickets/91
Attachments:
fix91-1.patch - https://www.assembla.com/spaces/clojure/documents/bYSqjYRuWr37WWeJe5cbCb/download/bYSqjYRuWr37WWeJe5cbCb

stuart.sierra said: [file:bYSqjYRuWr37WWeJe5cbCb]: fix, without auxiliary function

stuart.sierra said: (In revision:5a928e263ab88cb8d224de8585932f936aa30c8f) Fix EOF-handling in JSON reader; refs #91

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/90
Attachments:
0002-t90-default-reader-implementation-special-cases-for-.patch - https://www.assembla.com/spaces/clojure/documents/auuXEWSiur35DyeJe5cbCb/download/auuXEWSiur35DyeJe5cbCb
0001-t90-regression-test.patch - https://www.assembla.com/spaces/clojure/documents/amTyVwSt8r378NeJe5cbLr/download/amTyVwSt8r378NeJe5cbLr

bpsm said: I've looked at this defect (on master). It seems thorny to me.

I'm finding the control flow in c.c.io rather difficult to follow, what with all those extensions of the Streams protocol delegating to one-another. I'm reasonably certain that the solution is to special case the creation of a reader in append mode.

I'll attach a patch that does this by providing a default implementation for :writer, which seems to solve the problem, but I think I still need to think about it some more before I can call it 'done'.

Note: this defect is also present in clojure.java.io 1.2.0.

bpsm said: [file:auuXEWSiur35DyeJe5cbCb]

bpsm said: Correction: This issue is not present in clojure 1.2.0. my bad.
I was mistaken about this bug being present in clojure.java.io. append-writer doesn't even exist there and the append magic is gone there too as per clojure#311.
I think there was just something wonky with my swank-clojure:

clojure.contrib.io> (require 'clojure.java.io)
nil
clojure.contrib.io> (in-ns 'clojure.java.io)
#<Namespace clojure.java.io>
clojure.java.io> (with-open [x (append-writer "/tmp/foo.txt")] x)
; Evaluation aborted.  ;;; EXCEPTION HERE

bpsm said: [file:amTyVwSt8r378NeJe5cbLr]: regression test

bpsm said: The provided regression test demonstrates the described issue and confirms that the provided patch resolves the issue. All other io unit tests continue to pass.

stuart.sierra said: clojure.contrib.io is deprecated and will be removed before the next release.

bpsm said: Let's see if I'm on the same page that you're on:

Since 1.2.0 is at RC3 already, you must mean 1.3.0 when you say "next release", yes/no? Predicated on that:

• I think this should be fixed on the 1.2.x branch, where c.c.io is available, though deprecated. ("deprecated, but working" is better than "deprecated by slightly buggy.") The attached patch is against 1.2.x, not master, despite what my initial comment on this issue says.
• I've provided a patch on #93 to remove c.c.io on master (1.3.x).

Converted from http://www.assembla.com/spaces/clojure/tickets/89
Attachments:
prioritymap.diff - https://www.assembla.com/spaces/clojure/documents/aD2s4mKDqr34-UeJe5cbLr/download/aD2s4mKDqr34-UeJe5cbLr

puzzler said: http://github.com/clojure/clojure-contrib/commit/18c8713709e4cb095d10b154854f8d0b8fb50ad8

puzzler said: I realized shortly after uploading the file that although I made the equality of priority maps behave like regular maps and sorted maps, I forgot to adjust the hashCode method accordingly.

Fixed that, and added a corresponding test case.

http://github.com/clojure/clojure-contrib/commit/08b2d37a962cc5baf2c37ad767067233eadfc6ca

Converted from http://www.assembla.com/spaces/clojure/tickets/88
Attachments:
sql-stmt-opts-with-bean.diff - https://www.assembla.com/spaces/clojure/documents/cjDxceI4er36sweJe5cbCb/download/cjDxceI4er36sweJe5cbCb

importer said: [file:cFaBqYI38r3565eJe5cbLA]

importer said: [file:cjDxceI4er36sweJe5cbCb]

importer said: Hey Steve,

Any progress on this? Another option instead of passing a map of attributes and using bean would be to allow the user to pass an optional function that would be called on the statement object. I've seen code like this in compojure, I think:

(with-connection {���} 
    (.setAutoCommit (sql/connection) false) ;; needed for postgres 
    (with-query-results results ["SELECT id, data FROM nodes"] 
      #(.setFetchSize % 1) 
      (doseq [r results] 
        ���)))

If this sounds better to you, I can submit a patch.

Cheers,
Justin

importer said: Kyle Burton just posted a blog post about this issue: http://asymmetrical-view.com/2010/10/14/clojure-lazy-walk-sql-table.html

His fix is to add a new method called with-query-results-cursor which turns off auto-commit and sets the fetch size.

Steve, would this approach work better for you?

Converted from http://www.assembla.com/spaces/clojure/tickets/87

Converted from http://www.assembla.com/spaces/clojure/tickets/86
Attachments:
0001-Add-thread-safe-extensible-memoize-v2.patch - https://www.assembla.com/spaces/clojure/documents/aTrQGuAP0r35h6eJe5cbCb/download/aTrQGuAP0r35h6eJe5cbCb

bpsm said: ^{:doc "The naive safe-all cache strategy for memoize."}
Replace "safe" with "save".

meikelbrandmeyer said: Typo fixed.

Converted from http://www.assembla.com/spaces/clojure/tickets/85

Converted from http://www.assembla.com/spaces/clojure/tickets/84
Attachments:
base64-decode.patch - https://www.assembla.com/spaces/clojure/documents/c68LHyxEOr35_MeJe5cbCb/download/c68LHyxEOr35_MeJe5cbCb

anttipoi said: [file:c68LHyxEOr35_MeJe5cbCb]: Patch adding decode + tests

anttipoi said: BTW. Sorry about not raising the topic on the clojure-dev group first. I just lost my patience waiting to be let in.

anttipoi said: Note: I've modified the patch to support multi-line encoded data.

stuart.sierra said: (In revision:5263e4bd9ca8634b50755c5150ebef26e0d191f1) Base64 decoding from Teemu Antti-Poika; refs #84

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/83

I've tested that using #(.byteValue %) rather than byte? fixes the problem.

Converted from http://www.assembla.com/spaces/clojure/tickets/82

Converted from http://www.assembla.com/spaces/clojure/tickets/81

tomfaulhaber said: (In revision:661dcfde7965c3e6650d169afca4a20ef146c940) Remove gen-class requirement from clojure.contrib.pprint. See #81

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/80
Attachments:
0001-Support-catch-clauses-in-c.c.condition-for-regular-E.patch - https://www.assembla.com/spaces/clojure/documents/bn8Re8uIyr36S4eJe5cbLr/download/bn8Re8uIyr36S4eJe5cbLr

technomancy said: [file:bn8Re8uIyr36S4eJe5cbLr]: the patch

Converted from http://www.assembla.com/spaces/clojure/tickets/79

stuart.sierra said: (In revision:a1c66df5287776b4397cf3929a5f498fbb34ea32) Copy deleted/renamed namespaces from 1.1 release; refs #79

• For backward compatibility with 1.1 release.
• Namespaces copied: duck-streams, java-utils, seq-utils,
  shell-out, str-utils, str-utils2.
• These namespaces can be marked as deprecated.
• They are copied rather than simply aliased because
  some behavior has changed.

Branch: master

cemerick said: FWIW, the various signature and fn name changes between 1.1 and 1.2 still need to be unraveled by any codebase that wants to target both, and choosing which impl to use is still easiest by eagerly loading whereever the new impls are in a try/catch. I'm not arguing against restoring the old namespaces (at the moment! , just pointing out that doing so doesn't impact 1.1/1.2 compat.

Converted from http://www.assembla.com/spaces/clojure/tickets/78

Converted from http://www.assembla.com/spaces/clojure/tickets/77
Attachments:
77-refactor-c.c.io.diff - https://www.assembla.com/spaces/clojure/documents/b9K9uwuu4r37NTeJe5d-aX/download/b9K9uwuu4r37NTeJe5d-aX
77-refactor-c.c.io2.diff - https://www.assembla.com/spaces/clojure/documents/cGY9s2vRir37QQeJe5cbCb/download/cGY9s2vRir37QQeJe5cbCb

cemerick said: [file:b9K9uwuu4r37NTeJe5d-aX]

cemerick said: Based on discussion on the clojure-dev list, I've eliminated the buffer-streams var and the associated usage. We can revisit buffering control strategies / APIs at some future point without any API incompatibilities.

Modified patch attached (#2).

cemerick said: [file:cGY9s2vRir37QQeJe5cbCb]

stuart.sierra said: This has been completed in the new Clojure namespace clojure.java.io

Converted from http://www.assembla.com/spaces/clojure/tickets/76
Attachments:
0001-fixed-stack-consumpton-in-pr-more.patch - https://www.assembla.com/spaces/clojure/documents/cXM85ssJqr37KVeJe5d-aX/download/cXM85ssJqr37KVeJe5d-aX

djpowell said: Oops - posted to contrib's assemba space rather than clojure's - will repost to clojure's space...

Converted from http://www.assembla.com/spaces/clojure/tickets/75

c.c.io no longer exists, as of 2c6c9e3. So this ticket should likely move to Clojure proper (for clojure.java.io).

A cursory look through the clojure.java.io tests shows that most public functions are covered, but there's probably still room for more tests there. Needs more investigation.

The real link to the Assembla ticket is http://www.assembla.com/spaces/clojure-contrib/tickets/75

Converted from http://www.assembla.com/spaces/clojure/tickets/74
Attachments:
0001-Use-seq-instead-of-list-to-determine-codeiness-.-Ref.patch - https://www.assembla.com/spaces/clojure/documents/cqHmfyuIur35MTeJe5cbLr/download/cqHmfyuIur35MTeJe5cbLr

technomancy said: [file:cqHmfyuIur35MTeJe5cbLr]: Implements the fix

Converted from http://www.assembla.com/spaces/clojure/tickets/73
Attachments:
0001-lazy-xml-Fix-reify-uses-missing-this-arguments.patch - https://www.assembla.com/spaces/clojure/documents/dIdkISrv4r36_-eJe5aVNr/download/dIdkISrv4r36_-eJe5aVNr

oranenj said: Oops, didn't notice Chouser was ahead of me. Closing as invalid.

Converted from http://www.assembla.com/spaces/clojure/tickets/72
Attachments:
0001-Fixed-references-to-duck-streams-in-clojurescript.patch - https://www.assembla.com/spaces/clojure/documents/ajeN44l_Or34IreJe5avMc/download/ajeN44l_Or34IreJe5avMc

Clojurescript is wildly outdated. To use it, it would be best to use contrib and clojure from approximately Clojure 1.0. Thanks for patch, but I think forcing Clojurescript to use a recent version of Clojure would actually complicate the situation for anyone desperate enough to try to use it.

Converted from http://www.assembla.com/spaces/clojure/tickets/71
Attachments:
0001-cleaned-up-formatting-and-improved-documentation-of-.patch - https://www.assembla.com/spaces/clojure/documents/bANPRCfq0r34l9eJe5afGb/download/bANPRCfq0r34l9eJe5afGb
0002-removed-assert-args-macro-borrowed-from-core-and-rep.patch - https://www.assembla.com/spaces/clojure/documents/bANTaAfq0r34l9eJe5afGb/download/bANTaAfq0r34l9eJe5afGb
c.c.mock-updates.diff - https://www.assembla.com/spaces/clojure/documents/djL5oaC8Wr37DOeJe5cbLr/download/djL5oaC8Wr37DOeJe5cbLr

matt.clark.1 said: [file:djL5oaC8Wr37DOeJe5cbLr]: Use only this patch. The other two are hopelessly out of date.

Converted from http://www.assembla.com/spaces/clojure/tickets/70
Attachments:
c-c-string-fixes.patch - https://www.assembla.com/spaces/clojure/documents/djkmaEeoGr36OOeJe5afGb/download/djkmaEeoGr36OOeJe5afGb

stuart.sierra said: Please reformat the patch according to http://clojure.org/patches

trolard said: [file:djkmaEeoGr36OOeJe5afGb]: Patch for remaining itesm in c.c.string migration.

trolard said: (In revision:af788ed71a5c92f32daa5bfc5673455bd8843faa) c.c.string migration changes; fixes #70

Signed-off-by: Stuart Sierra <mail@stuartsierra.com>

Branch: master

stu said: Updating tickets (#2, #3, #33, #38, #51, #52, #65, #67, #70)

Converted from http://www.assembla.com/spaces/clojure/tickets/69

stuart.sierra said: Latest sources use -Dclojure.jar as the trigger for a local build.

You can also add -o to the mvn command line to prevent downloading artifacts.

Please ask questions on the mailing list before creating tickets. Thanks,
-SS

Converted from http://www.assembla.com/spaces/clojure/tickets/68

stuart.sierra said: Maven doesn't have targets. "mvn clean" removes all generated files, so it is equivalent to distclean.

Converted from http://www.assembla.com/spaces/clojure/tickets/67

stuart.sierra said: (In revision:8d5f9fa4920fb6afb0e8b2859e5d4a4de2f7ef9f) c.c.json.read: accept any Reader type; fixes #67

Branch: master

stu said: Updating tickets (#2, #3, #33, #38, #51, #52, #65, #67, #70)

Converted from http://www.assembla.com/spaces/clojure/tickets/66

stuart.sierra said: It appears that the ColumnWriter/-init function is getting called with 3 arguments.

stuart.sierra said: I don't think this was caused by changes in the build. Something has changed about how arguments get passed to init functions. The ColumnWriter init function is getting the same arguments as the PrettyWriter init function (a Writer, 72, and 40).

stuart.sierra said: (In revision:5b3beaed9ef8520c8c1e09ff7ac5b817786f51e2) Fix mis-named ns in pprint.gen-class; refs #66

Branch: master

stuart.sierra said: Never mind, it was a simple typo in the gen_class.clj file. Nothing to do with pprint or with the build process.

Tests re-enabled; all pass.

Converted from http://www.assembla.com/spaces/clojure/tickets/65

stuart.sierra said: (In revision:3275810556b075ff9a3a0abc0d08b3a19ee46bae) pprint: Move gen-class expressions to separate file; refs #65

To avoid order-of-compilation issues,
this patch puts the gen-class expressions
for ColumnWriter and PrettyWriter in a
separate file, rather than in the ns
declarations.

Branch: master

stuart.sierra said: (In revision:aa34fb9e52fa500c99bb45448bdfcd4020db5392) Reenable compiling of test namespaces in POM; refs #65

But disable tests of pprint, which fail currently

Branch: master

stuart.sierra said: I think I have fixed this by placing the gen-class directives in a separate file; only that file will be AOT-compiled.

tomfaulhaber said: What a mess! This seems like a big problem with gen-class if we have to jump through this many hoops to make it work once we have more than one class in a hierarchy.

Of course it worked fine back in ant-land where we had control over the compilation order.

stuart.sierra said: It's not that bad. The Ant build script was messier. This is more flexible, because it only AOT-compiles things that need it, i.e. gen-class.

cemerick said: I mentioned this elsewhere, but perhaps there's a reason why this isn't workable in this case: I believe if you require clojure.contrib.pprint.ColumnWriter in PrettyWriter's ns declaration (perhaps before the :gen-class form?), then the compiler will visit and gen CW before attempting to gen-class PW.

This would eliminate the need to explicitly specify which namespaces to compile.

stuart.sierra said: Tried it. Didn't work.

stu said: Updating tickets (#2, #3, #33, #38, #51, #52, #65, #67, #70)

Converted from http://www.assembla.com/spaces/clojure/tickets/64
Attachments:
0001-teach-duck-streams-to-read-clojure-forms.patch - https://www.assembla.com/spaces/clojure/documents/doGgPKcSqr34XKeJe5aVNr/download/doGgPKcSqr34XKeJe5aVNr

stuart.sierra said: Updating tickets (#1, #2, #3, #4, #6, #20, #23, #25, #30, #31, #33, #34, #35, #37, #38, #52, #55, #58, #59, #60, #61, #62, #63, #64)

technomancy said: You can do this by composing read-string and slurp*, is that good enough?

bpsm said: Well, more-or-less. The intent of my patch was to allow a file containing multiple forms to be read lazily (i.e. one form at a time). The (read-string (slurp* x)) solution is eager.

That said, I'd like to withdraw the patch because I'm not really happy with the fact that the implementation fails to close the underlying file if the sequence is not consumed fully. (This is a more general problem with lazy sequences based on resources not managed by the GC.)

Converted from http://www.assembla.com/spaces/clojure/tickets/63
Attachments:
0001-teach-duck-streams-classpath-on62.patch - https://www.assembla.com/spaces/clojure/documents/a8_B2gcSmr37PueJe5aVNr/download/a8_B2gcSmr37PueJe5aVNr
0001-teach-duck-streams-classpath.patch - https://www.assembla.com/spaces/clojure/documents/a8_zgOcSmr37PueJe5aVNr/download/a8_zgOcSmr37PueJe5aVNr

stuart.sierra said: Updating tickets (#1, #2, #3, #4, #6, #20, #23, #25, #30, #31, #33, #34, #35, #37, #38, #52, #55, #58, #59, #60, #61, #62, #63, #64)

stu said: I am going to reject this patch for now, because I don't like:

1. the double-purposing of filelike names. If a "foo/bar" points to something on the classpath, and something different on the filesystem, which one should dominate?
2. the asymmetry with writing: you can't write to things on the classpath, so writer and reader would become asymmetric.

Better IMO just to be explicit about hitting the classpath.

bpsm said: Fair enough. The overloaded meaning of 'path-like-string' isn't pretty. As an alternative, perhaps you would consider including:

(defn #^URL resource
  "Return the URL of the named resource on the CLASSPATH.
nil indicates no such resource was found."
  [#^String name]
  (.getResource (clojure.lang.RT/baseLoader) name))
</code></pre>
This would allow formulations like:
<pre>{{(input-stream (resource "foo/bar.gif"))}}</pre>
or even:
<pre><code>(-?> "foo/bar.gif" resource input-stream)

Which is reasonably compact and makes the meaning of the string clear.

Converted from http://www.assembla.com/spaces/clojure/tickets/62
Attachments:
0001-c.c.io-provides-input-stream-and-output-stream-for-b.patch - https://www.assembla.com/spaces/clojure/documents/d_99D0cRWr34N6eJe5afGb/download/d_99D0cRWr34N6eJe5afGb
0001-c.c.io-provides-input-stream-and-output-stream-for-b.patch - https://www.assembla.com/spaces/clojure/documents/b8NlJSrXKr346PeJe5afGb/download/b8NlJSrXKr346PeJe5afGb

bpsm said: [file:d_99D0cRWr34N6eJe5afGb]: compatible with mavenized master (e.g. 18c6d2102a)

bpsm said: Teaching duck-streams to try to resolve a string that isn't a file or URL as a classpath resource more properly belongs in a separate ticket.

stuart.sierra said: Updating tickets (#1, #2, #3, #4, #6, #20, #23, #25, #30, #31, #33, #34, #35, #37, #38, #52, #55, #58, #59, #60, #61, #62, #63, #64)

bpsm said: [file:b8NlJSrXKr346PeJe5afGb]: rebased for clojure.contrib.io

Converted from http://www.assembla.com/spaces/clojure/tickets/61
Attachments:
add-nilsafe-thread-last.diff - https://www.assembla.com/spaces/clojure/documents/dkG7yKcdqr36GOeJe5aVNr/download/dkG7yKcdqr36GOeJe5aVNr

stuart.sierra said: Updating tickets (#1, #2, #3, #4, #6, #20, #23, #25, #30, #31, #33, #34, #35, #37, #38, #52, #55, #58, #59, #60, #61, #62, #63, #64)

oranenj said: This ticket has a patch, so marking as 'test'

stu said: Less useful than -?> since nil/empty falls out anyway but worth it for completeness and for where the nil/empty distinction matters.

Converted from http://www.assembla.com/spaces/clojure/tickets/60
Attachments:
add-strint.diff - https://www.assembla.com/spaces/clojure/documents/c1uE4-cc4r35wteJe5afGb/download/c1uE4-cc4r35wteJe5afGb
add-strint2.diff - https://www.assembla.com/spaces/clojure/documents/aeyw6icJSr37PueJe5aVNr/download/aeyw6icJSr37PueJe5aVNr

cemerick said: [file:aeyw6icJSr37PueJe5aVNr]: include bugfix

stuart.sierra said: Updating tickets (#1, #2, #3, #4, #6, #20, #23, #25, #30, #31, #33, #34, #35, #37, #38, #52, #55, #58, #59, #60, #61, #62, #63, #64)

Converted from http://www.assembla.com/spaces/clojure/tickets/59

stuart.sierra said: Updating tickets (#1, #2, #3, #4, #6, #20, #23, #25, #30, #31, #33, #34, #35, #37, #38, #52, #55, #58, #59, #60, #61, #62, #63, #64)

stuart.sierra said: This is probably caused by the way Windows handles paths. Needs a fix for portability.

stu said: Using File/separator should work cross-platform. Added in commit ebf0d212dcc076ebee6984d276ff037ce1a7ecbe.

Converted from http://www.assembla.com/spaces/clojure/tickets/58
Attachments:
easy-logging-args.patch - https://www.assembla.com/spaces/clojure/documents/buYy7Qa1Cr35jGeJe5afGb/download/buYy7Qa1Cr35jGeJe5afGb

ataggart said: [file:buYy7Qa1Cr35jGeJe5afGb]: patch to add format-string-based and println-style log macros

ataggart said: Done. Left extant macros unchanged since modifying them could have unexpected results for end-users.

New macros follow similar naming to the original ones, with println-style macros ending in 'p', and format-string ones ending in 'f'.

In an ideal world, the -p variants would be the default. Backwards-compatibility is a bitch.

stuart.sierra said: Updating tickets (#1, #2, #3, #4, #6, #20, #23, #25, #30, #31, #33, #34, #35, #37, #38, #52, #55, #58, #59, #60, #61, #62, #63, #64)

ataggart said: Incorporated the ideas here into the new c.c.logging code.

Converted from http://www.assembla.com/spaces/clojure/tickets/57

timothypratley said: SS has fixed it already

Converted from http://www.assembla.com/spaces/clojure/tickets/56
Attachments:
reductions.diff - https://www.assembla.com/spaces/clojure/documents/dCrXzw-bqr3PBmeJe5aVNr/download/dCrXzw-bqr3PBmeJe5aVNr

timothypratley said: Passes the reductions tests.

timothypratley said: [file:dCrXzw-bqr3PBmeJe5aVNr]: faster reductions

meikelbrandmeyer said: Reductions was moved to core. See here: http://www.assembla.com/spaces/clojure/tickets/312-audit---promote-some-clojure-contrib-seq-fns

Sorry. I wasn't aware of this ticket and your patch.

Converted from http://www.assembla.com/spaces/clojure/tickets/55
Attachments:
sql-internal.diff - https://www.assembla.com/spaces/clojure/documents/btl6lW9Mmr3OPceJe5aVNr/download/btl6lW9Mmr3OPceJe5aVNr

rnewman said: [file:btl6lW9Mmr3OPceJe5aVNr]: Diff against current head.

stuart.sierra said: Updating tickets (#1, #2, #3, #4, #6, #20, #23, #25, #30, #31, #33, #34, #35, #37, #38, #52, #55, #58, #59, #60, #61, #62, #63, #64)

scgilardi said: Following the discussion in the developer group and as suggested by Stuart Halloway, I'm planning to make these changes:

[1] adopt the substance of Richard Newman's patch, changes to sql.internal's print-sql-exception, print-sql-exception-chain, print-update-counts functions
[2] remove the automatic printing to err on exceptions. It will be up to the caller to handle the exceptions as he desires: eating, logging, or printing, etc.
[3] move the print* functions to c.c.sql proper as they will now be "public".

This will be addressed in clojure.java.jdbc and needs to be migrated to the new JIRA project for it once that is created (I don't have permission to do anything beyond comment / clone this issue).

Converted from http://www.assembla.com/spaces/clojure/tickets/54

stu said: (In revision:f24f6412a1cee7015285856e5e4fc6ddc3974439) clean up temporary namespaces, fixes #54

Branch: master

Converted from http://www.assembla.com/spaces/clojure/tickets/53
Attachments:
0001-Don-t-AOT-logging.clj.patch - https://www.assembla.com/spaces/clojure/documents/aqNkDi9byr3Rn8eJe5aVNr/download/aqNkDi9byr3Rn8eJe5aVNr

technomancy said: [file:aqNkDi9byr3Rn8eJe5aVNr]: A patch to build.xml

rnewman said: Phil, did you see #44?

http://www.assembla.com/spaces/clojure-contrib/tickets/44-AOT-compilation-of-clojure-contrib-jar-pre-sets-logging-implementation

technomancy said: Oops; dupe of #44.

Converted from http://www.assembla.com/spaces/clojure/tickets/52
Attachments:
test-52.patch - https://www.assembla.com/spaces/clojure/documents/aqVdMo8fqr3QImeJe5afGb/download/aqVdMo8fqr3QImeJe5afGb
test-52-b.patch - https://www.assembla.com/spaces/clojure/documents/drZN2e8Ner3QImeJe5afGb/download/drZN2e8Ner3QImeJe5afGb

mikehinchey said: [file:aqVdMo8fqr3QImeJe5afGb]: patch to improve testing from ant

mikehinchey said: Build will fail cleanly if tests fail, by using exit.
Fork in ant so exit can be used.
Similar code will be submitted to clojure, but this does not depend on that patch.

mikehinchey said: [file:drZN2e8Ner3QImeJe5afGb]: fixes #52, including datalog (replaces test-52.patch)