This was discussed briefly on the clojure dev list, but no consensus was reached. Instead, I have attached the changes that have fixed the original library and if the clojure-contrib members wish to include it (again), then it's readily available.

The original code by Sierra required 2 changes to get working. First, @ was macro-expanding to a lazy-seq, so the filtering based on list? would fail. Second, I added a check for an explicit call to (deref). Also, I re-added auto-agent namespace for compilation to build.xml.

My live changes can be found at: http://github.com/fogus/clojure-contrib/tree/auto-agent-again. The tests can be run with (run-tests 'clojure.contrib.auto-agent).

If it is merged back into the contrib master, then I would be happy to roll the tests into the test-contrib framework.

Failing to do this causes a lot of confusion (I've already gotten bit) when you have stable releases out in the world and the docs reflect an alpha version. This has been painful, for example, with the shift of clojure.contrib.test-is to clojure.test.

Add the namespace c.c.table, as described here:

http://groups.google.com/group/clojure-dev/browse_thread/thread/b60015723d81aa34

Also, support functions described here:
http://groups.google.com/group/clojure-dev/browse_thread/thread/4b20e40d83095c67
http://groups.google.com/group/clojure-dev/browse_thread/thread/155c8b9893d673bc

Sean

This is a ticket for patches related to c.c.map-utils. See the following discussions:

http://groups.google.com/group/clojure-dev/browse_thread/thread/9a518c853bfbba8b
http://groups.google.com/group/clojure-dev/browse_thread/thread/4b20e40d83095c67

The problem is that c.c.sql.internal calls `.println` on a "stream" to print update counts and errors. That method only exists on a `PrintWriter`. This isn't true within Slime, where it's a `StringWriter`.

The attached patch binds `out` and uses `println` instead, which does the right thing. I've augmented the docstrings to request a `Writer` as the value of `stream`, which aligns with the docstring for `print`.

c.c.io has few tests, despite being on the most used libraries in contrib. Be a clojure here and write some unit tests for this module. Code review comments would be welcome too!

Currently using clojure.contrib.condition is awkward if you need to handle both Conditions and Exceptions. This patch by Steve Gilardi and myself allows you to include catch clauses in your handle-case forms for regular Exceptions.

Design goals

• keep key libraries in contrib, protecting provenance and license so that non-technical issues do not keep people from using code
• continue to produce a monolithic contrib build for casual/one-off application consumers
• start building individual libraries within contrib, so that larger apps can manage dependencies in a granular fashion

I propose we start with the new match (matchure) library, get feedback, and then take requests for what other libraries need to be bundled separately.

I've cleaned up the documentation and got rid of the old assert-args code from c.c.mock. The attached patches contain the two commits I made on my repository. I'm new to patches and git so let me know if I missed anything obvious!

Add the thread-safe, extensible memoize sparked from the discussion here: http://groups.google.com/group/clojure/browse_thread/thread/36a13d150d830683/fe6daf462d3ebfac

If you have a query that results in a very large dataset you will run out of memory because by default, with-query-results pulls the entire result set into memory (even though it creates a lazy-seq using resultset-seq).

This issue has been discussed previously here:
http://groups.google.com/group/clojure/browse_thread/thread/7b0c250e0ba6c9eb/fb9001522b49c20a

The fix is simple, just call (.setFetchSize stmt 1). But, with-query-results doesn't give you a way to do that currently. I propose adding an optional parameter after sql-params that is a hash of attributes to set on the PreparedStatement before executing it.

So you can do this:

(with-connection {���} 
    (.setAutoCommit (sql/connection) false) ;; needed for postgres 
    (with-query-results results ["SELECT id, data FROM nodes"] 
      {:fetch-size 1000} 
      (doseq [r results] 
        ���)))

The new code in clojure.contrib.sql is very simple, but it depends on a new contrib namespace called clojure.contrib.bean. Here is more info on my proposed fix:
http://groups.google.com/group/clojure-dev/browse_thread/thread/d8334759f10f3f45

Reproduce the bug with:

(require 'clojure.contrib.io)
(clojure.contrib.io/append-writer "/xyz.txt")
</code></pre>
which will throw an Exception ���Cannot change an open stream to append mode���.

This is caused because of a flaw in the call chain.
*clojure.contrib.io/writer* for Strings calls again *writer* for whatever *clojure.contrib.io/output-stream*
returns. We call *append-writer* which then calls *writer* on the String which in turn then calls:
<pre><code>
output-stream for ^String which calls
    output-stream for ^URL which calls
        output-stream for ^File which binds *append* to false and calls
            output-stream for ^OutputStream which
            returns a BufferedOutputStream instance which then jumps back to the
        ^File handler, which removes its binding for *append*!! and returns the BOS to the
    ^URL handler which returns the BOS to the
^String handler

At this point the outer binding (for append) is set to true again, and assert-not-appending fails.

on clojure-contrib master:
gen-html-docs :uses c.c.def without actually using anything from it.
This causes the maven build to fail because clojure.contrib:def is not listed as a dependency in gen-html-docs' pom.xml.

The handler-case macro detects forms of the form "(handle ...)" by checking for items in the body for which list? returns true that begin with the symbol handle. code can be built from seqs that are not lists (e.g., clojure.lang.Cons's or lazy-seqs). The proper predicate is "seq?" not "list?".

Pulled this from clojure assembla ticket #436 to clojure-contrib
See clojure-436

What (small set of) steps will reproduce the problem?
$ java -cp lib/clojure-1.2.0.jar:lib/clojure-contrib-1.2.0.jar clojure.main
Clojure 1.2.0
user=> (require 'clojure.contrib.json)
nil
user=> (clojure.contrib.json/read-json "")
java.lang.IllegalArgumentException: Value out of range for char: -1 (NO_SOURCE_FILE:0)
user=>

What is the expected output? What do you see instead?

Expected:

(if eof-error?
  (throw (EOFException. "JSON error (end-of-file)"))
  eof-value)

What version are you using?
1.2

Was this discussed on the group? If so, please provide a link to the discussion
[13:51] <na_ka_na> Hey guys I think there's a bug in clojure.contrib.json at line 116
[13:51] <na_ka_na> in clojure 1.2
[13:52] <na_ka_na> it has a (char i) and then checks for (= i -1) ... but (char -1) fails
[13:52] <na_ka_na> where can I report it ?
[13:53] <LauJensen> na_ka_na: assembla/support

Apparently, defttrace does not support functions with doc-strings. I tried replacing defn with deftrace in a function of mine (as the docs indicated) and I got the following error -

java.lang.IllegalArgumentException: Don't know how to create ISeq from: Symbol
</code></pre>

Sample code to reproduce the error - 

<pre><code>(deftrace fact
  "Calculate the factorial of x"
  [x]
  (if (< x 1)
    1
    (* x (fact (- x 1)))))

Would be great if this bug is fixed, all my functions have doc-strings

Since the April 8th commit to no longer recognize "earmuff" variables as dynamic by default, clojure-contrib/logging and clojure-contrib/trace are broken.

See:

https://groups.google.com/group/clojure/browse_frm/thread/cc88ca26352bc604?hl=en#

When called via a namespace-qualified symbol and given three or more arguments, -?> gives the error:

user=> (clojure.contrib.core/-?> 1 inc inc)
CompilerException java.lang.Exception: Unable to resolve symbol: -?>
in this context, compiling:(NO_SOURCE_PATH:3)

(defn set-system-properties
"Set some system properties. Nil clears a property."
[settings]
(doseq [[name val] settings]
(if val
(System/setProperty (name name) (name val))
(System/clearProperty (name name)))))

Somebody did a find/replace as-str -> name and created fn/variable colision with "name"

This bug does not seem to occur on my Linux box, but when run under Windows I get the following:

user> (read-json "\"C:\\Users\"")

"C:nullsers"

On Linux I get what I would expect:

user> (read-json "\"C:\\Users\"")

"C:\Users"

Build failure

ashee:clojure-contrib amitava$ mvn assembly:assembly -Dclojure.jar=/Users/amitava/opt/clojure/clojure.jar

....Lots of output elided....

Testing clojure.contrib.test-logging
Exception in thread "main" java.lang.IllegalStateException: Can't dynamically bind non-dynamic var: clojure.contrib.logging/log-factory
at clojure.lang.Var.pushThreadBindings(Var.java:339)
at clojure.core$push_thread_bindings.invoke(core.clj:1716)
at clojure.contrib.test_logging$eval248$fn__249.invoke(test_logging.clj:19)
at clojure.test$compose_fixtures$fn_6529$fn_6530.invoke(test.clj:670)
at clojure.test$default_fixture.invoke(test.clj:663)
at clojure.test$compose_fixtures$fn__6529.invoke(test.clj:670)
at clojure.test$test_all_vars.invoke(test.clj:705)
at clojure.test$test_ns.invoke(test.clj:728)
at clojure.core$map$fn__3840.invoke(core.clj:2433)
at clojure.lang.LazySeq.sval(LazySeq.java:42)
at clojure.lang.LazySeq.seq(LazySeq.java:60)
at clojure.lang.Cons.next(Cons.java:39)
at clojure.lang.RT.boundedLength(RT.java:1607)
at clojure.lang.RestFn.applyTo(RestFn.java:130)
at clojure.core$apply.invoke(core.clj:602)
at clojure.test$run_tests.doInvoke(test.clj:743)
at clojure.lang.RestFn.invoke(RestFn.java:408)
at user$eval488$fn__491.invoke(run-test8724407867004279179.clj:9)
at user$eval488.invoke(run-test8724407867004279179.clj:7)
at clojure.lang.Compiler.eval(Compiler.java:6406)
at clojure.lang.Compiler.load(Compiler.java:6843)
at clojure.lang.Compiler.loadFile(Compiler.java:6804)
at clojure.main$load_script.invoke(main.clj:282)
at clojure.main$script_opt.invoke(main.clj:342)
at clojure.main$main.doInvoke(main.clj:426)
at clojure.lang.RestFn.invoke(RestFn.java:408)
at clojure.lang.Var.invoke(Var.java:401)
at clojure.lang.AFn.applyToHelper(AFn.java:161)
at clojure.lang.Var.applyTo(Var.java:518)
at clojure.main.main(main.java:37)
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Clojure Contrib parent module ..................... SKIPPED
[INFO] def ............................................... SKIPPED
[INFO] types ............................................. SKIPPED
[INFO] generic ........................................... SKIPPED
[INFO] accumulators ...................................... SKIPPED
[INFO] agent-utils ....................................... SKIPPED
[INFO] base64 ............................................ SKIPPED
[INFO] jar ............................................... SKIPPED
[INFO] classpath ......................................... SKIPPED
[INFO] combinatorics ..................................... SKIPPED
[INFO] command-line ...................................... SKIPPED
[INFO] complex-numbers ................................... SKIPPED
[INFO] cond .............................................. SKIPPED
[INFO] seq ............................................... SKIPPED
[INFO] condition ......................................... SKIPPED
[INFO] core .............................................. SKIPPED
[INFO] graph ............................................. SKIPPED
[INFO] except ............................................ SKIPPED
[INFO] dataflow .......................................... SKIPPED
[INFO] datalog ........................................... SKIPPED
[INFO] error-kit ......................................... SKIPPED
[INFO] fcase ............................................. SKIPPED
[INFO] find-namespaces ................................... SKIPPED
[INFO] fnmap ............................................. SKIPPED
[INFO] prxml ............................................. SKIPPED
[INFO] gen-html-docs ..................................... SKIPPED
[INFO] greatest-least .................................... SKIPPED
[INFO] import-static ..................................... SKIPPED
[INFO] java-utils ........................................ SKIPPED
[INFO] jmx ............................................... SKIPPED
[INFO] json .............................................. SKIPPED
[INFO] lazy-seqs ......................................... SKIPPED
[INFO] lazy-xml .......................................... SKIPPED
[INFO] logging ........................................... SKIPPED
[INFO] macro-utils ....................................... SKIPPED
[INFO] macros ............................................ SKIPPED
[INFO] map-utils ......................................... SKIPPED
[INFO] math .............................................. SKIPPED
[INFO] miglayout ......................................... SKIPPED
[INFO] mmap .............................................. SKIPPED
[INFO] ns-utils .......................................... SKIPPED
[INFO] mock .............................................. SKIPPED
[INFO] monads ............................................ SKIPPED
[INFO] monadic-io-streams ................................ SKIPPED
[INFO] priority-map ...................................... SKIPPED
[INFO] stream-utils ...................................... SKIPPED
[INFO] probabilities ..................................... SKIPPED
[INFO] profile ........................................... SKIPPED
[INFO] reflect ........................................... SKIPPED
[INFO] repl-ln ........................................... SKIPPED
[INFO] repl-utils ........................................ SKIPPED
[INFO] server-socket ..................................... SKIPPED
[INFO] set ............................................... SKIPPED
[INFO] singleton ......................................... SKIPPED
[INFO] sql ............................................... SKIPPED
[INFO] with-ns ........................................... SKIPPED
[INFO] strint ............................................ SKIPPED
[INFO] swing-utils ....................................... SKIPPED
[INFO] trace ............................................. SKIPPED
[INFO] zip-filter ........................................ SKIPPED
[INFO] complete .......................................... SKIPPED
[INFO] standalone ........................................ SKIPPED
[INFO] Clojure Contrib ................................... FAILURE [2:34.296s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2:35.348s
[INFO] Finished at: Wed Jun 01 21:48:18 EDT 2011
[INFO] Final Memory: 10M/81M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.theoryinpractise:clojure-maven-plugin:1.3.3:test (test-clojure) on project logging: Clojure failed. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :logging

In clojure.contrib.command-line, you could specify a 'catch-all' argument at the end of your spec and all arguments after the ones that were parsed would be collected in. In tools.cli, nothing like this seems to exist.

For example, with tools.cli, there is no way to handle stuff like this: "myapp --foo bar --baz foo a b c". The last three arguments, a, b, and c will all be discarded with no way to retrieve them.

Finally, if this wasn't the right place to put this issue, I apologize. tools.cli doesn't seem to be listed as a project and you guys don't accept issues on Github, so I wasn't sure what else to do.

I noticed that math.combinatorics isn't being built or released yet. Here is the pom file needed to get it into CI builds.

clojure.core/byte was modified a couple weeks ago as follows:

(defn byte
"Coerce to byte"
{:tag Byte
:inline (fn [x] `(. clojure.lang.RT (byteCast ~x)))}

• [^Number x] (. x (byteValue)))
  + [^Number x] (clojure.lang.RT/byteCast x))

byteValue and byteCast behave differently with values outside the
range of byte values:
user=> (. 255 (byteValue))
-1
user=> (clojure.lang.RT/byteCast 255)
java.lang.IllegalArgumentException: Value out of range for byte: 255
(NO_SOURCE_FILE:0)

The new version breaks clojure.contrib.shell/sh's :out :bytes mode (mapping byte over values returned by InputStream.read in shell.clj, line 125).
Perhaps have sh use #(.byteValue %) instead of byte? (untested)

pprint-logical-block macro can't be used from the outside:
java.lang.IllegalStateException: var: clojure.contrib.pprint/current-level is not public

I ran into the situation where reflection in clojure.contrib.condition was taking up much more time than I would have liked it too. I added the needed type hints to avoid reflection and the changes have solved the problem for me.

I've attached the patch. It is also available on github if you prefer:

https://github.com/bmabey/clojure-contrib/commit/acf0017e4b8c4259a03fba03a90050b0e9cb0890