<< Back to previous view

[CONTRIB-72] Replace references to duck-streams with io in clojurescript Created: 15/Mar/10  Updated: 29/Oct/10  Resolved: 29/Oct/10

Status: Resolved
Project: Clojure-Contrib
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect
Reporter: Anonymous Assignee: Chouser
Resolution: Declined Votes: 0
Labels: None


 Description   

duck-streams was renamed to io back in February 1st, but clojure-script still references duck-streams. Attached is a very simple patch that fixes this.



 Comments   
Comment by Assembla Importer [ 24/Aug/10 2:51 PM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/72
Attachments:
0001-Fixed-references-to-duck-streams-in-clojurescript.patch - https://www.assembla.com/spaces/clojure/documents/ajeN44l_Or34IreJe5avMc/download/ajeN44l_Or34IreJe5avMc

Comment by Chouser [ 29/Oct/10 12:46 AM ]

Clojurescript is wildly outdated. To use it, it would be best to use contrib and clojure from approximately Clojure 1.0. Thanks for patch, but I think forcing Clojurescript to use a recent version of Clojure would actually complicate the situation for anyone desperate enough to try to use it.





[CONTRIB-98] c.c.json/json-str handles maps with keys containing quotes incorrectly Created: 30/Sep/10  Updated: 26/Nov/10  Resolved: 26/Nov/10

Status: Resolved
Project: Clojure-Contrib
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect
Reporter: Anonymous Assignee: Stuart Sierra
Resolution: Completed Votes: 0
Labels: None

Attachments: Text File clojure-contrib-json-98.patch    
Patch: Code and Test

 Description   

Consider:

> (println (json-str {"\"" 1})) 
{""":1} 
</code></pre>

...while I (and my parsers) would expect <pre><code>{"\"":1}
.

This happens in both contrib 1.2.0 and 1.3-alpha1.



 Comments   
Comment by Assembla Importer [ 28/Oct/10 3:05 PM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/98

Comment by Jan Rychter [ 29/Oct/10 2:37 AM ]

The enclosed patch escapes object keys. It passes all tests. I've added a test that fails without the fix and passes with it.

Comment by Jan Rychter [ 04/Nov/10 11:18 AM ]

I've been told that issues are marked as "resolved" only after the patch gets applied. I'm reopening the issue, then, hoping that someone will pick it up from here.

Comment by Stuart Sierra [ 18/Nov/10 5:11 PM ]

Patch does not apply, appears to be formatted for contrib pre-modularization.

Comment by Stuart Sierra [ 26/Nov/10 9:11 AM ]

Rewrote patch to work with modularized contrib; applied in d6f6ccfaeac03e35b1f9dbfa04424866cd9b2a41

Comment by Daniel Janus [ 26/Nov/10 4:17 PM ]

Is this going to be backported to 1.2 branch? It would be greatly appreciated.





[CONTRIB-96] Cartesian product with nil args Created: 24/Sep/10  Updated: 26/Nov/10  Resolved: 26/Nov/10

Status: Resolved
Project: Clojure-Contrib
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect
Reporter: Anonymous Assignee: Stuart Sierra
Resolution: Completed Votes: 0
Labels: None


 Description   

http://groups.google.com/group/clojure-dev/browse_thread/thread/ac3582cd1698be1

user> (cartesian-product [1 2] [true false] ) 
((1 true) (1 false) (2 true) (2 false)) 
user> (cartesian-product [1 2] [false true]) 
nil 
user> (cartesian-product [1 2] [nil 4]) 
nil 
false/nil in first position seems to cause failure.


 Comments   
Comment by Assembla Importer [ 24/Sep/10 3:01 PM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/96

Comment by Assembla Importer [ 24/Sep/10 3:01 PM ]

stuart.sierra said: (In revision:499b9c02d1932ba0c0651e04b627c25f7f04f0c8) cartesian-product nil-arg fix; refs #96

Branch: master

Comment by Stuart Sierra [ 26/Nov/10 8:58 AM ]

Fixed in repository commit 499b9c02d1932ba0c0651e04b627c25f7f04f0c8





[CONTRIB-114] java.jmx build failure due to missing JAR Created: 19/Aug/11  Updated: 19/Aug/11  Resolved: 19/Aug/11

Status: Resolved
Project: Clojure-Contrib
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Critical
Reporter: Michael Nygard Assignee: Unassigned
Resolution: Declined Votes: 0
Labels: None
Environment:

Mac OS X Lion, Maven 3.0.3, JDK 1.6.0_26



 Description   

Appears to be a problem with parent POM:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 3.663s
[INFO] Finished at: Fri Aug 19 14:58:52 EDT 2011
[INFO] Final Memory: 6M/81M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.7.2:test (default-test) on project java.jmx: Error to resolving surefire provider dependency: Missing:
[ERROR] ----------
[ERROR] 1) org.apache.maven.surefire:surefire-junit3:jar:2.7.2
[ERROR]
[ERROR] Try downloading the file manually from the project website.
[ERROR]
[ERROR] Then, install it using the command:
[ERROR] mvn install:install-file -DgroupId=org.apache.maven.surefire -DartifactId=surefire-junit3 -Dversion=2.7.2 -Dpackaging=jar -Dfile=/path/to/file
[ERROR]
[ERROR] Alternatively, if you host your own repository you can deploy the file there:
[ERROR] mvn deploy:deploy-file -DgroupId=org.apache.maven.surefire -DartifactId=surefire-junit3 -Dversion=2.7.2 -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
[ERROR]
[ERROR] Path to dependency:
[ERROR] 1) dummy:dummy:jar:1.0
[ERROR] 2) org.apache.maven.surefire:surefire-junit3:jar:2.7.2
[ERROR]
[ERROR] ----------
[ERROR] 1 required artifact is missing.
[ERROR]
[ERROR] for artifact:
[ERROR] dummy:dummy:jar:1.0



 Comments   
Comment by Michael Nygard [ 19/Aug/11 2:14 PM ]

Please disregard. Stale <repositories> in my own ~/.m2/settings.xml appear to have been the cause.





[CONTRIB-112] clojure.java.classpath/system-classpath is incorrect when running in a classloader other than the application classloader Created: 07/Jul/11  Updated: 27/Jan/12  Resolved: 27/Jan/12

Status: Resolved
Project: Clojure-Contrib
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Major
Reporter: Justin Balthrop Assignee: Stuart Sierra
Resolution: Duplicate Votes: 1
Labels: None

Attachments: File system-classpath2.diff     File system-classpath.diff    
Patch: Code

 Description   

Because system-classpath uses java.class.path, it doesn't work when running in a classloader other than the application classloader.

This happens when running in any container that uses a custom classloader (e.g. Jetty, Cake, TomCat).

The fix is to use (.getURLs (.getClassLoader clojure.lang.RT)) instead of (System/getProperty "java.class.path"). A patch is attached.



 Comments   
Comment by Justin Balthrop [ 07/Jul/11 1:52 PM ]

Here is an updated patch with a fix for the system-classpath docstring as well.

Comment by Justin Balthrop [ 13/Sep/11 4:02 PM ]

Any update on this?

Comment by Justin Balthrop [ 13/Sep/11 7:04 PM ]

There is now a ticket in the CLASSPATH project for this (http://dev.clojure.org/jira/browse/CLASSPATH-1).

Comment by Stuart Sierra [ 27/Jan/12 9:45 AM ]

CLASSPATH-1





[CONTRIB-100] Control output of non-ASCII characters in clojure-contrib.json Created: 31/Oct/10  Updated: 30/Nov/10  Resolved: 30/Nov/10

Status: Resolved
Project: Clojure-Contrib
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Enhancement Priority: Minor
Reporter: Alex Ott Assignee: Stuart Sierra
Resolution: Completed Votes: 0
Labels: None

Attachments: Text File cc.json-escape-chars.patch    

 Description   

Current version of JSON output functions perform escaping of non-ASCII characters into \uXXXX sequences, although json allows to use any Unicode character in strings. When working with non-Latin-1 based texts, this lead to additional traffic.

Given patch fixes this problem, leaving old behavior by default, but adding new option to output functions, that now accept :escape-chars option, that control how non-ASCII characters in string will output. When this option has value 'true' (default), then hex sequences are used for these characters, and when 'false', then characters are output as-is

P.S. I sent CA at start of June, so Rich should already have it



 Comments   
Comment by Alex Ott [ 31/Oct/10 10:10 AM ]

Or you can merge from my clojure-contrib repo from 'unquoted-json' branch - http://github.com/alexott/clojure-contrib/commit/c22da330f1f5b64a5789bde2bbb958cd9fdc31fa

Comment by Stuart Sierra [ 30/Nov/10 11:32 AM ]

I'm happy with the idea. Not sure about the implementation.

For other configuration options (keywordizing object fields) I used local arguments, assuming it would be faster than Var lookups. With recent enhancements to Var lookup, that may no longer be true. Need to investigate.

Comment by Stuart Sierra [ 30/Nov/10 11:34 AM ]

Patch file submitted 31/Oct/10 does not work. "git am -s" returns "Patch does not have a valid e-mail address." http://clojure.org/patches

Comment by Stuart Sierra [ 30/Nov/10 11:54 AM ]

Alternate implementation committed

Comment by Stuart Sierra [ 30/Nov/10 2:34 PM ]

Enhancement committed.





[CONTRIB-109] Incorrect line separator handling in spy macro Created: 18/May/11  Updated: 18/May/11  Resolved: 18/May/11

Status: Resolved
Project: Clojure-Contrib
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Trivial
Reporter: Alexander Taggart Assignee: Alexander Taggart
Resolution: Completed Votes: 0
Labels: None


 Description   

The spy macro removes a trailing newline added by pprint, but windows systems have two-character line separators.

Also applies to clojure.tools.logging.



 Comments   
Comment by Alexander Taggart [ 18/May/11 11:42 AM ]

Now uses clojure.string.trim-newline.

https://github.com/clojure/clojure-contrib/commit/c4810ab19657bd82ad94efe5551db1d338aad23c
https://github.com/clojure/tools.logging/commit/623c6df079835f15ae8b1e885eda397c2e32a5e6





Generated at Thu Apr 24 04:11:57 CDT 2014 using JIRA 4.4#649-r158309.