[CRRBV-7] test name test-reduce redef's in tests, reducing test coverage Created: 27/Dec/14 Updated: 06/Jan/15
|Reporter:||Andy Fingerhut||Assignee:||Michał Marczyk|
If two deftest's have the same name, only the tests in the last one with the same name are actually run. test-reduce is used as a deftest name twice in file src/test/clojure/clojure/core/rrb_vector_test.clj
Also there is an unnecessary  in test-assoc!
Found via Eastwood Clojure lint tool: https://github.com/jonase/eastwood
|Comment by Andy Fingerhut [ 27/Dec/14 1:30 PM ]|
Patch crrbv-7-v1.patch dated Dec 27 2014 corrects the two issues mentioned in the description, and passes all tests, including the ones that were not being run before.
|Comment by Michał Marczyk [ 06/Jan/15 2:57 PM ]|
Oddly enough, I have these corrected locally, but never got round to pushing a commit. It's only right that I should apply your patch for it, though – I found both issues using Eastwood myself! I'll do that in time for the next release. Thanks!
|Comment by Andy Fingerhut [ 06/Jan/15 3:21 PM ]|
Please do whatever is easiest – I don't mind if my name isn't on the commit.