<< Back to previous view

[DCSV-2] \return characters do not trigger value quoting Created: 10/Feb/12  Updated: 14/Feb/12  Resolved: 13/Feb/12

Status: Resolved
Project: data.csv
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Major
Reporter: Giorgio Valoti Assignee: Jonas Enlund
Resolution: Completed Votes: 0
Labels: None
Environment:

Apache Maven 3.0.3 (r1075438; 2011-02-28 18:31:09+0100)
Maven home: /usr/share/maven
Java version: 1.6.0_29, vendor: Apple Inc.
Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home
Default locale: it_IT, platform encoding: MacRoman
OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"


Attachments: File csv.clj     File csv_test.clj    
Patch: Code and Test

 Description   

If the csv file contains \return characters the values are not quoted. A possible patch is attached.



 Comments   
Comment by Jonas Enlund [ 13/Feb/12 11:16 PM ]

This is fixed in version 0.1.1. I couldn't accept your patch though, as I didn't find you on the contributor list at http://clojure.org/contributing

Comment by Giorgio Valoti [ 14/Feb/12 12:36 AM ]

oh, sorry about that. I’ve completely forgot it because of the problems with jira. Glad to hear it was useful, anyway.

BTW
Why didn’t I receive notifications from Jira when the tickets were closed? Should I “watch” it





[DCSV-4] \return as record separator with unquoted fields is read as part of the field Created: 24/Oct/12  Updated: 10/Aug/15  Resolved: 10/Aug/15

Status: Resolved
Project: data.csv
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Major
Reporter: John Hume Assignee: Jonas Enlund
Resolution: Completed Votes: 1
Labels: None

Attachments: Text File return-record-separator.patch    

 Description   

This regards the gray area of being "more forgiving." If I understand RFC 4180 correctly, I want to suggest substituting one bit of forgiveness for another: rather than supporting unquoted, multi-line cell values, I suggest supporting CSVs with just \return as the record-separator. Would you accept a patch for that?

A file with \return as record-separator is interpreted by read-csv as a single row like (["Header1" "Header2\rval1" "val2"]). I believe the RFC only allows fields to contain CR and LF when they're escaped (i.e., surrounded in double quotes). See the ABNF at the end of section 2.

As far as implementation, I believe this would require wrapping any Reader w/o markSupported in one that does, so that the LF following a CR can be consumed when present.

[I've classified this as a major defect because I ran into a \return-delimited file as soon as I passed a CSV from a Linux machine to a Windows machine, so I'm guessing these files are common. Feel free to reclassify.]



 Comments   
Comment by Jonas Enlund [ 24/Oct/12 3:00 PM ]

> rather than supporting unquoted, multi-line cell values, I suggest supporting CSVs with just \return as the record-separator. Would you accept a patch for that?

Sounds good to me.

> As far as implementation, I believe this would require wrapping any Reader w/o markSupported in one that does

I think that's ok, since BufferedReader supports it.

Comment by Paul Stadig [ 10/Aug/15 7:52 AM ]

A patch by myself (Paul Stadig) and Nate Young. We both have CAs on file.

This patch will wrap any reader in a PushbackReader.

When parsing a CSV file, a single return character (ASCII 13) will be treated as a record separator.

We ran into this issue in production. Apparently on OSX if you export an Excel spreadsheet as CSV it will use return as a record separator. However, if you export it as a "Windows CSV" it will use CRLF. This is a bit too subtle for some users, and it would be preferable to be more flexible parsing record separators.

Comment by Jonas Enlund [ 10/Aug/15 12:12 PM ]

I released 0.1.3 with this fix. Thanks for the patch!





[DCSV-3] Some minor documentation typos Created: 14/Jun/12  Updated: 15/Jun/12  Resolved: 15/Jun/12

Status: Resolved
Project: data.csv
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Trivial
Reporter: Trent Ogren Assignee: Jonas Enlund
Resolution: Completed Votes: 0
Labels: docs, documentation, typo

Attachments: Text File 0001-Documentation-typo-fixes.patch    
Patch: Code

 Description   

I found a couple minor typos: one in the README, one in a docstring. I've included a patch.






Generated at Mon Aug 31 10:28:03 CDT 2015 using JIRA 4.4#649-r158309.