<< Back to previous view

[DFINGER-1] x should be x# in definition of equiv method inside defdigit? Created: 30/Nov/13  Updated: 30/Nov/13  Resolved: 30/Nov/13

Status: Resolved
Project: data.finger-tree
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Minor
Reporter: Andy Fingerhut Assignee: Chouser
Resolution: Completed Votes: 0
Labels: None


 Description   

In this sequence of lines in defdigit:

IPersistentCollection
        (empty [_]) ; TBD ; not needed?
        (equiv [_ x] false) ; TBD
        (cons [_ x#] (digit ~'meter-obj ~@items x#))

it appears like the equiv method should have x# instead of x.

I would not have noticed this, except I have been trying out tools.analyzer and tools.analyzer.jvm on the contrib libraries, and it threw an exception when analyzing method equiv because the defdigit macro expanded into a deftype that had a namespace on the parameter x.



 Comments   
Comment by Chouser [ 30/Nov/13 2:06 PM ]

Fixed, thanks.

https://github.com/clojure/data.finger-tree/commit/eccb3c416e75d61b5cb07f92b7d3dd3047da1833





Generated at Wed Nov 26 00:43:07 CST 2014 using JIRA 4.4#649-r158309.