iterable.patch
[DPRIMAP-1] Implement java.lang.Iterable Created: 04/Sep/12 Updated: 09/Sep/12 Resolved: 09/Sep/12 |
|
| Status: | Resolved |
| Project: | data.priority-map |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Defect | Priority: | Major |
| Reporter: | Alan Malloy | Assignee: | Sean Corfield |
| Resolution: | Completed | Votes: | 0 |
| Labels: | None | ||
| Attachments: |
iterable.patch
|
| Patch: | Code |
| Description |
|
Clojure collections are expected to implement all relevant java collection interfaces, and things will quietly and subtly break if any are missed. In this case, the reducers library assumes all instances of java.util.Map implement java.lang.Iterable, and since this one doesn't it can't reduce over us, even inefficiently. |
| Comments |
| Comment by Sean Corfield [ 09/Sep/12 2:30 AM ] |
|
The patch from Alan did not apply but it was only a two line addition so I did that manually. Passes current tests but there are no new tests for Iterable (yet). |
[DPRIMAP-2] data.priority-map has no artifacts information in the README Created: 14/Sep/12 Updated: 23/Nov/12 Resolved: 23/Nov/12 |
|
| Status: | Resolved |
| Project: | data.priority-map |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Enhancement | Priority: | Minor |
| Reporter: | Andy Fingerhut | Assignee: | Mark Engelberg |
| Resolution: | Completed | Votes: | 0 |
| Labels: | None | ||
| Description |
|
data.priority-map README has no artifacts information and does not conform to the Contrib README standards in any way. Because clojure-dev is a closed group, I am filing it here |
| Comments |
| Comment by Mark Engelberg [ 23/Nov/12 3:01 AM ] |
|
Updated README |
[DPRIMAP-3] Add more developer info and Markdown markup to README Created: 02/Apr/13 Updated: 02/Apr/13 |
|
| Status: | Open |
| Project: | data.priority-map |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Enhancement | Priority: | Minor |
| Reporter: | Andy Fingerhut | Assignee: | Mark Engelberg |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Attachments: |
dprimap-readme-touchups-patch-v1.txt
|
| Patch: | Code |
| Description |
|
Just a bit more tweaking of the README. |
| Comments |
| Comment by Andy Fingerhut [ 02/Apr/13 1:19 PM ] |
|
Patch dprimap-readme-touchups-patch-v1.txt To see how these changes look on Github, see my forked version here: https://github.com/jafingerhut/data.priority-map/tree/cleanup-readme |
[DPRIMAP-4] There is one reflection warning in data.priority-map when invoking .equiv Created: 25/Apr/13 Updated: 28/Apr/13 |
|
| Status: | Open |
| Project: | data.priority-map |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Enhancement | Priority: | Minor |
| Reporter: | Andy Fingerhut | Assignee: | Mark Engelberg |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Attachments: |
dprimap-4-eliminate-equiv-reflection-patch-v1.txt
|
| Patch: | Code |
| Description |
|
Reflection warning, clojure/data/priority_map.clj:215:19 - call to equiv can't be resolved. That line of source is this one inside the deftype for PersistentPriorityMap: |
| Comments |
| Comment by Andy Fingerhut [ 28/Apr/13 2:50 AM ] |
|
Patch dprimap-4-eliminate-equiv-reflection-patch-v1.txt dated Apr 28 2013 eliminates an occurrence of reflection in the call to .equiv by adding a type hint. |
[DPRIMAP-5] Add support for subseq, rsubseq Created: 28/Apr/13 Updated: 28/Apr/13 |
|
| Status: | Open |
| Project: | data.priority-map |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Enhancement | Priority: | Minor |
| Reporter: | Andy Fingerhut | Assignee: | Mark Engelberg |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Attachments: |
dprimap-5-add-support-for-subseq-rsubseq-patch-v1.txt
|
| Patch: | Code and Test |
| Description |
|
This depends upon some kind of change to clojure.core, either to the Sorted interface or the implementation of subseq and rsubseq, as discussed in this thread: http://groups.google.com/group/clojure-dev/browse_thread/thread/fdb000cae4f66a95 There is a ticket CLJ-428 for these proposed clojure.core changes. |
| Comments |
| Comment by Andy Fingerhut [ 28/Apr/13 2:25 AM ] |
|
Patch dprimap-5-add-support-for-subseq-rsubseq-patch-v1.txt dated Apr 28 2013 depends upon Mark Engelberg's "inclusive" patch for CLJ-428, or something similar, being accepted into clojure.core. It mostly just uncomments some code that Mark wrote, but also slightly modifies the implementation of seqFrom to take advantage of that new parameter. |