<< Back to previous view

[DXML-22] Adding hiccup generation function for elements Created: 24/Feb/14  Updated: 28/Mar/14

Status: Open
Project: data.xml
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Enhancement Priority: Minor
Reporter: Chris Zheng Assignee: Ryan Senior
Resolution: Unresolved Votes: 0
Labels: None
Environment:

N/a



 Description   

This is for completeness really. See pull request https://github.com/clojure/data.xml/pull/10

I would like to:

  • generate an element using hiccup (already exists)
  • generate hiccup using an element (proposed)


 Comments   
Comment by Chris Zheng [ 28/Mar/14 7:22 AM ]

I'm hoping someone can at least give some feedback to this ticket.

Comment by Ryan Senior [ 28/Mar/14 7:53 AM ]

Hi Chris,

Thanks for the reminder on this. I'll have more time to dig in this weekend, but off the top of my head I think more will need to be done on this, both on implementation and on testing. I think what you have now won't work with comments or cdata. One way to flesh some of that out is to create round trip types of tests in src/test/clojure/clojure/data/xml/test_sexp.clj.





[DXML-21] Some unit tests are never run because their names are the same Created: 23/Dec/13  Updated: 23/Dec/13

Status: Open
Project: data.xml
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Minor
Reporter: Andy Fingerhut Assignee: Ryan Senior
Resolution: Unresolved Votes: 0
Labels: None

Attachments: File dxml-21-v1.diff    

 Description   

Whenever two deftest statements have the same name, the first is ignored and its tests are never run.

In namespace clojure.data.xml.test-emit, there are two deftests with name defaults, and two with the name test-indent.

Found using pre-release version of Eastwood Clojure lint tool.



 Comments   
Comment by Andy Fingerhut [ 23/Dec/13 5:50 PM ]

Patch dxml-21-v1.diff makes all deftest names unique. I have not attempted to correct any new failing tests, if any.





Generated at Wed Apr 16 02:27:23 CDT 2014 using JIRA 4.4#649-r158309.