<< Back to previous view

[JDBC-140] Both :identifiers and :entities should be ident? -> ident? functions Created: 24/Aug/16  Updated: 25/Aug/16  Resolved: 25/Aug/16

Status: Closed
Project: java.jdbc
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major
Reporter: Sean Corfield Assignee: Sean Corfield
Resolution: Completed Votes: 0
Labels: None


 Description   

Although originally intended to both be String -> String, the docs are not clear and, up until :qualifiers was added, String -> Keyword worked for :identifiers. @Bronsa pointed this out https://github.com/clojure/java.jdbc/commit/6934d169cc2b4140138ccad8018c858e5c51ba8e#commitcomment-18758345 and the code should be updated so both work. This should be reflected in the new jdbc.spec namespace as well (currently the types of those functions is not specified).



 Comments   
Comment by Nicola Mometto [ 25/Aug/16 12:30 PM ]

Two cases that the `qualifier` change has broken:
1-

(jdbc/query conn ["SELECT 1 AS \"foo/bar\""] {:result-set-fn first})

the key for this map is now a keyword with namespace = `nil` and name = `foo/bar` while previously it used to be a keyword with namespace `foo` and name = `bar`

2-

(jdbc/query conn ["SELECT 1 AS x"] {:identifiers keyword})

this used to return correctly but now fails because `(keyword nil :x)` throws an exception while `(keyword :x)` works as expected.

Comment by Sean Corfield [ 25/Aug/16 2:40 PM ]

Fixed in 0.6.2-alpha3 (coming soon).

Comment by Sean Corfield [ 25/Aug/16 2:45 PM ]

Release 0.6.2-alpha3.





Generated at Sun Aug 28 14:06:10 CDT 2016 using JIRA 4.4#649-r158309.