[JDBC-140] Both :identifiers and :entities should be ident? -> ident? functions Created: 24/Aug/16 Updated: 25/Aug/16 Resolved: 25/Aug/16
|Reporter:||Sean Corfield||Assignee:||Sean Corfield|
Although originally intended to both be String -> String, the docs are not clear and, up until :qualifiers was added, String -> Keyword worked for :identifiers. @Bronsa pointed this out https://github.com/clojure/java.jdbc/commit/6934d169cc2b4140138ccad8018c858e5c51ba8e#commitcomment-18758345 and the code should be updated so both work. This should be reflected in the new jdbc.spec namespace as well (currently the types of those functions is not specified).
|Comment by Nicola Mometto [ 25/Aug/16 12:30 PM ]|
Two cases that the `qualifier` change has broken:
the key for this map is now a keyword with namespace = `nil` and name = `foo/bar` while previously it used to be a keyword with namespace `foo` and name = `bar`
this used to return correctly but now fails because `(keyword nil :x)` throws an exception while `(keyword :x)` works as expected.
|Comment by Sean Corfield [ 25/Aug/16 2:40 PM ]|
Fixed in 0.6.2-alpha3 (coming soon).
|Comment by Sean Corfield [ 25/Aug/16 2:45 PM ]|