<< Back to previous view

[JDBC-144] Passes options all the way down in key CRUD fns Created: 21/Sep/16  Updated: 21/Sep/16

Status: Open
Project: java.jdbc
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Enhancement Priority: Major
Reporter: Isaac Sanders Assignee: Sean Corfield
Resolution: Unresolved Votes: 0
Labels: None

Attachments: Text File 0001-Passes-options-all-the-way-down-in-key-CRUD-fns.patch    
Patch: Code


Specifically `insert!`, `update!`, and `delete!`.

This is terribly inconvenient to not be able to pass options down, especially when it may allow one to tune their use of the library better.

Comment by Sean Corfield [ 21/Sep/16 11:33 AM ]

For reference: https://github.com/clojure/java.jdbc/pull/45

Isaac, thanks for creating the JIRA issue for tracking. Do you think you'll sign the CA etc? If not, that's fine, but I won't be able to touch the patch. As noted on the PR, I'll just use the changes in the PR as a checklist of places to review in the code.

Comment by Isaac Sanders [ 21/Sep/16 12:58 PM ]

I don't think I will be able to sign the CA for this contribution. I would appreciate it if you were able to review and make changes in the spirit of the PR.

– Isaac

Comment by Sean Corfield [ 21/Sep/16 1:32 PM ]

No problem, just wanted to check with you first, before deciding what path to take.

Generated at Wed Sep 28 00:13:21 CDT 2016 using JIRA 4.4#649-r158309.