<< Back to previous view

[MATCH-116] core.match clojurescript should be self-host compatible Created: 23/Oct/16  Updated: 27/Oct/16

Status: Open
Project: core.match
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Enhancement Priority: Major
Reporter: Yehonathan Sharvit Assignee: David Nolen
Resolution: Unresolved Votes: 7
Labels: bootstrap

Attachments: Text File MATCH-116.patch    


core.match clojurescript should be self-host compatible

Comment by Yehonathan Sharvit [ 23/Oct/16 9:20 AM ]

Basically what I did was to take `match.clj` from https://github.com/clojure/core.match/blob/master/src/main/clojure/clojure/core/match.clj

renamed in to `match.cljc` and make a branch for `:cljs`.

Patch is attached

Comment by Yehonathan Sharvit [ 23/Oct/16 9:22 AM ]

I tested it with KLIPSE - http://app.klipse.tech/?cljs_in.gist=viebel/10da8338c4a1573fab8c04989e471704&external-libs=%5Bhttps%3A%2F%2Fraw.githubusercontent.com%2Fviebel%2Fcore.match%2Fmaster%2Fsrc%2Fmain%2Fclojure%2F%5D

Comment by Alex Miller [ 27/Oct/16 8:52 AM ]

Please note that at the moment our automated CI build box is unable to build or release projects containing cljc files. I am actively working on fixing that but until it is, this can't move forward. (And after it's fixed, I would be happy to do so.)

Comment by Yehonathan Sharvit [ 27/Oct/16 8:55 AM ]

Anyway, I'd be happy to get feedback on my patch.
It's a lot of code dealing with the differences between cljs and clojure types.

Generated at Fri Oct 28 16:39:37 CDT 2016 using JIRA 4.4#649-r158309.