<< Back to previous view

[NREPL-65] Clients have no way to signal EOF when reading stdin Created: 24/Aug/14  Updated: 25/Aug/14  Resolved: 24/Aug/14

Status: Resolved
Project: tools.nrepl
Component/s: None
Affects Version/s: 0.2.4
Fix Version/s: 0.2.5

Type: Defect Priority: Major
Reporter: Colin Jones Assignee: Colin Jones
Resolution: Completed Votes: 0
Labels: None


 Description   

As described in https://github.com/technomancy/leiningen/issues/1658

The client ought to be able to signal an EOF by sending a message like {:op :stdin :stdin nil}.



 Comments   
Comment by Colin Jones [ 24/Aug/14 11:00 PM ]

Closed by https://github.com/clojure/tools.nrepl/commit/eb526fd8498ced1b4bd1555f8ff680f3ad65f1b4

Comment by Chas Emerick [ 25/Aug/14 7:50 AM ]

Good, thanks!





[NREPL-63] Add :version-string property to the Clojure version Created: 22/Aug/14  Updated: 22/Aug/14  Resolved: 22/Aug/14

Status: Closed
Project: tools.nrepl
Component/s: None
Affects Version/s: 0.2.4
Fix Version/s: 0.2.5

Type: Enhancement Priority: Minor
Reporter: Bozhidar Batsov Assignee: Bozhidar Batsov
Resolution: Completed Votes: 0
Labels: enhancement

Attachments: Text File 0001-Add-version-string-property-to-the-Clojure-version.patch    
Patch: Code and Test

 Description   

This aligns the Clojure version map with the nREPL and Java version maps (and simplifies the lives of tool writers).



 Comments   
Comment by Chas Emerick [ 22/Aug/14 9:24 PM ]

Applied as da0443d, thanks!





[NREPL-62] Improve Java version information Created: 22/Aug/14  Updated: 22/Aug/14  Resolved: 22/Aug/14

Status: Closed
Project: tools.nrepl
Component/s: None
Affects Version/s: 0.2.4
Fix Version/s: 0.2.5

Type: Enhancement Priority: Minor
Reporter: Bozhidar Batsov Assignee: Bozhidar Batsov
Resolution: Completed Votes: 0
Labels: enhancement

Attachments: Text File 0001-Extend-Java-version-information.patch     Text File 0001-Extend-Java-version-information.patch    
Patch: Code and Test

 Description   

As discussed before - structure the Java version information similarly to nREPL and Clojure's.



 Comments   
Comment by Chas Emerick [ 22/Aug/14 8:54 AM ]

My original hesitation was largely due to a suspicion that JVM version strings are not particularly regular, especially across vendors. Perhaps that simple regex will work on all Sun/Oracle VM's, but let's keep things clean in any cases where it won't: if no match is found, let's not include the major/minor/etc slots with nil values.

Comment by Bozhidar Batsov [ 22/Aug/14 9:32 AM ]

See the updated patch - if we don't find 4 numbers in the version string we don't include any extra slots.

Comment by Chas Emerick [ 22/Aug/14 1:41 PM ]

Thanks, applied. Looks like there's often no update version included, so I tweaked things so that 3-4 slots are acceptable. e.g. http://build.clojure.org/job/tools.nrepl-test-matrix/163/CLOJURE_VERSION=1.3.0,jdk=Oracle%20JDK%201.7/console (search for java.version).

Comment by Bozhidar Batsov [ 22/Aug/14 2:53 PM ]

Yeah, turns out the first build doesn't have an update. Thanks!





[NREPL-61] Typo in README Created: 22/Aug/14  Updated: 22/Aug/14  Resolved: 22/Aug/14

Status: Closed
Project: tools.nrepl
Component/s: None
Affects Version/s: 0.2.4
Fix Version/s: 0.2.5

Type: Defect Priority: Trivial
Reporter: Bozhidar Batsov Assignee: Bozhidar Batsov
Resolution: Completed Votes: 0
Labels: documentation

Attachments: Text File 0001-Fix-a-typo-and-remove-some-trailing-whitespace.patch    
Patch: Code

 Description   

Just a small typo fix.



 Comments   
Comment by Chas Emerick [ 22/Aug/14 8:01 AM ]

Applied as 222c456. Thanks!





Generated at Wed Aug 27 13:57:55 CDT 2014 using JIRA 4.4#649-r158309.