<< Back to previous view

[TCLI-85] Use of undeclared Var cljs.tools.cli/make-summary-parts at line 302 Created: 04/May/16  Updated: 04/May/16  Resolved: 04/May/16

Status: Resolved
Project: tools.cli
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Major
Reporter: Matthew Boston Assignee: Sean Corfield
Resolution: Completed Votes: 0
Labels: None

Attachments: Text File 0001-FIX-TCLI-85.patch    

 Description   

cljs.tools.cli/make-summary-parts was renamed to make-summary-part but the reference to it in cljs.tools.cli/summarize was not updated. This causes the error in the title of this bug.

Introduced in 0.3.4 (commit 401c51f3c2c5c549b9b4713951e41ed20cfcc4d7).



 Comments   
Comment by Sean Corfield [ 04/May/16 6:32 PM ]

Sorry, I thought I caught all the singularizations

Comment by Sean Corfield [ 04/May/16 6:38 PM ]

Fixed in 0.3.5.

Comment by Matthew Boston [ 04/May/16 6:40 PM ]

Thanks!





[TCLI-36] Add compilation of spec vector to summarize Created: 22/Oct/15  Updated: 01/May/16  Resolved: 01/May/16

Status: Resolved
Project: tools.cli
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Major
Reporter: Tim Richardt Assignee: Sean Corfield
Resolution: Completed Votes: 0
Labels: None

Attachments: Text File 0001-Add-compilation-of-spec-vector-to-summarize.patch    
Patch: Code

 Description   

The compilation of the spec vectors to the spec map is missing in summarize. This leads to a fail of the destructuring of specs make-summary-parts.



 Comments   
Comment by Sean Corfield [ 22/Oct/15 11:13 AM ]

Thank you for catching that Tim!

As it stands, I can't accept the patch until you've signed a Contributor's Agreement and you're listed on http://clojure.org/contributing (you can read about becoming a contributor on that page), but this is a small, self-contained fix so I'll try to create a test case for it and then I'll fix it.

Comment by Sean Corfield [ 22/Oct/15 11:27 AM ]

I looked at the tests and summarize expects to be called with a "compiled" set of specs. If you look at parse-opts, you'll see the :summary value it passes back is the result of calling either summarize or the user-supplied summary-fn on (compile-option-specs option-specs).

I'll update the summarize docstring to make that clear.

Comment by Sean Corfield [ 22/Oct/15 11:38 AM ]

That essentially makes summarize uncallable (unless you reach in and use #'clojure.tools.cli/compile-option-specs) so I'll have to review the documentation and see what to do about summarize.

Comment by Tim Richardt [ 23/Oct/15 4:31 AM ]

Thank you for the quick response and sorry for inaccurate patch. I was too rash commiting it.

Comment by Sean Corfield [ 01/May/16 7:33 PM ]

Expanded docstring on summarize. Exposed two helper functions it uses as public so it's easier to write your own :summary-fn (and added docstrings to those!).





Generated at Thu May 05 03:34:55 CDT 2016 using JIRA 4.4#649-r158309.