<< Back to previous view

[TLOG-13] tools.logging ns form :require and :use subforms unrecognized by tools.namespace Created: 23/Aug/14  Updated: 29/Aug/14

Status: Open
Project: tools.logging
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Enhancement Priority: Trivial
Reporter: Andy Fingerhut Assignee: Alexander Taggart
Resolution: Unresolved Votes: 0
Labels: None

Attachments: Text File tlog-13-1.patch    


Cross-reference: TNS-21

I am not sure whether this is something that should be changed in tools.logging or tools.namespace. To be sure, at most one of them should change, if either. Stuart Sierra has mentioned in TNS-21 that the ns doc string shows :require :use etc. subforms always in parentheses, and not vectors. It might be best to change tools.logging's ns form.

tools.namespace expects (:require ...) and (:use ...) subforms of the ns form to be in lists, not vectors, otherwise it ignores them.

tools.logging has ns forms that use vectors like [:require ...] and [:use ...], and are thus ignored by tools.namespace.

The Clojure compiler seems to handle these dependencies just fine, but this may be just another case where it accepts more things than it is documented to accept.

Comment by Andy Fingerhut [ 29/Aug/14 7:42 PM ]

Patch tlog-13-1.patch dated Aug 29 2014 simply replaces [] with () around subforms of ns forms.

Generated at Wed Sep 17 18:50:40 CDT 2014 using JIRA 4.4#649-r158309.