[TTRACE-9] Use aprint when displaying value Created: 29/Oct/14 Updated: 31/Oct/14
|Reporter:||Jérémie Grodziski||Assignee:||Luc Préfontaine|
|Patch:||Code and Test|
Problem: when trace-ns is used, very long displays in the output stream is very hard to read when the fn calls are important and with voluminous data structure
|Comment by Andy Fingerhut [ 30/Oct/14 7:36 AM ]|
Jeremie, I am not certain, but I believe it is a policy of Clojure contrib libraries not to depend on libraries other than those in Clojure or Clojure contrib.
Perhaps if new arities were added to some existing tools.trace functions or macros, sprint or any other developer-desired function could be provided as arguments to control how printing occurs?
|Comment by Jérémie Grodziski [ 30/Oct/14 8:17 AM ]|
Thanks for your comment, yes I thought about that and known it would be the greatest concern...
In the end, adding aprint (both for color and layout) made a HUGE difference for me in usability...
|Comment by Alex Miller [ 30/Oct/14 10:18 AM ]|
Andy, that is not a policy afaik, merely a preference to minimize them as much as possible. There are other contribs that have external dependencies. It's up to Luc as the contrib lead whether he thinks this is ok here.
|Comment by Luc Préfontaine [ 30/Oct/14 10:59 AM ]|
I've looked into this. 'Inlining aprint' in tools.trace would be my first choice.
Being a regular user of this tool, I find the arity avenue painful. It happens that we use this in
I think we need a mode state to enable/disable this feature. In the repl you would need a single
Eventually this could migrate to core.pprint but that will require some time before it ends up in a clojure release.
Meanwhile we can keep this isolated in tools.trace so it can be moved later elsewhere.
|Comment by Luc Préfontaine [ 30/Oct/14 12:50 PM ]|
I sent an email to Vlad and the url to this ticket.
|Comment by Vlad Bokov [ 31/Oct/14 12:27 AM ]|
Hi Jérémie, Alex and Luc,
I'm the author of aprint and really happy about you like my lib
1) I really like the idea to push it into tools.trace
Now some points about the question "what will get inlined?"
4) I'm a bit surprised, that people don't share my intent to integrate it with repl like this https://github.com/greglook/whidbey, don't like colors, they simply like the layout. So coloring could be thrown away and we eliminate dependance on clansi. Or I could inline clansi (has MIT license), document a :^dynamic to turn on colors (which will get off by default)