http://dev.clojure.org/jira/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+10010+AND+labels+%3D+metadata An XML representation of a search request en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJ-918 Clojure <p>When defining a var with <tt>^{:macro true</tt>} the call of the binded macro does emit a warning when the definition has been AOT compiled.</p> <p>See example outputs with demo code here: <a href="https://refheap.com/paste/389">https://refheap.com/paste/389</a></p> <p>Bronsa on #clojure created a patch: <a href="http://sprunge.us/bWcc">http://sprunge.us/bWcc</a></p> Tested with 1.3.0 and 1.4.0 CLJ-918

Vars with {:macro true} meta data do not work when loaded from AOT compiled file

Enhancement Trivial Closed Duplicate Unassigned Jannik Schorg Compiler enhancement metadata Mon, 23 Jan 2012 16:06:06 -0600 Thu, 13 Sep 2012 14:29:01 -0500 Thu, 13 Sep 2012 14:29:01 -0500 0 1 <p>Duplicate of <a href="http://dev.clojure.org/jira/browse/CLJ-1021" title="(let [i 5] (defmacro m [v] v) m) interprets m as a function, not a macro">CLJ-1021</a>. Later ticket kept in preference to this one, because it has a patch and this one does not.</p> Global Rank Patch New http://dev.clojure.org/jira/browse/CLJ-916 Clojure <p>The into fn loses metadata.</p> <p>I'm seeing some team members (myself included) rely on metadata. Metadata has been incredibly useful in some cases, however the silent destruction of metadata by core clojure fns (into, walk, etc) have been a source of increasing complexity and confusion. </p> <p>A team member could start relying on a 3rd party library that used 'into'. Actually, the into fn could essentially be added to the code base at any time in many ways. Wrt metadata the potential for incidental complexity increases exponentially as more developers and libraries enter the mix. </p> <p>One of the reasons Clojure has worked for us so well is because it has greatly reduced incidental complexity.<br/> IMHO the 'into metadata bug' seriously limits the usefulness of metadata and would love to see the into fn fixed in 1.4.</p> CLJ-916

into loses metadata

Defect Major Closed Completed Unassigned Mark Swanson into metadata walk Sat, 21 Jan 2012 11:58:29 -0600 Sat, 18 Aug 2012 07:50:41 -0500 Sat, 18 Aug 2012 07:50:41 -0500 Release 1.3 Release 1.5 4 5 <p>Someone please correct this if it is wrong, but it seems that into loses metadata because it is implemented using transients, and transients lose metadata. If true, then one way to fix this ticket is to implement metadata for transients.</p> <p>Are there any fundamental reasons why it would be difficult to add metadata to transients, as long as the metadata itself was immutable?</p> <p>First rough cut of a patch that makes not only into, but also select-keys, clojure.set/project, and clojure.set/rename preserve metadata. Added tests for these and many other functions. Still some open questions about other functions not tested in comments. This patch does not attempt to make transients preserve metadata.</p> <p>clj-916-make-into-and-others-preserve-metadata-patch2.txt is semantically same patch and comments as March 16, 2012. Merely touched up to apply cleanly to latest master as of Mar 23, 2012.</p> <p>I just ran into this issue myself. Is there anything that I could do to help get this fixed? Test writing? Patch checks? I'm happy to help in any way I can.</p> <p>You could examine the existing patch, including its tests, and see if it would have done what you were hoping it would do. Add a comment here regarding whether the changes look good to you. The attached patch is already on my weekly list of prescreened patches, but it is only one among many.</p> <p>The code is clean and tests test what they should test. Regarding the questions in the test file:</p> <ul> <li>I recommend (royal) we create another ticket for the remaining clojure.set functions and discuss them there. Once resolved the questions in the metadata.clj test file should be removed.</li> </ul> <ul> <li><tt>remove</tt> returns a LazySeq, but the intent of the question is clear. I vote that remove preserve metadata as well, but that should be the topic of yet another ticket.</li> </ul> <p>One final point. I'd prefer that tickets be addressed in isolation and not contain extra fixes. This is a personal preference, but one that I'd like to take up on the clojure-dev list.</p> <p>clj-916-make-into-preserve-metadata-patch1.txt dated Aug 15 2012 only changes the behavior of into so that it preserves metadata. One or more other tickets will be created for some other functions that currently do not preserve metadata, but perhaps should.</p> Approval Ok Global Rank Patch Code and Test