http://dev.clojure.org/jira/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+10010+AND+labels+%3D+queue An XML representation of a search request en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJ-1078 Clojure <p>This patch adds functions for PersistentQueue. queue, queue? and queue* match the list functions of the same naming conventions. Patches include updates to tests. </p> CLJ-1078

Added queue, queue* and queue? to clojure.core

Enhancement Trivial Open Unresolved Unassigned Timothy Baldridge data-structures queue Wed, 26 Sep 2012 23:38:59 -0500 Sat, 6 Apr 2013 08:06:15 -0500 Release 1.5 2 2 <p>Timothy, I tried applying both of these Sep 26, 2012 patches to latest Clojure master as of that date. I had to apply 0001-make-PersistentQueue-ctor-public.patch by hand since it failed to apply using git or patch. It built fine, but failed to pass several of the Clojure tests. Have you looked into those test failures to see if you can find the cause and fix them? I tested on Ubuntu 11.10 with Oracle JDK 1.6 and 1.7, and saw similar failures with both.</p> <p>Fixed the patch. Tests pass, created the patch, applied it to a different copy of the source and the tests still pass. So this new patch should be good to go.</p> <p>Timothy, I'm not sure how you are getting successful results when applying this patch. Can you try the steps below and see what happens for you? I get errors trying to apply the patch with latest Clojure master as of Oct 26, 2012. Also please use the steps on the JIRA workflow page to create a git format patch (<a href="http://dev.clojure.org/display/design/JIRA+workflow">http://dev.clojure.org/display/design/JIRA+workflow</a> under "Development" heading).</p> <p>% git clone git://github.com/clojure/clojure.git<br/> % cd clojure<br/> % patch -p1 &lt; queues.patch<br/> patching file src/clj/clojure/core.clj<br/> patching file src/jvm/clojure/lang/PersistentQueue.java<br/> Hunk #1 FAILED at 32.<br/> 1 out of 1 hunk FAILED &#8211; saving rejects to file src/jvm/clojure/lang/PersistentQueue.java.rej<br/> patching file test/clojure/test_clojure/data_structures.clj<br/> Hunk #1 succeeded at 123 with fuzz 2.<br/> Hunk #2 succeeded at 861 with fuzz 2.<br/> Hunk #3 FAILED at 872.<br/> 1 out of 3 hunks FAILED &#8211; saving rejects to file test/clojure/test_clojure/data_structures.clj.rej<br/> patching file test/clojure/test_clojure/java_interop.clj</p> <p>I was using git apply. I tried the method you show above, and now I'm seeing the same issues you show above. </p> <p>Just so you know, the preferred way to create and apply patches are the "git format-patch master --stdout &gt; patch.txt" to create a patch (after doing the branching commands described on the JIRA workflow page to create a branch for your changes), and the "git am --keep-cr -s &lt; patch.txt" to apply a patch. If a patch was created that way and applies cleanly with that command, then you are definitely good to go.</p> <p>The "patch -p1 &lt; patch.txt" command is just a secondary method sometimes used to try to apply patches that aren't in the format produced above, or have errors when applying using that method.</p> <p>Just so you know, the preferred way to create and apply patches are the "git format-patch master --stdout &gt; patch.txt" to create a patch (after doing the branching commands described on the JIRA workflow page to create a branch for your changes), and the "git am --keep-cr -s &lt; patch.txt" to apply a patch. If a patch was created that way and applies cleanly with that command, then you are definitely good to go.</p> <p>The "patch -p1 &lt; patch.txt" command is just a secondary method sometimes used to try to apply patches that aren't in the format produced above, or have errors when applying using that method.</p> <p>added patch</p> <p>That one applies cleanly and passes all tests. It should show up on the next list of prescreened patches. Thanks.</p> <p>we don't use the queue* convention elsewhere, e.g. vec and vector. I think queue should take a collection like vec and set. (queue <span class="error">&#91;1 2 3&#93;</span>) could be made to 'adopt' the collection as front.</p> <p>Patch queue.patch dated Oct 26 2012 no longer applies cleanly after recent <a href="http://dev.clojure.org/jira/browse/CLJ-1000" title="Performance drop in PersistentHashMap.valAt(...) in v.1.4 -- Util.hasheq(...) ?"><del>CLJ-1000</del></a> commits, but only because of one line of changed patch context. It still applies cleanly with "patch -p1 &lt; queue.patch". Not bothering to update the stale patch given Rich's comments suggesting more substantive changes.</p> <p>See also <a href="http://dev.clojure.org/jira/browse/CLJ-976" title="Implement reader literal and print support for PersistentQueue data structure">CLJ-976</a> (tagged literal support for PersistentQueue)</p> Global Rank Patch Code and Test http://dev.clojure.org/jira/browse/CLJ-976 Clojure <p>Clojure's PersistentQueue structure has been in the language for quite some time now and has found its way into a fair share of codebases. However, the creation of queues is a two step operation often of the form:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>(conj clojure.lang.PersistentQueue/EMPTY :a :b :c) ;=&gt; #&lt;PersistentQueue clojure.lang.PersistentQueue@78d5f6bc&gt; </pre> </div></div> <p>A better experience might be the following:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>#queue [:a :b :c] ;=&gt; #queue [:a :b :c] (pop #queue [:a :b :c]) ;=&gt; #queue [:b :c] </pre> </div></div> <p>This syntax is proposed and discussed in the Clojure-dev group at <a href="https://groups.google.com/forum/?fromgroups#!topic/clojure-dev/GQqus5Wycno">https://groups.google.com/forum/?fromgroups#!topic/clojure-dev/GQqus5Wycno</a></p> <p>Open question: Should the queue literal's arguments eval? The implications of this are illustrated below:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>;; non-eval case #queue [1 2 (+ 1 2)] ;=&gt; #queue [1 2 (+ 1 2)] ;; eval case #queue [1 2 (+ 1 2)] ;=&gt; #queue [1 2 3] </pre> </div></div> <p>The answer to this open question will determine the implementation.</p> CLJ-976

Implement reader literal and print support for PersistentQueue data structure

Enhancement Minor Open Unresolved Fogus Fogus data-structures queue reader tagged-literals Fri, 27 Apr 2012 09:31:36 -0500 Sat, 6 Apr 2013 08:07:20 -0500 Release 1.5 0 4 <p>I think the non-eval behavior would be consistent with the other reader literals in Clojure 1.4. It's definitely better for interop where some other language implementation could be expected to handle a few literal representations, but not the evaluation of Clojure expressions. Use a regular function if the args need evaluation.</p> <p>The precedent of records seems relevant:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">=&gt; (defrecord A [b]) user.A =&gt; #user.A[(+ 4 5)] #user.A{:b (+ 4 5)} =&gt; #user.A{:b (+ 4 5)} #user.A{:b (+ 4 5)}</pre> </div></div> <p>This continues to make sense, as otherwise queues would need to print with an extra <tt>(quote …)</tt> form around lists — which records neatly avoid:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">=&gt; (A. '(+ 4 5)) #user.A{:b (+ 4 5)}</pre> </div></div> <p>Does this mean that a <tt>queue</tt> fn (analogous to <tt>vector</tt>, maybe) will also make an appearance? It'd be handy for HOF usage.</p> <p>Added a patch for the tagged literal support ONLY. This is only one part of the total solution. This provides the read-string and printing capability. I'd like more discussion around the eval side before I get dive into the compiler.</p> <p>In addition to Chas' observations on consistency with record literals, would eval in queue literals open up the same security hole as #=, needing to respect *<b>read-eval</b>*?<br/> When needing eval inside a queue literal, embedding a #= seems more apropos.</p> <p>Evalable queue literal support.</p> <p>Neither of the patches <a href="http://dev.clojure.org/jira/browse/CLJ-976" title="Implement reader literal and print support for PersistentQueue data structure">CLJ-976</a>-queue-literal-tagged-parse-support-only.diff dated Apr 27, 2012 nor <a href="http://dev.clojure.org/jira/browse/CLJ-976" title="Implement reader literal and print support for PersistentQueue data structure">CLJ-976</a>-queue-literal-eval.diff dated May 4, 2012 apply cleanly to latest master as of May 10, 2012.</p> <p>Updated patch file to merge with latest master.</p> <p>New patch with support fixed for syntax-quote.</p> <p>Patch does not apply as of commit f5f4faf95051f794c9bfa0315e4457b600c84cef</p> <p>Weird. I was able to download the <a href="http://dev.clojure.org/jira/browse/CLJ-976" title="Implement reader literal and print support for PersistentQueue data structure">CLJ-976</a>-queue-literal-eval-and-synquote.diff patch and apply it to HEAD as of just now (f5f4faf95051f794c9bfa0315e4457b600c84cef). There were whitespace warnings, but the patch applied, compiles and passes all tests.</p> <p>With latest head I was able to successfully apply patch <a href="http://dev.clojure.org/jira/browse/CLJ-976" title="Implement reader literal and print support for PersistentQueue data structure">CLJ-976</a>-queue-literal-eval-and-synquote.diff with this command:</p> <p>git am --keep-cr -s &lt; <a href="http://dev.clojure.org/jira/browse/CLJ-976" title="Implement reader literal and print support for PersistentQueue data structure">CLJ-976</a>-queue-literal-eval-and-synquote.diff</p> <p>with some warnings, but successfully applied. If I try it without the --keep-cr option, the patch fails to apply. I believe this is often a sign that either one of the files being patched, or the patch itself, contains CR/LF line endings, which some of the Clojure source files definitely do.</p> <p>The command above (with --keep-cr) is currently the one recommended for applying patches on page <a href="http://dev.clojure.org/display/design/JIRA+workflow">http://dev.clojure.org/display/design/JIRA+workflow</a> in section "Screening Tickets". I added the suggested --keep-cr option after running across another patch that applied with the option, but not without it.</p> <p>Presumptuously changing Approval from Incomplete back to Test, since the latest patch does apply cleanly if --keep-cr option is used.</p> <p>this needs more time</p> <p>Rich, </p> <p>Do you mind providing a little more detail? I would be happy to make any changes if needed. However, if it's just a matter of its relationship to EDN and/or waiting until the next release then I am happy to wait. In either case, I'd like to complete this or push it to the back of my mind. Thanks.</p> <p>clj-976-queue-literal-eval-and-synquote-patch-v2.txt dated Oct 5 2012 is identical to Fogus's patch <a href="http://dev.clojure.org/jira/browse/CLJ-976" title="Implement reader literal and print support for PersistentQueue data structure">CLJ-976</a>-queue-literal-eval-and-synquote.diff dated Jul 20 2012. It simply removes one line addition to clojure.iml that Rich has since added in a different commit, so that this patch now applies cleanly to latest master.</p> <p>clj-976-queue-literal-eval-and-synquote-patch-v3.txt dated oct 16 2012 is identical to Fogus's patch <a href="http://dev.clojure.org/jira/browse/CLJ-976" title="Implement reader literal and print support for PersistentQueue data structure">CLJ-976</a>-queue-literal-eval-and-synquote.diff dated Jul 20 2012. It simply removes one line addition to clojure.iml that Rich has since added in a different commit, so that this patch now applies cleanly to latest master.</p> <p>Fogus, with the recent commit of a patch for <a href="http://dev.clojure.org/jira/browse/CLJ-1070" title="PersistentQueue&#39;s hash function does not match its equality"><del>CLJ-1070</del></a>, my touched-up patch clj-976-queue-literal-eval-and-synquote-patch-v3.txt dated Oct 16 2012 doesn't apply cleanly. In this case it isn't simply a few lines of context that have changed, it is the interfaces that PersistentQueue implements have been changed. It might be best if you take a look at the latest code and the patch and consider how it should be updated.</p> <p>Related to <a href="http://dev.clojure.org/jira/browse/CLJ-1078" title="Added queue, queue* and queue? to clojure.core">CLJ-1078</a>.</p> Approval Test Global Rank Patch Code and Test