Clojure JIRA

[CLJ-1161] sources jar has bad versions.properties resource

Fri, 24 May 2013 11:13:59 -0500

Summary: patch leaves version.properties file out of sources JAR, where it causes problems for tools.

The "sources" jar (at least since Clojure 1.4 and including 1.5 RC) has a bad version.properties file in it. The resource clojure/version.properties is literally:

version=${version}

The regular Clojure jar has the correct version string in that resource.

I came across a problem when I was experimenting with the sources jar (as used by IDEs). I naively added the sources jar to my classpath, and Clojure died on start up. The bad clojure/versions.properties file was found first, which led to a parse error as the clojure version was being set.

[CLJ-944] compiler makes different concrete maps then the reader

Fri, 24 May 2013 09:03:46 -0500

I (Stu) agree with Nicola's assessment in the comments: the single real problem here is that the compiler's MapExpr parser emits maps differently from other map-makers, e.g. RT's factory functions.

Patch clj944-plus-tests does three things:

has the compiler emit map types consistent with the reader (like the previous "0002" patch)
adds tests
removes broken tests

Original report follows:

Hi guys, I am getting the following exception:

(.containsKey {:one 1} :one)
;=> ClassCastException clojure.lang.PersistentArrayMap cannot be cast to clojure.lang.PersistentHashMap

The map is a clojure.lang.PersistentArrayMap, which obviously has a containsKey method (https://github.com/clojure/clojure/blob/master/src/jvm/clojure/lang/PersistentArrayMap.java#L95).

Casting it works fine though:

(.containsKey ^clojure.lang.PersistentArrayMap {:one 1} :one)
;=> true

The mailing list suggest that the compiler injects an incorrect cast to clojure.lang.PersistentHashMap. In this case it should probably be cast to a clojure.lang.Associative, the highest common interface having the .containsKey method.

The problem is not present in Clojure 1.2.1.

[CLJ-1018] range's behavior is inconsistent

Fri, 24 May 2013 07:34:58 -0500

Problem statement: The current behavior of range is inconsistent. (range 0 9 0) has always produced (). (range 0 9 -1) has always produced (). (range 9 0 1) has always produced (). However, (range 9 0 0) produces (9 9 9 9 ...), and (range 0 0 0) produces '(0 0 0 0 ...)

Proposal: Make the behavior of range consistent when using a step of 0 to make it produce an empty list.

Please see attached code and patch.

[CLJ-1154] Compile.java closes out preventing java from reporting exceptions

Fri, 12 Apr 2013 09:31:03 -0500

I was trying to compile a project that has some native dependencies. I am using clojure-maven-plugin version 1.3.13 with Maven 2.0. I forgot to set java.library.path properly so that the native library could be found, and only got an error of

[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Clojure failed.
[INFO] ------------------------------------------------------------------------

I traced this down to Compile.java, where it is flushing and closing

out

in the finally block. The JVM uses out to write out a stack trace for any uncaught exceptions. When out is closed it is unable to write out the stack trace for the UnsatisfiedLinkError that was being thrown. This made it very difficult to debug what was happening.

[CLJ-927] default tagged literal reader

Fri, 1 Mar 2013 09:49:21 -0600

With data reader support, it's impossible to write a program to read an arbitrary stream of Clojure forms. For example, the following code will fail with the current 1.4.0-beta1 tagged literal support:

#point [0 2]

It might be enough to require that the read side define a reader for point, but what if we do not wish to require that both sides of the conversation know about the #point tag beforehand? Using the identity function as a default allows the reader to handle the literal form as is even when it doesn't recognize a tag (or even care to translate it).

The change from the current behavior is that missing tagged literal parsers are no longer error conditions.

[CLJ-1000] Performance drop in PersistentHashMap.valAt(...) in v.1.4 -- Util.hasheq(...) ?

Fri, 1 Mar 2013 09:49:21 -0600

It seems there is a 30-40% performance degradation of PersistentHashMap.valAt(...) in Clojure 1.4.
Possibly due to references to new CPU-hungry implementation of Util.hasheq(...).

I have created a demo project with more details and some profiling information here:
https://github.com/oshyshko/clj-perf

[CLJ-1032] seque leaks threads from the send-off pool

Fri, 1 Mar 2013 09:49:21 -0600

Because a new (fill) action is created every time an item is (drain)ed, the LBQ gets loaded up with piles of EOS markers. If the output seq is consumed faster than the input sequence can produce items, then the original agent action does all of the filling in a single action, while the agent's queue continues to back up with (fill) actions. Eventually the entire sequence is consumed, and each queued action does a blocking .put of an EOS marker; once the queue has filled up, one of these actions blocks forever, since nobody will ever .take from the queue again.

The attached patch does two things:

Make sure to put exactly one EOS marker in the stream, by setting the agent's state to nil if and only if a .offer of EOS has been accepted.
Replace all occurrences of .put with .offer (and appropriate checking of the return value). This is necessary because if .put ever blocks, it's possible for the system to remain in that state forever (say, because the client stops consuming the queue), thus leading to the same leaked-thread scenario.

The diff is a little bit inconvenient to read because of indentation changes; https://gist.github.com/b7ecd4395a0d3d473de6 is an ignore-whitespace view of the patch for convenience.

[CLJ-1048] add test.generative to Clojure's tests

Fri, 1 Mar 2013 09:49:21 -0600

The 0.1.5 release of test generative includes data generators and specs based on data generation, plus a runner that can run both c.t and c.t.g. tests under the same umbrella.

[CLJ-1106] Broken equality for sets

Fri, 1 Mar 2013 09:49:21 -0600

Equality for sets is not consistent with other persistent collections when the hashCode differs:

(= {(Integer. -1) :foo} {(Long. -1) :foo})
=> true

(= [(Integer. -1)] [(Long. -1)])
=> true

(= #{(Integer. -1)} #{(Long. -1)})
=> false

Attached is what I believe to be a basic fix. It removes a hashCode check from APersistentSet.equals. A similar check was removed from APersistentMap in the following commit:

https://github.com/clojure/clojure/commit/b5f5ba2e15dc2f20e14e05141f7de7c6a3d91179

With this patch, set equality works as expected and all tests pass.

My understanding of the implications of this change are limited, so someone more knowledgeable would need to chime in about its correctness.

[CLJ-1116] More REPL-friendly 'ns macro

Fri, 1 Mar 2013 09:49:21 -0600

The 'ns macro is not as dynamic as it could be.
For instance, the following line typed in a repl (ns a)(ns b (:require a)) currently (1.4, 1.3, etc.) fails with an exception because the (:require a) call tries to reach the filesystem for file a.clj or a__init.class.

The attached patch ( dynamic-ns-patch2.diff ) allows a successful call to (ns a) behave the same as a successful call to (require 'a), adding namespace a to the list of loaded-libs.

Discussion on googlegroup's mailing list: http://groups.google.com/group/clojure-dev/browse_thread/thread/fb231e6fab4a5ad

[CLJ-1140] {:as x} destructuring with an empty list raises exception

Fri, 1 Mar 2013 09:49:21 -0600

user=> (clojure-version)
"1.4.0"
user=> (let [{:as x} '()] x)
{}

...

user=> (clojure-version)
"1.5.0-RC1"
user=> (let [{:as x} '()] x)
IllegalArgumentException No value supplied for key: null  clojure.lang.PersistentHashMap.create (PersistentHashMap.java:77)

The bug was introduced by a change[1] to support duplicate keys in map
destructuring. Using PersistentHashMap/create here introduces the above
bug, since it does not properly handle empty lists.

[1]: https://github.com/clojure/clojure/commit/93c795fe10ee5c92a36b6ec6373b3c80a31135c4

[CLJ-157] Need better error report when omitting parameter list from (fn) or (defn)

Fri, 1 Mar 2013 09:49:21 -0600

Somehow I just forgot to define parameters for my zero argument function and it took me a long time to notice it, mostly because I had been working with a lot of macros but especially because I didn't get an error that said "You must provide a list of parameter names", but instead: "Don't know how to create ISeq from: Symbol".

[CLJ-779] Document clojure.org differences between 1.2 and 1.3

Fri, 1 Mar 2013 09:49:21 -0600

Documentation at http://clojure.org should always represent the latest release version. When we ship Release.next, we need to update the documentation there to reflect the latest changes.

[CLJ-936] Improve docs about argument destructuring at clojure.org

Fri, 1 Mar 2013 09:49:21 -0600

What:
Make the description of argument destructuring more visible at http://clojure.org/special_forms, namely:

add a heading such as "<h4>Binding Forms (Argument Destructuring)</h4>" to the section describing it
make all occurences of "binding-form" a link to that heading, especially under the let and fn headings
for (fn ..) add a new second paragraph like "Regarding binding forms, also known as argument destructuring, <a href=#thea-new-heading>read more in the binding forms section</a> under the let special form."

Why:
It was always surprisingly difficult for me to google out the explanation of destructuring in Clojure and only today have I discovered that it is described pretty well under the let special form. Thus it should be made more visible to the readers (and preferably also search engines). (Even though Google has returned the page as one of the first matches, I had problems seeing it there - partly due to usually mistyping destructuring e.g. as deconstruction).

Thanks a lot!

PS: I haven't found a better way to report this, such as a commenting capability on the page itself.

[CLJ-990] Implement clojure.core.reducers/mapcat and some initial reducers tests

Fri, 1 Mar 2013 09:49:21 -0600

The first patch implements a reducers equivalent of clojure.core/mapcat, and the second patch adds a new reducers.clj to the clojure tests that checks that map, mapcat, filter, and reduce are equivalent in clojure.core and clojure.core.reducers.

[CLJ-1098] Extend CollFold and IKVReduce to nil

Fri, 1 Mar 2013 09:49:21 -0600

Currently, reduce-kv and fold throw when used on nil, because their respective protocols don't extend to nil. This seems strange, since Clojure tends to handle nils gracefully where possible, especially in places where collections are expected.

See thread https://groups.google.com/d/topic/clojure/tGI8sIKQoh0/discussion

[CLJ-1062] CLJ-940 breaks compilation of namespaces that don't have any public functions

Fri, 1 Mar 2013 09:49:20 -0600

~~CLJ-940~~ that was recently committed to master break compilation of namespaces that don't have any public functions in them
(for example, like https://github.com/michaelklishin/monger/blob/master/src/clojure/monger/json.clj that only extends
a protocol).

This affects several of clojurewerkz.org projects that no longer can compile with 1.5.0-master-SNAPSHOT.

[CLJ-985] make jsr166 available at build time

Fri, 1 Mar 2013 09:49:20 -0600

but no runtime requirement.

[CLJ-987] pprint doesn't flush the underlying stream

Fri, 1 Mar 2013 09:49:20 -0600

Unlike prn, pprint doesn't flush the underlying stream.

pretty_writer currently overrides .flush with behaviour that pushes its own data, but does not flush the underlying stream.

pprint should behave similarly to prn with respect to flushing the underlying stream.

[CLJ-1150] Make some PersistentVector, SubVector internals public

Fri, 1 Mar 2013 09:49:20 -0600

This should help with RRBT-PV interop.

[CLJ-902] doc macro broken for namespaces

Fri, 1 Mar 2013 09:49:20 -0600

Example:

Clojure 1.3.0
user=> (doc clojure.pprint)
ClassNotFoundException clojure.pprint java.net.URLClassLoader$1.run (URLClassLoader.java:366)

It appears it is not safe to call resolve on a symbol representing a namespace; you get the error above. FWIW, I seem to have resolved the problem (see attached diff) by moving the find-ns clause above the resolve clause (in the cond); also the reference to namespace-doc needs to be var-quoted since namespace-doc is private.

[CLJ-945] clojure.string/capitalize can give wrong result if first char is supplementary

Fri, 1 Mar 2013 09:43:19 -0600

When the first unicode code point of a string is supplementary (i.e. requires two 16-bit Java chars to represent in UTF-16), and that first code point is changed by converting it to upper case, clojure.string/capitalize gives the wrong answer.

[CLJ-967] java.io/do-copy can still garble multibyte characters on IBM JDK 1.5 and 1.6

Fri, 1 Mar 2013 09:43:02 -0600

Same issue as ~~CLJ-886~~, but while the patch applied for that issue fixes the problem for many OS/JDK combos, there appear to be differences in how surrogate pair characters are handled in some OS/JDK combos. In particular, at least Linux + IBM JDK 1.5 and Linux + IBM JDK 1.6 still fail the tests checked in for do-copy.

[CLJ-1024] Varargs protococol impls can be defined but not called

Thu, 14 Feb 2013 10:03:07 -0600

The compiler accepts this:

(deftype foo []
clojure.lang.IFn
(invoke [this & xs]))

However calling ((foo.) :bar) will throw an AbstractMethodError. Wouldn't some checking be desirable?

[CLJ-1135] Add previous changelog items back to changes.md

Sat, 2 Feb 2013 16:32:09 -0600

Add previous changelog items back to changes.md

[CLJ-1111] Loops returning primtives are boxed even in return position

Sat, 22 Dec 2012 09:53:50 -0600

Reported here: https://groups.google.com/d/topic/clojure/atoFzbyuyos/discussion

(defn first-bit?
  {:inline (fn [n] `(== 1 (clojure.lang.Numbers/and ~n, 1)) )}
  [^long n]
  (== 1 (clojure.lang.Numbers/and n, 1)))

(defn exp-int
  ^double [^double x, ^long c]
  (loop [result 1.0, factor x, c c]
    (if (> c 0)
        (recur
         (if (first-bit? c)
           (* result factor)
           result),
         (* factor factor),
         (bit-shift-right c 1))
      result)))

Last lines of the Java bytecode of `exp-int`:

59 dload 5;               /* result */
61 invokestatic 40;       /* java.lang.Double java.lang.Double.valueOf(double c) */
64 checkcast 85;          /* java.lang.Number */
67 invokevirtual 89;      /* double doubleValue() */
70 dreturn;

The compiler doesn't currently infer the primitive type as soon as there is a recur:

(use '[clojure.contrib.repl-utils :only [expression-info]])
(expression-info '(loop [a 1] a))
;=> {:class long, :primitive? true}
(expression-info '(loop [a 1] (if true a (recur a)))
;=> nil

Patch attached.

[CLJ-1092] New function re-quote-replacement has incorrect :added metadata

Sat, 22 Dec 2012 09:53:50 -0600

I created the patch for ~~CLJ-870~~ that added the function re-quote-replacement before Clojure 1.4 was released, and I was apparently hoping it would get into that release. It is in now, but incorrectly states that fn re-quote-replacement was added in 1.4.

[CLJ-1091] update changes.md to include 1.5 changes

Tue, 11 Dec 2012 13:09:08 -0600

update changes.md to include 1.5 changes

[CLJ-788] Add source and line members and getters to CompilerException

Sun, 2 Dec 2012 17:41:54 -0600

To improve the reliability and ease of using CompilerException in tooling, add source path and line getters to CompilerException.

When handling compiler exceptions programmatically, the source path and line currently have to be parsed out of the compiler exception.

[CLJ-948] It would be very useful to be able to annotate the constructors of classes created with gen-class

Sat, 20 Oct 2012 09:53:42 -0500

gen-class currently provides a way to annotate methods, but not constructors.

when interoperating with java code that uses google juice heavily the ability to annotate constructors is required.

[CLJ-960] Capture :column metadata (needed for ClojureScript source maps)

Sat, 20 Oct 2012 09:53:42 -0500

I've begun working on implementing SourceMaps for ClojureScript. For an overview of SourceMaps, see: http://www.html5rocks.com/en/tutorials/developertools/sourcemaps/ For discussion of the feature in ClojureScript, see: https://groups.google.com/d/topic/clojure-dev/zgmXO2iM1JQ/discussion

In order to produce accurate source maps, I need column information in addition to line information from the Clojure reader.

I've made the necessary enhancement to LispReader, etc. but have some cleanup and testing left to do. I'd also like a sanity check from the core team before attaching a formal patch. You can find my work in progress here: https://github.com/brandonbloom/clojure/compare/columns

[CLJ-1066] No dependency on jsr166y

Sat, 20 Oct 2012 09:53:42 -0500

The Clojure 1.5.0-alpha4 jars that have been deployed to maven.org seem to have been compiled against JDK6 which causes
an exception if one tries to use reducers/fold.

— snip —
Setup:

user=> (require '[clojure.core.reducers :as r])
nil
user=> (def v (vec (range 10000)))
#'user/v

;; JDK7 + clojure 1.5.0-alpha4 from maven.org
;; → :dependencies [[org.clojure/clojure "1.5.0-alpha4"]] in project.clj

user=> (r/fold + (r/map inc v))
ClassNotFoundException jsr166y.ForkJoinTask java.net.URLClassLoader$1.run (URLClassLoader.java:366)

;; JDK7 + clojure 1.5.0-alpha4 from maven.org
;; → :dependencies [[org.clojure/clojure "1.5.0-alpha4"]
;; [org.codehaus.jsr166-mirror/jsr166y "1.7.0"]]

user=> (r/fold + (r/map inc v))
50005000

;; JDK7 + clojure 1.5.0-alpha4 locally compiled (mvn install) against OpenJDK7
;; → :dependencies [[org.clojure/clojure "1.5.0-alpha4"]] in project.clj

user=> (r/fold + (r/map inc v))
5000050000
— snip —

It would be wonderful if this issue could be fixed before the release of 1.5.0.

Have a nice day

Wolodja

[CLJ-1070] PersistentQueue's hash function does not match its equality

Sat, 20 Oct 2012 09:53:42 -0500

There are two issues:

1) PersistentQueue's hash function doesn't match its equiv function:

(def iq (conj clojure.lang.PersistentQueue/EMPTY (Integer. -1)))
(def lq (conj clojure.lang.PersistentQueue/EMPTY (Long. -1)))
[(= iq lq) (= (hash iq) (hash lq))]
;=> [true false]

2) PersistentQueue's hash function doesn't match PersistentVector's hash:

(def q (conj clojure.lang.PersistentQueue/EMPTY 1 2 3))
[(= [1 2 3] q) (= (hash [1 2 3]) (hash q))]
;=> [true false]

[CLJ-1085] clojure.main/repl unconditionally refers REPL utilities into ns

Sat, 20 Oct 2012 09:53:42 -0500

A number of vars from clojure.repl, clojure.java.javadoc, and clojure.pprint are unconditionally referred into *ns* by clojure.main/repl. This is fine when it is being used e.g. as the primary driver of a terminal-bound Clojure REPL, but other usages can end up bringing those utility vars into namespaces other than 'user. This can cause problems if clojure.main/repl is used to drive a REPL within namespaces that already have referred or interned vars with the same names as those utility vars, e.g.:

$ java -jar ~/.m2/repository/org/clojure/clojure/1.5.0-alpha6/clojure-1.5.0-alpha6.jar
Clojure 1.5.0-alpha6
user=> (ns foo)
nil
foo=> (defn pp [] "hi!")
#'foo/pp
foo=> (pp)
"hi!"
foo=> (clojure.main/repl)
foo=> (pp)
nil
nil
foo=> (defn pp [] "whoops")
CompilerException java.lang.IllegalStateException: pp already refers to: #'clojure.pprint/pp in namespace: foo, compiling:(NO_SOURCE_PATH:7:1)

Worse, nREPL uses clojure.main/repl (in large part to maximize the consistency of REPL behaviour across different Clojure versions), where each user expression is evaluated through a separate clojure.main/repl invocation. This leads to the same problems as above, but for every nREPL user, session, and expression (reported @ ~~NREPL-31~~).

A simple fix for this is to perform these refers only if *ns* is 'user (which, AFAICT, was the only intended effect of ~~CLJ-310~~, ~~CLJ-454~~, and https://github.com/clojure/clojure/commit/04764db, the changes that added these automatic implicit refers to clojure.main/repl).

[CLJ-917] clojure.core/definterface is not included in the API docs

Sat, 20 Oct 2012 09:53:42 -0500

Is definterface meant to be a public API? If yes, then it needs a docstring.

[CLJ-1052] assoc should throw exception if missing val for last key

Sat, 20 Oct 2012 09:53:42 -0500

https://groups.google.com/forum/?fromgroups=#!topic/clojure/k2R4OdPUCzg

Suggested by Ambrose Bonnaire-Sergeant:

I think assoc should throw an error when applied with uneven arguments.

Currently, the "missing" value is just replaced with nil.

(assoc {} :a 1 :b)
;=> {:a 1, :b nil}

[CLJ-1061] when-first double evaluation

Sat, 20 Oct 2012 09:53:42 -0500

The when-first macro will evaluate the xs expression twice. Admittedly, it does exactly what the doc string says, but that seems undesirable to me. Even without side effects, there's a potential performance issue if xs is some expensive operation.

Patch attached. The main diff is:

- `(when (seq ~xs)
- (let [~x (first ~xs)]
- ~@body))))
+ `(when-let xs# (seq ~xs)
+ (let ~x (first xs#)
+ ~@body))))

[CLJ-1084] (object-array [1]) is ~3x slower than (object-array (rseq [1]))

Sat, 20 Oct 2012 09:53:42 -0500

{{user=> (time (dotimes [_ 10000000] (object-array [1])))
"Elapsed time: 1178.116257 msecs"
nil
user=> (time (dotimes [_ 10000000] (object-array (rseq [1]))))
"Elapsed time: 422.42248 msecs"
nil}}

This appears to be because PersistentVector$ChunkedSeq does not implement Counted, so RT.count is iterating the ChunkedSeq to get its count.

[CLJ-1065] Allow duplicate set elements and map keys for all set and map constructors

Thu, 4 Oct 2012 10:15:06 -0500

See description here http://dev.clojure.org/display/design/Allow+duplicate+map+keys+and+set+elements

[CLJ-988] the locking in MultiFn.java (synchronized methods) can cause lots of contention in multithreaded programs

Fri, 21 Sep 2012 14:21:33 -0500

if you call a single multimethod a lot in multithreaded code you get lots of contention for the lock on the multimethod. this contention slows things down a lot.

this is due to getMethod being synchronized. it would be great if there was some fast non-locking path through the multimethod.

[CLJ-1071] ExceptionInfo does no abstraction

Fri, 21 Sep 2012 14:21:33 -0500

There oughtta be an interface

[CLJ-940] Passing a non-sequence to refer :only results in uninformative exception

Sat, 1 Sep 2012 08:37:48 -0500

Compiling the following code results in a Don't know how to create ISeq from: clojure.lang.Symbol exception

code
(ns clj14.myns
(:use
[clojure.core :only seq]))
code

[CLJ-910] [Patch] Allow for type-hinting the method receiver in memfn

Sat, 1 Sep 2012 08:37:48 -0500

The attached patch copies metadata given to the method name symbol of memfn to the method receiver in the expansion. That way, memfn is able to be used even for type-hinted calls resulting in a big performance win.

user> (time (dotimes [i 1000000] ((memfn intValue) 1)))
Reflection warning, NO_SOURCE_FILE:1 - call to intValue can't be resolved.
"Elapsed time: 2579.229115 msecs"
nil
user> (time (dotimes [i 1000000] ((memfn ^Number intValue) 1)))
"Elapsed time: 12.015235 msecs"
nil

[CLJ-963] Support pretty printing namespace declarations under code-dispatch

Sat, 1 Sep 2012 08:37:48 -0500

Currently when you print code with an (ns ) declaration in it, the ns declaration comes out kind of messy. This patch makes that beautiful.

[CLJ-1034] "Conflicting data-reader mapping" triggered when the same data_readers.clj is on the classpath twice

Sat, 1 Sep 2012 08:37:48 -0500

If you have two data_readers.clj files on the classpath that agree with one another about the mapping of a given literal, Clojure still claims there is a conflict.

[CLJ-828] clojure.core/bases returns a cons when passed a class and a Java array when passed an interface

Sat, 18 Aug 2012 09:19:35 -0500

clojure.core/bases returns a clojure.lang.Cons when called with a class as parameter, but a Java array ( [Ljava.lang.Class; ) when called with an interface. Both should return values of the same type, which I guess should be a seq.

Showing the problem at the REPL:
user=> (bases java.util.List)
#<Class[] [Ljava.lang.Class;@315b0333>
user=> (bases java.util.ArrayList)
(java.util.AbstractList java.util.List java.util.RandomAccess
java.lang.Cloneable java.io.Serializable)

I have attached a patch which calls the seq function on the else part of clojure.core/bases. Also updated the clojure.test-clojure.java-interop/test-bases test. However these test do not currently seem to run as part of the maven build. I have however run the test manually and verified that it works.

[CLJ-745] gen-class should allow exposes-methods to expose protected final methods

Sat, 18 Aug 2012 07:50:41 -0500

Currently, there is no way in Clojure to call a protected final method of a superclass. While this may be an acceptable limitation for proxy, gen-class should provide that ability. Otherwise, one is now forced to create a dummy subclass in Java for the sole purpose of widening the visibility of such methods.

My patch makes it so that protected final methods may be exposed via the :exposes-methods mechanism. It is still impossible to override them.

[CLJ-757] Empty transient maps/sets return wrong value for .contains

Sat, 18 Aug 2012 07:50:41 -0500

As explained in http://groups.google.com/group/clojure/browse_thread/thread/496ffc7fb9058699/6e9d8152b6fd6365?show_docid=6e9d8152b6fd6365, (.contains (transient #{}) :some-key) returns true instead of false. (contains? #{} :some-key) works properly, but the plain .contains method does not.

The issue is in TransientHashMap.doValAt(key, notFound), and the attached patch is a simple fix with test.

[CLJ-916] into loses metadata

Sat, 18 Aug 2012 07:50:41 -0500

The into fn loses metadata.

I'm seeing some team members (myself included) rely on metadata. Metadata has been incredibly useful in some cases, however the silent destruction of metadata by core clojure fns (into, walk, etc) have been a source of increasing complexity and confusion.

A team member could start relying on a 3rd party library that used 'into'. Actually, the into fn could essentially be added to the code base at any time in many ways. Wrt metadata the potential for incidental complexity increases exponentially as more developers and libraries enter the mix.

One of the reasons Clojure has worked for us so well is because it has greatly reduced incidental complexity.
IMHO the 'into metadata bug' seriously limits the usefulness of metadata and would love to see the into fn fixed in 1.4.

[CLJ-870] clojure.string/replace behaves unexpectedly when \ or $ are part of the result string

Sat, 18 Aug 2012 07:50:41 -0500

clojure.string/replace uses javas replace function to do it's work, the replace function has the tricky habit of 'double evaluating' the replacement string (third argument). This means that every \ in the string (so i.e. "
") is evaluated by the java code behind replace.

Since this behavior isn't documented it can lead to confusing errors, for example (made up semi real world example to explain the issue):

(clojure.string/replace "c:/windows/" #"/" "\\")

This should replace all unix folder separators with windows separators, this crashes with a index out of bound exemption since java tries to evaluate "
" as a semi regexp.

(println (str "\"" (clojure.string/replace "my string with \\ and \" in it" #"[\"\\]" (fn [x] (str "\\" x))) "\""))

The expected result would be:

"my string with \\ and \" in it"

the actual result is:

"my string with \ and " in it"

This should return an 'escaped' string, it does not since the 'double evaluation' of the return string results in \\\\ being reduced to
again.

[CLJ-909] Make LineNumberingPushbackReader's buffer size configurable

Sat, 18 Aug 2012 07:50:41 -0500

In some situations, it's necessary to configure the buffer size of LineNumberingPushbackReader's wrapped java.io.LineNumberReader, that gets created in the constructor. A concrete problem case is where you want to avoid doing reads from the underlying Reader whenever possible, so using a buffer size of 1 makes it a bit lazier. I can also imagine cases where you'd want to increase the buffer from java.io.BufferedReader's 8192-char default, but I haven't dealt with that one directly.

There's no good way to do this by subclassing LineNumberingPushbackReader, since all the action happens in the constructors: those of java.io.LineNumberReader and the superclass of LineNumberingPushbackReader, which is java.io.PushbackReader. So my current workaround is to copy the entirety of LineNumberingPushbackReader, change the name, and add a constructor. Having LineNumberingPushbackReader support this directly would be great.

Both java.io.LineNumberReader and java.io.PushbackReader have constructors that accept the buffer size as the second argument, so it seems very reasonable to me to add a similar constructor for LineNumberingPushbackReader.

[CLJ-932] contains? should throw exception on non-keyed collections

Sat, 18 Aug 2012 07:50:41 -0500

The contains? function, given a collection which is not an associative (Map, Set, String, array), returns false instead of throwing an exception.

This is a subject of confusion when people call contains? on sequential collections like lists, and on associative collections which do not implement the Associative interface.

Other predicates, such as even?, throw an exception when passed arguments of an invalid type.

[CLJ-966] Add support for marker protocols

Sat, 18 Aug 2012 07:50:41 -0500

The attached patch adds support to marker protocols, for example

(defprotocol Sequential
"marker protocol indicating a sequential type")

[CLJ-923] Reading ratios prefixed by + is not working

Sat, 18 Aug 2012 07:12:53 -0500

In general Clojure's number types can be read prefixed with either a +
or - and this seems to work correctly for reading integers and floats.
In the case of ratios however things break down when ratios are
prefixed with a +.

The ratio pattern in LispReader.java does match on ratios starting
with both + and - but matchNumber fails on ratios prefixed with +
because it ends up calling "new BigInteger(m.group(1))" and it turns
out the constructor for BigInteger has no problems with negative
numbers but it doesn't like numbers prefixed by a +.

[CLJ-1041] reduce-kv on sorted maps should stop on seeing a Reduced value

Sat, 18 Aug 2012 07:12:53 -0500

The current implementation is dereferencing Reduced and returning them up the chain; but that means that parent nodes don't know the reduction has completed, so the reduction might continue along other paths down the tree.

This patch touches the same areas of code as ~~CLJ-1040~~ so will have conflicts if both patches are merged separately. However, as noted in my comment on ~~CLJ-1040~~, I don't think the patch there is correct yet, so I've also included a commit (7beb14256) to fix the issue in ~~CLJ-1040~~. Thus, this patch can be merged independently of 1040's patch, solving both issues without a merge conflict.

This patch also includes tests for both issues, which fail before my commits are applied, and pass afterwards.

[CLJ-977] (int \a) returns a value, (long \a) throws an exception

Sat, 18 Aug 2012 07:12:53 -0500

As described in the summary, calling (long ...) on a character throws a ClassCastException. I know the semantics surrounding numbers has changed a bit, but I think it would be nice for this to be consistent.

[CLJ-1009] make print-table org mode compatible

Sat, 18 Aug 2012 07:12:53 -0500

make print-table org mode compatible

[CLJ-964] test-clojure/rt.clj has undeclared dependency on clojure.set

Sat, 18 Aug 2012 07:12:53 -0500

In test-clojure/rt.clj, the test last-var-wins-for-core evaluates #'clojure.set/subset?. This fails unless clojure.set has been loaded. In the normal run of the test suite, this dependency is satisfied by test-clojure/core-set being loaded first.

[CLJ-1011] clojure.data/diff should cope with null and false values in maps

Sat, 18 Aug 2012 07:12:52 -0500

Current behaviour of clojure.data/diff:

=> (diff {:a false} {:a true})
(nil {:a true} nil)
=> (diff {:a false} {:a nil})
(nil nil nil)

Proposed behaviour:

=> (diff {:a false} {:a true})
({:a false} {:a true} nil)
=> (diff {:a false} {:a nil})
({:a false} {:a nil} nil)

[CLJ-1012] partial function should also accept 1 arg (just f)

Sat, 18 Aug 2012 07:12:52 -0500

The partial function should accept just a function. This allows it to be properly used with apply.

E.g. This breaks (but shouldn't) if args are nil: (apply partial f args)

[CLJ-1019] ns-resolve doc has a typo

Sat, 18 Aug 2012 07:12:52 -0500

The doc string for ns-resolve has a typo: environement should be environment.

[CLJ-820] int coercion doesn't work in clojure 1.3

Fri, 20 Jul 2012 16:54:48 -0500

Using the clojure git head as of 2011-07-14 (commit f704853751d02faf72bd53be599ee0be6c1da63e), int coercion doesn't work:

user> (class (int 1))
java.lang.Long

byte, short, double, and float coercion work fine, though:

user> (class (byte 1))
java.lang.Byte
user> (class (short 1))
java.lang.Short
user> (class (double 1))
java.lang.Double
user> (class (float 1))
java.lang.Float

Also creating integers directly works fine:

user> (class (Integer. "100"))
java.lang.Integer
user> (class (Integer/valueOf 1))
java.lang.Integer
user> (class (Integer. 100))
java.lang.Integer

This is probably related to ~~CLJ-439~~.

[CLJ-844] NPE calling keyword on map from bean

Fri, 15 Jun 2012 11:09:26 -0500

Calling a keyword on a map returned from clojure.core/bean causes a null pointer exception if the keyword is not a key in the map:

user=> (:a (bean {}))
java.lang.NullPointerException (NO_SOURCE_FILE:0)
user=> (.printStackTrace *e)
Caused by: java.lang.NullPointerException
at clojure.core$bean$v__4765.invoke(core_proxy.clj:385)
at clojure.core$bean$fn__4786.invoke(core_proxy.clj:394)
at clojure.core.proxy$clojure.lang.APersistentMap$0.valAt(Unknown Source)
at clojure.lang.KeywordLookupSite.fault(KeywordLookupSite.java:33)
at user$eval1062.invoke(NO_SOURCE_FILE:7)
at clojure.lang.Compiler.eval(Compiler.java:5424)
... 9 more

The object returned by bean claims to be an APersistentMap FWIW:

user=> (class (bean {}))
clojure.core.proxy$clojure.lang.APersistentMap$0

[CLJ-943] When load-lib fails, a namespace is still created

Fri, 15 Jun 2012 11:09:26 -0500

When requiring a namespace that doesn't compile, a namespace is still created. The attached patch removes the namespace on failure if the namespace wasn't already present on entry to load-lib. See the test case in the patch for repro instructions.

This is obviously a subset of having atomic loads. Would a step further in this direction, e.g. using a swapable state object within clojure.lang.Namespace be of interest?

[CLJ-667] Allow loops fully nested in catch/finally

Fri, 15 Jun 2012 11:09:26 -0500

~/clj-git/clojure $ java -cp clojure.jar clojure.main
Clojure 1.3.0-alpha2-SNAPSHOT
user=> (try (catch Exception e (loop [x 0] (recur x))))
CompilerException java.lang.UnsupportedOperationException: Cannot recur from catch/finally, compiling:(NO_SOURCE_PATH:1)
user=> (try (finally (loop [x 0] (if false (recur x)))))
CompilerException java.lang.UnsupportedOperationException: Cannot recur from catch/finally, compiling:(NO_SOURCE_PATH:2)

With attached patch (should also fix ~~CLJ-31~~):

~/clj-head/clojure $ java -cp clojure.jar clojure.main
Clojure 1.3.0-alpha2-SNAPSHOT
user=> (try (catch Exception e (loop [x 0] (recur x))))
nil
user=> (try (finally (loop [x 0] (if false (recur x)))))
nil
user=> (loop [x 0] (try (if false (recur x))))
CompilerException java.lang.UnsupportedOperationException: Can only recur from tail position, compiling:(NO_SOURCE_PATH:3)
user=> (loop [x 0] (try (catch Exception e (recur x))))
CompilerException java.lang.UnsupportedOperationException: Can only recur from tail position, compiling:(NO_SOURCE_PATH:4)
user=> (loop [x 0] (try (finally (recur x))))
CompilerException java.lang.UnsupportedOperationException: Can only recur from tail position, compiling:(NO_SOURCE_PATH:5)

[CLJ-768] cl-format bug in ~f formatting

Fri, 15 Jun 2012 11:09:26 -0500

Carlos Ungil reports a bug in cl-format as follows (http://groups.google.com/group/clojure/browse_thread/thread/bb235ff4464aed78#):

Hello,

I don't know if there is a better way to file bug reports (if there is one,
it's not easy to find).

(use 'clojure.pprint)

(let [x 111.11111]
(doseq [fmt ["~3f~%" "~4f~%" "~5f~%" "~6f~%"]]
(cl-format true fmt x)))

;; 111.11111
;; 111.11111
;; 111.1
;; 111.11

There is clearly a problem in the first two cases, too many digits are being
printed.

For reference, this is what common lisp does:

(let ((x 111.11111))
(loop for fmt in '("_3f%" "_4f%" "_5f%" "_6f%")
do (format t fmt x)))

;; 111.
;; 111.
;; 111.1
;; 111.11

Cheers,

Carlos

[CLJ-897] deftype error message is misleading not useful

Fri, 15 Jun 2012 11:09:26 -0500

If you forget to include the argument vector for deftype, i.e.

(deftype second-request-handler
HttpServer.RequestHandler
(canRespond [this request] true)
(getResponse [this request] nil))

which should be...

(deftype second-request-handler []
HttpServer.RequestHandler
(canRespond [this request] true)
(getResponse [this request] nil))

I get the error message..

Don't know how to create ISeq from: clojure.lang.Symbol (main.clj:1)

When in fact the error is coming from (second-request-handler.clj:3). Can this error message be improved and give the actually location of the error?

[CLJ-934] disj! throws exception when attempting to remove multiple items in one call

Fri, 15 Jun 2012 11:09:26 -0500

disj! fails whenever called with multiple items to remove:

user=> (-> #{5 10 15 20} transient (disj! 10 15) persistent!)
ClassCastException clojure.lang.PersistentHashSet$TransientHashSet cannot be cast to clojure.lang.IPersistentSet clojure.core/disj (core.clj:1419)

It is a simple one line fix to disj! Clojure source code to correct this.

[CLJ-981] clojure.set/rename-keys deletes keys when there's a collision

Fri, 15 Jun 2012 11:09:26 -0500

(set/rename-keys {:a "one" :b "two" :c "three"} {:a :b :b :a}) returns {:b "one" :c "three"}
should be {:a "two" :b "one" :c "three"}

I have created a pull request for a fix, here: https://github.com/clojure/clojure/pull/23

[CLJ-763] Do not use hash-map constructor in destructuring to avoid multiple key check.

Fri, 18 May 2012 20:37:21 -0500

What I did:

(defn number-to-string
  [& {fmt :format locale :locale :or {locale (Locale/getDefault)}}]
  (fn [v]
    (String/format locale fmt (to-array [v]))))

(defn double-to-string
  [& options]
  (apply number-to-string :format "%f" options))

(def us-number (double-to-string :locale Locale/US))
(def legacy-number (double-to-string :format "% 3.2f"))

(us-number 3.14159)
(legacy-number 3.14159)

What I expected:

"3.14159"
"  3,14"

What I got:

java.lang.IllegalArgumentException: Duplicate key: :format

Using into or a combination of reduce and assoc instead of hash-map would allow this without breaking things.

If this is a desired modification, I can provide a patch. (CA is filed.)

[CLJ-867] Records of different types with the same data have the same hashcodes, even though they are not considered to be equal

Fri, 18 May 2012 20:37:11 -0500

Records which contain the same field values are not considered to be equal, but the record type is not currently included in the hash. This means that if an heterogenous map contains records of different types, where the fields aren't necessarily distinct, there is a high likelyhood of hash collisions.

I propose that the record type should be included in the hash code algorithm for records. There should be no expectation that unequal records of different types should have the same hash-code.

user=> (hash (->A 1))
1013911913
user=> (hash (->B 1))
1013911913
user=> (= (~~>A 1) (~~>B 1))
false

This issue also affects ClojureScript. But see CLJS-97, as ClojureScript also has an issue with record equality.

[CLJ-881] Problem with the "cl-format" function from the clojure.pprint

Fri, 18 May 2012 20:37:04 -0500

Let's see the following scenario:

vdim@home:~/clojure$ git log -1
commit ba930d95fc3a4a78c5bd6756ea483c9dac681618
Author: Rich Hickey <richhickey@gmail.com>
Date: Sun Oct 30 10:44:55 2011 -0400

inline equiv in variadic =
vdim@home:~/clojure$ rlwrap java -cp clojure-1.4.0-master-SNAPSHOT.jar clojure.main
Clojure 1.4.0-master-SNAPSHOT
user=> (use 'clojure.pprint)
nil
user=> (cl-format nil "~12,10F" 1.00000000074)
"1.0000000007"
user=> (cl-format nil "~12,10F" 1.00000000076)
NumberFormatException For input string: "10000000007" java.lang.NumberFormatException.forInputString (NumberFormatException.java:65)
user=>

The exception is caused from round-str function (cl-format.clj) where
my number (100000000076) is coerced to an Integer (see line with Integer/valueOf code
into this function).

Is this normal behaviour?

See patch with tests and my suggestion for solving this problem.

[CLJ-892] sort changes its argument, if a Java array

Fri, 18 May 2012 12:35:48 -0500

user> (let [a (to-array [32 11])]
(prn (seq a))
(sort a)
(prn (seq a)))
(32 11)
(11 32)
nil

Where the second line printed ought to be the same as the first.

[CLJ-952] bigdec does not properly convert a clojure.lang.BigInt

Fri, 18 May 2012 12:32:12 -0500

bigdec handles java.math.BigInteger when converting to java.math.BigDecimal, but it does not handle clojure.lang.BigInt. Instead it treats a clojure.lang.BigInt as a Number, by casting it to long. This causes the following error:

Clojure 1.4.0-beta3
user=> (bigdec (inc (bigint Long/MAX_VALUE)))
IllegalArgumentException Value out of range for long: 9223372036854775808 clojure.lang.RT.longCast (RT.java:1123)

[CLJ-893] crafted `vec' call allows created vector to be mutated

Fri, 18 May 2012 12:32:03 -0500

user> (let [a (to-array (repeat 31 0)), v (vec a)]
        [(v 2) (do (aset a 2 'no) (v 2))])
[0 no]
user> (let [a (to-array (repeat 33 0)), v (vec a)]
        [(v 2) (do (aset a 2 'no) (v 2))])
[0 0]

While a relaxation of when different changes to the environment are made may impact the resulting value of the vector, as it is with lazy seqs, it oughtn't be possible to get two different results for the same access, just as with lazy seqs.

[CLJ-730] Create test suite for functional fns (e.g. juxt, comp, partial, etc.)

Fri, 18 May 2012 12:31:51 -0500

The tests in other_functions.clj for the combinator functions are tenuous in some cases (comp) and missing in others (juxt, partial, complement, and constantly). It would be nice to have a full suite of combinator tests moving forward.

I would be happy to write the needed tests.

[CLJ-103] GC Issue 99: Incorrect error with if-let

Fri, 18 May 2012 12:26:37 -0500

Reported by rosejn, Mar 19, 2009

Example:
user=> (if-let [foo (+ 1 2)] foo + 1 foo)
java.lang.IllegalArgumentException: if-let requires a vector for its
binding (NO_SOURCE_FILE:2)

The error reports that if-let requires a vector for its binding, but the
problem here has nothing to do with the binding being a vector.  A paren
was forgotten before the '+', so the number of arguments is incorrect for
the if form.

[CLJ-962] Vectors returned by subvec allow access at negative indices

Fri, 18 May 2012 10:03:07 -0500

Google group thread: https://mail.google.com/mail/?shva=1#label/clojure/1365e058eaf0d5fa

Vectors returned by subvec correctly disallow access to elements after their end, but not before their beginning.

Clojure 1.3.0
user=> (def v1 (vec (range 100)))
#'user/v1
user=> (def v2 (subvec v1 50 52))
#'user/v2
user=> (v2 3)
IndexOutOfBoundsException clojure.lang.APersistentVector$SubVector.nth (APersistentVector.java:526)
user=> (v2 -48)
2

Clojure JIRA

[CLJ-1161] sources jar has bad versions.properties resource

[CLJ-944] compiler makes different concrete maps then the reader

[CLJ-1018] range's behavior is inconsistent

[CLJ-1154] Compile.java closes out preventing java from reporting exceptions

[CLJ-927] default tagged literal reader

[CLJ-1000] Performance drop in PersistentHashMap.valAt(...) in v.1.4 -- Util.hasheq(...) ?

[CLJ-1032] seque leaks threads from the send-off pool

[CLJ-1048] add test.generative to Clojure's tests

[CLJ-1106] Broken equality for sets

[CLJ-1116] More REPL-friendly 'ns macro

[CLJ-1140] {:as x} destructuring with an empty list raises exception

[CLJ-157] Need better error report when omitting parameter list from (fn) or (defn)

[CLJ-779] Document clojure.org differences between 1.2 and 1.3

[CLJ-936] Improve docs about argument destructuring at clojure.org

[CLJ-990] Implement clojure.core.reducers/mapcat and some initial reducers tests

[CLJ-1098] Extend CollFold and IKVReduce to nil

[CLJ-1062] CLJ-940 breaks compilation of namespaces that don't have any public functions

[CLJ-985] make jsr166 available at build time

[CLJ-987] pprint doesn't flush the underlying stream

[CLJ-1150] Make some PersistentVector, SubVector internals public

[CLJ-902] doc macro broken for namespaces

[CLJ-945] clojure.string/capitalize can give wrong result if first char is supplementary

[CLJ-967] java.io/do-copy can still garble multibyte characters on IBM JDK 1.5 and 1.6

[CLJ-1024] Varargs protococol impls can be defined but not called

[CLJ-1135] Add previous changelog items back to changes.md

[CLJ-1111] Loops returning primtives are boxed even in return position

[CLJ-1092] New function re-quote-replacement has incorrect :added metadata

[CLJ-1091] update changes.md to include 1.5 changes

[CLJ-788] Add source and line members and getters to CompilerException

[CLJ-948] It would be very useful to be able to annotate the constructors of classes created with gen-class

[CLJ-960] Capture :column metadata (needed for ClojureScript source maps)

[CLJ-1066] No dependency on jsr166y

[CLJ-1070] PersistentQueue's hash function does not match its equality

[CLJ-1085] clojure.main/repl unconditionally refers REPL utilities into *ns*

[CLJ-917] clojure.core/definterface is not included in the API docs

[CLJ-1052] assoc should throw exception if missing val for last key

[CLJ-1061] when-first double evaluation

[CLJ-1084] (object-array [1]) is ~3x slower than (object-array (rseq [1]))

[CLJ-1065] Allow duplicate set elements and map keys for all set and map constructors

[CLJ-988] the locking in MultiFn.java (synchronized methods) can cause lots of contention in multithreaded programs

[CLJ-1071] ExceptionInfo does no abstraction

[CLJ-940] Passing a non-sequence to refer :only results in uninformative exception

[CLJ-910] [Patch] Allow for type-hinting the method receiver in memfn

[CLJ-963] Support pretty printing namespace declarations under code-dispatch

[CLJ-1034] "Conflicting data-reader mapping" triggered when the same data_readers.clj is on the classpath twice

[CLJ-828] clojure.core/bases returns a cons when passed a class and a Java array when passed an interface

[CLJ-745] gen-class should allow exposes-methods to expose protected final methods

[CLJ-757] Empty transient maps/sets return wrong value for .contains

[CLJ-916] into loses metadata

[CLJ-870] clojure.string/replace behaves unexpectedly when \ or $ are part of the result string

[CLJ-909] Make LineNumberingPushbackReader's buffer size configurable

[CLJ-932] contains? should throw exception on non-keyed collections

[CLJ-966] Add support for marker protocols

[CLJ-923] Reading ratios prefixed by + is not working

[CLJ-1041] reduce-kv on sorted maps should stop on seeing a Reduced value

[CLJ-977] (int \a) returns a value, (long \a) throws an exception

[CLJ-1009] make print-table org mode compatible

[CLJ-964] test-clojure/rt.clj has undeclared dependency on clojure.set

[CLJ-1011] clojure.data/diff should cope with null and false values in maps

[CLJ-1012] partial function should also accept 1 arg (just f)

[CLJ-1019] ns-resolve doc has a typo

[CLJ-820] int coercion doesn't work in clojure 1.3

[CLJ-844] NPE calling keyword on map from bean

[CLJ-943] When load-lib fails, a namespace is still created

[CLJ-667] Allow loops fully nested in catch/finally

[CLJ-768] cl-format bug in ~f formatting

[CLJ-897] deftype error message is misleading not useful

[CLJ-934] disj! throws exception when attempting to remove multiple items in one call

[CLJ-981] clojure.set/rename-keys deletes keys when there's a collision

[CLJ-763] Do not use hash-map constructor in destructuring to avoid multiple key check.

[CLJ-867] Records of different types with the same data have the same hashcodes, even though they are not considered to be equal

[CLJ-881] Problem with the "cl-format" function from the clojure.pprint

[CLJ-892] sort changes its argument, if a Java array

[CLJ-952] bigdec does not properly convert a clojure.lang.BigInt

[CLJ-893] crafted `vec' call allows created vector to be mutated

[CLJ-730] Create test suite for functional fns (e.g. juxt, comp, partial, etc.)

[CLJ-103] GC Issue 99: Incorrect error with if-let

[CLJ-962] Vectors returned by subvec allow access at negative indices

[CLJ-1085] clojure.main/repl unconditionally refers REPL utilities into ns