Clojure JIRA

[CLJ-826] Include drop, take, butlast from clojure.contrib.string (1.2) in clojure.string 1.3

Fri, 2 Dec 2011 09:14:37 -0600

From clojure.contrib.string 1.2, I have found myself using drop, take,
and butlast. (These are more than just wrappers for String/substring,
because they behave nicely when indices exceed the string length.) I
like these methods in part because they match the behavior of
corresponding sequence methods, but have better performance. This
makes optimizing (when needed) easier.

[CLJ-806] clojure.test/are does not fail with insufficient arguments

Thu, 16 Feb 2012 11:43:13 -0600

If clojure.test/are is given an argument set with missing parameters, it silently ignores the extra parameters at the end instead of failing.

Clojure 1.3.0-master-SNAPSHOT
user=> (use 'clojure.test)
nil
user=> (deftest foo (are [x y] (= x y) 1 1 2 2 3 4))
#'user/foo
user=> (foo)

FAIL in (foo) (NO_SOURCE_FILE:6)
expected: (= 3 4)
  actual: (not (= 3 4))
nil
user=> (deftest missing-argument (are [x y] (= x y) 1 1 2 2 3))
#'user/missing-argument
user=> (missing-argument)
nil  ;; doesn't fail

[CLJ-785] Optimize /

Fri, 13 May 2011 09:26:14 -0500

Optimization to / such that the & more version expands to equivalent of (/ x (reduce * y more)) rather than (reduce / (/ x y) more). There should be an inlined variant of & more as well.

This was originally part of ~~CLJ-184~~, but was pulled out because it's big enough to be its own ticket. The rationale is that multiplies are significantly faster than divides on the JVM, and n-ary calls to / could be faster.

See "Java Multiplication (Much) Faster than Division" for background and Java benchmarks.

[CLJ-732] (keyword "") can be printed, but not read

Fri, 29 Jul 2011 07:49:21 -0500

user=> (keyword "")
:
user=> (prn-str *1)
":\n"
user=> (read-string *1)
java.lang.RuntimeException: java.lang.Exception: Invalid token: : (NO_SOURCE_FILE:0)

This obviously isn't a huge defect, but I'd argue that anything that can be printed should be readable.

[CLJ-720] check that argument to keys/vals is a Map

Fri, 28 Jan 2011 09:24:22 -0600

Current behavior:

If you call keys or vals on something that is not a Map, you do not get a ClassCastException until the KeySeq or ValSeq is consumed

Calling keys or vals on an empty collection of any type, even non-Map types, returns nil

The attached patch:

checks the type of the argument to keys and vals and throws IllegalArgumentException if it is neither java.util.Map nor null

changes tests for keys and vals to check that those functions throw IllegalArgumentException on empty collections that are not maps

[CLJ-466] Reflection incorrectly avoids "More than one matching method" exceptions

Mon, 15 Nov 2010 12:49:00 -0600

From the google group:

The following correctly throws an IllegalArgumentException "More than one matching method" due to the nil resulting in ambiguity between two overloaded version of append.

(let [sb (StringBuilder.)]
  (.append sb nil))</code></pre>And yet the following, which uses reflection, works:
<pre><code>(def s nil)
(let [sb (StringBuilder.)]
  (.append sb s))

This is due to a divergence in method resolution between direct and reflected calls. Both examples should result in an exception due to ambiguity.

[CLJ-464] RFE: Run FindBugs on Clojure source code

Fri, 7 Oct 2011 07:33:23 -0500

I ran FindBugs (http://findbugs.sourceforge.net/ExampleName) on a small Clojure program that I am writing and got multiple warnings on code from the clojure libraries.

It might be helpful to run this on the source code base. It might uncover some actual bugs .

[CLJ-463] Strip leading colons when creating keywords from single strings

Fri, 19 Nov 2010 10:07:07 -0600

This seems unfortunate:

=> (-> :foo str keyword)
::foo

Symbols are far saner in this regard:

=> (-> 'foo str symbol)
foo

Simply stripping leading colons from strings prior to turning them into keywords should suffice. The 2-arity Keyword.intern method and clojure.core/keyword fn should be left intact, so as to provide an escape hatch for those that really do need colon-prefixed keywords.

[CLJ-461] require namespace implicitly

Tue, 21 Jun 2011 18:41:38 -0500

Referencing a function with a fully-qualified namespace should work without first using require or use, similar to how a fully-qualified java class can be used without importing it.

It's a small change in Compiler that tries to call (require x) if the fully qualified classname is not found. This should give priority to the java class, which protects backwards compatibility. There is no runtime performance impact, only compile time (the first time the namespace is seen). The fact that code (the namespace) is loaded during compilation of a form is no different than loading code to look up a java class.

This makes it easier to write quick scripts as in the example below, also to use one-liners in the repl or ad hoc in code.

For example: java -cp src/clj/:classes clojure.main -e "(clojure.set/union #{1} #{2})"

Currently on master, this produces: Exception in thread "main" java.lang.ClassNotFoundException: clojure.set
but this works: java -cp src/clj/:classes clojure.main -e "(require 'clojure.set) (clojure.set/union #{1} #{2})"

Obviously, (use) would make the code shorter, but my goal is to make it implicit.

Discussion: http://groups.google.com/group/clojure-dev/t/69823ce63dd94a0c

[CLJ-455] Calculating large numbers results in java.math.BigIntegerArithmeticException

Sat, 23 Oct 2010 22:52:00 -0500

(class (* 1000 1000 1000 1000 1000 1000 1000))
1.1 returns : java.math.BigInteger
1.3.0-alpha returns : java.math.BigIntegerArithmeticException integer overflow clojure.lang.Numbers.throwIntOverflow (Numbers.java:1575)

[CLJ-449] NullPointerException in clojure.stacktrace

Fri, 5 Nov 2010 11:05:12 -0500

See http://groups.google.com/group/clojure-dev/browse_thread/thread/f4157c68df730bd9

clojure.stacktrace/print-trace-element tries to match StackTraceElement.getClass against a regex.
StackTraceElement.getClass returns null, so a NullPointerException gets thrown, totally obscuring the original exception.

Now, the null is supposedly impossible, according to the Javadocs for StackTraceElement. But in some rare cases it seems to happen.

[CLJ-446] 1.3 alpha1 gives reflection warning in a case where 1.2 does not

Fri, 9 Dec 2011 15:20:10 -0600

Feel free to reclassify this as something other than a bug if I've misclassified it.

Related Clojure Google group conversation: http://groups.google.com/group/clojure/browse_thread/thread/83c08f6c2f313c50#

When doing AOT compilation on the attached program nbody.clj with 1.2:

java -Dclojure.compile.path=. -cp clojure-1.2.0.jar:. clojure.lang.Compile nbody

there are no reflection warnings, and a more complex version of the program using the type Body runs quickly. When doing AOT compilation with 1.3 alpha1:

java -Dclojure.compile.path=. -cp clojure-1.3.0-alpha1.jar:. clojure.lang.Compile nbody

I see these reflection warnings, and a more complex version of the program using the type Body runs significantly more slowly, most likely due to the reflection warned about:

Reflection warning, nbody.clj:18 - reference to field x can't be resolved.
Reflection warning, nbody.clj:19 - reference to field y can't be resolved.

Changing the name of the file to nbod.clj and the first line to "(ns nbod", and making corresponding changes to the compilation commands above, causes the reflection warnings to go away in 1.3 alpha1.

Similarly, taking the original attached file nbody.clj and replacing the three occurrences of "nbody" that are not the namespace name with a different name like "nbod" (or probably any name other than "nbody") also causes the reflection warnings to go away in 1.3 alpha1.

In case it makes any difference, I was using Clojure jars pulled via Leiningen, and HotSpot 1.6.0_xxx JVMs on Mac OS X 10.5.8 and Ubuntu 10.4.

Admittedly, a change with very limited impact on typical Clojure users. I wanted to file a ticket in case this was an unwanted consequence of some desirable change in 1.3.

[CLJ-438] case* and code walkers

Fri, 13 Apr 2012 08:03:18 -0500

Clojure 1.2.0-master-SNAPSHOT
user=> (use 'clojure.walk)
nil
user=> (eval (macroexpand-all '(case 1 1 :test)))
java.lang.ClassCastException: clojure.lang.PersistentVector cannot be cast to clojure.lang.MapEntry (NO_SOURCE_FILE:2)

user=> (macroexpand-all '(case 1 1 :test))
(let* [G__9 1]
(case* G__9 0 1 1 1
(throw (new java.lang.IllegalArgumentException (clojure.core/str "No matching clause: " G__9)))

{1 [1 :test]}

false))

The existing code walkers convert the embedded [1 :test] into a PersistentVector that the compiler doesn't accept.
(symbol-macrolet [x :test] (case 1 1 x)) fails in the same way.

[CLJ-436] Bug in clojure.contrib.json/read-json

Fri, 1 Oct 2010 15:32:00 -0500

What (small set of) steps will reproduce the problem?
$ java -cp lib/clojure-1.2.0.jar:lib/clojure-contrib-1.2.0.jar clojure.main
Clojure 1.2.0
user=> (require 'clojure.contrib.json)
nil
user=> (clojure.contrib.json/read-json "")
java.lang.IllegalArgumentException: Value out of range for char: -1 (NO_SOURCE_FILE:0)
user=>

What is the expected output? What do you see instead?

Expected:

(if eof-error?
  (throw (EOFException. "JSON error (end-of-file)"))
  eof-value)

What version are you using?
1.2

Was this discussed on the group? If so, please provide a link to the discussion
[13:51] <na_ka_na> Hey guys I think there's a bug in clojure.contrib.json at line 116
[13:51] <na_ka_na> in clojure 1.2
[13:52] <na_ka_na> it has a (char i) and then checks for (= i -1) ... but (char -1) fails
[13:52] <na_ka_na> where can I report it ?
[13:53] <LauJensen> na_ka_na: assembla/support

[CLJ-431] with-junit-output should use with-test-out when writing header and testsuites tags

Fri, 5 Nov 2010 11:05:12 -0500

Need to be able to use *test-out* and *out* independently within with-junit-output in order to be able to XML escape general test output while leaving report output (XML) alone.

with-junit-output currently precludes this because it doesn't use with-test-out when writing the header and testsuites tags. It assumes it will always be wrapped with with-test-out but this permenantly merges *test-out* and *out*

[CLJ-424] instance? fails on deftype instance, when used from multiple files

Fri, 28 Jan 2011 15:43:25 -0600

When instance? is called from two separate namespaces to test an instance of a user defined type, one of them fails

In the attached project, the following (identical) tests run correctly:

lein test instance-test.test.core
lein test instance-test.test.core2

but this fails:

lein test

For ease of reference, the attached project contains the following:

(ns instance-test.core)
(deftype MyType [a])
(defn make-my-type
[]
(MyType. nil))

(ns instance-test.test.core
(:use [instance-test.core] :reload-all)
(:use [clojure.test])
(:import instance-test.core.MyType))

(deftest test1
(is (instance? instance-test.core.MyType (make-my-type))))

(ns instance-test.test.core2
(:use [instance-test.core] :reload-all)
(:use [clojure.test])
(:import instance-test.core.MyType))

(deftest test1
(is (instance? instance-test.core.MyType (make-my-type))))

[CLJ-419] LispReader uses Character.isWhitespace rather than Character.isSpaceChar

Sat, 23 Oct 2010 15:03:00 -0500

Character.isWhitespace doesn't handle non-breaking space correctly. Apparently it's pretty ancient from The Olden Days Before People Knew How To Do Character Encodings.

In Java 1.5 Character.isSpaceChar was added, which handles supplementary characters the right way: http://download.oracle.com/javase/1.5.0/docs/api/java/lang/Character.html#isWhitespace(char)

[CLJ-416] improvments on agent

Fri, 1 Mar 2013 12:47:03 -0600

hi,i have some ideas to improve the agent system:
1.Agent's thread pool must use a custom ThreadFactory to new threads.Set new thread a system name and set it to be daemon.Thread's name would be used for debug or monitor.And set thread to be daemon asking user to shutdown agents explicitly.

2.Beacause agent's thread is daemon,so if a application doesn't use any agents,the thread pool must not started.I think the agent's thread pools should be lazy initialized.

3.I think agent must allow use to define a agent-own thread pool.That thread pool is only used by a agent,not global.just like:
(define a (agent :executor (java.util.concurrent.Executors/newFixedThreadPool 2)))
or
(set-executor! a (java.util.concurrent.Executors/newFixedThreadPool 2))
And then,a new function to shutdown agent's custom thread pool:
(shutdown-agent a)

Why do we need a custom thread pool?
First, the default thread pool is global, send use the thread pool
is a fixed size cpus +2, is likely to become the system bottleneck
sometime. Although you can use the send-off, use the cache thread
pool, but in a real world application, I can not use the cache thread
pool, which will introduce the risk of OutOfMemoryError, normally I
like to use a fixed-size thread pool.

Second, the actions which global thread pool execute are from a
variety of agents, the actions are not homogeneous, and can not
maximize the efficient use of the thread pool.

These are my suggestions on agent,thanks for this great language,i enjoy it.

[CLJ-414] In latest clojure, empty list is neither true nor false

Tue, 24 Aug 2010 00:35:00 -0500

In latest Clojure, compiled today:

user> (true? ())
false
user> (false? ())
false

This makes empty collections the only entities in Clojure which are neither true, nor false.
I'm fairly sure () used to be true – is this an intentional change? Googling reveals lots of warnings about the empty list not being false in Clojure.

[CLJ-412] clojure.xml/emit, emit-element are not documented at clojure.org

Tue, 24 Aug 2010 00:34:00 -0500

Neither function makes an appearance here:
http://clojure.github.com/clojure/clojure.xml-api.html
Despite the fact that neither appears to be private. Perhaps the doc generator just ignores all functions that have no doc comment?

[CLJ-411] clojure.xml/emit should be encoding-aware

Fri, 1 Oct 2010 09:56:00 -0500

clojure.xml/emit blithely asserts that it's writing UTF-8 despite the fact that it's actually writing characters, not bytes. Encoding isn't actually decided until actual bytes are written. This forces clients using clojure.xml/emit to write XML back to disk to use UTF-8. They won't know to do that unless they actually peek at the implementation. This behavior isn't documented.

(defn emit [x]
  (println "<?xml version='1.0' encoding='UTF-8'?>")
  (emit-element x))

[CLJ-409] SAXParserFactoryImpl is missing at unit testing time

Tue, 24 Aug 2010 00:34:00 -0500

SAXParserFactoryImpl seems to be AWOL while clojure unit tests are running, but is present when clojure is started from the command line. WTF?

(ns clojure.test-clojure.clojure-xml
  (:use clojure.test)
  (:import [javax.xml.parsers SAXParserFactory])
  (:require [clojure.xml :as xml]))

(deftest sax-parser-factory-is-not-awol
  (is (SAXParserFactory/newInstance)))
</code></pre>
<pre><code>Tell ant to run the unit tests:

$ ant test

And get the following exception:

ERROR in (sax-parser-factory-is-not-awol) (SAXParserFactory.java:134)
expected: (SAXParserFactory/newInstance)
actual: javax.xml.parsers.FactoryConfigurationError: Provider
        org.apache.xerces.jaxp.SAXParserFactoryImpl not found
at javax.xml.parsers.SAXParserFactory.newInstance (SAXParserFactory.java:134)
   clojure.test_clojure.clojure_xml/fn (clojure_xml.clj:17)

Yet, when I run clojure from the command line and do the same thing,
all is well.

$ java -jar clojure.jar
Clojure 1.2.0-beta1
user=> (import 'javax.xml.parsers.SAXParserFactory)
javax.xml.parsers.SAXParserFactory
user=> (SAXParserFactory/newInstance)
#<SAXParserFactoryImpl org.apache.xerces.jaxp.SAXParserFactoryImpl@19381960>
user=>

[CLJ-408] clojure.xml emit does not properly escape attribute and element content

Mon, 15 Nov 2010 12:49:00 -0600

(with-out-str
  (clojure.xml/emit-element {:tag :e :attrs nil :content "&"}))
</code></pre>
produces: <e>&</e>
correct would be: <e>&amp;</e>
This is true for both element content and attribute content. < and > are not escaped as well. Furthermore, apostrophe ( ' ) in an attribute value leads to broken xml:
<pre><code>
<e a='''/>

[CLJ-406] Typo in underive causes breaking in the resulting hierarchy

Tue, 24 Aug 2010 18:31:00 -0500

There's a typo on line 4515 in core.clj, in the definition of underive:

{:parent ... }
; should be
{:parents ... }
</code></pre>
causing breakage in hierarchies which had relationships underived in them.

E.g.
<pre><code>
(derive ::foo ::bar)
(underive ::foo ::bar)
(derive ::foo ::bar)
; => NPE

#clojure discussion:

http://clojure-log.n01se.net/date/2010-07-21.html#20:54

[CLJ-395] "underive" corrupts ad hoc hierarchies.

Tue, 24 Aug 2010 11:06:00 -0500

See transcript below, from 1.20-dev snapshot compiled about a week ago:

user=> (derive ::dad ::grandad)
nil
user=> (derive ::son ::dad)
nil
user=> (underive ::dad ::grandad)
nil
user=> (derive ::dad ::grandad)
java.lang.NullPointerException (NO_SOURCE_FILE:0)
user=> (derive ::foo ::bar)
java.lang.NullPointerException (NO_SOURCE_FILE:0)
user=>

[CLJ-375] metadata literal enhancements

Tue, 28 Sep 2010 15:51:00 -0500

1) Merge metadata literals (i.e. metadata on literal with metadata adds to it rather than replaces (but will replace same key))
^{:fred :ethel} ^{:ricky :lucy} foo yields metadata of {:fred :ethel, :ricky :lucy}

2) ^:a-keyword becomes {:a-keyword true} metadata

[CLJ-363] defn doesn't put the right metadata on its fn value

Tue, 24 Aug 2010 08:20:00 -0500

duplicate of #270

user=> (defn foo {:bar :baz} [] 42)
#'user/foo
user=> (meta #'foo)
{:ns #<Namespace user>, :name foo, :file "NO_SOURCE_PATH", :line 221, :arglists ([]), :bar :baz}
user=> (meta foo)
{:ns #<Namespace user>, :name foo} ; the value has only the basic keys
user=> (defn foo {:lucy :ethel} [] 43)
#'user/foo
user=> (meta #'foo)
{:ns #<Namespace user>, :name foo, :file "NO_SOURCE_PATH", :line 224, :arglists ([]), :lucy :ethel}
user=> (meta foo) ; the value has the previous metadata
{:ns #<Namespace user>, :name foo, :file "NO_SOURCE_PATH", :line 221, :arglists ([]), :bar :baz}

[CLJ-354] <= and >= comparisons against NaN return true

Sat, 19 Mar 2011 18:44:55 -0500

I would expect the attached clojure program to have the same output as the attached java program. However, their output differs. The following is a unidiff from the clojure output to the java output, i.e., each line beginning with a minus sign is what I would consider wrong output, and the corresponding line beginning with a plus sign is the correct output.

@@ -14,3 +14,3 @@

<= 0 NaN true
<= NaN 1 true
<= NaN NaN true
+ <= 0 NaN false
+ <= NaN 1 false
+ <= NaN NaN false
@@ -22,3 +22,3 @@
>= 0 NaN true
>= NaN 1 true
>= NaN NaN true
+ >= 0 NaN false
+ >= NaN 1 false
+ >= NaN NaN false

Here Java follows IEEE 754; see also <http://java.sun.com/docs/books/jls/third_edition/html/expressions.html#153654>.

I suspect the bug is because clojure.lang.Numbers.lte(x,y) is implemented by negating the result of lt(y,x), and similarly for gte: <http://github.com/richhickey/clojure/blob/65ae4928119a50e892bc33e8cbb47a82ebef98ee/src/jvm/clojure/lang/Numbers.java#L193>.

This is with Clojure 1.2.0-master-SNAPSHOT (git hash 65ae4928119a50e892bc33e8cbb47a82ebef98ee).

I mentioned this on the Google group, but no-one commented anything: <http://groups.google.com/group/clojure/browse_thread/thread/623d7f50fafaa816>.

[CLJ-350] namespace function NPE if namespace does not exist

Fri, 1 Oct 2010 16:45:00 -0500

The namespace function throws an NPE if the namespace of the symbol does not exist. For example:

(namespace ::x/y)
;=> NPE

The following patch changes corrects this. The resulting code throws an IllegalArgumentException with the message: "Namespace does not exist: x".

(Note: My Contributor's Agreement is in place, but since my request to join the Google clojure-dev group is still pending I decided to go ahead and submit the patch here.)

-David McNeil

====

From 5d65e5d9aabebf4ea5961e4e0bd8483618f8247e Mon Sep 17 00:00:00 2001
From: David McNeil <dem@dem-laptop.(none)>
Date: Sat, 15 May 2010 10:55:28 -0500
Subject: [PATCH] Avoid NPE and throw better exception if symbol's namespace does not exist.

—
src/jvm/clojure/lang/LispReader.java | 6 ++++--
1 files changed, 4 insertions, 2 deletions

diff --git a/src/jvm/clojure/lang/LispReader.java b/src/jvm/clojure/lang/LispReader.java
index 0bfae97..361b9cc 100644
— a/src/jvm/clojure/lang/LispReader.java
+++ b/src/jvm/clojure/lang/LispReader.java
@@ -302,9 +302,11 @@ private static Object matchSymbol(String s){
{
Symbol ks = Symbol.intern(s.substring(2));
Namespace kns;

if(ks.ns != null)
+ if(ks.ns != null) { kns = Compiler.namespaceFor(ks); - else + if(kns == null) + throw new IllegalArgumentException("Namespace does not exist: " + ks.ns); + } else
kns = Compiler.currentNS();
//auto-resolving keyword
return Keyword.intern(kns.name.name,ks.name);
- 1.6.3.3

[CLJ-345] clojure.contrib.string.replace-str throws NPE on nil string

Fri, 1 Oct 2010 06:44:00 -0500

Version: Clojure 1.2 / clojure-contrib 1.2

This call:

user=> (clojure.contrib.string/replace-str "a" "b" nil)
#<CompilerException java.lang.NullPointerException (NO_SOURCE_FILE:29)>

throws a NullPointerException when passed a nil string. It seems like more corner cases could be automatically handled by returning nil in this case rather than throwing an NPE. At the very least, it would be nice to update the docstring to state that s cannot be nil.

[CLJ-339] Integer autopromotion error

Fri, 1 Oct 2010 10:13:00 -0500

From this thread:
http://groups.google.com/group/clojure/browse_thread/thread/db1ffbb36c7d6f48

user=>(def imax (Integer/MAX_VALUE))
user=>(+ imax imax)
4294967294

user=>(+ (Integer/MAX_VALUE) (Integer/MAX_VALUE))
java.lang.ArithmeticException: integer overflow (NO_SOURCE_FILE:0)

Also:
user=>(+ Integer/MAX_VALUE Integer/MAX_VALUE)
java.lang.ArithmeticException: integer overflow (NO_SOURCE_FILE:0)

user=> (+ (Integer/MAX_VALUE) imax)
4294967294

user=> (+ imax (Integer/MAX_VALUE))
4294967294

user=> (+ Integer/MAX_VALUE Integer/MAX_VALUE Integer/MAX_VALUE)
6442450941

Possibly a bug with inlining?

[CLJ-293] doto doc minor typo

Tue, 24 Aug 2010 16:23:00 -0500

doto doc has a small typo

[CLJ-288] Make clojure.core/merge-with accept a wider range of map types

Fri, 24 Aug 2012 07:40:43 -0500

The current implementation of merge-with works only with map types that implement the IFn protocol for key lookup. In particular, this means that it doesn't work with map-like types created with deftype. The attached patch replaces the call to the map by a call to clojure.core/get, which works on any map-like type.

[CLJ-287] (take-nth 0 coll) spins wheels on Solaris

Tue, 24 Aug 2010 10:10:00 -0500

(take-nth 0 (range 5)) is a silly thing to do, but if you're anything like me then it inexorably fills heap space and cpu time by an infinite number of RMI calls.
I'm running Clojure 1.1.0-master-SNAPSHOT under Java 1.6R17 on Solaris 10 and I watched it fill up to 56GB
I think it should raise an exception instead but Im too new to clojure to recommend one. Sorry
Cheers
Simon

[CLJ-284] Cannot cast 0xFF to a byte (fails range check)

Tue, 28 Sep 2010 13:05:00 -0500

Prompted by a thread on the clojure group.

The recently added range checking to casts/coercions adversely affects a common usage of the byte cast to pull the 8 LSBs of an integer. Since the numerical representation of a byte is signed in java, the Byte.MIN_VALUE</code> and <code>Byte.MAX_VALUE</code> used in the range check of <code>clojure.lang.RT.byteCast() do not allow for integer values up to 0xFF.

[CLJ-283] recur ignores rest args

Tue, 24 Aug 2010 07:55:00 -0500

When you recur inside a function, the arguments are not assigned as expected:

(defn weird [& b]
(println b)
(when (< (first b) 2)
(recur (inc (first b)))))

(weird 1)

The first time it runs, b is a seq, but the second time it's just an integer.

After some discussion I found out this is because there's no way to apply recur, so technically making recur act as a normal function call means you can't pass a seq of args in. While this is arguably a decent workaround, it leads to very confusing, undocumented behaviour; at the very least it should be tracked in an issue until a better solution can be found.

[CLJ-279] Numbers as keys in maps must be of the same class to match

Tue, 28 Sep 2010 09:23:00 -0500

In maps, numbers need to be of the same class to match:

({(BigInteger. "1") "one"} 1) => nil
({(Long. "1") "one"} 1) => nil
({(Integer. "1") "one"} 1) => "one"

although:

(= (BigInteger. "1") 1) => true
(= (Long. "1") 1) => true

[CLJ-255] add denominator and numerator fns for Ratio

Tue, 28 Sep 2010 07:07:00 -0500

currently the only way to get the denominator or numerator is via the exposed fields of the Ratio class.

On Thu, Jan 21, 2010 at 7:57 AM, Jacek Generowicz
<jacek.generowicz@googlemail.com> wrote:
> Clojure has a Ratio type; presumably there should be an easy way to
> find the numerator and denominator of a Ratio object.
>
> I didn't have much luck on clojure.org or with find-doc, but
>
> (show 1/2)
>
> taught me that there are numerator and denominator methods on Ratio's
> underlying Java implementation, so I can now do:
>
> (.numerator 1/2) ; => 1
> (.denominator 1/2) ; => 2
>
> Is there a more direct way? (Not that this is bad! But you can't
> use .numerator as a first-order function (though #(.numerator %) is
> still pretty damn good).)
>
> In general, do you have any hints on how to go about looking for
> useful Clojure functions which work with certain Clojure types ?
>

[CLJ-251] macroexpand should respect :inline

Fri, 7 Oct 2011 07:47:38 -0500

macroexpand and macroexpand-1 currently do not respect the :inline metadata of
functions. For example you currently see:

(macroexpand '(+ 1 2))
;=> (+ 1 2)

Instead, macroexpand should return something like:

;=> (. clojure.lang.Numbers (add 1 2))

...depending of course on the exact definition of +'s :inline fn.

[CLJ-238] Make re-pattern accept multiple arguments to concatenate them.

Fri, 7 Oct 2011 07:51:41 -0500

This would help concatenating multiple regular expressions. The attached patch simply converts all arguments to a string and then pass that string to re-pattern. Currently if you're trying to concatenate literal regular expressions, you're force to use the str function. It's not much extra code, but given the similarity between re-pattern and str, I thought it would be nice to have them behave the same way. e.g.:

(re-pattern (apply str (map (partial format "%s{%s}") [\a \b \c \d \e] (iterate inc 1))))
would become
(apply re-pattern (map (partial format "%s{%s}") [\a \b \c \d \e] (iterate inc 1)))

It only save one call to str, so it might not warrant the extra code in the end.

[CLJ-237] Adding a :only-keys destructuring option, that throws an exception if there's extra key(s).

Fri, 17 Feb 2012 14:15:44 -0600

While discussing the issue that prompted ticket [[ticket:236]] on clojure-dev, Richard Newman suggested modifying map destructuring to incorporate a :only-keys. It works exactly like :keys but raises an exception if the destructured map contains other keys. The attached patch shows a possible implementation.

[CLJ-212] Direct linking breaks clojure.contrib.repl-ln.

Tue, 24 Aug 2010 05:22:00 -0500

Direct linking (commit 4d08439a9cf79f34a730714f12edd5959aae126e) breaks clojure.contrib.repl-ln.

To reproduce, run the following in the standard REPL:
(require 'clojure.contrib.repl-ln) (clojure.contrib.repl-ln/repl)

Expected output (obtained with commit 98366f353463afdc195b9b8fdf9d220bca7d0d6a):
nil
1:2 user=>

Result with commit 4d08439a9cf79f34a730714f12edd5959aae126e:
nil
java.lang.NullPointerException (NO_SOURCE_FILE:0)

The NullPointerException happens in clojure.contrib.repl-ln/prompt-hook where (private :prompt) returns nil.

[CLJ-176] structs printed with print-dup true cannot be read

Tue, 24 Aug 2010 06:14:00 -0500

(defstruct thing :a :b)
(def my-thing (struct thing 1 2))
(def s (binding [*print-dup* true] (pr-str my-thing)))
s 
;;=> "#=(clojure.lang.PersistentStructMap/create {:a 1, :b 2})"
(read-string s)
;;=> java.lang.IllegalArgumentException:
;;   No matching method found: create

[CLJ-147] Bug: Compile-time NPE on set! of non-existent field [for 1.0]

Mon, 15 Nov 2010 12:49:00 -0600

The bug described in #142 also exists in Clojure 1.0.0

[CLJ-132] Agents printed at the REPL do not always reflect their value

Tue, 24 Aug 2010 07:46:00 -0500

Starting with a fresh REPL and entering the following:

(def counter (agent 0))
(defn add1 [x] (inc x))
(send counter add1)
;; repeat many times
(send counter add1)

The representation printed at the REPL will not always display the correct value for the agent (e.g. the second call to `send` would print #<Agent@743fba: 1>). This appears to happen only in the first few calls to `send` before the value eventually "catches up". This behavior of course never occurs with `send-off`. This appears to only affect the printed value and not the actual value, but can still cause confusion.

My setup is as follows:
Mac OSX 10.5
Clojure 1.0.0
Running with `java -server -cp $CP jline.ConsoleRunner clojure.lang.Repl $*` where $CP points to clojure.jar, clojure-contrib.jar, and jline.jar

This also occurs with a fresh build of Clojure 1.1.0-alpha-SNAPSHOT from github.

-m

[CLJ-122] GC Issue 118: Patch to add :svn to clojure-version

Tue, 24 Aug 2010 06:45:00 -0500

Reported by miki.tebeka, May 16, 2009

Attached is a patch to add :svn to *clojure-version*.
In order for it to work do "svn ps svn:keywords Revision
src/clj/clojure/core.clj"

This way when people report problem in clojure, we can know the exact
revision they are talking about.

[CLJ-121] GC Issue 117: FAQ Page has formatting errors

Fri, 13 Apr 2012 08:02:57 -0500

Reported by miki.tebeka, May 13, 2009

The FAQ page (http://code.google.com/p/clojure/wiki/FAQ) has several
formatting errors:

* "How do I call a Java method that takes a variable number of arguments?"
is missing a space to make it a header.
* The link to SICP showing the URL

[CLJ-120] GC Issue 116: partition with pad

Fri, 2 Dec 2011 12:17:05 -0600

Reported by dimi...@gashinsky.com, May 09, 2009

;; A lot of times I needed a padding option on the partition. This is
;; my attempt to solve this problem. Any suggestions are welcome. I
;; hope this patch or something similar will make its way into the
;; core.

Some discussion that happened here:
http://groups.google.com/group/clojure/browse_frm/thread/6fcc1dd999a5ec02?tvc=1
was integrated into the patch.

[CLJ-118] GC Issue 114: version.properties in branch/1.0 is inaccurate

Fri, 20 Jul 2012 16:55:35 -0500

Reported by hlship, May 04, 2009

The version.properties in the 1.0 branch generates snapshot releases.
Ideally, there should be a tags/1.0 branch that locks down the 1.0 release.
Context: trying to build a 1.0 release artifact for the Maven repository.

Comment 1 by richhickey, May 04, 2009

Do you believe this advice was erroneous?

http://groups.google.com/group/clojure/msg/cb46994561dbc732

Comment 2 by hlship, May 05, 2009

I'm bothered that the 1.0 release is a 1.0 release, but not really.  Either its a
final release or its not. Saying its still a snapshot when you've broadcasted to the
world that its final seems very odd to me.

On the mailing list, I espoused the "Apache Way", which is to not get hung up on a
"1.0.0" number, but keep releasing.  If "1.0.2" has bugs, fix them and release
"1.0.3".  If that is finally stable, announce "Clojure 1.0 is version 1.0.3". Let the
release prove itself valid.

Older Tapestry releases were based on the "line in the sand" approach ... and always
ended up requiring a flurry of dot release bug fixes.

[CLJ-114] GC Issue 110: clojure version number patch

Tue, 24 Aug 2010 00:45:00 -0500

Reported by laurent....@gmail.com, Apr 26, 2009

Patch with the necessary changes to handle version numbering for clojure:

 * a src/clj/clojure/version.properties file
 * this version.properties file is the reference for version numbers. It is
on the classpath so it can be seen by clojure at runtime. It is in a
subdirectory of clojure-the-project so any tool can refer to it relatively
to the installation of clojure.

 * I've added the necessary code to clojure to load clojure version number
at startup time


I've also added function (clojure.core/clojure-version) that will return a
string representing the version from the structured *clojure-version* map.
The algorithm here is simple: 
<MAJOR>.<MINOR>[.<INCREMENT>][-<QUALIFIER>][-SNAPSHOT]

 * I've changed the ant build.xml so that it creates fully qualified names
with version attributes for the generated jars.
 * Note on the :interim attribute: to protect the person who makes releases
from itself, instead of considering :interim to be true if there is the
"true" string in the properties file, I've made the opposite choice:
interim is true for any value other than "false". So if there is a typo in
version.properties (e.g. tru instead of true), then the release will be
marked as interim, and that will not be a big deal. In the other case, it
would be a big deal if an official release was made accidentally instead of
an interim.

* finally, pom.xml file is now generated from ant as part of the classic
init step.

Note: I strongly suggest that the clojure.version.interim property remains
true in svn, so that it's not possible to inadvertently release a version
"too early".

Comment 1  by richhickey, Apr 27, 2009

I can't apply the patch due to missing pom-template.xml?

Also, could you just put the contents of core_version.clj into core.clj? I'd rather
not have another file just for this.

Thanks!

Comment 2 by laurent....@gmail.com, Apr 27, 2009

OK, core_version.clj content back into core.clj.

There was a problem with pom-template.xml probably because I tried on my local
working copy to make a svn rename pom.xml pom-template.xml, and somehow the svn diff
command did not like that.

What I've done in the current patch is first svn remove pom.xml then svn add
pom-template.xml.

Comment 3  by richhickey, Apr 27, 2009

patch applied- svn 1357 - thanks!

Status: Accepted
Comment 4 by scgilardi, May 12, 2009

(clojure-version) for 1.0 has a trailing "-". The intention (as noted above in the
issue) is that when the qualifier is absent, there should be no "-". The current
setup is reading a blank qualifier as an empty string, but checking later for nil
rather than nil or the empty string.

Clojure 1.0.0-
user=> *clojure-version*
{:major 1, :minor 0, :incremental 0, :qualifier ""}
user=> (clojure-version)
"1.0.0-"
user=> 



Comment 5 by laurent....@gmail.com, May 12, 2009

OK, a mistake on my part.

Rich, I also see you have made implicitly the "incremental" attribute mandatory in
trunk (since you apply Integer/valueOf on it without checking for nullity or string
emptyness).

If it is intentional, I can also add in the corrective patch a modified build.xml
that verifies this (incremental being mandatory) when building with ant, or I can
change the patch to keep the "incremental" attribute optional.

Waiting for your answer before creating the patch.

[CLJ-89] GC Issue 85: In a defn, arglists metadata becomes the first (unexpected?) symbol

Tue, 24 Aug 2010 03:45:00 -0500

Reported by jochu0, Feb 22, 2009

> What (small set of) steps will reproduce the problem?

(:arglists (meta (defn arglists broken-arglist ([a] a) ([a b] b))))
(broken-arglist)

> What is the expected output? What do you see instead?

I would expect ([a] [a b]) if not an error.

> What version are you using?

Using the latest clojure (r1298) and also likely to exist before lazy-seq.

> Was this discussed on the group? If so, please provide a link to the
discussion:

http://groups.google.com/group/clojure/browse_thread/thread/bafdb169330a9344

[CLJ-87] GC Issue 83: PersistentArrayMap trust the reader (map literals) too much

Tue, 24 Aug 2010 00:45:00 -0500

Reported by karmazilla, Feb 17, 2009

What (small set of) steps will reproduce the problem?

PersistentArrayMap gets it wrong:

user=> {1 1 1 1 1 1 2 2}
{1 1, 1 1, 1 1, 2 2}

What is the expected output? What do you see instead?

But PersistentHashMap gets it right:

user=> (hash-map 1 1 1 1 1 1 2 2)
{1 1, 2 2}

What version are you using?

rev 1286.

Was this discussed on the group? If so, please provide a link to the 
discussion:
http://groups.google.com/group/clojure/browse_thread/
thread/5a38a6b61b09e025

Please provide any additional information below.

PersistentArrayMap seems to be the culprits. Line 65 to 73. They should 
probably assoc the individual items like PersistentHashMap do, I guess.

[CLJ-61] GC Issue 57: Compiler internal error when expanding macro: class not found

Tue, 24 Aug 2010 03:44:00 -0500

Reported by tuomas.lukka, Jan 29, 2009
 
------------------------------

What (small set of) steps will reproduce the problem?

Run the following code:

(defmacro b [] (let [ x (fn [] []) ] x))
(def a (fn [] (b)))


What is the expected output? What do you see instead?

I'd expect it to either pass or give a proper error. What I get
is

Exception in thread "main" java.lang.ExceptionInInitializerError (test.clj:2)
 at clojure.lang.Compiler$DefExpr.eval(Compiler.java:308)
 at clojure.lang.Compiler.eval(Compiler.java:4147)
 at clojure.lang.Compiler.load(Compiler.java:4470)
 at clojure.lang.Compiler.loadFile(Compiler.java:4437)
 at clojure.lang.Script.main(Script.java:65)
Caused by: java.lang.ExceptionInInitializerError
 at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
 at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
 at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
 at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
 at java.lang.Class.newInstance0(Class.java:355)
 at java.lang.Class.newInstance(Class.java:308)
 at clojure.lang.Compiler$FnExpr.eval(Compiler.java:3218)
 at clojure.lang.Compiler$DefExpr.eval(Compiler.java:297)
 ... 4 more
Caused by: java.lang.RuntimeException: java.lang.ClassNotFoundException:
clojure.core$b__1$x__3
 at clojure.lang.RT.readString(RT.java:1192)
 at clojure.core$a__7.<clinit>(test.clj:2)
 ... 12 more
Caused by: java.lang.ClassNotFoundException: clojure.core$b__1$x__3
 at java.net.URLClassLoader$1.run(URLClassLoader.java:200)
 at java.security.AccessController.doPrivileged(Native Method)
 at java.net.URLClassLoader.findClass(URLClassLoader.java:188)
 at clojure.lang.DynamicClassLoader.findClass(DynamicClassLoader.java:52)
 at java.lang.ClassLoader.loadClass(ClassLoader.java:307)
 at java.lang.ClassLoader.loadClass(ClassLoader.java:252)
 at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:320)
 at java.lang.Class.forName0(Native Method)
 at java.lang.Class.forName(Class.java:247)
 at clojure.lang.RT.classForName(RT.java:1506)
 at clojure.lang.LispReader$EvalReader.invoke(LispReader.java:908)
 at clojure.lang.LispReader$DispatchReader.invoke(LispReader.java:530)
 at clojure.lang.LispReader.read(LispReader.java:143)
 at clojure.lang.RT.readString(RT.java:1188)
 ... 13 more


What version are you using?

20081217

Was this discussed on the group? If so, please provide a link to the
discussion:

no

[CLJ-50] GC Issue 46: callable defstruct (PersistentStructMap$Def extends AFn)

Mon, 15 Nov 2010 08:14:04 -0600

Reported by chouser, Jan 15, 2009
Describe the feature/change.

This much works already:
(defstruct rect :width :height)
(struct rect 5 10)  ==> {:width 5, :height 10}

With the included patch you can also:
(rect 5 10)  ==> {:width 5, :height 10}

Was this discussed on the group? If so, please provide a link to the
discussion:

http://groups.google.com/group/clojure/browse_thread/thread/12a138ad58ff6c36/b20b68ef939fccf7

Comment 1 by chouser, Jan 15, 2009
Forgot the patch attachment.
 structmap-def-extends-restfn.patch
923 bytes Download

[CLJ-17] GC Issue 13: validate in (keyword s) and (symbol s)

Fri, 7 Oct 2011 08:03:06 -0500

Reported by richhickey, Dec 17, 2008
Make sure they create readable keywords/symbols

Comment 1 by p...@hagelb.org, Apr 27, 2009
Could this be done with a regex, or should it try to confirm the name using the reader?
Comment 2 by p...@hagelb.org, Apr 27, 2009
I've implemented this in the attached patch. One thing that could be improved is that
invalid names simply raise an Exception, though it seems LispReader's ReaderException
would be more appropriate. I wasn't sure how to raise that though since it needs a
line number; it's not clear how to get the current line number.

The patch is still an improvement on the current state of things, though I'd
appreciate a tip as to how to raise the right exception.

I've also attached a patch to the test suite that ensures (symbol s) and (keyword s)
work properly in the context of invalid names. I can re-submit this to the contrib
project if that's desired if the core patch is accepted.
 0001-Test-invalid-symbol-keyword-names-raise-exceptions.patch
1.6 KB Download
Comment 3 by p...@hagelb.org, Apr 27, 2009
Last patch had a problem; used things like defn- etc. before they were defined in
core.clj. This attachment fixes that.
 validate-symbol-keyword-names.patch
2.1 KB Download
Comment 4 by p...@hagelb.org, Jun 13 (3 days ago)
This exists as a git branch too now: 
http://github.com/technomancy/clojure/tree/validate-symbols-issue-13

Clojure JIRA

[CLJ-826] Include drop, take, butlast from clojure.contrib.string (1.2) in clojure.string 1.3

[CLJ-806] clojure.test/are does not fail with insufficient arguments

[CLJ-785] Optimize /

[CLJ-732] (keyword "") can be printed, but not read

[CLJ-720] check that argument to keys/vals is a Map

[CLJ-466] Reflection incorrectly avoids "More than one matching method" exceptions

[CLJ-464] RFE: Run FindBugs on Clojure source code

[CLJ-463] Strip leading colons when creating keywords from single strings

[CLJ-461] require namespace implicitly

[CLJ-455] Calculating large numbers results in java.math.BigIntegerArithmeticException

[CLJ-449] NullPointerException in clojure.stacktrace

[CLJ-446] 1.3 alpha1 gives reflection warning in a case where 1.2 does not

[CLJ-438] case* and code walkers

[CLJ-436] Bug in clojure.contrib.json/read-json

[CLJ-431] with-junit-output should use with-test-out when writing header and testsuites tags

[CLJ-424] instance? fails on deftype instance, when used from multiple files

[CLJ-419] LispReader uses Character.isWhitespace rather than Character.isSpaceChar

[CLJ-416] improvments on agent

[CLJ-414] In latest clojure, empty list is neither true nor false

[CLJ-412] clojure.xml/emit, emit-element are not documented at clojure.org

[CLJ-411] clojure.xml/emit should be encoding-aware

[CLJ-409] SAXParserFactoryImpl is missing at unit testing time

[CLJ-408] clojure.xml emit does not properly escape attribute and element content

[CLJ-406] Typo in underive causes breaking in the resulting hierarchy

[CLJ-395] "underive" corrupts ad hoc hierarchies.

[CLJ-375] metadata literal enhancements

[CLJ-363] defn doesn't put the right metadata on its fn value

[CLJ-354] <= and >= comparisons against NaN return true

[CLJ-350] namespace function NPE if namespace does not exist

[CLJ-345] clojure.contrib.string.replace-str throws NPE on nil string

[CLJ-339] Integer autopromotion error

[CLJ-293] doto doc minor typo

[CLJ-288] Make clojure.core/merge-with accept a wider range of map types

[CLJ-287] (take-nth 0 coll) spins wheels on Solaris

[CLJ-284] Cannot cast 0xFF to a byte (fails range check)

[CLJ-283] recur ignores rest args

[CLJ-279] Numbers as keys in maps must be of the same class to match

[CLJ-255] add denominator and numerator fns for Ratio

[CLJ-251] macroexpand should respect :inline

[CLJ-238] Make re-pattern accept multiple arguments to concatenate them.

[CLJ-237] Adding a :only-keys destructuring option, that throws an exception if there's extra key(s).

[CLJ-212] Direct linking breaks clojure.contrib.repl-ln.

[CLJ-176] structs printed with *print-dup* true cannot be read

[CLJ-147] Bug: Compile-time NPE on set! of non-existent field [for 1.0]

[CLJ-132] Agents printed at the REPL do not always reflect their value

[CLJ-122] GC Issue 118: Patch to add :svn to *clojure-version*

[CLJ-121] GC Issue 117: FAQ Page has formatting errors

[CLJ-120] GC Issue 116: partition with pad

[CLJ-118] GC Issue 114: version.properties in branch/1.0 is inaccurate

[CLJ-114] GC Issue 110: clojure version number patch

[CLJ-89] GC Issue 85: In a defn, arglists metadata becomes the first (unexpected?) symbol

[CLJ-87] GC Issue 83: PersistentArrayMap trust the reader (map literals) too much

[CLJ-61] GC Issue 57: Compiler internal error when expanding macro: class not found

[CLJ-50] GC Issue 46: callable defstruct (PersistentStructMap$Def extends AFn)

[CLJ-17] GC Issue 13: validate in (keyword s) and (symbol s)

[CLJ-176] structs printed with print-dup true cannot be read

[CLJ-122] GC Issue 118: Patch to add :svn to clojure-version