[CLJ-999] Wrong link in gh-pages index (api-index.html)

Mon, 20 May 2013 16:24:12 -0500

The api-index.html includes wrong links for the following:

All entries for all listed as part of clojure.test.tap
All entries for all listed as part of clojure.test.junit
All entries for all listed as part of clojure.core.protocols

The links point to pages that do not exist. The problem is that the documentation for those entries is on a "parent" page, for example, the link clojure.core.protocols-api.html#clojure.core.protocols/internal-reduce should have been clojure.core-api.html#clojure.core.protocols/internal-reduce

Not a huge bug for me, but you might want to get it fixed.

And please give my huge thanks to whoever is in charge of the documentation, I'm the developer behind Dash, a Mac OS X documentation browser, and I was in the process of creating a documentation set for Clojure, and because you guys have an index, you made my work 1000 times easier.

[CLJ-1173] One-arg protocol functions whose name begins in a dash generates a call to a wrong field in the emitted code

Fri, 17 May 2013 13:36:40 -0500

(defprotocol P (-foo [this]))

This code generates a reflective call to a non-existing foo field instead of the correct -foo method.

I was told by Christophe Grand that changing the line 557 in core_deftype.clj from:

(. ~(with-meta target {:tag on-interface}) ~(or on-method method) ~@(rest gargs))

(. ~(with-meta target {:tag on-interface}) (~(or on-method method) ~@(rest gargs)))

is a quick fix. However I don't know too much about the compilation specifics of . to judge whether this is the correct fix.

Issue reproduction:

Clojure
user=> (set! *warn-on-reflection* true)
true
user=> (defprotocol P (-foo [this]))
P
Reflection warning, REPL:4 - reference to field foo can't be resolved.

Clojure JIRA

[CLJ-999] Wrong link in gh-pages index (api-index.html)

[CLJ-1173] One-arg protocol functions whose name begins in a dash generates a call to a wrong field in the emitted code