Clojure JIRA

[CLJ-1] Add chunk support to map filter et al

Tue, 24 Aug 2010 06:43:00 -0500

add conditional logic to test for chunked seq and handle specially

[CLJ-3] Test ticket

Tue, 24 Aug 2010 11:44:00 -0500

this is a test ticket

[CLJ-9] GC Issue 5: Allow single classes in import

Tue, 24 Aug 2010 03:44:00 -0500

Reported by m...@kotka.de, Dec 17, 2008
Currently import expects lists of a packages with classes, which should be imported
from the given package.

(import '(package ClassA ClassB ...) ...)

Sometimes however one just wants to import a single class from a package, but
one still has to specify the list form:

(import '(package ClassA))

use/require also allow a similar style of prefix list. However, they also allow a
shortcut in case one requires only one lib with a given prefix. The attached
patch modifies import to allow also this style of shortcut:

(import 'package.ClassA)

This change would be backward compatible.


 modified-import.patch
1.3 KB Download
Comment 1 by m...@kotka.de, Dec 17, 2008
I'm sorry for the dupe. The proxy gave me an error message, so I submitted again...
Also sorry for the wrong categorisation. Should be Enhancement not Defect...
Comment 2 by richhickey, Dec 17, 2008
(No comment was entered for this change.)

Comment 3 by richhickey, Dec 17, 2008
 Issue 4  has been merged into this issue.
Comment 4 by richhickey, Dec 17, 2008
(No comment was entered for this change.)
Owner: richhickey
Comment 5 by richhickey, Dec 17, 2008
I think the conditional here should test for symbol? rather than seq?, i.e. reverse
the condition. We should avoid hardwiring lists when possible.
Comment 6 by m...@kotka.de, Dec 19, 2008
Ok. Checks for symbol? now and if branches reversed. 
 modified-import.patch
1.3 KB Download
Comment 7 by richhickey, Dec 21, 2008
patch applied (svn 1179) - thanks!
Status: Done

[CLJ-6] GC Issue 1: :validator as keyword arg for ref/atom/agent

Tue, 24 Aug 2010 06:44:00 -0500

Reported by richhickey, Dec 14, 2008
switch to keyword args for reference ctors:
(ref val & options)
(atom va & options)
(agent val & options)

Comment 1 by richhickey, Dec 17, 2008
(No comment was entered for this change.)
Labels: -Priority-Medium Priority-High
Comment 2 by richhickey, Dec 17, 2008
(No comment was entered for this change.)
Status: Accepted
Comment 3 by richhickey, Dec 17, 2008
(No comment was entered for this change.)
Owner: ---
Comment 4 by richhickey, Jan 05, 2009
svn 1193
Status: Fixed

[CLJ-12] GC Issue 8: :default as keyword arg to defmulti

Tue, 24 Aug 2010 03:44:00 -0500

Reported by richhickey, Dec 17, 2008
rather than positional arg

Comment 1 by richhickey, Dec 17, 2008
(No comment was entered for this change.)
Status: Accepted
Comment 2 by richhickey, Dec 17, 2008
(No comment was entered for this change.)
Owner: ---
Comment 3 by m...@kotka.de, Jan 05, 2009
Attached is a patch, which turns the default dispatch value from a positional argument
into a keyword argument. The syntax is:

(defmulti name dispatch-fn :default dispatch-value)

Uses of the old syntax throw an exception pointing to the new syntax.
 issue-8.diff
1.4 KB Download
Comment 4 by m...@kotka.de, Jan 11, 2009
Another update of the patch, also including docstring and metadata support, similar to defn.

This was brought up several times on the list. Eg. in the thread:

http://groups.google.com/group/clojure/tree/browse_frm/thread/21af6e0431ae2e63/f7751913e875953f?
rnum=11&_done=%2Fgroup%2Fclojure%2Fbrowse_frm%2Fthread%2F21af6e0431ae2e63%2Ff7751913e875953f%
3F#doc_b5a6f9049a2ff250
 issue-8.diff
2.5 KB Download
Comment 5 by richhickey, Jan 22, 2009
Patch applied - svn 1226 - thanks!
Status: Fixed

[CLJ-13] GC Issue 9: Not all vars have doc strings

Tue, 24 Aug 2010 03:44:00 -0500

Reported by richhickey, Dec 17, 2008
Need to audit and fix

Comment 1 by richhickey, Dec 17, 2008
(No comment was entered for this change.)
Owner: ---
Comment 2 by mmcgrana, Jan 05, 2009
Possible audit method for public clojure.core *vars missing doc strings:

(prn
  (let [publics (ns-publics 'clojure.core)
        stared  (filter #(re-find #"^\*" (str (first %))) publics)
        undoced (remove #(:doc (meta (second %))) stared)]
    (map first undoced)))

=> (*compile-path* *ns* *allow-unresolved-vars* *macro-meta* ...
Comment 3 by chouser, Jan 09, 2009
For Vars interned via Java code, there's no original 'def' statement
where docstrings can be added.  Should a block of statments like
following be added to the end of clojure/core.clj ?

(alter-meta! #'*compile-path* assoc :doc
  "Specifies the directory where 'compile' will write out .class
  files.  This directory must be in the classpath for 'compile' to
  work.")

Comment 4 by richhickey, Jan 10, 2009
That seems right to me
Comment 5 by Chousuke, Jan 18, 2009
Here is a patch that adds at least *some* documentation for some of the variables.
It's missing a few that I did not know the purpose for, though.

--
Jarkko
 var-doc.patch
2.5 KB Download
Comment 6 by richhickey, Jan 22, 2009
Patch applied - svn 1225 - thanks!
Status: Fixed

[CLJ-11] GC Issue 7: Make syntax-quote Classname. aware

Tue, 24 Aug 2010 14:44:00 -0500

Reported by richhickey, Dec 17, 2008
should turn into fully.qualified.Classname.

Comment 1 by m...@kotka.de, Jan 02, 2009
The attached patch fixes this issue. It checks for Symbol w/o namespace and a trailing dot.
Then the dot is removed, the Symbol resolved and the dot added again.

The second patch fixes a related issue with .methodName Symbols: those were also resolved
when in fact they should not have been. So the patch checks for Symbols w/o namespace
and a leading dot. Those Symbols are simply left alone and quoted as is.

The second patch should be applied after the first.
 issue-7.diff
785 bytes Download
 issue-7a.diff
611 bytes Download
Comment 2 by richhickey, Jan 07, 2009
Patches applied svn 1202 - thanks!
Status: Fixed

[CLJ-7] GC Issue 2: gen-class - :exposes should expose static fields as static methods

Tue, 24 Aug 2010 06:44:00 -0500

Reported by richhickey, Dec 14, 2008
right now it doesn't look at type of field, and always generates instance
methods

Comment 1 by richhickey, Dec 17, 2008
(No comment was entered for this change.)
Owner: ---
Comment 2 by richhickey, Dec 18, 2008
(No comment was entered for this change.)
Labels: Priority-High
Comment 3 by chouser, Mar 06, 2009
The attached patch was tested using this gen-class call:

  (ns clojure.contrib.test-clojure.gen-class
    (:gen-class
      :extends javax.swing.border.TitledBorder
      :exposes {TEXT_SPACING {:get getSpacing :set setSpacing}
                title {:get getString :set setString}}))

Then:

  (compile 'clojure.contrib.test-clojure.gen-class)
  (def x (clojure.contrib.test_clojure.gen_class. "hi"))

  (.getString x)  ==> "hi"
  (.setString x "yo")
  (.getString x)  ==> "yo"

  (.getSpacing x)
  ==> java.lang.IncompatibleClassChangeError: Expected non-static field
clojure.contrib.test_clojure.gen_class.TEXT_SPACING (NO_SOURCE_FILE:0)

With the patch applied, .getString and .setString work the same, but now:

  (clojure.contrib.test_clojure.gen_class/getSpacing)  ==> 2
  (clojure.contrib.test_clojure.gen_class/setSpacing 10)
  ==> java.lang.IllegalAccessError (NO_SOURCE_FILE:0)

This last error is because the static field is final.

--Chouser
 genclass-exposes-statics.patch
2.2 KB Download
Comment 4 by richhickey, Apr 12, 2009
Patch applied - r1345 - thanks!
Status: Fixed

[CLJ-4] test ticket 2

Tue, 24 Aug 2010 11:44:00 -0500

a second test ticket

[CLJ-10] GC Issue 6: Include condp in clojure.core

Tue, 24 Aug 2010 14:44:00 -0500

Reported by m...@kotka.de, Dec 17, 2008
fcase from clojure.contrib is planned to be included in clojure.core
as condp. Currently there are two suggestions, on how to implement
this.

The attached patch proposes the following form:

(condp predicate expr
  test-expr result-expr
  ...)

For each pair test-expr and result-expr the predicate will
be called in the form (predicate test-expr result-expr). If
the predicate returns true, the result-expr is executed.

Using the vector binding form as known from let and friends
one might also assign the result of the call to predicate to
a local which may be used in the result-expr.

(condp [local predicate] expr
  test-expr result-expr
  ...)

If the number of test-expr result-expr pairs is odd, then
the last clause is evaluated, in case no previous clause was
chosen by the predicate. If the number of pairs is even,
an exception is thrown.

Furthermore the following changes to cond are proposed
to implement functionality similar to clojure.contrib.cond-let.

(cond
  [local test-expr] result-expr
  ...)

In case the test-expr in cond is a vector the first item is
used as the name of local which is bound to result of the
test-expr (second item in the vector) in result-expr.

This patch is backward-compatible.

Additionally another solution using templates was proposed
on the google group. More information on this proposal
may be found in the following thread:

http://groups.google.com/group/clojure/browse_thread/thread/19544014a89f24e9/dfdecc1bc
8330785?lnk=gst&q=stab+condp#dfdecc1bc8330785

 cond-condp.patch
2.9 KB Download
Comment 1 by richhickey, Dec 17, 2008
You meant: (predicate test-expr expr) right?

I think we should take any changes to cond off the table at present. 

It would be nicer if condp could do binding on a per-clause basis, as you did for
cond, but doing it the same way would rule out vectors as test exprs (with predicates
like nth, I guess).

The alternative is Scheme's:

test-expr => result-fn

where result-fn is a fn of one arg, passed the result of the predicate.

This can end up being more compact. I guess in Clojure we'd use a keyword:

test-expr :> result-fn

Comment 2 by m...@kotka.de, Dec 18, 2008
Modified the implementation. The syntax is now as follows:

(condp predicate expr
  test-expr result-expr
  test-expr :> result-expr
  ...)

In the first case result-expr is evaluated and its result is returned
if (predicate test-expr expr) returns non-nil/non-false.

In the second case, result-expr is expected to evaluate to a function
of one argument, which is passed the result of the predicate call.
Again: only if the result of the predicate call is non-nil/non-false.

In case there is a single clause at the end which does not fit the above
patterns it is taken as default in case no test-expr yields a success.
If no such default is given an exception is thrown.

The patterns may be freely mixed.

Cond is not modified.
 condp.diff
2.6 KB Download
Comment 3 by richhickey, Dec 21, 2008
In the end I found these patches too complex and wrote my own, thanks for the input!
svn 1180
Status: Done

[CLJ-14] GC Issue 10: remove all #=()s from non-dup prints

Tue, 24 Aug 2010 03:44:00 -0500

Reported by richhickey, Dec 17, 2008
Need to audit and fix

Comment 1 by richhickey, Dec 17, 2008
(No comment was entered for this change.)
Owner: ---
Comment 2 by chouser, Jan 09, 2009
Currently:

user=> (java.util.HashMap. {:a 1})
#=(java.util.HashMap. {:a 1})

What's the desired output?  Perhaps the unreadable:

#<java.util.HashMap. {:a 1}>

Comment 3 by richhickey, Jan 10, 2009
Yes, the unreadable form is good
Comment 4 by chouser, Jan 10, 2009
All occurrences of #= are in RT.java and core_print.clj.

In core_print.clj, all occurrences of #= are in print-dup methods,
except for one occurrence in the print-ctor function.  print-ctor is
in turn used only in print-dup methods, except for 3 print-method's
for Java set, map, and collection types.  The attached patch removes
those print-method's, causing the default method to be used, which
generates informative output for humans but which is not readable by
LispReader.

In RT.java, #= is generated by the print() method when
PRINT_INITIALIZED is unbound or false, for Class and Var objects.
Changing these to print non-dup style output makes the Clojure compile
process throw exceptions, so I'm guess these need to stay the way they
are.

For the record, these outputs can be tested at the REPL like this:

(defmacro pre-init [x]
  `(binding [clojure.core/print-initialized false]
    (clojure.lang.RT/print ~x *out*)
    (println)))

user=> (pre-init Integer)
#=java.lang.Integer
nil
user=> (pre-init #'filter)
#=(var clojure.core/filter)
nil

--The janitor
 remove-hash-equals.patch
1.7 KB Download
Comment 5 by richhickey, Jan 14, 2009
Patch applied, svn 1209 - thanks!
Status: Fixed

[CLJ-18] GC Issue 14: make RT.ROOT_CLASSLOADER load on demand, possibly never if AOT compiled

Tue, 24 Aug 2010 06:44:00 -0500

Reported by richhickey, Dec 17, 2008
To enable applets and other situations not supporting custom classloaders
or dynamic classloading

Comment 1 by richhickey, Dec 17, 2008
(No comment was entered for this change.)
Labels: -Type-Defect Type-Enhancement
Comment 2 by richhickey, Jan 07, 2009
svn 1201
Status: Fixed

[CLJ-16] GC Issue 12: improve doc for contains?

Tue, 24 Aug 2010 14:44:00 -0500

Reported by richhickey, Dec 17, 2008
Explain the behavior of contains? for vectors, i.e. associative

Comment 1 by richhickey, Dec 18, 2008
(No comment was entered for this change.)
Labels: Priority-High
Comment 2 by chouser, Jan 09, 2009
Expands both 'contains?' and 'some' docstrings.
 contains-docs.patch
1.3 KB Download
Comment 3 by richhickey, Jan 14, 2009
patch applied, svn 1214 - thanks!
Status: Fixed

[CLJ-25] GC Issue 21: bigdec truncates rational

Tue, 24 Aug 2010 00:44:00 -0500

Reported by tomfaulhaber, Dec 28, 2008
The clojure.core/bigdec function truncates rationals to ints:

(bigdec 1/2) => 0M

As opposed to:

(bigdec 0.5) => 0.5M

This happens because rationals fall into the number? case in bigdec which
converts the rational to a long before converting to BigDecimal.

I'm not sure that this behavior is completely wrong (since there's no way
to specify the behavior of 1/3 in the current API, for instance), but we
should probably at least document it.


Comment 1 by jbondeson, Jan 30, 2009
I discussed this along with another issue here:
http://groups.google.com/group/clojure/browse_thread/thread/1f8029b8556ce851/9b7538b192490097?lnk=gst&q=ratio#9b7538b192490097

(bigdec (/ 1 3)) should probably behave exactly like (/ 1M 3) which throws an
ArithmeticException unless you are inside a "with-precision" block.

I have attached a rather simple fix for this to have Ratio -> BigDecimal conversion
behave like this.
 bigdec-ratio.diff
521 bytes Download
Comment 2 by richhickey, Feb 09, 2009
fixed in svn 1257 - thanks!
Status: Fixed

[CLJ-24] GC Issue 20: release-pending-sends

Tue, 24 Aug 2010 00:44:00 -0500

Reported by richhickey, Dec 23, 2008
Agents in perpetual loops would like to send actions that don't wait for
current action completion

Comment 1 by richhickey, Dec 23, 2008
added in svn 1185
Status: Fixed

[CLJ-26] GC Issue 22: Make sure all integer ops return smallest representation

Tue, 24 Aug 2010 03:44:00 -0500

Reported by richhickey, Dec 28, 2008
Right now not all integers that can be represented as longs are, leading to
cases of different representations of integers of same value, and the
resulting problems for hashCode.

Comment 1 by christophe.grand, Dec 29, 2008
added LongOps 
uncommented the two lines in reduce(BigInteger)
 LongOps.patch
4.9 KB Download
Comment 2 by richhickey, Dec 29, 2008
Thanks! I'm having some problems applying the patch. I get a LongOps class with
several opsWith(LongOps) entries and other errors.

Would it be possible to produce a patch/diff with more context?
Comment 3 by christophe.grand, Dec 29, 2008
diff -u5 this time, hoping it works better for you than plain svn diff.
 LongOps.diff
5.6 KB Download
Comment 4 by richhickey, Dec 29, 2008
Patch applied - svn 1190 - thanks!
Status: Fixed

[CLJ-28] GC Issue 24: Remove hard search for .class files in RT.load

Tue, 24 Aug 2010 14:44:00 -0500

Reported by richhickey, Dec 29, 2008
On Android, class can be loadable without accessible .class file, so no
.class or .clj is not an error. Must try to load speculatively in that case.

Comment 1 by richhickey, Dec 29, 2008
svn 1188
Status: Fixed

[CLJ-20] GC Issue 16: Pretty printing

Tue, 24 Aug 2010 06:44:00 -0500

Reported by richhickey, Dec 17, 2008
A rudimentary pprint
Some efforts have been posted to group, no consensus yet

[CLJ-30] GC Issue 26: agent error queue

Tue, 24 Aug 2010 03:44:00 -0500

Reported by richhickey, Jan 01, 2009
Route agent errors to a queue

Comment 1 by chouser, May 26, 2009
The attached patch allows agents to have an error-callback, which could be used to
route errors to one or more queues.

Example usage:

user=> (send-off (agent nil
                   :error-callback (fn [a es]
                                     (.printStackTrace (first es))
                                     (clear-agent-errors a)))
                 (fn f [_]
                   (Thread/sleep 1000)
                   (send-off *agent* f)))
#<Agent@5dd2b9b7: nil>
user=> (shutdown-agents)
nil
user=>
java.lang.RuntimeException: Error executing action user$eval__394$f__399@63d87b85
        at clojure.lang.Agent$Action.execute(Agent.java:63)
        at clojure.lang.Agent$Action.doRun(Agent.java:107)
        at clojure.lang.Agent$Action.run(Agent.java:118)
        at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
        at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
        at java.lang.Thread.run(Thread.java:619)
Caused by: java.util.concurrent.RejectedExecutionException
        at
java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:1760)
        at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:767)
        at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:658)
        at clojure.lang.Agent$Action.execute(Agent.java:57)
        ... 5 more

 error-callback.patch
3.9 KB Download

[CLJ-32] GC Issue 28: Substraction sometimes yields wrong result due to IntegerOps.Negate overflow (with patch

Tue, 24 Aug 2010 06:44:00 -0500

Reported by olov.lassus, Jan 02, 2009
Negating Integer.MIN_VALUE overflows but should return a BigInteger.  
It also affects binary subtraction since Clojure implements it using  
negation and addition. The overflow occurs silently without throwing  
an exception.

These examples trigger the flaw:

user=> (- -2147483648)
-2147483648

user=> (- -1 -2147483648)
-2147483649


The attached patch apply cleanly against trunk r1195. Same examples after
applying it:

user=> (- -2147483648)
2147483648

user=> (- -1 -2147483648)
2147483647

 detect_negate_overflow.patch
507 bytes Download
Comment 1 by richhickey, Jan 07, 2009
fixed in svn 1203
Status: Fixed

[CLJ-29] GC Issue 25: ClassNotFoundException when loading a clojure app under the Android vm

Tue, 24 Aug 2010 06:44:00 -0500

Reported by va3pip, Dec 29, 2008
What (small set of) steps will reproduce the problem?
Compile and run a clojure based Android app under the emulator.  While
loading, it'll throw a clojure.core__init class not found exception. A good
sample clojure Android app is at: 
    http://github.com/Nafai77/helloandroid/tree/master

What is the expected output? What do you see instead?
It should be able to find clj based classes

What version are you using?
svn 1191

Please provide any additional information below.
I've attached a patch to RT.java that changes classForName() and
loadClassForName() to try the default classloader if DynamicClassLoader
fails to find the requested class.  I probably overlooked some corner case
with these 2 changes, so I'll expect you'll fix/change this patch :) - but
I'll send in a CA tomorrow anyways, just in case.  Note: it still won't run
the app as there's a VerifyError with StringBuilder.append() - for details,
see:   http://paste.lisp.org/display/72811

 dalvikvm.patch
791 bytes Download
Comment 1 by richhickey, Dec 30, 2008
svn 1192
Status: Fixed

[CLJ-23] GC Issue 19: Unquote not in syntax-quote yield (unquote x)

Tue, 24 Aug 2010 04:44:00 -0500

Reported by richhickey, Dec 23, 2008
Currently yields an Unquote object
clojure/unquote would remain undefined, thus would still be error if
evaluated, but user macros could use for escaping

Comment 1 by richhickey, Dec 23, 2008
added svn 1184
Status: Fixed

[CLJ-38] GC Issue 34: A Lisp reader without access to EvalReader()

Tue, 24 Aug 2010 06:44:00 -0500

Reported by dresweng...@dreish.org, Jan 06, 2009
Like any good Lisp, Clojure can compile and run code while reading, read and compile code while 
running, and read and run code while compiling.

Unfortunately that means it isn't safe for an application to use (read) to read something from an 
untrusted source. If the input stream contains, e.g., #=(eval (def core-app-function #(throw 
(Exception.)))), the application would blow up.

Feature request is for a version of the reader that has #= shut off, for reading untrusted data.

(Discussion was on #clojure; rhickey asked me to add this, so there's no Google Group discussion 
that I'm aware of.)
Comment 1 by christophe.grand, Jan 17, 2009
the aforementioned discussion: http://clojure-log.n01se.net/date/2009-01-06.html#18:41c
Comment 2 by the.stuart.sierra, Feb 18, 2009
Common Lisp has *read-eval*:
http://www.lispworks.com/documentation/HyperSpec/Body/v_rd_eva.htm

A similar flag might be an easy way to implement a "safe" reader.
Comment 3 by jhawk28, Mar 17, 2009
adds the *read-eval*
 Issue 34.patch.txt
2.1 KB Download
Comment 4 by richhickey, Apr 12, 2009
Patch applied - r1347 - thanks!
Status: Fixed

[CLJ-33] GC Issue 29: Range sometimes yields wrong sequence (with patch)

Tue, 24 Aug 2010 04:44:00 -0500

Reported by olov.lassus, Jan 02, 2009
The clojure.lang.Range type is implemented with integer type start and end
indices. The core.clj range function should detect when an index doesn't
fit inside an int and create an increasing sequence using iterate instead.
The current implementation detects too large positive, but not too large
negative ranges. The overflow occurs silently without throwing an exception.

Before:
user=> (take 1 (range -2147483649 0))
(2147483647)


After applying the patch which apply cleanly against trunk r1195:
user=> (take 1 (range -2147483649 0))
(-2147483649)


I also made the range function slightly less conservative < vs <= wise.
This shouldn't affect correctness but (range 0 2147483647) will now return
a Range (after patch) instead of a LazyCons (before).

 support_large_negative_range.patch
918 bytes Download
Comment 1 by richhickey, Jan 07, 2009
Patch applied - svn 1204 - thanks!
Status: Fixed

[CLJ-37] GC Issue 33: resultset-seq breaks when the result set contains duplicate column names (with patch)

Tue, 24 Aug 2010 03:44:00 -0500

Reported by arohner, Jan 05, 2009
What (small set of) steps will reproduce the problem?

Create a java.sql.ResultSet containing two columns with the same name, and
then pass it to resultset-seq. 

What is the expected output? What do you see instead?
The expected output is an exception message that is helpful in diagnosing
the problem. resultset-seq instead throws "java.lang.RuntimeException:
java.lang.IllegalArgumentException: Too many arguments to struct constructor" 

What version are you using?
This was first reproduced in r1060. svn shows the function has not been
touched since 2008-07-29

Was this discussed on the group? If so, please provide a link to the
discussion:
http://groups.google.com/group/clojure/browse_frm/thread/e533e9cdf758f210?q=#43e5775c2d959dc7
http://groups.google.com/group/clojure/browse_thread/thread/58e4921de5c86c3c/7ca1de2daad839da?show_docid=7ca1de2daad839da

The attached patch modifies resultset-seq to throw an exception with the
message "
 resultset-seq.patch
1.5 KB Download
Comment 1 by arohner, Jan 05, 2009
The attached patch modifies resultset-seq to throw an exception with the message
"result set must have unique column names" when the column names are duplicated. It
also moves the definition of the set function above resultset-seq.
Comment 2 by richhickey, Feb 09, 2009
shouldn't this use distinct? instead of set+count
Comment 3 by arohner, Feb 09, 2009
You're right. I was not aware of distinct? Attaching v2 of the patch. This time,
rather than moving the definition of set up, I've moved the definition of
resultset-seq to below the definition of distinct?
 resultset-seq.v2.patch
2.2 KB Download
Comment 4 by richhickey, Apr 12, 2009
Fixed (also moved to using column labels) - r1346 - thanks for the report.
Status: Fixed

[CLJ-34] GC Issue 30: Add doc string to ns macro

Tue, 24 Aug 2010 00:44:00 -0500

Reported by richhickey, Jan 04, 2009
Support
(ns
  "doc string goes here"
 ...)

Comment 1 by m...@kotka.de, Jan 04, 2009
Allow optional docstrings for a namespace as:

(ns foo.bar
  "docstring here"
  ...)

Attached patch uses the namespace symbol to transport the docstring to the namespace.

The Namespace class is modified to call its superclass constructor with the metadata
of the symbol passed in as name. If the first item of the references part of the ns macro
is a string, it is attached to the metadata of the given Symbol. From there it is again
transferred to the meta data of the Namespace.

Modified doc to check for the given symbol being a Namespace. If so its docstring is
retrieved and printed. If the symbol does not name a Namespace, it is interpreted as
a Var.

Added helper print-namespace-doc to complement print-doc.


 issue-30.diff
2.2 KB Download
Comment 2 by richhickey, Jan 22, 2009
Patch applied - svn 1224 - thanks!
Status: Fixed

[CLJ-40] GC Issue 36: Add Counted marker interface

Tue, 24 Aug 2010 03:44:00 -0500

Reported by richhickey, Jan 07, 2009
Marker interface with no methods. Would indicate O(1) count for
collections. Could be used to optimize vectr creation and some sequence ops

Comment 1 by chouser, Feb 10, 2009
Besides Java built-in classes, RT.count() works on
IPersistentCollection objects, so these are the ones that need to be
examined to see if they should implement Counted.

(defn getClassesInDir [basedir subdir]
  (let [regex (re-pattern (str basedir #"(.*)\.class"))]
    (map #(Class/forName (.replace (second (re-find regex (str %))) "/" "."))
         (.listFiles (java.io.File. (str basedir subdir))))))

(def clj-classes (getClassesInDir "/home/chouser/build/clojure/classes/" "clojure/lang"))

(defn has-count? [c]
  (try (.getMethod c "count" (into-array Class []))
    (catch NoSuchMethodException e)))

(count (filter has-count? clj-classes))  ==> 62 -- hopefully there are some useful
base classes.

(defn has-own-count? [c]
  (try (.getDeclaredMethod c "count" (into-array Class []))
    (catch NoSuchMethodException e)))

(count (filter has-own-count? clj-classes))  ==> 26 -- better

user=> (dorun (map println (sort (map str (filter has-own-count? clj-classes)))))
class clojure.lang.AMapEntry
class clojure.lang.APersistentSet
class clojure.lang.APersistentVector$RSeq
class clojure.lang.APersistentVector$Seq
class clojure.lang.APersistentVector$SubVector
class clojure.lang.ASeq
class clojure.lang.ArraySeq
class clojure.lang.ArraySeq$ArraySeq_double
class clojure.lang.ArraySeq$ArraySeq_float
class clojure.lang.ArraySeq$ArraySeq_int
class clojure.lang.ArraySeq$ArraySeq_long
class clojure.lang.Cons
class clojure.lang.LazilyPersistentVector
class clojure.lang.PersistentArrayMap
class clojure.lang.PersistentArrayMap$Seq
class clojure.lang.PersistentHashMap
class clojure.lang.PersistentList
class clojure.lang.PersistentList$EmptyList
class clojure.lang.PersistentQueue
class clojure.lang.PersistentQueue$Seq
class clojure.lang.PersistentStructMap
class clojure.lang.PersistentTreeMap
class clojure.lang.PersistentTreeMap$Seq
class clojure.lang.PersistentVector
class clojure.lang.Range
interface clojure.lang.IPersistentCollection

The promise of Counted is non-obvious for some of these.  For example,
APersistentSet and PersistentStructMap both have count() methods that
rely on IPersistentMap, which does not itself promise Counted.
However everything in clojure.lang that currently provides
IPersistentMap also promises Counted, so it seems appropriate for
APersistentSet and PersistentStructMap to promise Counted as well.

Similarly, APersistentVector$Seq uses count() from IPersistentVector
which does not itself promise Counted.  But since PersistentVector and
LazilyPersistentVector are both Counted, APersistentVector$Seq can
promise Counted.

Finally, PersistentQueue and PersistentQueue$Seq use ISeq.count(), but
the only ISeqs they use are PersistentList or seqs on vectors, so both
can also promise Counted.

If any of those conclusions are incorrect, or if the Counted marker
should be moved up to a parent interface in any of those cases, please
let me know.

The first patch attached marks almost all of the 'has-own-count?'
classes listed earlier as Counted.  The four non-Counted classes from
that list are:

(dorun (map println (filter #(and (has-own-count? %)
                                  (not (isa? % clojure.lang.Counted)))
                            clj-classes)))
clojure.lang.ASeq
clojure.lang.PersistentTreeMap$Seq
clojure.lang.Cons
clojure.lang.IPersistentCollection

There are total of 36 Counted classes, and 27 non-Counted
IPersistentCollection classes.

 add-counted.patch
10.2 KB Download
Comment 2 by richhickey, Feb 10, 2009
Thanks for doing the legwork on this, fixed in 1268
Status: Fixed

[CLJ-39] GC Issue 35: Wiki is closed to the public

Tue, 24 Aug 2010 03:44:00 -0500

Reported by dresweng...@dreish.org, Jan 07, 2009
Last night on IRC, the GC Wiki was suggested as a way to organize a users'
wish-list so rhickey can conveniently ignore it and focus on real issues in
the issue tracker.  Unfortunately, it appears only rhickey is allowed to
edit, much less add pages to, the wiki.

Comment 1 by richhickey, Jan 07, 2009
No, the suggestion was to use the user wiki:

http://en.wikibooks.org/wiki/Clojure_Programming
Status: WontFix

[CLJ-44] GC Issue 40: Overflow check in Numbers.minus (+ patch)

Tue, 24 Aug 2010 14:44:00 -0500

Reported by achim.passen, Jan 10, 2009
There are some corner cases where "-"  overflows but does not throw an "integer overflow" 
exception:

user=> (- Integer/MAX_VALUE Integer/MIN_VALUE) 
-1 
user=> (- Long/MAX_VALUE Long/MIN_VALUE) 
-1 

The problem seems to be that negating MIN_VALUE yields MIN_VALUE   
again, so it slips through the overflow check. The patch adds extra checks for MIN_VALUE.

version: SVN r1205

http://groups.google.com/group/clojure/browse_thread/thread/3db6cb2b71008e73

 overflow.diff
693 bytes Download
Comment 1 by richhickey, Jan 14, 2009
patch applied - svn 1212 - thanks!
Status: Fixed

[CLJ-43] GC Issue 39: Reader metadata fails for empty collection literals

Tue, 24 Aug 2010 04:44:00 -0500

Reported by chouser, Jan 09, 2009
What (small set of) steps will reproduce the problem?

Originally reported by Tomasz Skutnik.

user=> (meta #^{:some :metadata} [])
nil
user=> (meta #^{:some :metadata} ())
nil
user=> (meta #^{:some :metadata} {})
nil

What is the expected output? What do you see instead?

I expect to see metadata {:some :metadata} as I do in these cases:

user=> (meta #^{:some :metadata} [1])
{:some :metadata}
user=> (meta '#^{:some :metadata} (1))
{:some :metadata}
user=> (meta #^{:some :metadata} {:a 1})
{:some :metadata}
user=> (meta (with-meta [] {:some :metadata}))
{:some :metadata}
user=> (meta (with-meta () {:some :metadata}))
{:some :metadata}
user=> (meta (with-meta {} {:some :metadata}))
{:some :metadata}

What version are you using?

SVN 1205

Was this discussed on the group? If so, please provide a link to the
discussion:

http://groups.google.com/group/clojure/msg/686e161b780565e0

Please provide any additional information below.

Comment 1 by richhickey, Jan 14, 2009
fixed in svn 1213 - thanks for the report
Status: Fixed

[CLJ-41] GC Issue 37: .hashCode and .equals for Clojure vectors/seqs break Java contract.

Tue, 24 Aug 2010 06:44:00 -0500

Reported by wolfe.a.jason, Jan 07, 2009
What (small set of) steps will reproduce the problem?

(list (.equals [1 2] (seq [1 2])) (.hashCode [1 2]) (.hashCode '(1 2)))


What is the expected output? What do you see instead?

I see (true 994 -1919631597)
I think I should see (true i i), or perhaps (false i j) for some ints i, j


What version are you using?

svn 1162


Was this discussed on the group? If so, please provide a link to the
discussion:

http://groups.google.com/group/clojure/browse_thread/thread/5d11bc0da25a7ecc/06d6cd888a516119?hl=en&lnk=gst&q=.hashcode#06d6cd888a516119

Nobody asked me to add this here so I hope this isn't out of line ... 


Please provide any additional information below.

The crux is, the Java API says:

"If two objects are equal according to the equals(Object)  method, then
calling the hashCode method on each of the two objects must produce the
same integer result. "

As you can see here:

user> (doseq [s ['(1 2) (seq '(1 2)) [1 2] (seq [1 2]) (ArrayList. [1
2])]]
  (print "\n" (.hashCode s))
  (doseq [t ['(1 2) (seq '(1 2)) [1 2] (seq [1 2]) (ArrayList. [1
2])]]
    (print "\t" (.equals s t))))

 -1919631597     true    true    true    true    false
 -1919631597     true    true    true    true    false
 994             true    true    true    true    true
 -1919631597     true    true    true    true    false
 994             false   false   true    false   true 

this contract is violated by Clojure collections.  In particular, 
(.equals [1 2] (seq [1 2]) but they have different .hashCode()s.  

Some issues this can cause
  - Clojure hash-map and array-map have different behaviors
  - (get (hash-map {(vector &args) true} (list &args)) will return true
    iff there is a hash collision between the vector and list (?) 
  - Unexpected pain in unknown places when using Clojure objects in Java
code that expects the contract to hold

-Jason

Comment 1 by wolfe.a.jason, Jan 07, 2009
P.S. I realized that the reason for the discrepancy might be that java.util.list
hashCodes (used by vectors) are defined in a front-to-back manner.  This makes it
perhaps non-obvious how to efficiently compute them recursively back-to-front, as one
might like to to for seqs (so that each rest-seq can cache its hash value).  This
code shows that this can in fact be done efficiently.

(defn forward-hash "How hashCode() is defined in java.util.List"  [s]
  (loop [s (seq s) h (int 1)]
    (if s 
        (recur (rest s) (int (unchecked-add (unchecked-multiply h 31) (hash (first s)))))
      h)))


(def int-pow 
     (memoize 
      (fn [x n]
 (let [x (int x) n (int n)]
   (cond (zero? n) 1
  (even? n) (let [h (int-pow x (/ n 2))] (unchecked-multiply h h))
  :else     (unchecked-multiply x (int-pow x (dec n))))))))

(defn backward-hash "Compute the same value as forward-hash, but back-to-front."  [s]
  (let [s (seq s) p (int-pow 31 (count (rest s)))]
    (if s 
        (unchecked-add (unchecked-multiply 30 p)
         (unchecked-add (int (backward-hash (rest s)))
          (unchecked-multiply (int (hash (first s))) p)))
 1)))
   

user> (map #(% (vec (range 1000))) [forward-hash backward-hash #(.hashCode %)])
(133786869 133786869 133786869)

HTH, Jason

P.P.S. I'll put my Contributor Agreement in the mail today.   
Comment 2 by wolfe.a.jason, Jan 07, 2009
Note on a small special case: Java null effectively has hash code 0 (I think) whereas
java.util.List hashCode() must be 1 for empty Lists.  Fortunately, the REPL says:

user> (.equals [1] (seq [1]))
true
user> (.equals [] (seq []))
false

so I guess the empty vector is not .equal to the empty seq anyway (as mandated by the
Java API).  So, giving non-empty seqs java.util.List hashCodes would in fact be the
right thing to do, it seems to me.  


Comment 3 by richhickey, Jan 15, 2009
Fixed - svn 1215 - thanks for the report

Status: Fixed

[CLJ-45] GC Issue 41: [PATCH] several macros claim to want only 2 binding forms, allow more

Tue, 24 Aug 2010 04:44:00 -0500

Reported by Chousuke, Jan 10, 2009
several macros only check for (even? (count bindings)) even though they
should check for exactly 2 bindings. 

Trivial fix attached.

--
Jarkko Oranen
 fix-check.patch
1.5 KB Download
Comment 1 by chouser, Jan 10, 2009
Whoops.  Thanks for catching that, Jarkko.
Comment 2 by richhickey, Jan 14, 2009
patch applied - svn 1211 - thanks!
Status: Fixed

[CLJ-46] GC Issue 42: Classes from :methods argument vectors are not resolved before passing to overload-names (+ patch (?))

Tue, 24 Aug 2010 07:44:00 -0500

Reported by m...@kotka.de, Jan 10, 2009
What (small set of) steps will reproduce the problem?

Try to compile the following namespace definition:

(ns foo.Bar
  (:gen-class
     :methods [[toString [Object] String]]))

What is the expected output? What do you see instead?

I expect this to compile normally, but the following exception is thrown:

1:1 user=> (binding [*compile-path* "tmp"] (compile 'foo.Bar))
java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: 
java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: 
java.lang.RuntimeException: java.lang.IllegalArgumentException: No matching field found: 
getSimpleName for class clojure.lang.Symbol (Bar.clj:1)

What version are you using?

SVN rev. 1195

Was this discussed on the group? If so, please provide a link to the discussion:

The issue was brought up by baggins on #clojure:
http://clojure-log.n01se.net/date/2009-01-10.html#07:54

Please provide any additional information below.

Attached is a patch, which fixes the symptom. But I'm not sure, whether it fixes the issue.
 issue-42.diff
851 bytes Download
Comment 1 by richhickey, Jan 14, 2009
Path applied - svn 1210 - thanks!
Status: Fixed

[CLJ-27] GC Issue 23: mod (modulo) operator

Tue, 24 Aug 2010 14:44:00 -0500

Reported by mark.engelberg, Dec 28, 2008
mod (modulo) is similar to rem, but the result will always have the same
positive/negative sign as the second input:

(mod 2 5) -> 2
(mod 2 -5) -> -3
(mod -2 5) -> 3
(mod -2 -5) -> -2

Note that rem always has a result whose sign matches the first input:
(rem 2 5) -> 2
(rem 2 -5) -> 2
(rem -2 5) -> -2
(rem -2 -5) -> -2

So mod and rem yield the same answer if both inputs are positive, or both
are negative.  However, when the signs are mixed, they differ.

Sample code:
(defn mod [a b]
  (if (or (< a 0 b) (< b 0 a))
    (+ (rem a b) b)
    (rem a b)))
Comment 1 by achim.passen, Dec 29, 2008
A patch that adds mod and sgn
 mod-sgn.diff
6.9 KB Download
Comment 2 by richhickey, Jan 07, 2009
hmm... Mark's sample code looks much simpler - anything wrong with it?
Comment 3 by achim.passen, Jan 08, 2009
Not at all, it's functionally equivalent. I implemented it in Java mainly to be consistent with the other basic math 
op implementations. The Java version seems to be a tick faster (~500ms vs ~600ms on 100000 pairs of 
randomly typed random numbers here).

Attached is a simplified patch which adds LongOps support and gets rid of signum.


 r1205+mod.diff
4.9 KB Download
Comment 4 by richhickey, Jan 22, 2009
Added Mark's version, SVN 1227 - thanks!
Status: Fixed
Comment 6 by timothypratley, Feb 12, 2009
Yet another 'fixed' version:
(mod 9 -3) -> 0
(mod 4.5 2) -> 0.5
 mod-fix.patch
759 bytes Download
Comment 7 by richhickey, Feb 23, 2009
patch applied - svn 1302 - thanks!

[CLJ-49] GC Issue 45: :post-init option for gen-class

Tue, 24 Aug 2010 14:44:00 -0500

Reported by chouser, Jan 15, 2009
Describe the feature/change.

It's currently impossible to create a class with gen-class that calls
its own (or its super-classes') methods when it is constructed.  This
is a problem if there is stateful initialization required by the
superclass for which it has only methods, not ctor args.

Was this discussed on the group? If so, please provide a link to the
discussion:

http://groups.google.com/group/clojure/browse_thread/thread/d1fbdb7450b46dee/b5539e4a21c411c6
http://clojure-log.n01se.net/date/2009-01-15.html#10:22-10:37a

Comment 1 by chouser, Mar 07, 2009
(No comment was entered for this change.)
 gen-class-post-init.patch
3.7 KB Download
Comment 2 by cjkent, Mar 24, 2009
I've applied the patch and it works, but only if I define a post-init function with
no args.  I was expecting at least a single "this" arg.  Or is there another way to
get a reference to the newly created object?
Comment 3 by chouser, Mar 24, 2009
The args given to your class's constructor are passed directly to your post-init
function.  But you have a good point -- the 'this' arg should probably be included. 
I've attached a new patch that allows this:

(ns clojure.contrib.test-clojure.gen-class
  (:gen-class
     :extends javax.swing.border.TitledBorder
     :constructors {[int int String] [String]}
     :init my-init
     :post-init after-ctor))

(defn -my-init [x y s]
  (println "Init ignoring" x "and" y ", going with" (str "foo+" s))
  [[(str "foo+" s)] nil])

(defn -after-ctor [this x y s]
  (print "Constructing" this "with ")
  (prn x y s))

user=> (compile 'clojure.contrib.test-clojure.gen-class)
clojure.contrib.test-clojure.gen-class

user=> (clojure.contrib.test_clojure.gen_class. 3 4 "hello")
Init ignoring 3 and 4 , going with foo+hello
Constructing #<gen_class clojure.contrib.test_clojure.gen_class@1ab2b55> with 3 4 "hello"
#<gen_class clojure.contrib.test_clojure.gen_class@1ab2b55>

 post-init.patch
3.8 KB Download
Comment 4 by cjkent, Mar 25, 2009
Great, that works perfectly.  Thanks.
Comment 5 by richhickey, Apr 12, 2009
Patch applied - r1348 - thanks!
Status: Fixed

[CLJ-52] GC Issue 48: Per defmulti hierarchies

Tue, 24 Aug 2010 07:44:00 -0500

Reported by m...@kotka.de, Jan 17, 2009
Describe the feature/change.

This is an issue from the TODO list.

Currently multimethods use the global-hierarchy. However sometimes it is useful, to define
a dedicated hierarchy for a given set of multimethods. The attached patch adds a new
:hierarchy argument to defmulti which specifies the desired hierarchy. The hierarchy may be
any IRef.

The patch depends on the patch of  issue #8 .

Was this discussed on the group? If so, please provide a link to the discussion:

http://groups.google.com/group/clojure/browse_frm/thread/f8b1be403c927b03/438c21a8007
2a105?lnk=gst&q=per+defmulti+hierarchies

 issue-48.diff
3.4 KB Download
Comment 1 by richhickey, Feb 09, 2009
patch applied - svn 1262 - thanks!
Status: Fixed

[CLJ-35] GC Issue 31: Report more incorrect usages of binding vectors

Tue, 24 Aug 2010 06:44:00 -0500

Reported by chouser, Jan 05, 2009
What (small set of) steps will reproduce the problem?

The (< x y) form of the following expression is silently ignored:
(take 100 (for [x  (range 1000) y (range 1000) (< x y)][x y])) 

What version are you using?

SVN 1195

Was this discussed on the group? If so, please provide a link to the
discussion:

http://groups.google.com/group/clojure/browse_thread/thread/56793fb65903cece

Please provide any additional information below.

The attached patch is identical to the one in the discussion thread.
 binding-assertions.patch
8.1 KB Download
Comment 1 by richhickey, Jan 07, 2009
patch applied - svn 1205 - thanks!
Status: Fixed

[CLJ-48] GC Issue 44: non-Exception throwables stay wrapped in InvocationTargetException

Tue, 24 Aug 2010 06:44:00 -0500

Reported by s-google...@localtoast.org, Jan 14, 2009
What (small set of) steps will reproduce the problem?

Invoke a java method which throws an AssertionError (or any other subclass
of Error), through reflection.

What is the expected output? What do you see instead?

I'd expect to catch the AssertionError object itself (which is the case for
a type-annotated call). Instead, I end up catching an InvocationTargetException

What version are you using?

r1214

Comment 1 by richhickey, Jan 24, 2009
Could you please provide some Clojure code that demonstrates the problem?
Comment 2 by s-google...@localtoast.org, Jan 29, 2009
; method defined through clojure for brevity, any java method which throws a
non-Exception will suffice
user=> (defn throw-error [] (throw (new Error)))
#'user/throw-error

; expected behavior (type annotation creates a direct call)
user=> (let [#^clojure.lang.IFn o throw-error] (.invoke o))
java.lang.Error (NO_SOURCE_FILE:0)

; unexpected behavior, the reflect code has wrapped our Throwable
user=> (let [o throw-error] (.invoke o))
java.lang.reflect.InvocationTargetException (NO_SOURCE_FILE:0)


Comment 3 by richhickey, Feb 23, 2009
fixed - svn 1303 - thank for the report
Status: Fixed
Comment 4 by berlin.brown, Feb 24, 2009
I am getting this error also, is this fixed in the december release:


(defn simple-mkdirs-handler
  "Simple utility to make directories.  Throws error on invalid directory."
  [dirname]
  ;;;;;;;;;;;;;;;;;
  (if (empty? dirname) (throw (Error. "ERR: <mkdirs> Invalid Directory"))
      (let [file (new File dirname)]
        (if (not (.canWrite file))
          (throw (Error. "ERR: <mkdirs> Invalid Directory. Cannot write."))
          (try (.mkdirs file)
               (catch Exception e
                      (throw (Error. (str "ERR: <mkdirs> Invalid Directory. Cannot
mkdir => " 
                                          (.getMessage e))))))))))

[CLJ-22] GC Issue 18: with-open allows multiple bindings but silently closes only the first

Tue, 24 Aug 2010 04:44:00 -0500

Reported by Chousuke, Dec 18, 2008
in Clojure rev 1175
------------------------------
(import '(java.io StringReader))
(def stream1 (StringReader. "Test"))
(def stream2 (StringReader. "Test2"))

(with-open [a stream1 b stream2] (println "do-nothing"))

(.ready stream2) ; should throw an exception, but doesn't, since stream2 is
not closed

the reason is simple enough: in with-open, the bindings parameter is passed
to let, but in the finally clause, only a simple (.close ~(first bindings))
is emitted.

I have a patch to make with-open support multiple bindings cleanly, but I
do not have a CA so I can't submit it.

--
Jarkko Oranen




Comment 1 by m...@kotka.de, Dec 18, 2008
Reading the docstring I get the impression, that only one binding was intended at the beginning.
However allowing multiple bindings would a) not be a problem, b) justify the let style binding and
c) have pratical relevance.

I attached a simple patch.
 with-open.diff
887 bytes Download
Comment 2 by Chousuke, Dec 19, 2008
The patch is essentially identical to the solution I came up with, except that I used
let* instead of let for safety because destructuring doesn't make sense for with-open.

I'm going to have to go submit a CA so that next time I have an issue with a solution
I can actually submit the patch myself :)
Comment 3 by richhickey, Dec 19, 2008
That is a good point - destructuring is not supported. I don't think let* is the way
to achieve that - no one should be writing let* directly. The macro could just check
that all bindings are to simple symbols.

Also, the closes should happen in reverse order.

This can be achieved by solving the last, most important problem - you can't just do
this with one let, as each binding could potentially fail:

open a
open b
throw exception opening c

b and a never closed.

i.e., multi-binding with-open must use nested lets/trys, maybe could be defined in
terms of recursive calls to current macro.
Comment 4 by m...@kotka.de, Dec 19, 2008
Argh. I should really think, before writing.

Ok. Here the next idea:
with-open calls itself recursively. It checks that the next binding target (?) is a symbol.
Then it assigns just this one binding to a let and again calls itself wrapped in a try. This
gives in particular the reverse order for closing. And in case something bad happens
during opening ensures that previously opened streams are closed.

I had one problem though: Since we check for the bindings being a vector, one has
to take care, that one passes around the bindings again as a vector. Or one uses an
inner macro, where with-open does the check and then passes on to with-open*,
which also accepts a seq.

I took a different route and simply did a subvec instead of a take or drop. Then
we check for the vector several times, but I think this is the least intrusive version.
I had to move the subvec defn upwards, though.

 with-open.diff
2.3 KB Download
Comment 5 by richhickey, Dec 23, 2008
Patch applied (svn 1182) - thanks!
Status: Fixed

[CLJ-56] GC Issue 52: Make set/union accept any number of arguments

Tue, 24 Aug 2010 00:44:00 -0500

Reported by konrad.h...@laposte.net, Jan 20, 2009
Describe the feature/change.

set/union currently accepts two sets as arguments. The operation is well defined for any number of 
sets and similar operations (+, concat, ...) take any number of arguments, so I think set/union 
should do so as well.

Was this discussed on the group? If so, please provide a link to the discussion:


 set-union.diff
575 bytes Download
Comment 1 by scgilardi, Jan 20, 2009
There are implementations here as well:

http://groups.google.com/group/clojure/msg/5bb548afe2cbbe02

At one point, this was on Rich's public Clojure "to-do" list.

Comment 2 by wolfe.a.jason, Jan 22, 2009
On a somewhat related note, let me plug my own post about efficient set operations:

http://groups.google.com/group/clojure/browse_thread/thread/29609929e94f279c?hl=en#

(I am in favor of multi-arg set functions as well; while my versions don't do this, I
believe this can be done simply by (reduce union #{} sets) or (reduce
intersection/difference (first sets) (rest sets))


Comment 3 by wolfe.a.jason, Feb 02, 2009
This may now be subsumed by this issue:

http://code.google.com/p/clojure/issues/detail?id=64&colspec=ID%20Type%20Status%20Priority%20Reporter%20Owner%20Summary

which includes a patch for multi-arg, more efficient
clojure.set/union/difference/intersection functions.
Comment 4 by richhickey, Feb 22, 2009
(No comment was entered for this change.)
Status: Fixed

[CLJ-51] GC Issue 47: format, name and namespace are not hinted {:tag String}

Tue, 24 Aug 2010 07:44:00 -0500

Reported by christophe.grand, Jan 15, 2009
format, name and namespace are not hinted {:tag String}

(If you can't apply this patch, I promise to never use svn diff again!)
 name-namespace-format.patch
933 bytes Download
Comment 1 by christophe.grand, Jan 16, 2009
A broader patch that removes many reflection warnings from clojure.core files.
(I don't see how to prevent inlinable fns to raise warnings for their "default case".)
 clojure-core-hints.patch
14.6 KB Download
Comment 2 by christophe.grand, Jan 17, 2009
added hints to to-array and to-array-2d.
 clojure-core-hints2.patch
15.2 KB Download
Comment 3 by richhickey, Jan 24, 2009
This is great!

patch applied - svn 1229 - thanks!
Status: Fixed

[CLJ-59] GC Issue 55: "repeat" with multiple arities and remove "replicate"

Tue, 24 Aug 2010 03:44:00 -0500

Reported by timothypratley, Jan 28, 2009
"repeat" with multiple arities and remove "replicate"
http://groups.google.com/group/clojure/browse_thread/thread/bb2bd6ad6986fed
f


 repeat.patch
746 bytes Download
Comment 1 by timothypratley, Jan 28, 2009
opps didn't mean to submit this yet sorry, hang on.
Comment 2 by timothypratley, Jan 28, 2009
Please find attached the 'real' patch! Sorry, first time using this system.
 repeat.patch
3.1 KB Download
 contrib-repeat.patch
740 bytes Download
Comment 3 by richhickey, Feb 09, 2009
I don't have a CA from you, please see:

http://clojure.org/contributing
Comment 4 by richhickey, Apr 12, 2009
Repeat now supports an optional number-of-repetitions arg. Removing replicate is
another issue
Status: Fixed

[CLJ-50] GC Issue 46: callable defstruct (PersistentStructMap$Def extends AFn)

Mon, 15 Nov 2010 08:14:04 -0600

Reported by chouser, Jan 15, 2009
Describe the feature/change.

This much works already:
(defstruct rect :width :height)
(struct rect 5 10)  ==> {:width 5, :height 10}

With the included patch you can also:
(rect 5 10)  ==> {:width 5, :height 10}

Was this discussed on the group? If so, please provide a link to the
discussion:

http://groups.google.com/group/clojure/browse_thread/thread/12a138ad58ff6c36/b20b68ef939fccf7

Comment 1 by chouser, Jan 15, 2009
Forgot the patch attachment.
 structmap-def-extends-restfn.patch
923 bytes Download

[CLJ-62] GC Issue 58: `() gives strange compiler error (i.e. backquote of empty list)

Tue, 24 Aug 2010 03:44:00 -0500

Reported by tuomas.lukka, Jan 29, 2009

What (small set of) steps will reproduce the problem?

Run the code `()   

What is the expected output? What do you see instead?

I'd expect it to return a quoted empty list. Instead an error results:

Exception in thread "main" java.lang.UnsupportedOperationException: Unknown
Collection type (test.clj:1)
 at clojure.lang.Compiler.load(Compiler.java:4476)
 at clojure.lang.Compiler.loadFile(Compiler.java:4437)
 at clojure.lang.Script.main(Script.java:65)
Caused by: java.lang.UnsupportedOperationException: Unknown Collection type
 at clojure.lang.LispReader$SyntaxQuoteReader.syntaxQuote(LispReader.java:711)
 at clojure.lang.LispReader$SyntaxQuoteReader.invoke(LispReader.java:655)
 at clojure.lang.LispReader.read(LispReader.java:143)
 at clojure.lang.Compiler.load(Compiler.java:4466)
 ... 2 more

What version are you using?

20081217

Was this discussed on the group? If so, please provide a link to the
discussion:

no

Please provide any additional information below.

Comment 1 by richhickey, Feb 09, 2009
fixed in svn 1255 - thanks for the report
Status: Fixed

[CLJ-61] GC Issue 57: Compiler internal error when expanding macro: class not found

Tue, 24 Aug 2010 03:44:00 -0500

Reported by tuomas.lukka, Jan 29, 2009
 
------------------------------

What (small set of) steps will reproduce the problem?

Run the following code:

(defmacro b [] (let [ x (fn [] []) ] x))
(def a (fn [] (b)))


What is the expected output? What do you see instead?

I'd expect it to either pass or give a proper error. What I get
is

Exception in thread "main" java.lang.ExceptionInInitializerError (test.clj:2)
 at clojure.lang.Compiler$DefExpr.eval(Compiler.java:308)
 at clojure.lang.Compiler.eval(Compiler.java:4147)
 at clojure.lang.Compiler.load(Compiler.java:4470)
 at clojure.lang.Compiler.loadFile(Compiler.java:4437)
 at clojure.lang.Script.main(Script.java:65)
Caused by: java.lang.ExceptionInInitializerError
 at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
 at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
 at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
 at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
 at java.lang.Class.newInstance0(Class.java:355)
 at java.lang.Class.newInstance(Class.java:308)
 at clojure.lang.Compiler$FnExpr.eval(Compiler.java:3218)
 at clojure.lang.Compiler$DefExpr.eval(Compiler.java:297)
 ... 4 more
Caused by: java.lang.RuntimeException: java.lang.ClassNotFoundException:
clojure.core$b__1$x__3
 at clojure.lang.RT.readString(RT.java:1192)
 at clojure.core$a__7.<clinit>(test.clj:2)
 ... 12 more
Caused by: java.lang.ClassNotFoundException: clojure.core$b__1$x__3
 at java.net.URLClassLoader$1.run(URLClassLoader.java:200)
 at java.security.AccessController.doPrivileged(Native Method)
 at java.net.URLClassLoader.findClass(URLClassLoader.java:188)
 at clojure.lang.DynamicClassLoader.findClass(DynamicClassLoader.java:52)
 at java.lang.ClassLoader.loadClass(ClassLoader.java:307)
 at java.lang.ClassLoader.loadClass(ClassLoader.java:252)
 at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:320)
 at java.lang.Class.forName0(Native Method)
 at java.lang.Class.forName(Class.java:247)
 at clojure.lang.RT.classForName(RT.java:1506)
 at clojure.lang.LispReader$EvalReader.invoke(LispReader.java:908)
 at clojure.lang.LispReader$DispatchReader.invoke(LispReader.java:530)
 at clojure.lang.LispReader.read(LispReader.java:143)
 at clojure.lang.RT.readString(RT.java:1188)
 ... 13 more


What version are you using?

20081217

Was this discussed on the group? If so, please provide a link to the
discussion:

no

[CLJ-65] GC Issue 62: Make clojure.main not exit when exception during --init if user requested a repl

Tue, 24 Aug 2010 14:45:00 -0500

Reported by arohner, Jan 31, 2009

Describe the feature/change.

clojure.main should not exit if there was an exception in an --init file
and the user requested a repl. i.e.

java -cp clojure.jar clojure.main --init file-with-errors.clj -r 

should not exit. Having a repl is useful to read doc strings and experiment
with fixes for the problem.

Was this discussed on the group? If so, please provide a link to the
discussion:

http://groups.google.com/group/clojure/browse_frm/thread/f96109d71fa47200#

The attached patch adds a try/catch around the init method for the repl in
clojure.main. It does not change the behavior for the case where the user
specifies a file to run rather than a repl.

Comment 1  by richhickey, Feb 09, 2009
patch applied - svn 1258 - thanks!
Status: Fixed

[CLJ-60] GC Issue 56: Make printed IRef's more useful

Tue, 24 Aug 2010 03:44:00 -0500

Reported by chouser, Jan 28, 2009
Describe the feature/change.

Currently when you print an IRef, the contents are not printed.  With
the attached patch:

user=> (agent 99)
#<Agent@1dee400: 99>

user=> (atom #{:bomb})
#<Atom@e3849c: #{:bomb}>

user=> (ref "erence")
#<Ref@44cbbe: "erence">

Note that they're no more readable in the (read) sense.  Also note
that Vars are unchanged:

user=> #'nil?
#'clojure.core/nil?

Was this discussed on the group? If so, please provide a link to the
discussion:

http://groups.google.com/group/clojure/browse_thread/thread/e63c5e3e1f429f6e

 print-iref.patch
694 bytes Download
Comment 1 by richhickey, Feb 09, 2009
patch applied - svn 1254 - thanks!
Status: Fixed

[CLJ-63] GC Issue 60: Ratio to floating point conversion miscalculation

Tue, 24 Aug 2010 03:44:00 -0500

Reported by jbondeson, Jan 30, 2009
Originally discussed here:
http://groups.google.com/group/clojure/browse_thread/thread/1f8029b8556ce851/9b7538b192490097?lnk=gst&q=ratio#9b7538b192490097

The current implementation of conversion of clojure.lang.Ratio class
to a fixed precision floating point value is not what one would expect. 
For example:

user> (double (/ (expt 2 1024) 3))
Infinity
when in fact it should return: 5.992310449541053E307  

Attached is the fix for the Ratio class to allow for the proper conversion
to a double or float by using a BigDecimal division with a fixed precision.

Additionally, I sent in my CA on Monday, so it should be there anytime now.
 ratio-conv.diff
1.0 KB Download
Comment 1 by richhickey, Feb 09, 2009
patch applied - svn 1256 - thanks!
Status: Fixed

[CLJ-66] GC Issue 63: docstring for refer-clojure is outdated

Tue, 24 Aug 2010 00:45:00 -0500

Reported by chouser, Feb 02, 2009

What (small set of) steps will reproduce the problem?

user=> (doc refer-clojure)
-------------------------
clojure.core/refer-clojure
([& filters])
Macro
  Same as (refer 'clojure <filters>)
nil

What is the expected output? What do you see instead?

Docstring should be:
Same as (refer 'clojure.core <filters>)

What version are you using?

1241 trunk

Was this discussed on the group? If so, please provide a link to the
discussion:

http://groups.google.com/group/clojure/msg/598502ccfc42a5ce

Please provide any additional information below.

Comment 1 by richhickey, Feb 09, 2009
fixed in svn 1259 - thanks for the report
Status: Fixed

[CLJ-55] GC Issue 51: defmacro forms return nil when evaled

Tue, 24 Aug 2010 00:44:00 -0500

Reported by christophe.grand, Jan 19, 2009
defmacro forms return nil when evaled while defn and def forms return the
defined Var.

 defmacro-returns-var.patch
700 bytes Download
Comment 1 by richhickey, Jan 24, 2009
patch applied - svn 1230 - thanks!
Status: Fixed

[CLJ-54] GC Issue 50: Fully qualified/classpath relative filename in a Var's metadata

Tue, 24 Aug 2010 03:44:00 -0500

Reported by m...@kotka.de, Jan 19, 2009
Describe the feature/change.

Currently only the basename of the file where a Var is defined is stored in its metadata.
Unfortunately this is ambiguous. So extracting the exact position in the source tree
through use of the metadata is not possible.

Attached is a patch which stores

- the classpath relative filename for files loaded through the classpath or
- an absolute filename for files loaded via load-file

in the metadata of the Var. This removes any ambiguity.

Was this discussed on the group? If so, please provide a link to the discussion:

This was briefly asked on the #clojure channel.
http://clojure-log.n01se.net/date/2009-01-19.html#11:55

 issue-50.diff
921 bytes Download
Comment 1 by richhickey, Apr 12, 2009
Patch applied - r1349 - thanks!
Status: Fixed

[CLJ-36] GC Issue 32: Fix stray CPL comments and docstring for 'delay'

Tue, 24 Aug 2010 06:44:00 -0500

Reported by chouser, Jan 05, 2009
What (small set of) steps will reproduce the problem?

N/A

What is the expected output? What do you see instead?

N/A

What version are you using?

SVN 1195

Was this discussed on the group? If so, please provide a link to the
discussion:

http://groups.google.com/group/clojure/browse_thread/thread/b2d73537eca894f0/d5a3b1e31f80c49f

Please provide any additional information below.

 comments.patch
5.6 KB Download
Comment 1 by richhickey, Jan 06, 2009
oops - gotta change that comment template in all my editors

patch applied svn 1197 - thanks!
Status: Fixed

[CLJ-70] GC Issue 67: clojure.lang.Compile doesn't provide a way to control warn-on-reflection

Tue, 24 Aug 2010 00:45:00 -0500

Reported by cemer...@snowtide.com, Feb 06, 2009

Attached is a patch to add a warn-on-reflection option to  
clojure.lang.Compile.  In short, if the clojure.compile.warn-on-
reflection system property is set to "true", then *warn-on-reflection*  
is set to true for the duration of the compile process for the libs  
specified as command line args. 

This feature was discussed in #clojure on 2009.02.05:
http://clojure-log.n01se.net/date/2009-02-05.html#08:18

Comment 1  by richhickey, Feb 09, 2009

patch applied - svn 1260 - thanks!

Status: Fixed

[CLJ-72] GC Issue 69: Documentation: repl_and_main page should discuss use of java -jar clojure.jar

Tue, 24 Aug 2010 04:45:00 -0500

Reported by hlship, Feb 08, 2009

In many cases, when you have a script with no extra dependencies outside of
Clojure, it is easiest to:

java -jar clojure.jar myscript.clj

This should be mentioned on:

http://clojure.org/repl_and_main

Comment 1 by richhickey, Feb 09, 2009

This was discussed and it was agreed that this causes more problems later on for new
users when try to use other jars and -cp doesn't work

Status: WontFix

[CLJ-71] GC Issue 68: every? returns nil instead of false

Tue, 24 Aug 2010 04:45:00 -0500

Reported by pedro.dhb, Feb 07, 2009


What (small set of) steps will reproduce the problem?

(every? #{\space} "dam") #=> nil


What is the expected output? What do you see instead?
The expected output is false according to the API docs for every?. Currently nil is returned.

What version are you using?
SVN revision 1252

Was this discussed on the group? If so, please provide a link to the discussion:
It was mentioned on the IRC but not in the groups.

Please provide any additional information below.
_END _INFO



Comment 1 by slash2314, Feb 24, 2009

If need needs to return false in this case, I propose the following patch.

[CLJ-53] GC Issue 49: Complement ~x => (unquote x) with ~@x => (unquote-splicing x)

Tue, 24 Aug 2010 06:44:00 -0500

Reported by m...@kotka.de, Jan 18, 2009
Describe the feature/change.

Currently, ~ outside a syntax-quote is expanded to (clojure.core/unquote ..).
However this is not done for ~@. The attached patch also introduces the
expansion of ~@ to (clojure.core/unquote-splicing ...).

Was this discussed on the group? If so, please provide a link to the discussion:

http://groups.google.com/group/clojure/browse_frm/thread/6d0c5f7e37909055


 issue-49.diff
2.2 KB Download
Comment 1 by richhickey, Feb 09, 2009
patch applied - svn 1263 - thanks!
Status: Fixed

[CLJ-57] GC Issue 53: tree-seq arbitrarily requires its root arg to be a branch

Tue, 24 Aug 2010 10:44:00 -0500

Reported by christophe.grand, Jan 24, 2009
r1228:
user=> (tree-seq (constantly false) seq [1 2 3])
([1 2 3] 1 2 3) ; I expected ([1 2 3])

The actual behaviour of tree-seq is undefined when the root isn't a branch
since children is called upon root without any check.

The attached patch fixes this by always checking if a node is a branch
before calling children on it.

http://groups.google.com/group/clojure/browse_thread/thread/335707370295b654



 tree-seq.patch
1.6 KB Download
Comment 1 by richhickey, Jan 24, 2009
patch applied - svn 1231 - thanks!
Status: Fixed

[CLJ-76] GC Issue 73: proxy macro allows invalid method declaration

Tue, 24 Aug 2010 06:45:00 -0500

Reported by jbondeson, Feb 09, 2009

This patch was originally discussed in IRC on 2009-02-09.

The proxy macro allows you to define methods of the same name within the
same block.  This results in a last-defined-wins scenario.

user> (def p (proxy [java.util.concurrent.Future] [] (get [] 0) (get
[timeout unit] 2)))
#'user/p
user> (.get p 30 java.util.concurrent.TimeUnit/MILLISECONDS)
2
user> (.get p)
java.lang.IllegalArgumentException: Wrong number of args passed to:
user$fn--1271$fn (NO_SOURCE_FILE:0)

If the definitions are reversed the results are reversed:

user> (def q (proxy [java.util.concurrent.Future] [] (get [timeout unit] 2)
(get [] 0)))
#'user/q
user> (.get q)
0
user> (.get q 30 java.util.concurrent.TimeUnit/MILLISECONDS)
java.lang.IllegalArgumentException: Wrong number of args passed to:
user$fn--1416$fn (NO_SOURCE_FILE:0)

The correct way to do multiple files of different -arity is:

user> (def r (proxy [java.util.concurrent.Future] [] (get ([] 0) ([timeout
unit] 2))))
#'user/r
user> (.get r)
0
user> (.get r 30 java.util.concurrent.TimeUnit/MILLISECONDS)
2

The attached patch will catch an incorrect method redefinition and throw an
IllegalArgumentException identifying the method redefined.

Comment 1  by richhickey, Feb 10, 2009

patch applied - svn 1257 - thanks!

Status: Fixed

[CLJ-75] CG Issue 72: clojure.main/repl manipulates in in the body of the loop rather than in a read hook, can't override that behavior

Tue, 24 Aug 2010 03:45:00 -0500

Reported by scgilardi, Feb 09, 2009

What (small set of) steps will reproduce the problem?

    The defect is apparent by inspecting the source for clojure.main/repl.
Defect reported by Eric Thorsen.

What is the expected output? What do you see instead?

    N/A

What version are you using?

    svn 1263

Was this discussed on the group? If so, please provide a link to the
discussion:

    http://groups.google.com/group/clojure/browse_frm/thread/237632fbd6b3c01b

Please provide any additional information below.

    A patch is attached. I cleaned up the read manipulations into a new
repl-read hook. clojure.main/repl is more readable now. I also made
functions in clojure.main for repl-prompt and repl-caught, formerly inline
functions. Clarified some hook descriptions in the docs string for repl.
Avoided using a var (even private) for the eof sentinel in eval-opt.

Note: the number of arguments to the read hook has changed. When this patch
is applied, all previous read hooks will need an update. I'll handle the
one in clojure.contrib.repl-ln.

Comment 1  by richhickey, Feb 10, 2009

Thanks! While this patch says it is based on rev 1263, it doesn't seem to reflect the
changes of rev 1258:

http://code.google.com/p/clojure/source/diff?spec=svn1258&r=1258&format=side&path=/trunk/src/clj/clojure/main.clj

added for  issue 62 :

http://code.google.com/p/clojure/issues/detail?id=62

Is this just an oversight or was there a problem with that patch?


Comment 2 by scgilardi, Feb 10, 2009

It was just an oversight. I'm sorry about that. Thanks for catching it. The enclosed
patch: repl-read-2.patch includes the functionality from the fix to  issue 62 .

Comment 3  by richhickey, Feb 10, 2009

patch applied - svn 1269 - thanks!

Status: Fixed

[CLJ-67] GC Issue 64: Efficient, multi-arg clojure.set/union/difference/intersection

Tue, 24 Aug 2010 14:45:00 -0500

Reported by wolfe.a.jason, Feb 02, 2009

Describe the feature/change.

Efficient set operations that use information about set sizes to iterate
through smaller sets.

Was this discussed on the group? If so, please provide a link to the
discussion:

http://groups.google.com/group/clojure/browse_thread/thread/29609929e94f279c?hl=en&tvc=2&q=jason+set

http://groups.google.com/group/clojure/browse_thread/thread/b35ca9035762e1a4/67786ac082d5f6f4?hl=en&lnk=gst&q=jason+set#67786ac082d5f6f4

In particular, the second link describes the algorithms implemented in the
patch.

Also, since you didn't respond to my question, I decided to go ahead and
merge with this issue:

http://code.google.com/p/clojure/issues/detail?id=52&colspec=ID%20Type%20Status%20Priority%20Reporter%20Owner%20Summary

and make multi-arg versions.  I can provide a two-arg patch instead if you
prefer.

Right now, there is no calling of "set" or "set?", and so very unexpected
behavior may occur when non-sets are passed:

user=> (union #{1 2} #{4 5} [5 6 7] #{7 8})
[5 6 7 7 8 1 2 4 5]

(Since the vector is largest, it is used as the seed, and calling "into" on
it uses vector rather than set semantics).

user=> (intersection #{0 1} [5 6 7])
#{0 1}

(Since the set is smallest, it is used as the seed.  Then, when we ask the
vector if it "contains?" 0 or 1, it uses vector contains-index semantics
rather than set contains-value semantics).

If calling "set" on the arguments is low-overhead for things that are
already sets, I would be in favor of that rather than allowing the above
behaviors.  But, I got the impression you would not be, so I left this out
for now.  

Please let me know if you have any questions.

Comment 1  by richhickey, Feb 09, 2009

I don't understand the homemade sorts and two-arg-xxx fns

Comment 2 by wolfe.a.jason, Feb 09, 2009

The "homemade sorts" are several times faster than "sort" or the equivalent, because
they only need to extract the largest or smallest set from the arglist.  I couldn't
find a more concise or clear way of writing them that didn't slow the entire
functions down significantly when passed a few small sets.

The two-arg fns are just helpers, to avoid repeating the same code several times.

Take intersection, for instance.  The basic algorithm is:
  - Find and extract the smallest set from the arg-list
  - Successively intersect this with each other set, using two-arg-intersection
    (which iterates through the first set, which will always be smaller).
This means that intersection is O((size of smallest set) * (number of sets)) rather
than O(sum of set sizes) as you would get with a simpler implementation.



Comment 3 by richhickey, Feb 10, 2009

You could probably use min-key + remove if you don't need a full sort:

(let [mv (apply min-key count vs) ovs (remove #(identical? mv %) vs)]...

If the hand bubble still has utility, you could make it its own function. The
duplication in union and intersection is not good.

As far as the external two-arg-fns, all I meant was that there's no reason not to
make these the two-arg arity overloads themselves, i.e. the variable arity
'difference' can reduce with the arity-2 'difference'. Lots of Clojure code does this.


Comment 4 by wolfe.a.jason, Feb 10, 2009

My main goal in writing these was efficiency; in particular, my objective was to
perform as close to the current versions (with reduce) when passed a bunch of small
(e.g., single-element sets).  This meant trying to reduce the amount of per-argument
overhead.

I originally had factored out an extract-min (i.e., hand-bubble) function, but for it
to work for both union and intersection it had to take a compare or key function as
argument, and this seemed to slow things down substantially over inlining (along with
the one or two extra conses needed).

Similarly, the problem with making the two-arg version of intersection an arity
overload is that (the only way I can see how to do it) this would triple-up on calls
to count.  I guess there's no reason not to do it for difference though; that's
probably an artifact of an earlier version.

Anyway, I'll do some more experiments, try to clean these up a bit more, and submit
an updated patch.  In general, what's your feeling about trading off clarity of code
for efficiency?  For instance, if getting rid of the inlined hand-bubble causes a 50%
performance hit on small sets, is this worth it?

Thanks!

Comment 5 by richhickey, Feb 10, 2009

> In general, what's your feeling about trading off clarity of code for efficiency?  

I'm generally against it.

> For instance, if getting rid of the inlined hand-bubble causes a 50% performance
hit on small sets, is this worth it? 

Yes. Really, I don't want micro-optimized code like this in Clojure. Things change
pretty fast in JVM optimization, and the tweaks you make now can become completely
irrelevant or even counterproductive in the future. Best to keep things simple and clear.


Comment 6 by wolfe.a.jason, Feb 11, 2009

OK, a second stab at a patch is attached.  I've tried to clean things up as much as I
could without hurting efficiency too much.

In particular,
 - I extracted a bubble-max-key function.  I must have done something wrong before,
since this didn't actually slow things down by much.
 - I got rid of the "two-arg" functions.  This had no effect for difference, but
slowed down intersection by up to 40% by tripling calls to "count".

Overall, intersection is up to 45% slower than the previous version, union is up to
25% slower, and difference is the same.  If you really don't like bubble-max-key, you
can replace it by

(defn bubble-max-key [k coll]
  (let [max (apply max-key k coll)]
    (cons max (remove #(identical? max %) coll))))

but this will make union and intersection run about twice as slow on inputs like
[#{1} #{2} #{3}].

Thanks!

Comment 7  by richhickey, Feb 11, 2009

patch applied - svn 1276 - thanks!

Your analysis of how much % slower is flawed though, a classic example of improving
the time of something that will be only a small part of the total runtime with
non-trivial sized sets, i.e. the algorithmic differences matter, the constant factors
per set (count calls etc) don't.

Status: Fixed

[CLJ-58] GC Issue 54: defn with proxy inside with invalid proxy name gives a strange error

Tue, 24 Aug 2010 00:44:00 -0500

Reported by tuomas.lukka, Jan 27, 2009
------------------------------

What (small set of) steps will reproduce the problem?

(defn a []
    (proxy [Runnable] []
        (run [] (println "HEI"))))

(defn a []
    (proxy [Foo] []
        (run [] (println "HEI"))))


What is the expected output? What do you see instead?

I'd expect a reasonable compiler error. I get an internal
error instead.
java.lang.NullPointerException (test.clj:7)
 at clojure.lang.Compiler.analyzeSeq(Compiler.java:4113)
 at clojure.lang.Compiler.analyze(Compiler.java:3935)
 at clojure.lang.Compiler.analyze(Compiler.java:3908)
 at clojure.lang.Compiler$BodyExpr$Parser.parse(Compiler.java:3613)
 at clojure.lang.Compiler$FnMethod.parse(Compiler.java:3456)
 at clojure.lang.Compiler$FnMethod.access$1100(Compiler.java:3335)
 at clojure.lang.Compiler$FnExpr.parse(Compiler.java:2921)
 at clojure.lang.Compiler.analyzeSeq(Compiler.java:4104)
 at clojure.lang.Compiler.analyze(Compiler.java:3935)
 at clojure.lang.Compiler.analyzeSeq(Compiler.java:4094)
 at clojure.lang.Compiler.analyze(Compiler.java:3935)
 at clojure.lang.Compiler.access$100(Compiler.java:38)
 at clojure.lang.Compiler$DefExpr$Parser.parse(Compiler.java:366)
 at clojure.lang.Compiler.analyzeSeq(Compiler.java:4106)
 at clojure.lang.Compiler.analyze(Compiler.java:3935)
 at clojure.lang.Compiler.analyzeSeq(Compiler.java:4094)
 at clojure.lang.Compiler.analyze(Compiler.java:3935)
 at clojure.lang.Compiler.analyze(Compiler.java:3908)
 at clojure.lang.Compiler.eval(Compiler.java:4146)
 at clojure.lang.Compiler.load(Compiler.java:4470)
 at clojure.lang.Compiler.loadFile(Compiler.java:4437)
 at clojure.main$load_script__5177.invoke(main.clj:117)
 at clojure.main$script_opt__5209.invoke(main.clj:163)
 at clojure.main$_main__5222.doInvoke(main.clj:227)
 at clojure.lang.RestFn.applyTo(RestFn.java:142)
 at clojure.main.main(Unknown Source)
Caused by: java.lang.NullPointerException
 at clojure.lang.Reflector.invokeInstanceMethod(Reflector.java:26)
 at clojure.core$get_super_and_interfaces__4708.invoke(core_proxy.clj:195)
 at clojure.core$proxy__4729.doInvoke(core_proxy.clj:270)
 at clojure.lang.RestFn.invoke(RestFn.java:445)
 at clojure.lang.Var.invoke(Var.java:335)
 at clojure.lang.AFn.applyToHelper(AFn.java:180)
 at clojure.lang.Var.applyTo(Var.java:444)
 at clojure.lang.Compiler.macroexpand1(Compiler.java:4025)
 at clojure.lang.Compiler.analyzeSeq(Compiler.java:4092)
 ... 25 more



What version are you using?

20081217

Was this discussed on the group? If so, please provide a link to the
discussion:

Please provide any additional information below.

Comment 1 by tuomas.lukka, Jan 27, 2009
(and note that the first expression with Runnable works, the second with Foo is the
one that produces the error).
Comment 2 by richhickey, Apr 12, 2009
Fixed by r1342 - thanks for the report
Status: Fixed

[CLJ-80] GC Issue 77: r1265 causes VerifyError on dalvik

Tue, 24 Aug 2010 00:45:00 -0500

Reported by rwvtveer, Feb 12, 2009

The inlining as provided by r1265 produces verifyerrors on dalvik (android):

W/dalvikvm(  214): VFY: unable to resolve virtual method 6650: Ljava/lang/StringBuilder;.append (C)Ljava/lang/AbstractStringBuilder;
W/dalvikvm(  214): VFY:  rejecting opcode 0x6e at 0x0043
W/dalvikvm(  214): VFY:  rejected Lclojure/core$slurp__4218;.invoke(Ljava/lang/Object;)Ljava/lang/Object;
W/dalvikvm(  214): Verifier rejected class Lclojure/core$slurp__4218;
W/dalvikvm(  214): Exception Ljava/lang/VerifyError; thrown during Lclojure/core__init;.<clinit>
W/dalvikvm(  214): Exception Ljava/lang/RuntimeException; thrown during Lclojure/lang/RT;.<clinit>

As discussed on ml: http://groups.google.com/group/clojure/browse_thread/thread/399090b419f72add/395d3b2b32660211

Comment 1 by r.p.levy, Mar 11, 2009

Are you working on getting Clojure to function on the Android phone?  How can I learn
more about the status of that effort? Thanks! Rob

Comment 2 by rwvtveer, Mar 17, 2009

Without this r1265 changeset and the beans function AOT compiled code works on
dalvik.  Checkout http://github.com/remvee/clojure/ and
http://github.com/remvee/clojurehelloandroid/ if you want to play with clojure on
Android.

Comment 3 by richhickey, Apr 12, 2009

Fixed r1344 - thanks for the report!

Status: Fixed

[CLJ-81] GC Issue 78: patch to improve startup time on low end hardware

Tue, 24 Aug 2010 03:45:00 -0500

Reported by rwvtveer, Feb 12, 2009

As discussed on ml: http://groups.google.com/group/clojure/browse_thread/thread/c40b2973109db24/f7c51fddaaec0d3b

The attached patch provides custom constant serialization for:

* base types: String, Integer, Double, Character, Class, Symbol, Keyword and Var
* collections: IPersistentMap, IPersistentVector and IPersistentList/ISeq

If meta data is associated with on the emitted object it will be serialized and attached.  If the object is of a different type the previous method, using 
lispreader, is used.  The *print-initialized* hack is still in place because in a theoretical case it is still needed.

Comment 1  by richhickey, Mar 03, 2009

patch applied (w/some changes) - svn 1322 - thanks
I'd like top revisit this as a multimethod at some point

Status: Fixed

[CLJ-83] GC Issue 80: Make reference watch notification synchronous (again)

Tue, 24 Aug 2010 00:45:00 -0500

Reported by richhickey, Feb 12, 2009

since synchronous notification can send async actions, it offers more
flexibility than async-always

Comment 1 by richhickey, Mar 02, 2009

added add-watch, svn 1309

Status: Fixed

[CLJ-68] GC Issue 65: zip/remove does not return the correct loc

Tue, 24 Aug 2010 03:45:00 -0500

Reported by christophe.grand, Feb 04, 2009

What (small set of) steps will reproduce the problem?
user=> (require '[clojure.zip :as zip])
user=> (-> '((1 2) 3) zip/seq-zip zip/next zip/next zip/next zip/node)
2
user=> (-> '((1 2) 3) zip/seq-zip zip/next zip/next zip/next zip/next 
zip/node)
3
user=> (-> '((1 2) 3) zip/seq-zip zip/next zip/next zip/next zip/next 
zip/remove zip/node)
(1 2)

What is the expected output? 
2

Was this discussed on the group? If so, please provide a link to the
discussion:
http://groups.google.com/group/clojure/browse_thread/thread/794c17dd17d06b2c/8c2056d8310c2b68?lnk=gst&q=zip%2Fremove#8c2056d8310c2b68

Comment 1 by christophe.grand, Feb 04, 2009

This current patch introduce righmost as an helper function for this fix.

It also adds leftmost and prev which are germane but not directly related to this bug
and its fix.

Comment 2  by richhickey, Feb 09, 2009

patch applied - svn 1259 - thanks!

Status: Fixed

[CLJ-82] GC Issue 79: Allow read to accept readers other than a PushbackReader

Tue, 24 Aug 2010 00:45:00 -0500

Reported by p...@hagelb.org, Feb 12, 2009

"read" should be able to accept different kinds of readers, wrapping them
in a PushbackReader where necessary.

This should be implemented in LispReader.java rather than the read function
in core.clj, since the latter would require turning read into a multimethod.

http://groups.google.com/group/clojure/browse_thread/thread/fedbb2a63af633f0


Comment 1 by p...@hagelb.org, Feb 12, 2009

Attached a small patch that provides this and updates the docstring for read.

Simple test case: (= [1 2 3] (read (java.io.StringReader. "[1 2 3]")))

Comment 2  by p...@hagelb.org, Feb 20, 2009

Feel free to close this out as a wontfix; I can't find any way around the problems
brought up by the mailing list.

Comment 3 by richhickey, Feb 21, 2009

ok - WontFix

Status: WontFix

[CLJ-85] Double post of #84

Tue, 24 Aug 2010 00:45:00 -0500

Double post of #84

[CLJ-90] GC Issue 86: dorun implementation tripping lazy sequence assert logic

Tue, 24 Aug 2010 00:45:00 -0500

Reported by jbondeson, Feb 23, 2009

What (small set of) steps will reproduce the problem?

(dorun (list (lazy-seq nil)))

What is the expected output? What do you see instead?

This should not assert.

What version are you using?

svn r1300


Attached is a patch to have dorun use the do special form rather than force
the evaluation in the if statement.

Comment 1  by richhickey, Feb 23, 2009

fixed in svn 1301

Status: Fixed

[CLJ-91] GC Issue 87: *-seq should return seq/nil

Tue, 24 Aug 2010 00:45:00 -0500

Reported by aaraines, Feb 26, 2009

This patch alters line-seq, resultset-seq, re-seq, and tree-seq to return
nil if the LazySeq is empty, as discussed in #clojure.

http://clojure-log.n01se.net/date/2009-02-26.html#14:05

Comment 1  by aaraines, Feb 26, 2009

Patch against SVN 1309.

Comment 2 by aaraines, Feb 27, 2009

This patch uses (seq s) for its test rather than (first s).

[CLJ-73] GC Issue 70: Maven integration

Tue, 24 Aug 2010 06:45:00 -0500

Reported by hlship, Feb 08, 2009

It would be nice if Clojure could be deployed into a Maven repository, with
source, even if it does not use Maven to build.

This is just a matter of keeping the maven-ant-tasks JAR handy, and
providing a POM to identify the clojure version number.

Part of this would be to package the Java source for Clojure, to assist in
debugging.

If there is interest in this (I hope there is) I will be happy to provide a
patch.

I'm also interested in hosting a continuous integration build of Clojure at
Tapestry360 (http://tapestry.formos.com).

Comment 1 by hlship, Feb 08, 2009

Attached is a patch; it removes all but the essential content from pom.xml, and
extends build.xml with new targets for deploying.

You will need the copy of maven-ant-tasks-2.0.9.jar in the root directory.

I would recommend changing the groupId from "jvm.clojure" to "org.clojure" to follow
established standards.

Comment 2  by richhickey, Feb 09, 2009

Thanks.

Will they always need maven-ant-tasks-2.0.9.jar (i.e. when they don't care about
Maven)? Currently, building Clojure requires no deps other than Ant itself

Comment 3 by hlship, Feb 09, 2009

I could reformulate the patch so that maven-ant-tasks is only needed when performing
a deploy operation.  However, there is no problem with just checking the JAR into the
SVN repository. That's what I do on a number of projects that need to be otherwise
self-reliant (i.e., they then download their dependencies from Maven using the tasks
inside the maven-ant-tasks JAR).

Comment 4 by hlship, Feb 09, 2009

Is this stalled (.e. are you waiting for updated patch) or going forward with
checking the JAR in?

Comment 5 by richhickey, Feb 10, 2009

My current feeling is to not require any maven support jars for the current ant
process. Would Maven users have maven-ant-tasks anyway?

Would you mind asking on the group how people feel about having a jar that large in
the repository? Personally, I'm against it. Clojure doesn't come with Ant either.

Also, I don't know what the groupId is for, but yes, "org.clojure" seems better.

Comment 6 by hlship, Feb 10, 2009

The new patch fixes the groupId in pom.xml.  It also requires that users who want to
run the nightly-build or stable-build targets have a copy of the Maven ant tasks in
their $ANT_HOME/lib.  Since that's basically the CI server (for nightly builds) and
perhaps you, its not a problem.  Other users, with our without the Maven ant tasks,
can run the build as before.

Comment 7  by richhickey, Feb 10, 2009

Thanks! This seems like a fine plan, however your patch seems to be against a very
old rev, and I'm afraid of messing it up in the merge. Could you produce a patch
against current trunk?

Comment 8 by hlship, Feb 10, 2009

That's odd, I thought I had down a refresh before I started.  Give me a few minutes.

Comment 9 by hlship, Feb 10, 2009

Cleaned it up a lot; it now builds the slim jar and deploys it as an attached
artifact (meaning that Maven users can decide to use it instead of the full JAR by
providing <classifier>slim</classifier>, which is the whole point).

Comment 10  by richhickey, Feb 10, 2009

Hmm..., I'm still unable to apply this, seems to be built on rev 1162, we're up to
1265 now.

Comment 11 by hlship, Feb 10, 2009

Wierd.  I've never had svn give me this kind of trouble before.  I'll do a fresh
checkout and try again. It shouldn't be this difficult.

Comment 12 by hlship, Feb 10, 2009

OK.  Try this one. Freshly redid the changes.

BTW, If you have Maven installed it will look something like:

$ ant nightly-build
Buildfile: build.xml

clean:

init:
    [mkdir] Created dir: /Users/Howard/work/clojure/target/classes

compile-java:
    [javac] Compiling 121 source files to /Users/Howard/work/clojure/target/classes
    [javac] Note: Some input files use unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.

compile-clojure:
     [java] Compiling clojure.core to /Users/Howard/work/clojure/target/classes
     [java] Compiling clojure.main to /Users/Howard/work/clojure/target/classes
     [java] Compiling clojure.set to /Users/Howard/work/clojure/target/classes
     [java] Compiling clojure.xml to /Users/Howard/work/clojure/target/classes
     [java] Compiling clojure.zip to /Users/Howard/work/clojure/target/classes
     [java] Compiling clojure.inspector to /Users/Howard/work/clojure/target/classes

jar:
      [jar] Building jar: /Users/Howard/work/clojure/clojure.jar
      [jar] Building jar: /Users/Howard/work/clojure/clojure-slim.jar
      [jar] Building jar: /Users/Howard/work/clojure/target/clojure-sources.jar

all:

nightly-build:
[mvn:deploy] Deploying to file:/var/www/maven-snapshot-repository
[mvn:deploy] Uploading:
org/clojure/clojure-lang/1.0-SNAPSHOT/clojure-lang-1.0-20090211.005400-2.jar to remote
[mvn:deploy] Uploaded 1405K
[mvn:deploy] Uploading:
org/clojure/clojure-lang/1.0-SNAPSHOT/clojure-lang-1.0-20090211.005400-2-sources.jar
to remote
[mvn:deploy] Uploaded 276K
[mvn:deploy] Uploading:
org/clojure/clojure-lang/1.0-SNAPSHOT/clojure-lang-1.0-20090211.005400-2-slim.jar to
remote
[mvn:deploy] Uploaded 515K

BUILD SUCCESSFUL
Total time: 14 seconds
~/work/clojure
$ 

Comment 13  by richhickey, Feb 10, 2009

patch applied - svn 1270 - thanks!

Status: Fixed
Comment 14 by richhickey, Feb 11, 2009

I had to back out this patch as it broke the build destination directories

Status: Started
Comment 15 by hlship, Feb 11, 2009

Was there something sacrosanct about the classes going in ./build?  I follow the
conventions that all derived files go somewhere under ./target, such that the clean
target just has to delete that one directory.

This coding via patches thing is really annoying; it's like coding underwater!

Comment 16 by richhickey, Feb 11, 2009

Well, people can run Clojure by just putting the ./classes and ./src/clj dirs in the
classpath. I do this when the jar won't build due to broken code in core clj files,
or when making incremental changes on the Java side. ./classes is also the default
dir for AOT compilation, and people expect clean to clear it. So, it is a breaking
change.

Comment 17 by hlship, Feb 11, 2009

OK, then. I'll make a less intrusive patch if that's ok.

Comment 18 by hlship, Feb 11, 2009

Ok, this one puts the compiled classes into ./classes the way it was before.  I'm
checking to see if I can sign you CLA, and maybe I can help out more directly.  I'm
on the opposite side of this a lot, getting patches that are (sometimes) more work to
use than it would be to write the functionality myself from scratch!

Comment 19  by richhickey, Feb 21, 2009

I'm ready to give this another try if you could please make a patch based off of
trunk (there were some recent changes that need to be preserved). Also, these patches
seem to do a substantial reorganization of the file, making them difficult to assess.

Comment 20 by hlship, Feb 21, 2009

I'll have something together in about an hour.

Comment 21 by hlship, Feb 21, 2009

OK, I focused this time on making minimal disruption rather than making the Ant
build.xml more conformant.

Comment 22  by richhickey, Feb 21, 2009

patch applied - svn 1299 - thanks!

Status: Fixed
Comment 23 by dimi...@gashinsky.com, Feb 22, 2009

Cannot do mvn install after this patch
Attaching a fix to do ant install for the same effect.

[CLJ-86] GC Issue 82: read-line bug

Tue, 24 Aug 2010 00:45:00 -0500

Reported by DiscipleRayne, Feb 17, 2009

What (small set of) steps will reproduce the problem?

Call read-line

What is the expected output? What do you see instead?

Should accept input.

Instead it throws a clojure.lang.LineNumberingPushbackReader cannot be cast
to java.io.BufferedReader


What version are you using?

Rev 1286

Revision

1268

Was this discussed on the group? If so, please provide a link to the
discussion:

No

Please provide any additional information below.

Doesn't do this in the release version, only in the newest revisions. It's
been redefined, don't know why though.

Comment 1 by scgilardi, Mar 02, 2009

Discussion is here:

http://groups.google.com/group/clojure/browse_frm/thread/48f1fb08b3052083/eaff1f7c16ce84e2?tvc=1&q=read-line#eaff1f7c16ce84e2

Comment 2 by slash2314, Mar 02, 2009

A simple fix to this bug would be the following patch.

Comment 3  by chouser, Mar 02, 2009

slash2314: Have you sent in your CA?  If so, which name at
http://clojure.org/contributing is yours?

The bug appears to have been introduced by this change, line 1972:
http://tinyurl.com/ahhqaz

Registered contributor Perry Trolard has a fix here:
http://groups.google.com/group/clojure/msg/85f858df39daca2a

I've attached Perry's fix in patch form.

--Chouser

Comment 4  by richhickey, Mar 03, 2009

fixed in svn 1321 - thanks!

Status: Fixed

[CLJ-94] GC Issue 90: Support metadata on fns

Tue, 24 Aug 2010 06:45:00 -0500

Reported by richhickey, Mar 04, 2009

Requires dealing with the with-meta copying issues for closures

[CLJ-93] GC Issue 89: letrec

Tue, 24 Aug 2010 00:45:00 -0500

Reported by richhickey, Feb 27, 2009

add oft-requested letrec


Comment 1 by H.Duerer, Feb 27, 2009

I would find this quite useful.  As discussed on IRC channel the alternatives seem upgly.

In my need I basically want to do something like

(let [result (cons initial-value 
              (map complex-function result other-sequence1 other-sequence2 ...))]
  result)

Comment 2 by richhickey, Feb 28, 2009

added letfn - svn 1315

Status: Fixed

[CLJ-95] GC Issue 91: Documentation for rand inaccurate

Tue, 24 Aug 2010 06:45:00 -0500

Reported by joshuatfox, Mar 04, 2009

A minor issue.

The doc says that the number is between 0 and 1, but if the parameter n is 
not 1, then this is not accurate.

Reproduce as below in the REPL.



user=> (doc rand)
-------------------------
clojure.core/rand
([] [n])
  Returns a random floating point number between 0 (inclusive) and
  1 (exclusive).
nil
user=> (rand 100000)
44028.44964067226

Comment 1 by richhickey, Apr 09, 2009

fixd in r1343 - thanks for the report

Status: Fixed

[CLJ-96] GC Issue 92: Check for key identity in collections

Tue, 24 Aug 2010 06:45:00 -0500

Reported by chouser, Mar 09, 2009

Describe the feature/change.

Clojure code routes key lookups through
clojure.lang.Util.equiv()/equals(), which do an identity check.

Using the collections from outside Clojure may to more expensive
comparisons even on identical objects, so each collection should also
do an identity check.

Was this discussed on the group? If so, please provide a link to the
discussion:

http://groups.google.com/group/clojure/msg/6a2e491fcf564a68

[CLJ-92] GC Issue 88: Add :let support for 'doseq' and 'for'

Tue, 24 Aug 2010 00:45:00 -0500

Reported by chouser, Feb 26, 2009

Describe the feature/change.

Attached patch supports forms like:

(for [x (range 10)
      y (range 10)
      :let [z (+ x y)
            zz (- x y)]
      :when (< z 5)]
  [z zz])
-> ([0 0] [1 -1] [2 -2] [3 -3] [4 -4] [1 1] [2 0] [3 -1]
    [4 -2] [2 2] [3 1] [4 0] [3 3] [4 2] [4 4])

(doseq [x (range 10)
        y (range 10)
        :let [z (+ x y)
              zz (- x y)]
        :when (< z 5)]
  (prn z zz))
0 0
1 -1
2 -2
3 -3
4 -4
1 1
2 0
3 -1
4 -2
2 2
3 1
4 0
3 3
4 2
4 4
-> nil

Was this discussed on the group? If so, please provide a link to the
discussion:

http://clojure-log.n01se.net/date/2009-02-26.html#11:16b

Comment 1  by richhickey, Feb 27, 2009

I don't think there's any way to avoid becoming order-sensitive on these :options :(

Comment 2 by chouser, Feb 27, 2009

Still need to do 'for', but I think this should work for 'doseq':

(defmacro doseq
  "Repeatedly executes body (presumably for side-effects) with
  bindings and filtering as provided by \"for\".  Does not retain
  the head of the sequence. Returns nil."
  [seq-exprs & body]
  (assert-args doseq
     (vector? seq-exprs) "a vector for its binding"
     (even? (count seq-exprs)) "an even number of forms in binding vector")
  (let [step (fn step [recform exprs]
               (if-not exprs
                 [true `(do ~@body)]
                 (let [k (first exprs)
                       v (second exprs)
                       seqsym (when-not (keyword? k) (gensym))
                       recform (if (keyword? k) recform `(recur (next ~seqsym)))
                       steppair (step recform (nnext exprs))
                       needrec (steppair 0)
                       subform (steppair 1)]
                   (cond
                     (= k :let) [needrec `(let ~v ~subform)]
                     (= k :while) [false `(when ~v
                                            ~subform
                                            ~@(when needrec [recform]))]
                     (= k :when) [false `(if ~v
                                           (do
                                             ~subform
                                             ~@(when needrec [recform]))
                                           ~recform)]
                     :else [true
                            `(loop [~seqsym (seq ~v)]
                               (when-let [~k (first ~seqsym)]
                                 ~subform
                                 ~@(when needrec [recform])))]))))]
    (nth (step nil (seq seq-exprs)) 1)))

Comment 3 by chouser, Mar 02, 2009

Attached is a new patch that emits code for :while, :when, and :let in the order they
are given.  This allows :while and :when to guard each other as well as :let.  This
'doseq' is essentially the same as my previous comment, but won't stop when there's a
nil in the seq.  This 'for' is quite different from the 'doseq', and instead is
similar to the old 'for' with some refactoring.

Both 'for' and 'doseq' still pass the regression tests in
clojure.contrib.test-clojure.for.

Comment 4  by richhickey, Mar 03, 2009

patch applied - svn 1320 - thanks!

Status: Fixed

[CLJ-100] GC Issue 96: In FOR macro the :let clause does not establish a lexical binding

Tue, 24 Aug 2010 00:45:00 -0500

Reported by splendidlord, Mar 14, 2009

> What (small set of) steps will reproduce the problem?

In a fresh Clojure:
(for [a (range 5) :let [x (* a a)]] x)
==> java.lang.Exception: Unable to resolve symbol: x in this context

Now:
(def x -1000)
(for [a (range 5) :let [x (* a a)]] x)
==> (-1000 -1000 -1000 -1000 -1000)


> What is the expected output? What do you see instead?

It should be:
(for [a (range 5) :let [x (* a a)]] x)
==> (0 1 4 9 16)


> What version are you using?

SVN r1327

Comment 1 by splendidlord, Mar 14, 2009

Sorry, I have two clojure.jars on my system and I used an older one.
In r1327 this bug does not longer exist. Please close the issue, thanks.

Comment 2 by richhickey, Mar 16, 2009

(No comment was entered for this change.)

Status: Invalid

[CLJ-97] GC Issue 93: proxy: inheriting a method from more than one iface

Tue, 24 Aug 2010 03:45:00 -0500

Reported by christophe.grand, Mar 09, 2009

What (small set of) steps will reproduce the problem?
(do (proxy [clojure.lang.IPersistentVector] []) nil)

What is the expected output? What do you see instead?
Expected:
nil
Observed:
java.lang.ClassFormatError: Duplicate method name&signature in class file
clojure/proxy/java/lang/Object$IPersistentVector

Discussed on the group:
http://groups.google.com/group/clojure/msg/5cfc8d64fcbe2f52

Comment 1 by christophe.grand, Mar 09, 2009

Changed duplicate methods detection to not take the return type into account.
Changed stub generation to always generate a stub for the most specific return type.

Comment 2  by richhickey, Mar 16, 2009

patch applied - svn 1328 - thanks!

Status: Fixed
Comment 3 by christophe.grand, Mar 17, 2009

(No comment was entered for this change.)

Comment 4  by christophe.grand, Mar 17, 2009

with patch93bis.patch proxy emits bridge methods for covariant return types (except
for the method whose return type is the most specific)

Comment 5 by richhickey, Mar 17, 2009

(No comment was entered for this change.)

Status: Started
Comment 6 by richhickey, Mar 17, 2009

patch applied - r1333 - thanks!

Status: Fixed

[CLJ-79] GC Issue 76: adding sorted-set-by

Tue, 24 Aug 2010 14:45:00 -0500

Reported by timothypratley, Feb 11, 2009

http://groups.google.com/group/clojure/browse_thread/thread/9d280b6229aef38
4/0e5a2e1f80cb3810

user=> (sorted-set-by #(> (:hat %1) (:hat %2)) {:hat 2} {:hat 3} {:hat 1})
#{{:hat 3} {:hat 2} {:hat 1}}

Printed+signed CA is in the snail mail

[CLJ-104] GC Issue 100: gen-class creating non-compliant field names

Tue, 24 Aug 2010 03:45:00 -0500

Reported by solkis, Apr 04, 2009

The defect was described in this clojure group post by Michael Reid: 

http://groups.google.com/group/clojure/browse_thread/thread/e64719d716c29ce0

It appears that IBM JVMs have more stringent field name checking than do
the Sun JVMs.

Classes generated by gen-class and executing on IBM JVMs used with the
WebSphere Application Server require the basic fix outlined in the patch on
the thread above or the following error will result:

java.lang.ClassFormatError: JVMCFRE114 field name is invalid;

[CLJ-98] GC Issue 94: (ancestors ClassName) does not include tag ancestors of ClassName's superclasses

Tue, 24 Aug 2010 03:45:00 -0500

Reported by cemer...@snowtide.com, Mar 10, 2009

ancestors does not include the tag parents of a class' superclasses.  It
therefore is inconsistent with isa?.  Interaction example:

;;;;;;;;;;;
user=> (ancestors String)
#{java.io.Serializable java.lang.Object java.lang.CharSequence  
java.lang.Comparable}
user=> (ancestors Object)
nil
user=> (derive String ::foo)
nil
user=> (derive Object ::bar)
nil
user=> (isa? String ::foo)
true
user=> (isa? String ::bar)
true
user=> (ancestors Object)
#{:user/bar}
user=> (ancestors String)  ;; should include ::bar!
#{java.io.Serializable java.lang.Object java.lang.CharSequence :user/
foo java.lang.Comparable}
;;;;;;;;;;;

I'd expect that ::bar would be included in the set returned by  
(ancestors String).  A similar interaction involving only keywords shows
that the tag ancestors of a parent are obviously included in the set of
ancestors of a child:

;;;;;;;;;;
user=> (derive ::p ::gp)
nil
user=> (derive ::c ::p)
nil
user=> (ancestors ::c)
#{:user/p :user/gp}
;;;;;;;;;;

The fix appears to be relatively simple, assuming I'm fully understanding
the problem.  Patch attached.

Comment 1  by richhickey, Mar 17, 2009

patch applied - r1334 - thanks!

Status: Fixed

[CLJ-88] GC Issue 84: Wiki pages have wrong copyright year

Tue, 24 Aug 2010 00:45:00 -0500

Reported by hlship, Feb 21, 2009

It's listed as 2008, should start seeing 2009 for changed pages.

Comment 1 by richhickey, Feb 24, 2009

(No comment was entered for this change.)

Status: Fixed

[CLJ-101] GC Issue 97: partition-by does not work correctly when passed a function with side-effects

Tue, 24 Aug 2010 04:45:00 -0500

> What (small set of) steps will reproduce the problem?

(def coll '(a a b c nil nil nil d e f))
(partition-by #(or (nil? %) (gensym)) coll)
==> partition-by runs into an endless loop


> What is the expected output? What do you see instead?

From what the doc string says it seems that
partition-by would return:
((a) (a) (a) (b) (c) (nil nil nil) (d) (e) (f))
The provided function returns for non-nil elements
a new value.


> What version are you using?

r1327


> Please provide any additional information below.

A minimum change would be to update the doc strings,
stating that f must not have side-effects.
But if we would like to keep that door open, then the
current behaviour could be patched.
The problem is this:
In partition-by fv gets assigned (f (first s)), and
only a moment later (f (first s)) is evaluated again,
in the binding for run, in the take-while.
But as f has side effects we have:
(= (f (first s)) (f (first s))) ==> false
Now take-while will return an empty lazy-seq and the
drop will remove zero elements, as run is empty.

Instead fv should always be an element of run, and
take-while should run on the rest of s instead of on
s itself.

Comment 1  by richhickey, Mar 16, 2009

partition-by is not part of Clojure core

Status: Invalid

[CLJ-89] GC Issue 85: In a defn, arglists metadata becomes the first (unexpected?) symbol

Tue, 24 Aug 2010 03:45:00 -0500

Reported by jochu0, Feb 22, 2009

> What (small set of) steps will reproduce the problem?

(:arglists (meta (defn arglists broken-arglist ([a] a) ([a b] b))))
(broken-arglist)

> What is the expected output? What do you see instead?

I would expect ([a] [a b]) if not an error.

> What version are you using?

Using the latest clojure (r1298) and also likely to exist before lazy-seq.

> Was this discussed on the group? If so, please provide a link to the
discussion:

http://groups.google.com/group/clojure/browse_thread/thread/bafdb169330a9344

[CLJ-105] GC Issue 101: Strongly typed minus throws too often (with patch)

Tue, 24 Aug 2010 03:45:00 -0500

Reported by olov.lassus, Apr 04, 2009

First issue is for binary minus, long and int types.  Issue 40  touched upon
this but didn't cover all cases.

Actual (r1338):
user=> (- Integer/MAX_VALUE Integer/MIN_VALUE)
java.lang.ArithmeticException: integer overflow (NO_SOURCE_FILE:0)
user=> (- Long/MAX_VALUE Long/MIN_VALUE)      
java.lang.ArithmeticException: integer overflow (NO_SOURCE_FILE:0)
user=> (- (int -1) Integer/MIN_VALUE)         
java.lang.ArithmeticException: integer overflow (NO_SOURCE_FILE:0)
user=> (- (long -1) Long/MIN_VALUE)     
java.lang.ArithmeticException: integer overflow (NO_SOURCE_FILE:0)

Expected (with patch):
user=> (- Integer/MAX_VALUE Integer/MIN_VALUE)
java.lang.ArithmeticException: integer overflow (NO_SOURCE_FILE:0)
user=> (- Long/MAX_VALUE Long/MIN_VALUE)      
java.lang.ArithmeticException: integer overflow (NO_SOURCE_FILE:0)
user=> (- (int -1) Integer/MIN_VALUE)         
2147483647
user=> (- (long -1) Long/MIN_VALUE)   
9223372036854775807


Second issue is for unary minus, long type.

Actual (r1338):
user=> (- (long (Integer/MIN_VALUE)))
java.lang.ArithmeticException: integer overflow (NO_SOURCE_FILE:0)

Expected (with patch):
user=> (- (long (Integer/MIN_VALUE)))
2147483648

Comment 1  by richhickey, Apr 09, 2009

Patches applied - svn r1341 - thanks!

Status: Fixed

[CLJ-111] CG Issue 107: Old junk on sourceforge

Tue, 24 Aug 2010 04:45:00 -0500

Reported by chrisperkins99, Apr 15, 2009

The first google hit for "clojure download" points directly to an old
(2008-03-29) version on sourceforge.

Perhaps you should remove the download, or remove the whole sourceforge
project, or at least update it to point unsuspecting newbies to the new
google-code location for the project.


Comment 1 by richhickey, Apr 27, 2009

(No comment was entered for this change.)

Status: Fixed

[CLJ-74] GC Issue 71: IDeref print method can recurse infinitely

Tue, 24 Aug 2010 05:45:00 -0500

Reported by chouser, Feb 09, 2009

What (small set of) steps will reproduce the problem?

(binding [*print-level* 4]
  (let [a (atom nil)]
    (prn (reset! a a))))

What is the expected output? What do you see instead?

Desired output:
#<Atom@1e67e6a: #<Atom@1e67e6a: #<Atom@1e67e6a: #<Atom@1e67e6a: #>>>>

Actual output:
#<Atom@1a9d1b: #<Atom@1a9d1b: #<Atom@1a9d1b: #<Atom@1a9d1b: #<Atom@1a9d1b:
#<Atom@1a9d1b: #<Atom@1a9d1b: #<Atom@1a9d1b: ...etc...
StackOverflowError (NO_SOURCE_FILE:0)

What version are you using?

SVN trunk 1261

Was this discussed on the group? If so, please provide a link to the
discussion:

http://clojure-log.n01se.net/date/2009-02-09.html#17:53d

Please provide any additional information below.

Quick work-around for anyone seeing this problem:
(remove-method print-method clojure.lang.IDeref)

At the very least, the *print-level* should be honored, and the
attached patch does that.

Comment 1  by richhickey, Feb 10, 2009

patch applied - svn 1266 - thanks!

Status: Fixed

[CLJ-78] GC Issue 75: stackoverflow when counting a long cons chain

Tue, 24 Aug 2010 06:45:00 -0500

Reported by chouser, Feb 10, 2009

What (small set of) steps will reproduce the problem?

(count (nth (iterate #(cons 1 %) [0]) 10000))

What is the expected output? What do you see instead?

Expected: 10001
Actual:   java.lang.StackOverflowError (NO_SOURCE_FILE:0)

What version are you using?

SVN 1263 trunk

Was this discussed on the group? If so, please provide a link to the
discussion:

http://groups.google.com/group/clojure/browse_thread/thread/7bfb8898fb393afc/1a20cba75a95ceca

Please provide any additional information below.

As a result of the conversation linked above, the following issue was
created:

http://code.google.com/p/clojure/issues/detail?id=36

The patch attached here depends on the patch from  issue 36  above,
specifically a Counted marker interface.  With both patches applied:

Using 'count' on a large Cons chain no longer crashes:

(def x (nth (iterate #(cons 1 %) [0]) 10000000))

user=> (time (count x))
"Elapsed time: 337.329691 msecs"
10000001

Using 'count' on a vector of the same size is of course still much
faster:

user=> (def y (into [] x))
user=> (time (count y))
"Elapsed time: 0.092615 msecs"
10000001

Counting a cons of a single item onto a vector seq is still much
faster than walking the whole length of the seq:

user=> (time (count (cons 1 y)))
"Elapsed time: 0.159946 msecs"
10000002

Comment 1  by richhickey, Feb 10, 2009

patch applied - svn 1268 - thanks!

Status: Fixed

[CLJ-106] GC Issue 102: Possible bug in proxy: NPE for unqualified class

Tue, 24 Aug 2010 03:45:00 -0500

Reported by paul.drummond.webmail, Apr 05, 2009

Using latest svn version of clojure (rev 1338)

The following works - note ActionListener is fully qualified:

-----
user=> (.addActionListener (javax.swing.JButton.)
                   (proxy [java.awt.event.ActionListener] []
                     (actionPerformed [evt]
                                      (println "button press"))))
nil
-----
If I remove the package name I get a NullPointerException:

-----
user=> (.addActionListener (javax.swing.JButton.)
                   (proxy [ActionListener] []
                     (actionPerformed [evt]
                                      (println "button press"))))
java.lang.NullPointerException (NO_SOURCE_FILE:161)
user=>
------

Of course, I haven't imported ActionListener so I wouldn't expect it
to evaluate without error - I just wasn't expecting a
NullPointerException.

Comment 1 by richhickey, Apr 09, 2009

fixed in r1342 - thanks for the report

Status: Fixed

[CLJ-116] CG Issue 112: Use platform default encoding for in, out, and err

Tue, 24 Aug 2010 03:45:00 -0500

Reported by scgilardi, Apr 29, 2009

What (small set of) steps will reproduce the problem?

    Code inspection, RT.java

What is the expected output? What do you see instead?

    *in* *out* and *err* use UTF-8 encoding currently. Using the platform
default encoding (as determined by the JVM environment) is a better choice.

What version are you using?

    SVN 1359

Was this discussed on the group? If so, please provide a link to the
discussion:

    http://groups.google.com/group/clojure/browse_frm/thread/621aa30c78ba1b9e

Please provide any additional information below.

    As requested, a patch is enclosed. Note that this changes only *in*,
*out*, and *err*. Clojure source files are still expected (by the reader
and compiler) to be UTF-8 encoded.

Comment 1  by richhickey, Apr 29, 2009

Patch applied - r1360 - thanks!

Status: Fixed

[CLJ-117] GC Issue 113: Incorrect handling of trailing decimal points in numbers

Tue, 24 Aug 2010 00:45:00 -0500

Reported by scgilardi, May 04, 2009

What (small set of) steps will reproduce the problem?

        user=> (class 123.)
        java.lang.Integer

In contrast, Java reads such a number as a double.

        % javac Foo.java
        Foo.java:5: possible loss of precision
        found   : double
        required: int
                    int a = 123.;
                            ^
        1 error

Another place this comes up is with a number formatted as 123.e4.  
Currently that's an invalid number in Clojure:

        user=> (class 123.e4)
        java.lang.NumberFormatException: Invalid number: 123.e4
        java.lang.Exception: Unmatched delimiter: )
        user=>

Java reads it as 1230000.0

What version are you using?

1.0.0

Was this discussed on the group? If so, please provide a link to the
discussion:

http://groups.google.com/group/clojure/browse_thread/thread/c0db774b78171b9b/c57e878f11f2f199?lnk=gst&q=number#c57e878f11f2f199

Please provide any additional information below.

I've enclosed a patch to LispReader.java that fixes the problem. The patch
contains two changes, one necessary, one optional:

necessary: change the regular expressions intPat and floatPat so that "1."
is not considered an "int" and "1.e3" is accepted as a legal float.

optional: change the handling of the "M" suffix in matchNumber to make the
float handling code use matcher groups like the int and bigint handling
code does rather than using string manipulations.

I recommend both changes.

Comment 1  by scgilardi, May 04, 2009

I've attached a patch to clojure-contrib/src/clojure/contrib/test_clojure/reader.clj
to provide additional tests for reading Doubles and BigDecimals that pass with the
fixed Clojure LispReader.

[CLJ-119] GC Issue 115: Document that #^chars works

Tue, 24 Aug 2010 03:45:00 -0500

Reported by hlship, May 05, 2009

In the Java Interop documentation, it identifies a number of special tags
that can be used to identify parameters of primitive arrays.

It does not list #^chars (equivalent to char[]) but this appears to (at
least partially) work.

On a related note, for this code:

(def #^StringBuilder *buffer*)

(defn- add-text
  "Adds text to the buffer and manages the *text-location* var."
  [#^chars ch start length]
  (.append *buffer* ch start length)  ;;;; line 98
  (when (nil? *text-location*)
        (set! *text-location* (current-location))))


I still get 

Reflection warning,
com/howardlewisship/cascade/internal/xmltokenizer.clj:98 - call to append
can't be resolved.

[CLJ-122] GC Issue 118: Patch to add :svn to clojure-version

Tue, 24 Aug 2010 06:45:00 -0500

Reported by miki.tebeka, May 16, 2009

Attached is a patch to add :svn to *clojure-version*.
In order for it to work do "svn ps svn:keywords Revision
src/clj/clojure/core.clj"

This way when people report problem in clojure, we can know the exact
revision they are talking about.

[CLJ-123] GC Issue 119: require doc out of date

Tue, 24 Aug 2010 03:45:00 -0500

Reported by hlship, May 20, 2009

The following doc for the (require) form seems to be out of date:

  'require loads a lib by loading its root resource. The root resource path
  is derived from the root directory path by repeating its last component
  and appending '.clj'. For example, the lib 'x.y.z has root directory
  <classpath>/x/y/z; root resource <classpath>/x/y/z/z.clj. The root
  resource should contain code to create the lib's namespace and load any
  additional lib resources.

Unless I'm missing something big, the root resource is
<classpath>/x/y/z.clj.  I'm not sure how the root directory feeds into
things now. If I remember back about 6 months, an older version of Clojure
did it this way.

[CLJ-125] GC Issue 121: slurp should accept an encoding name

Tue, 24 Aug 2010 03:45:00 -0500

Reported by cemer...@snowtide.com, Jun 09, 2009

clojure.core/slurp currently does not accept an encoding to use when
reading the content from the provided path.  Using the system-default
encoding is a very common failure pattern.

Attached is a patch which adds an encoding argument to slurp (while
retaining the existing behaviour of falling back on the system-default
encoding when one is not specified).

[CLJ-108] GC Issue 104: macro call from Java isn't evaluated

Tue, 24 Aug 2010 05:45:00 -0500

Reported by csaager, Apr 10, 2009

What (small set of) steps will reproduce the problem?
(defn abb [a [b] [& c]] b)
(defmacro extr [fun] `((meta (var ~fun)) :arglists))

Java 
Var extr,abb ...
Object arglists = extr.invoke(abb) 



What is the expected output? What do you see instead?
Expected ([a [b] [& c]]) (like in REPL)
Got: ((clojure.core/meta (var
#'org.enclojure.ide.nb.editor.ClojureSourceTemplate/abb)) :arglists) (a Cons)

What version are you using?
org-enclojure-ide-nb-editor-20090406.590.1337.nbm

Was this discussed on the group? If so, please provide a link to the
discussion:

Please provide any additional information below.

I tried to call Compiler.eval(arglists) and eval.invoke(arglists), both
threw an exception
Exception in thread "main" java.lang.ClassCastException: clojure.lang.Var
cannot be cast to clojure.lang.Symbol (NO_SOURCE_FILE:0)
        at clojure.lang.Compiler.analyzeSeq(Compiler.java:4493)
        at clojure.lang.Compiler.analyze(Compiler.java:4315)
        at clojure.lang.Compiler.analyze(Compiler.java:4276)
        at clojure.lang.Compiler$InvokeExpr.parse(Compiler.java:2761)
        at clojure.lang.Compiler.analyzeSeq(Compiler.java:4488)
        at clojure.lang.Compiler.analyze(Compiler.java:4315)
        at clojure.lang.Compiler.analyze(Compiler.java:4276)
        at clojure.lang.Compiler$InvokeExpr.parse(Compiler.java:2757)
        at clojure.lang.Compiler.analyzeSeq(Compiler.java:4488)
        at clojure.lang.Compiler.analyze(Compiler.java:4315)
        at clojure.lang.Compiler.analyze(Compiler.java:4276)
        at clojure.lang.Compiler$BodyExpr$Parser.parse(Compiler.java:3852)
        at clojure.lang.Compiler$FnMethod.parse(Compiler.java:3687)
        at clojure.lang.Compiler$FnMethod.access$1100(Compiler.java:3564)
        at clojure.lang.Compiler$FnExpr.parse(Compiler.java:2953)
        at clojure.lang.Compiler.analyzeSeq(Compiler.java:4484)
        at clojure.lang.Compiler.analyze(Compiler.java:4315)
        at clojure.lang.Compiler.eval(Compiler.java:4520)
        at clojure.core$eval__3975.invoke(core.clj:1743)
        at clojure.lang.Var.invoke(Var.java:346)
        at com.yourcompany.NewClass.main(NewClass.java:32)
Caused by: java.lang.ClassCastException: clojure.lang.Var cannot be cast to
clojure.lang.Symbol
        at clojure.lang.Compiler$TheVarExpr$Parser.parse(Compiler.java:485)
        at clojure.lang.Compiler.analyzeSeq(Compiler.java:4486)
        ... 20 more



Comment 1 by durka42, Apr 12, 2009

I am not sure this is a bug.

Macros are just functions with a bit set in the metadata, so when called like
functions they should just return code.
extr.invoke(abb) returns ((clojure.core/meta (var #'clojure.core/abb)) :arglists).
Note that the macro was called with the Var abb. When evaluated, this throws an
exception because var was called with a Var instead of a symbol (it is meant to be
called as (var abb)).
What the REPL does is more like extr.invoke(RT.readString("abb")) or
extr.invoke(Symbol.create("abb")), both of which return ((clojure.core/meta (var
abb)) :arglists) which can be evaluated as you expect.

Comment 2  by richhickey, Apr 12, 2009

Please discuss things like this on the group to clarify the issue and your
understanding before posting an issue here - thanks.

Status: Invalid

[CLJ-87] GC Issue 83: PersistentArrayMap trust the reader (map literals) too much

Tue, 24 Aug 2010 00:45:00 -0500

Reported by karmazilla, Feb 17, 2009

What (small set of) steps will reproduce the problem?

PersistentArrayMap gets it wrong:

user=> {1 1 1 1 1 1 2 2}
{1 1, 1 1, 1 1, 2 2}

What is the expected output? What do you see instead?

But PersistentHashMap gets it right:

user=> (hash-map 1 1 1 1 1 1 2 2)
{1 1, 2 2}

What version are you using?

rev 1286.

Was this discussed on the group? If so, please provide a link to the 
discussion:
http://groups.google.com/group/clojure/browse_thread/
thread/5a38a6b61b09e025

Please provide any additional information below.

PersistentArrayMap seems to be the culprits. Line 65 to 73. They should 
probably assoc the individual items like PersistentHashMap do, I guess.

[CLJ-102] GC Issue 98: proxy emits bytecode improperly referring to 21- & 22-arg overloads of IFn.invoke (Regression?)

Tue, 24 Aug 2010 06:45:00 -0500

Reported by cemer...@snowtide.com, Mar 15, 2009

Attempting to obfuscate a jar that includes clojure.jar's contents using
proguard results in two errors:

 [proguard] Warning: clojure.proxy.clojure.lang.APersistentMap: can't find
referenced method 'java.lang.Object
invoke(java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object)'
in class clojure.lang.IFn
 [proguard] Warning: clojure.proxy.clojure.lang.APersistentMap: can't find
referenced method 'java.lang.Object
invoke(java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object)'
in class clojure.lang.IFn

This is almost identical to a previously reported (and fixed) problem with
gen-class, where it used to emit 21- and 22-argument overloads of
IFn.invoke that delegated to the gen-class' superclass' implementation
(which obviously doesn't provide IFn.invoke overloads with greater than 20
arguments).  This issue was reported and fixed last August:

http://groups.google.com/group/clojure/browse_thread/thread/b3698314084d8f54

Looks like the problem has cropped up again, only this time in conjunction
with AOT compiled proxies.

Comment 1 by cemer...@snowtide.com, Mar 16, 2009

Fixed in r1330 -- thanks, Rich!

Comment 2 by richhickey, Mar 16, 2009

(No comment was entered for this change.)

Status: Fixed

[CLJ-109] GC Issue 105: Build patch: install results to local Maven repository

Tue, 24 Aug 2010 03:45:00 -0500

Reported by hlship, Apr 10, 2009

This patch creates a ci-build target that builds and installs the results
to the local Maven repository (where those changed JARs will be visible to
the clojure-contrib ci-build).

Comment 1  by dimi...@gashinsky.com, Apr 11, 2009

I've submitted a similar patch to the  Issue 70 .
Hope this one goes in.

Comment 2 by richhickey, Apr 14, 2009

Patch applied - r1352 - thanks!

Status: Fixed

[CLJ-114] GC Issue 110: clojure version number patch

Tue, 24 Aug 2010 00:45:00 -0500

Reported by laurent....@gmail.com, Apr 26, 2009

Patch with the necessary changes to handle version numbering for clojure:

 * a src/clj/clojure/version.properties file
 * this version.properties file is the reference for version numbers. It is
on the classpath so it can be seen by clojure at runtime. It is in a
subdirectory of clojure-the-project so any tool can refer to it relatively
to the installation of clojure.

 * I've added the necessary code to clojure to load clojure version number
at startup time


I've also added function (clojure.core/clojure-version) that will return a
string representing the version from the structured *clojure-version* map.
The algorithm here is simple: 
<MAJOR>.<MINOR>[.<INCREMENT>][-<QUALIFIER>][-SNAPSHOT]

 * I've changed the ant build.xml so that it creates fully qualified names
with version attributes for the generated jars.
 * Note on the :interim attribute: to protect the person who makes releases
from itself, instead of considering :interim to be true if there is the
"true" string in the properties file, I've made the opposite choice:
interim is true for any value other than "false". So if there is a typo in
version.properties (e.g. tru instead of true), then the release will be
marked as interim, and that will not be a big deal. In the other case, it
would be a big deal if an official release was made accidentally instead of
an interim.

* finally, pom.xml file is now generated from ant as part of the classic
init step.

Note: I strongly suggest that the clojure.version.interim property remains
true in svn, so that it's not possible to inadvertently release a version
"too early".

Comment 1  by richhickey, Apr 27, 2009

I can't apply the patch due to missing pom-template.xml?

Also, could you just put the contents of core_version.clj into core.clj? I'd rather
not have another file just for this.

Thanks!

Comment 2 by laurent....@gmail.com, Apr 27, 2009

OK, core_version.clj content back into core.clj.

There was a problem with pom-template.xml probably because I tried on my local
working copy to make a svn rename pom.xml pom-template.xml, and somehow the svn diff
command did not like that.

What I've done in the current patch is first svn remove pom.xml then svn add
pom-template.xml.

Comment 3  by richhickey, Apr 27, 2009

patch applied- svn 1357 - thanks!

Status: Accepted
Comment 4 by scgilardi, May 12, 2009

(clojure-version) for 1.0 has a trailing "-". The intention (as noted above in the
issue) is that when the qualifier is absent, there should be no "-". The current
setup is reading a blank qualifier as an empty string, but checking later for nil
rather than nil or the empty string.

Clojure 1.0.0-
user=> *clojure-version*
{:major 1, :minor 0, :incremental 0, :qualifier ""}
user=> (clojure-version)
"1.0.0-"
user=> 



Comment 5 by laurent....@gmail.com, May 12, 2009

OK, a mistake on my part.

Rich, I also see you have made implicitly the "incremental" attribute mandatory in
trunk (since you apply Integer/valueOf on it without checking for nullity or string
emptyness).

If it is intentional, I can also add in the corrective patch a modified build.xml
that verifies this (incremental being mandatory) when building with ant, or I can
change the patch to keep the "incremental" attribute optional.

Waiting for your answer before creating the patch.

[CLJ-128] Ensure that PersistentTreeMap.empty() (and therefore PersistentTreeSet.empty()) retain the callee's comparator

Tue, 24 Aug 2010 07:45:00 -0500

Currently:

user=> (-> (sorted-set-by (comparator >) 1 2 3) empty (into [1 2 3]))
#{1 2 3}

The above should evaluate to #{3 2 1} (the provided comparator is being dropped by the 'empty' call).

[CLJ-132] Agents printed at the REPL do not always reflect their value

Tue, 24 Aug 2010 07:46:00 -0500

Starting with a fresh REPL and entering the following:

(def counter (agent 0))
(defn add1 [x] (inc x))
(send counter add1)
;; repeat many times
(send counter add1)

The representation printed at the REPL will not always display the correct value for the agent (e.g. the second call to `send` would print #<Agent@743fba: 1>). This appears to happen only in the first few calls to `send` before the value eventually "catches up". This behavior of course never occurs with `send-off`. This appears to only affect the printed value and not the actual value, but can still cause confusion.

My setup is as follows:
Mac OSX 10.5
Clojure 1.0.0
Running with `java -server -cp $CP jline.ConsoleRunner clojure.lang.Repl $*` where $CP points to clojure.jar, clojure-contrib.jar, and jline.jar

This also occurs with a fresh build of Clojure 1.1.0-alpha-SNAPSHOT from github.

-m

[CLJ-133] GC Issue 68: every? returns nil instead of false

Tue, 24 Aug 2010 03:46:00 -0500

This ticket is for tracking #71 against Clojure 1.0

[CLJ-134] *-zip lose metadata

Tue, 24 Aug 2010 03:47:00 -0500

vector-zip and seq-zip do not transport metadata on the nodes.

Reported by Justin Balthrop on #clojure.

To reproduce:

1. Create a vector with metadata.
2. Create a vector zipper.
3. Move in the tree.
4. Recreate the root.

Now the metadata is lost.

Proposed fix:

Move the metadata in the make-node function of the vector zipper.

Patch attached.

[CLJ-135] zipper: children does not check node type

Tue, 24 Aug 2010 00:47:00 -0500

children does not check the node type.

Reported by Justin Balthrop on #clojure.

To reproduce:

(-> (clojure.core/vector-zip '[(1 2) (3 4)]) clojure.zip/down clojure.zip/down) descends into the list, where it should not.

Proposed fix:

children should check branch? and throw an exception if the node is actually a leaf.

Patch attached.

[CLJ-136] Enhancement: give meaningful names to inline expanders

Tue, 24 Aug 2010 00:48:00 -0500

Currently inline expander fns are anonymous, so the errors they report have no context:

user=>  (pos? 3 4)
java.lang.IllegalArgumentException: Wrong number of args passed to: core$fn (NO_SOURCE_FILE:114)
</code></pre>

Could be fixed by supplying a name to expander:

<pre><code>:inline (fn pos? [x] ...)

[CLJ-131] Move Clojure tests from contrib into Clojure

Tue, 24 Aug 2010 06:46:00 -0500

See this page in the wiki:

http://www.assembla.com/wiki/show/clojure/Getting_Tests_Into_Clojure

[CLJ-110] GC Issue 106: clojure.main should exit with non-zero code on unhandled exceptions

Tue, 24 Aug 2010 03:45:00 -0500

Reported by duelin.markers, Apr 12, 2009

See discussion in this thread:
http://groups.google.com/group/clojure/browse_thread/thread/8861acaff4db422d

Currently the following exits with a success exit code (zero).
java -jar clojure.jar clojure.main -e "some-garbage"

The attached patch allows unhandled exceptions to bubble up so the JVM can
terminate the way it normally would.

Comment 1  by richhickey, Apr 14, 2009

Fixed - r1351 - thanks for the report

Status: Fixed

[CLJ-138] min and max history for refs

Tue, 24 Aug 2010 00:50:00 -0500

knobs for history control. With positive min-history, will keep history even in absence of detected conflict. max history will limit dynamic history accumulation.

[CLJ-142] Bug: Compile-time NPE on set! of non-existent field

Tue, 24 Aug 2010 03:51:00 -0500

(set! (.foo "fred") 47)

[CLJ-146] NPE when creating an empty array of ints, longs, floats or doubles

Tue, 24 Aug 2010 06:53:00 -0500

(int-array []) should return an empty array - the same as (int-array 0). Also true for long-array, float-array and double-array.

user=> (doc int-array)
-------------------------
clojure.core/int-array
([size-or-seq] [size init-val-or-seq])
Creates an array of ints

OK:
user=> (int-array [1 2])
#<int[] [I@1342ba4>
user=> (vec (int-array [1 2]))
[1 2]

NPE:
user=> (int-array [])
java.lang.NullPointerException (NO_SOURCE_FILE:0)

OK:
user=> (int-array 2)
#<int[] [I@18d9850>
user=> (vec (int-array 2))
[0 0]
user=> (int-array 0)
#<int[] [I@1e97f9f>
user=> (vec (int-array 0))
[]

NPE:
user=> (long-array [])
java.lang.NullPointerException (NO_SOURCE_FILE:0)
user=> (float-array [])
java.lang.NullPointerException (NO_SOURCE_FILE:0)
user=> (double-array [])
java.lang.NullPointerException (NO_SOURCE_FILE:0)

user=> (int-array ())
java.lang.NullPointerException (NO_SOURCE_FILE:0)
user=> (int-array {})
java.lang.NullPointerException (NO_SOURCE_FILE:0)
user=> (int-array #{})
java.lang.NullPointerException (NO_SOURCE_FILE:0)

[CLJ-145] clojure.set/rename-keys doesn't do what it says it should

Tue, 24 Aug 2010 06:52:00 -0500

user=> (doc rename-keys)
-------------------------
clojure.set/rename-keys
([map kmap])
Returns the map with the keys in kmap renamed to the vals in kmap
nil

I expect the return value to be a map of the same size as the first input, with its keys being those in the first input other than those which are substituted according to the second. That is not what occurs:

user=> (rename-keys {:foo 1 :bar 2} {:foo :new-foo :zob :new-zob})
{:new-zob nil, :new-foo 1, :bar 2}

Tested against a1397390d8b3b63f2039359520629d87b152d717 (current at time of filing).

[CLJ-151] Function to return last n items of a seq

Tue, 24 Aug 2010 03:55:00 -0500

My fork on github of clojure had a last-n branch that is an unacceptable breaking change by returning a seq even for just a single item. A different solution is needed.

[CLJ-154] (keyword "a/b") => ns nil, name a/b; should be ns a, name b

Tue, 24 Aug 2010 06:55:00 -0500

From: http://groups.google.com/group/clojure/browse_thread/thread/c792fd218bedea1f

for generated keywords, seems dodgy
(keyword "aaaaa/bbbbb") => :aaaaa/bbbbb
(name (keyword "aaaaa/bbbbb")) => "aaaaa/bbbbb"
(namespace (keyword "aaaaa/bbbbb")) => nil

It would seem cleaner if the java Keyword.intern() and Symbol.intern()
methods were symmetrical and used the same way in core.clj.

[CLJ-155] Classname/staticThing leaves Classname unresolved at syntaxQuote time

Tue, 24 Aug 2010 00:55:00 -0500

Class names for static field and method references are resolved differently for modern vs. old syntax:

user=> `(Integer/foo)
(Integer/foo)
user=> `(. Integer foo)
(. java.lang.Integer user/foo)

This means that using an imported class in a defmacro via modern syntax will break if the macro is expanded in a namespace that doesn't have that class imported, or worse could attempt to a same-named class from a different package.

Reported by technomancy in IRC

[CLJ-144] test-clojure: change (are _ ...) to (are [x] (true? x) ...)

Tue, 24 Aug 2010 04:52:00 -0500

Old clojure.contrib.test-is framework used (are _ value1 value2 ...) syntax for testing if all values are logically true. New clojure.test uses (are [x] (true? x) value1 value2 ...) or (are [x] (if x true false) value1 value2 ...) and this change needs to be reflected in test_clojure/numbers.clj.

[CLJ-141] GC Issue 119: require doc out of date

Tue, 24 Aug 2010 03:51:00 -0500

This ticket is for tracking #123 against branch 1.0

[CLJ-139] defmulti should not add {:tag 'clojure.lang.MultiFn} to multimethod metatdata

Mon, 11 Oct 2010 15:25:00 -0500

defmulti's current behavior of adding a {:tag 'clojure.lang.MultiFn} to the new multimethod's metadata interferes with providing a type hint for the return value of the multimethod. This is easily fixed by deleting this behavior, as in the attached patch.

[CLJ-156] Classname/staticThing leaves Classname unresolved at syntaxQuote time [for 1.0 from #155]

Wed, 22 Sep 2010 14:27:00 -0500

Classname/staticThing leaves Classname unresolved at syntaxQuote time [for 1.0 from #155]

[CLJ-152] Doc string for "binding" should be explicit about binding in parallel

Tue, 24 Aug 2010 00:55:00 -0500

As Tom mentions here: http://groups.google.com/group/clojure/browse_frm/thread/81fc236d3436d72b
the parallel nature of the bindings created by "binding" does not appear to be documented either in its doc string or at clojure.org.
The doc string for binding should mention it.

A proposal for discussion/approval:

clojure.core/binding
([bindings & body])
Macro
binding => var-symbol init-expr

Creates new bindings for the (already-existing) vars, with the
supplied initial values, executes the exprs in an implicit do, then
re-establishes the bindings that existed before. The new bindings
are made in parallel: all init-exprs are evaluated before the
vars are bound as a group to their new values.

[CLJ-143] support overlapping ensures with no retry

Tue, 24 Aug 2010 04:52:00 -0500

Currently ref ensures have same retry effects as set/alters. Allow overlapping ensures to succeed without retry

Discussed here:

http://groups.google.com/group/clojure/browse_frm/thread/f7b4365b1c71b665/717e1a18c2f84daf?#717e1a18c2f84daf

[CLJ-158] Update tests to reflect new template syntax

Tue, 24 Aug 2010 00:59:00 -0500

There are still some tests (and comments) not updated correctly - predicates, reader, vars.

[CLJ-147] Bug: Compile-time NPE on set! of non-existent field [for 1.0]

Mon, 15 Nov 2010 12:49:00 -0600

The bug described in #142 also exists in Clojure 1.0.0

[CLJ-159] Add char? fn

Tue, 24 Aug 2010 13:00:00 -0500

Add a char? fn to test for java.lang.Character.

[CLJ-160] JUnit XML output for clojure.test

Tue, 24 Aug 2010 04:01:00 -0500

Sent in by Jason Sankey as clojure.contrib.test.junit

I have renamed it to clojure.test.junit, in the same style as clojure.test.tap

[CLJ-162] gen-class fails to accept type hints for arrays of primitives

Tue, 24 Aug 2010 04:03:00 -0500

gen-class fails to accept type hints for arrays of primitives like "[B"

This is a bug in genclass.clj's the-class, which should have (some #{\. \[} strx) instead of (some #{\.} strx)

[CLJ-137] Add math-context to with-bindings so it's set!-able at REPL

Tue, 24 Aug 2010 00:50:00 -0500

Add math-context</code> to <code>clojure.main/with-bindings so it's set!-able at REPL.

[CLJ-161] *-zip lose metadata [for 1.0 from #134]

Fri, 1 Oct 2010 08:46:00 -0500

This ticket is for tracking #134 against branch 1.0

[CLJ-166] TransientHashMap

Tue, 24 Aug 2010 13:07:00 -0500

Implement TransientHashMap

[CLJ-164] [PATCH] embedded constants

Tue, 24 Aug 2010 13:05:00 -0500

clojure.lang.Compiler.FnExpr now handles primitives

[CLJ-165] Enhancements to array seqs

Tue, 24 Aug 2010 13:06:00 -0500

Implement missing array seqs for byte[], char[] and boolean[].
Specialize .indexOf and .lastIndexOf (from java.util.List which array seqs implement via ASeq) to be more efficient. It would relax the need to depend on org.apache.commons.lang.ArrayUtils for such a mundane task: (-> a-byte-array #^List seq (.indexOf (byte 10)))

[CLJ-174] Make c.l.Keyword Serializable

Tue, 24 Aug 2010 06:12:00 -0500

As mentioned in ticket #64, keywords are not currently Serializable, which is problem in many application contexts.

I'm treating this separately from the broader question of making clojure data structures Serializable because keywords not being Serializable is the one thing in the way of making idiomatic structs Serializable (e.g. maps using keyword keys, with values including other maps, sets, vectors, strings, numerics, symbols, other keywords, etc; these other structures are already Serializable).

Beyond that, cons and PersistentList aren't widely used, and I don't want to wade into that when they may be getting replaced soon enough with newnew/reify implementations.

Patch (based on 1.0.x branch) attached.

[CLJ-173] Make PersistentHashSet implements IEditable

Tue, 24 Aug 2010 13:10:00 -0500

http://github.com/cgrand/clojure/commit/de2b2f9bc39ee2bb2758608c0a837a8a5333ff08

[CLJ-170] bound-fn macro

Tue, 24 Aug 2010 13:09:00 -0500

Added bound-fn macro to define a function, which saves away the current thread-local bindings. Before executing the body these bindings are restored. Useful for helper functions running on a different thread but requiring the same thread-local bindings.

For discussion see:
http://groups.google.com/group/clojure/browse_frm/thread/69367d3981de81d1

Needs patch from ticket:
https://www.assembla.com/spaces/clojure/tickets/169-thread-local-bindings-interface

Currently two fns are created. One wrapping the other into the necessary code. I also added the binding* helper function, because I missed it several times in my projects. So it may also be useful to others.

[CLJ-171] reflection warning from ns

Tue, 24 Aug 2010 15:10:00 -0500

This happens in the master branch, but not in 1.0. Reported on http://groups.google.com/group/clojure/browse_thread/thread/3f7989b0297e0a59/59c94c1b161a6693

user=> (set! warn-on-reflection true)
true
user=> (ns foo.bar)
Reflection warning, NO_SOURCE_PATH:2 - reference to field getClass can't be resolved.
Reflection warning, NO_SOURCE_PATH:2 - reference to field getClassLoader can't be resolved.
nil
foo.bar=>

[CLJ-169] thread-local bindings interface

Tue, 24 Aug 2010 13:09:00 -0500

The attached patch provides a clojure side interface to clojure.lang.Var get/push/popThreadBindings. Also modified binding to use these new functions.

Discussion here:
http://groups.google.com/group/clojure/browse_frm/thread/69367d3981de81d1

[CLJ-168] ant targets should fail on error, also test print report correctly

Tue, 24 Aug 2010 13:09:00 -0500

I found and fixed 3 problems with the ant task for running tests:

compile-clojure target should fail when the compilation fails so more targets aren't run and ant process returns error
test target should fail when the tests fail, not just print the report.
when the test target is used with compile (eg, ant all test), the report is not printed at all

[CLJ-167] tests for sequences, control, and numbers

Tue, 24 Aug 2010 08:09:00 -0500

I've written tests for various core functions: some, condp, loop, when, when-not, if-not, when-let, if-let, when-first, dotimes, while, bit-shift-left, bit-shift-right.

[CLJ-172] #^objects type hint shortcut

Tue, 24 Aug 2010 06:10:00 -0500

instead of the ugly and tiresome #^"[Ljava.lang.Object;"

http://github.com/cgrand/clojure/commit/15ac69ce25adeb3992a001596cd2c2ff11b2770f

[CLJ-175] "Second argument to def must be a Symbol" should say 'First argument'

Tue, 24 Aug 2010 06:14:00 -0500

See clojure/lang/Compiler.java, line 354 (in static class Parser, method parse())

> (def "hi" "there")
java.lang.Exception: Second argument to def must be a Symbol (NO_SOURCE_FILE:15)

The real problem the compiler means to say, is that "hi" is not a symbol, and that is the first argument to def.

[CLJ-178] Reloading core.clj from REPL fails with print-method exception

Tue, 28 Sep 2010 15:34:00 -0500

Example REPL session:

(in-ns 'clojure.core)
(def source-file "/path/to/clojure/src/clj/clojure/core.clj")
(load-string (slurp source-file))
</code></pre>

Result:
<pre><code>
java.lang.IllegalArgumentException: No method in multimethod 'print-method' for dispatch value: class clojure.lang.Var
Exception in thread "main" java.lang.IllegalArgumentException: No method in multimethod 'print-method' for dispatch value: class java.lang.String
        at clojure.lang.MultiFn.getFn(MultiFn.java:115)
        at clojure.lang.MultiFn.invoke(MultiFn.java:161)
        at clojure.core$pr_on__1315.invoke(Unknown Source)
        at clojure.core$pr__1318.invoke(Unknown Source)
        at clojure.lang.AFn.applyToHelper(AFn.java:173)
        at clojure.lang.RestFn.applyTo(RestFn.java:137)
        at clojure.core$apply__183.doInvoke(Unknown Source)
        at clojure.lang.RestFn.invoke(RestFn.java:428)
        at clojure.core$print__1332.doInvoke(Unknown Source)
        at clojure.lang.RestFn.invoke(RestFn.java:413)
        at clojure.core$printf__2285.doInvoke(Unknown Source)
        at clojure.lang.RestFn.invoke(RestFn.java:428)
        at clojure.main$repl_prompt__6713.invoke(main.clj:41)
        at clojure.main$repl__6737.doInvoke(main.clj:199)
        at clojure.lang.RestFn.invoke(RestFn.java:426)
        at clojure.main$repl_opt__6777.invoke(main.clj:251)
        at clojure.main$main__6812.doInvoke(main.clj:338)
        at clojure.lang.RestFn.invoke(RestFn.java:402)
        at clojure.lang.Var.invoke(Var.java:355)
        at clojure.lang.AFn.applyToHelper(AFn.java:171)
        at clojure.lang.Var.applyTo(Var.java:476)
        at clojure.main.main(main.java:37)

[CLJ-176] structs printed with print-dup true cannot be read

Tue, 24 Aug 2010 06:14:00 -0500

(defstruct thing :a :b)
(def my-thing (struct thing 1 2))
(def s (binding [*print-dup* true] (pr-str my-thing)))
s 
;;=> "#=(clojure.lang.PersistentStructMap/create {:a 1, :b 2})"
(read-string s)
;;=> java.lang.IllegalArgumentException:
;;   No matching method found: create

[CLJ-180] 1.0 bugfix: (namespace (symbol "/")) should return nil

Wed, 22 Sep 2010 16:27:00 -0500

Fix for master is valid for 1.0 too; see parent issue

[CLJ-177] Try latches instead of wait/notify in STM

Tue, 24 Aug 2010 13:16:00 -0500

wait/notify might not have best throughput, try CountdownLatch instead

[CLJ-181] proxy-name does not produce unique names

Tue, 24 Aug 2010 06:17:00 -0500

be.nsa.server=> (proxy-name Object [Signal$Listener])
"clojure.proxy.java.lang.Object$Listener"
be.nsa.server=> (proxy-name Object [Signal1$Listener])
"clojure.proxy.java.lang.Object$Listener"

Proposed solution: include more than the simple name of interfaces (up to the last dot) and a hash of the full names.

eg : (proxy-name Object [Signal1$Listener])
"clojure.proxy.java.lang.Object$Signal1$Listener$af458"
(proxy-name Object [Signal1$Listener])
"clojure.proxy.java.lang.Object$Signal$Listener$4d54e"

Wouldn't the hash suffice?

[CLJ-182] Make Symbol.create methods intern their args

Thu, 14 Oct 2010 14:27:00 -0500

Right now the create methods presume interned strings, but not all users are disciplined about that. Also, Terracotta can correctly identity-share explicitly interned strings but not implicit ones (like string literals). We care because symbol equality is based on string identity.

[CLJ-189] Doc for compare does not match implementation

Tue, 24 Aug 2010 04:29:00 -0500

(compare x y) returns a negative number, zero, or a positive number when x is logically 'less than', 'equal to', or 'greater than' y. The doc implies that it returns -1, 0, 1, respectively. We should fix the doc.

[CLJ-183] leafless PersistentHashMap

Tue, 24 Aug 2010 06:19:00 -0500

see http://groups.google.com/group/clojure-dev/browse_thread/thread/4ab5a2a00e82c566

[CLJ-187] StringSeq implements Counted but doesn't provide a specialized impl for count() [for 1.0 from #186]

Wed, 22 Sep 2010 23:27:00 -0500

StringSeq implements Counted but doesn't provide a specialized impl for count() [for 1.0 from #186]

[CLJ-192] hashmaps: count is not always updated when associng/dissocing a nil key

Tue, 24 Aug 2010 07:32:00 -0500

user=> (count (reduce conj (hash-map) (for [i (range 30)] [i nil])))
0

Patch attached.

(thanks to danlarkin for reporting it http://clojure-log.n01se.net/date/2009-09-16.html#13:12 )

BTW, what's the best way to add specific tests such as this one to the test suite?

[CLJ-188] NPE when creating an empty array of ints, longs, floats or doubles [from #146 for 1.0]

Wed, 22 Sep 2010 23:27:00 -0500

NPE when creating an empty array of ints, longs, floats or doubles [from #146 for 1.0]

[CLJ-193] Return summary & successful? for clojure.test

Tue, 24 Aug 2010 07:37:00 -0500

clojure.test/run-tests does not return a value, making it difficult to integrate with build frameworks such as Ant and Maven.

This patch was written by Jason Sankey, who is a registered contributor.

The patch modifies run-tests to return the test summary results (the same map sent to the report function).

The patch also adds a new function, "successful?", which returns true if the summary indicates that there were no failures or errors.

A test script or main program can call (successful? (run-tests ...)) and then indicate success or failure in System/exit.

[CLJ-186] StringSeq implements Counted but doesn't provide a specialized impl for count()

Tue, 24 Aug 2010 13:20:00 -0500

(count (seq (apply str (repeat 100000 "hello")))) throws a StackOverflowError

[CLJ-194] clojure.test use-fixtures function composes fixture functions repeatedly

Tue, 24 Aug 2010 04:45:00 -0500

If you call use-fixtures over and over again, it will simply compose the test deeper and deeper into a nesting of the fixture function.

�� (use-fixtures :each my-cleanup)
�� (deftest my-messy-test [...])

Load that a few times and you end up running the equivalent of:
(my-cleanup (my-cleanup (my-cleanup my-messy-test))).

[CLJ-185] clojure.zip/down doesn't always return nil when called on leaf

Tue, 24 Aug 2010 04:19:00 -0500

The docs for zip/down state: "Returns the loc of the leftmost child of the node at this loc, or nil if no children", but in fact, down will always try to call the zipper's children function, even if branch? is false, i.e. on leaves. This behaviour is inconsistent with the doc string and with the behaviour of up, left and right, which always return nil.

(-> [1] clojure.zip/vector-zip clojure.zip/down clojure.zip/down)
; => java.lang.IllegalArgumentException: Don't know how to create ISeq from: Integer

Related, but not identical to #135

[CLJ-195] Documentation: Where are the docs for clojure.test, clojure.walk, etc?

Tue, 24 Aug 2010 04:46:00 -0500

Several libraries were moved from clojure.contrib to the standard library. I can't find any documentation on how to use them anymore. They're not on clojure.org and they're not in the clojure contrib docs. Here's the list:

clojure.contrib.test-is -> clojure.test
clojure.contrib.stacktrace -> clojure.stacktrace
clojure.contrib.template -> clojure.template
clojure.contrib.walk -> clojure.walk

[CLJ-198] attr-map argument for clojure.core/ns

Tue, 24 Aug 2010 04:51:00 -0500

Discussion: http://groups.google.com/group/clojure-dev/browse_thread/thread/97ffdb1d89c0f847

The clojure.core/ns macro should have an attr-map argument like defn and defmulti. For example:

(ns example
  {:author "John Doe"
   :email "jdoe@example.com"}
  (:use clojure.contrib.def))

[CLJ-201] Make deftest keep var metadata

Tue, 24 Aug 2010 07:51:00 -0500

Currently deftest discards metadata from the symbol passed in to it.

[CLJ-199] chunked seqs support 'for' byte code can't be converted to dex for dalvik

Mon, 15 Nov 2010 12:49:00 -0600

Commit 306ef6 generates bytecode which can not be covered to dex for dalvik. See following git-bisect output for details.

306ef6d9e47253103ca0e5ae0f4b620d5fa2aeff is first bad commit
commit 306ef6d9e47253103ca0e5ae0f4b620d5fa2aeff (14316ae2110a779ffc8ac9c3da3f1c41852c4289)
Author: Chouser <chouser@n01se.net>
Date:   Sun Aug 23 21:36:41 2009 -0400

    Add support for chunked seqs to 'for'.  Refs #1

:040000 040000 d48a1b12db408d4bc5843367ea5529678522f57d 7d8717380716feab9ebc84883e60dceea8fb1e08 M src
:040000 040000 0d80fce85701005c13ce13c105524a4fff188396 5daece53b0dd2727dc7ffa9c0b773e7962de900d M test
bisect run success

processing clojure/core$generate_proxy__5911$iter__5947__5953$fn__5954$iter__5949__5956$fn__5957.class...

UNEXPECTED TOP-LEVEL EXCEPTION:
com.android.dx.cf.code.SimException: local variable type mismatch: attempt to set or access a value of type java.lang.Object using a local variable of type int. This is symptomatic of .class transformation tools that ignore local variable information.
 at com.android.dx.cf.code.BaseMachine.throwLocalMismatch(BaseMachine.java:537)
 at com.android.dx.cf.code.Simulator$SimVisitor.visitLocal(Simulator.java:504)
 at com.android.dx.cf.code.BytecodeArray.parseInstruction(BytecodeArray.java:472)
 at com.android.dx.cf.code.Simulator.simulate(Simulator.java:96)
 at com.android.dx.cf.code.Ropper.processBlock(Ropper.java:681)
 at com.android.dx.cf.code.Ropper.doit(Ropper.java:636)
 at com.android.dx.cf.code.Ropper.convert(Ropper.java:253)
 at com.android.dx.dex.cf.CfTranslator.processMethods(CfTranslator.java:252)
 at com.android.dx.dex.cf.CfTranslator.translate0(CfTranslator.java:131)
 at com.android.dx.dex.cf.CfTranslator.translate(CfTranslator.java:85)
 at com.android.dx.command.dexer.Main.processClass(Main.java:297)
 at com.android.dx.command.dexer.Main.processFileBytes(Main.java:276)
 at com.android.dx.command.dexer.Main.access$100(Main.java:56)
 at com.android.dx.command.dexer.Main$1.processFileBytes(Main.java:228)
 at com.android.dx.cf.direct.ClassPathOpener.processArchive(ClassPathOpener.java:245)
 at com.android.dx.cf.direct.ClassPathOpener.processOne(ClassPathOpener.java:130)
 at com.android.dx.cf.direct.ClassPathOpener.process(ClassPathOpener.java:108)
 at com.android.dx.command.dexer.Main.processOne(Main.java:245)
 at com.android.dx.command.dexer.Main.processAllFiles(Main.java:183)
 at com.android.dx.command.dexer.Main.run(Main.java:139)
 at com.android.dx.command.dexer.Main.main(Main.java:120)
 at com.android.dx.command.Main.main(Main.java:87)
...at bytecode offset 000000d7
locals[0000]: Lclojure/core$generate_proxy__5911$iter__5947__5953$fn__5954$iter__5949__5956$fn__5957;
locals[0001]: known-null
locals[0002]: known-null
locals[0003]: known-null
locals[0004]: known-null
locals[0005]: I
locals[0006]: Ljava/lang/Object;
stack[0003]: Lclojure/lang/IFn;
stack[0002]: Ljava/lang/Object;
stack[0001]: Ljava/lang/Object;
stack[top0]: known-null
...while working on block 00cd
...while working on method invoke:()Ljava/lang/Object;
...while processing invoke ()Ljava/lang/Object;
...while processing clojure/core$generate_proxy__5911$iter__5947__5953$fn__5954$iter__5949__5956$fn__5957.class

[CLJ-208] pom uses old artifactId

Tue, 24 Aug 2010 05:02:00 -0500

The pom generated by the build process uses the old "clojure-lang" artifact ID. Since the official repositories host a build with just plain "clojure", we should update to be consistent.

I believe this was discussed a while ago on the mailing list, but the fix never made it into git.

[CLJ-203] Add line to .gitignore for local netbeans project directory

Tue, 24 Aug 2010 13:53:00 -0500

Oddly, git always fails to cleanly merge an altered .gitignore we keep that contains a line for the local netbeans project directory. It would be very convenient if that line were to be added to .gitignore upstream...

[CLJ-206] make -> and ->> metadata-aware

Tue, 24 Aug 2010 07:55:00 -0500

Macros ></code> and <code>>> are currently hard to hint because metadata aren't preserved on lists.
Together with #205, it would allow to write:
(-> #^objects dd #^doubles (aget i) (aget j))
(instead of {{(let [#^doubles a (aget #^objects dd i)] (aget a j))}})

[CLJ-202] defmethod impl causes reflection warnings

Tue, 24 Aug 2010 05:53:00 -0500

...because the addMethod invocation isn't hinted. Doesn't impact runtime perf, but does litter one's compilation output with reflection warnings.

[CLJ-215] Deprecate ^ reader macro

Tue, 24 Aug 2010 05:24:00 -0500

Deprecate ^ reader macro, so eventually ^ can replace #^

[CLJ-216] Deprecate clojure.parallel

Tue, 24 Aug 2010 05:24:00 -0500

parallel.clj won't work with jdk7. Move to FJ work in par branch

[CLJ-204] clojure.test/thrown-with-msg? uses re-match, should use re-find

Tue, 24 Aug 2010 04:54:00 -0500

By the time exceptions percolate up to clojure.test, they are often decorated by additional levels of RuntimeException, thus the message being matched is usually "java.lang.RuntimeException: My error message". I end up always having to prefix my re with ".*". If I want to match the entire message, RE's allow that using ^.

[CLJ-179] (namespace (symbol "/")) returns "" instead of nil

Tue, 24 Aug 2010 06:17:00 -0500

(namespace (symbol "/")) returns "", but
(namespace '/) returns nil, which is the expected behaviour.

[CLJ-214] Deprecate add-classpath

Tue, 24 Aug 2010 05:24:00 -0500

Deprecate add-classpath

[CLJ-209] Unifying the array support for primitives (part 1)

Tue, 24 Aug 2010 05:08:00 -0500

As discussed here:
http://groups.google.com/group/clojure/browse_thread/thread/9a276a1709a88eeb

Simply adding X-array, Xs

[CLJ-217] Add :doc and :author strings to all core namespaces

Tue, 24 Aug 2010 08:25:00 -0500

Add :doc and :author strings to all core namespaces

[CLJ-197] Field 'count' not updated correctly for 'PersistentHashMap's when three hashes collide

Tue, 24 Aug 2010 07:50:00 -0500

Originally I had the problem that (count my-hashmap)</code> was smaller than <code>(count (rest my-hashmap)).
It turned out to be a problem with incorrect updates of the 'count' field:

<code>
(count (assoc clojure.lang.PersistentHashMap/EMPTY 97 0, \a 0, "a" 0))
</code>

A friend and I discovered this, took only 3 hours to find this minimal example

[CLJ-218] Deprecate old launch Classes

Tue, 24 Aug 2010 05:27:00 -0500

Deprecate clojure.lang.Repl and clojure.lang.Script and their implementations legacy-repl and legacy-script in clojure.main.

Discussed here:
http://groups.google.com/group/clojure-dev/browse_thread/thread/5d51d6540b08da55

[CLJ-205] Preserve type hints set on inlined or interop forms

Tue, 24 Aug 2010 05:55:00 -0500

Currently one can't hint forms which are expanded by the compiler (interop sugar and inlines):

on instance methods:
user=> (.size #^java.util.ArrayList (.clone (java.util.ArrayList.)))
Reflection warning, NO_SOURCE_PATH:2 - reference to field size can't be resolved.

on static methods:
user=> (.nth #^clojure.lang.Indexed (clojure.lang.RT/conj [] 2) (int 0))
Reflection warning, NO_SOURCE_PATH:21 - call to nth can't be resolved.

on instance fields:
user=> (.count #^clojure.lang.Counted (.val (clojure.lang.Box. [])))
Reflection warning, NO_SOURCE_PATH:23 - reference to field count can't be resolved.

on static fields:
user=> #(.withMeta #^clojure.lang.AFn clojure.lang.RT/EMPTY_GEN nil)
Reflection warning, NO_SOURCE_PATH:18 - call to withMeta can't be resolved.

on inlines;
user=> (.count #^clojure.lang.Counted (aget (into-array [[]]) 0))
Reflection warning, NO_SOURCE_PATH:33 - reference to field count can't be resolved.

Discussed on #clojure http://clojure-log.n01se.net/date/2009-10-22.html#08:18

[CLJ-212] Direct linking breaks clojure.contrib.repl-ln.

Tue, 24 Aug 2010 05:22:00 -0500

Direct linking (commit 4d08439a9cf79f34a730714f12edd5959aae126e) breaks clojure.contrib.repl-ln.

To reproduce, run the following in the standard REPL:
(require 'clojure.contrib.repl-ln) (clojure.contrib.repl-ln/repl)

Expected output (obtained with commit 98366f353463afdc195b9b8fdf9d220bca7d0d6a):
nil
1:2 user=>

Result with commit 4d08439a9cf79f34a730714f12edd5959aae126e:
nil
java.lang.NullPointerException (NO_SOURCE_FILE:0)

The NullPointerException happens in clojure.contrib.repl-ln/prompt-hook where (private :prompt) returns nil.

[CLJ-219] filter doesn't have a doc string

Tue, 24 Aug 2010 08:29:00 -0500

In commit cf3b547e7d8f95d6e4234881f8122bb823ff46cd ("made filter chunk-aware" on Jun 20, 2009), the doc string for filter was dropped.

I have included a patch that adds back the original doc string. I don't know if there was a reason Rich dropped that doc string or if it was just a finger fumble.

In any case, filter is a significant enough function and this is a small enough change that I recommend that we fix it for 1.1.

[CLJ-220] Adding more test cases for clojure set

Tue, 24 Aug 2010 08:31:00 -0500

Expanded the test cases to also test
difference
select
project
rename-keys
index
map-invert
join

Attached is the patch file.

[CLJ-222] line-seq returns element only when successive line is read

Tue, 24 Aug 2010 05:34:00 -0500

The lazy-seq</code> in <code>line-seq</code> wraps the call to <code>cons</code> but not the <code>readLine(), which delays each line of the reader from being returned until the next one is read.

http://groups.google.com/group/clojure/browse_thread/thread/e0d6efd53187ea09

[CLJ-229] Clean up changes.txt formatting

Tue, 24 Aug 2010 05:37:00 -0500

E.g., limit lines to 70 characters, normalize spacing between sections

[CLJ-210] sorted-set-by fails when given no values

Tue, 24 Aug 2010 14:10:00 -0500

As described here: http://groups.google.com/group/clojure/browse_thread/thread/1e9c368245800695
(sorted-set-by >) throws a null pointer exception.

[CLJ-225] Unintentional redef of bound-fn in clojure.core

Tue, 24 Aug 2010 14:36:00 -0500

Found an unintentional redefinition in core.clj:

On line 1285:

(defmacro bound-fn
"Returns a function defined by the given fntail, which will install the
same bindings in effect as in the thread at the time bound-fn was called.
This may be used to define a helper function which runs on a different
thread, but needs the same bindings in place."
[& fntail]
`(bound-fn* (fn ~@fntail)))

On line 3433:

(defn bound-fn
{:private true}
[#^clojure.lang.Sorted sc test key]
(fn [e]
(test (.. sc comparator (compare (. sc entryKey e) key)) 0)))

My initial guess is that the second one should be called bound?-fn as long as it's kosher to put a ? in the middle of an identifier.

I can whip up a patch if a good name is agreed upon.

[CLJ-228] Note old launcher deprecation in changes.txt

Tue, 24 Aug 2010 05:37:00 -0500

Note old launcher deprecation in changes.txt

[CLJ-227] rc0: changes.txt missing deprecations of legacy entry points

Tue, 24 Aug 2010 08:37:00 -0500

changes.txt should mention the deprecation of clojure.lang.Repl and clojure.lang.Script

[CLJ-221] document :pre and :post

Tue, 24 Aug 2010 08:32:00 -0500

http://github.com/richhickey/clojure/commit/0ac482878a1dd520cbee2faa0f5f6ab1082ffa76 is only documentation.

[CLJ-224] Create ZIP distribution from build

Tue, 24 Aug 2010 14:35:00 -0500

Need a way to generate a complete clojure-{VERSION}.zip file from the Ant build.

[CLJ-230] More precise docstring for #'delay

Tue, 24 Aug 2010 14:40:00 -0500

Change docstring for #'delay to precise deref forces delays too.
See http://groups.google.com/group/clojure-dev/browse_thread/thread/d835fd49d08e48ca

[CLJ-226] Formatting fixes for doc strings

Tue, 24 Aug 2010 14:36:00 -0500

Looking at the automatically generated API documentation, I noticed that some doc strings were running off the right margin because of very long lines. Also, remove-method had a tab in the middle of the doc string.

I've made a patch that contains only updates to the doc strings and no logic strings and recommend it for a 1.1 "cleanup" style fix.

[CLJ-232] Locals cleared too aggressively on delay

Tue, 24 Aug 2010 05:43:00 -0500

Steve Gilardi and I noticed some strange behaviour with local clearing in conjunction with delay:

(defn do-something [x]
(throw (Exception.)))

(defn clear-locals [x]
(delay (try (do-something x)
(catch Exception e
(println "argument value:" x)))))

(force (clear-locals :argument))
;; => argument value: nil

It seems the locals are getting cleared a little too aggressively here. I did some digging to discover that delay is a thin wrapper around an fn, but using an fn in this context (rather than a delay) does not trigger the problem. Also I found that throwing an exception directly inside the try block (rather than in a function called from the try block) did not trigger it.

I was able to reproduce in the new branch, the master branch, and 1.0.0, so it's not related to the more recent locals-clearing changes.

[CLJ-231] deftype cons doesn't support maps

Tue, 24 Aug 2010 14:43:00 -0500

The deftype IPersistentMap implementation of cons does not have the same functionality as APersistentMap.cons. The current implementation doesn't support cons'ing a map.

See this thread for the original report:
http://groups.google.com/group/clojure/browse_thread/thread/d4dd1a0a1ffee6c5#

[CLJ-238] Make re-pattern accept multiple arguments to concatenate them.

Fri, 7 Oct 2011 07:51:41 -0500

This would help concatenating multiple regular expressions. The attached patch simply converts all arguments to a string and then pass that string to re-pattern. Currently if you're trying to concatenate literal regular expressions, you're force to use the str function. It's not much extra code, but given the similarity between re-pattern and str, I thought it would be nice to have them behave the same way. e.g.:

(re-pattern (apply str (map (partial format "%s{%s}") [\a \b \c \d \e] (iterate inc 1))))
would become
(apply re-pattern (map (partial format "%s{%s}") [\a \b \c \d \e] (iterate inc 1)))

It only save one call to str, so it might not warrant the extra code in the end.

[CLJ-245] Unnamed fns should have no binding of name

Tue, 24 Aug 2010 15:52:00 -0500

Currently a binding is created for a generated name

[CLJ-242] Support implicit macro args for form and locals

Tue, 24 Aug 2010 07:51:00 -0500

Inside the body of a defmacro expander, &whole will refer to the original macro invocation form (thus allowing recovery and use of metadata on that form by the expander itself). &env will refer to a map of symbols to TBD, such symbols representing the locals in scope. This will break code that depends on defmacro creating a fn with exactly the same signature.

Possible alternate names: &locals, &form

[CLJ-239] Tests for types and protocols, round 2

Tue, 24 Aug 2010 05:51:00 -0500

Tests for types and protocols, round 2

[CLJ-223] Maven build produces empty JAR

Tue, 24 Aug 2010 14:34:00 -0500

Currently, "ant" generates a valid pom.xml. but "mvn install" doesn't work – the target JAR is empty.

[CLJ-241] Tests for reify

Tue, 24 Aug 2010 15:51:00 -0500

subsumed by #239 and #240

[CLJ-243] Add bound? and thread-bound? predicates

Tue, 24 Aug 2010 07:51:00 -0500

Discussed in #clojure here: http://clojure-log.n01se.net/date/2010-01-12.html#i96

Wraps Var.isBound and the truthiness of Var.getThreadBinding; the latter particularly handy for knowing whether or not set! will fail or not.

[CLJ-240] Tests for protocols and types, round 1

Tue, 24 Aug 2010 05:51:00 -0500

I have included a patch with my original tests (pre deftype/defrecord split) plus a final patch to get things passing with the latest greatest.

The final commit is worth looking at. The reduced dynamism of deftype is visible, in that I used to be able to redefine a type multiple times in a series of tests, and am now relying on per-test named types. I think this tradeoff is worth it for unification with the host type system. But a bigger issue occurs when working at the REPL: you can reload types, but not refer to the reloaded ones.

[CLJ-249] Add "starting at " to EOF while reading exceptions

Sat, 2 Oct 2010 00:48:00 -0500

Extend some EOF exceptions during read so they look like this:

java.lang.Exception: EOF while reading, starting at line 7 (bad.clj:15)

So while bad.clj:15 indicates the file name and the fact that
line 15 is the last one of the file, "starting at line 7" points
out the line where the unclosed grouping construct started.

Discussed: http://groups.google.com/group/clojure/browse_thread/thread/872c5b2ee7af19fe

[CLJ-246] direct binding inhibits clojure.test functionality

Tue, 24 Aug 2010 15:53:00 -0500

clojure.test offers features that rely on binding functions from its namespace. With the way direct binding is implemented now, this is impossible, since any namespaces beginning with "clojure" are directly bound. This also has a (probably) unintended of direct binding namespaces that just start with "clojure", like "clojuresque" and "clojure-http-client."

I propose that direct binding use a whitelist, instead of direct binding anything that starts with "clojure."

An ever better solution, though, would be to use namespace metadata to turn off/on direct binding. That way user code could turn on direct binding in hotspots. Unfortunately, there's an open bug (#130) which causes AOT compilation to erase namespace metadata, so until that's closed I would prefer the whitelist option.

[CLJ-253] Improve errors for "use"/"require" in REPL

Tue, 24 Aug 2010 06:07:00 -0500

in the repl when i (use 'foo) vs. (use :foo) they both return nil, so it doesn't help me know that the former is right and the latter isn't. would it be sensible for use to return true or something more positive than nil if it successfully brings in a namespace? or print out an error message when symbols are used?

[CLJ-260] Cannot load clojure classes from Jar files outside classpath using URLClassLoader

Tue, 24 Aug 2010 15:18:00 -0500

It is not possible to use URLClassLoader to load a class from a jar file if the jar is outside the classpath. It seems that RT.load tries to search for *.clj file within the classpath and doesn't respect the URLClassLoader and then fails with:

Exception in thread "main" java.lang.ExceptionInInitializerError
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
at java.lang.Class.newInstance0(Class.java:355)
at java.lang.Class.newInstance(Class.java:308)
at Loader.main(Loader.java:17)
Caused by: java.io.FileNotFoundException: Could not locate net/experimentalworks/Foo__init.class or net/experimentalworks/Foo.clj on classpath:
at clojure.lang.RT.load(RT.java:402)
at clojure.lang.RT.load(RT.java:371)
at clojure.core$load_6449$fn_6458.invoke(core.clj:4171)
at clojure.core$load__6449.doInvoke(core.clj:4170)
at clojure.lang.RestFn.invoke(RestFn.java:413)
at clojure.lang.Var.invoke(Var.java:359)
at net.experimentalworks.Foo.<clinit>(Unknown Source)
... 7 more

The attached .tar.gz contains a sample jar file and the clojure file that was used to generate the class files as well as the sample loader. Java oder Scala written classes can be loaded without any problems. For sure the I put the clojure runtime into the classpath but not the loadme-clojure.jar

[CLJ-251] macroexpand should respect :inline

Fri, 7 Oct 2011 07:47:38 -0500

macroexpand and macroexpand-1 currently do not respect the :inline metadata of
functions. For example you currently see:

(macroexpand '(+ 1 2))
;=> (+ 1 2)

Instead, macroexpand should return something like:

;=> (. clojure.lang.Numbers (add 1 2))

...depending of course on the exact definition of +'s :inline fn.

[CLJ-262] (resolve 'FooBar.) should return nil

Tue, 24 Aug 2010 06:19:00 -0500

Currently, (resolve 'FooBar.) throws a ClassNotFoundException it should return nil.

[CLJ-261] Use Ant instead of Maven for Clojure-Contrib

Tue, 24 Aug 2010 06:19:00 -0500

It would be nice if we could go back to Ant for building the clojure-contrib. At this time, it appears to be downloading many different packages that are not a part of the Clojure-Contrib source but Maven dependencies. Furthermore, it would be consistent with the way that we currently build Clojure.

[CLJ-255] add denominator and numerator fns for Ratio

Tue, 28 Sep 2010 07:07:00 -0500

currently the only way to get the denominator or numerator is via the exposed fields of the Ratio class.

On Thu, Jan 21, 2010 at 7:57 AM, Jacek Generowicz
<jacek.generowicz@googlemail.com> wrote:
> Clojure has a Ratio type; presumably there should be an easy way to
> find the numerator and denominator of a Ratio object.
>
> I didn't have much luck on clojure.org or with find-doc, but
>
> (show 1/2)
>
> taught me that there are numerator and denominator methods on Ratio's
> underlying Java implementation, so I can now do:
>
> (.numerator 1/2) ; => 1
> (.denominator 1/2) ; => 2
>
> Is there a more direct way? (Not that this is bad! But you can't
> use .numerator as a first-order function (though #(.numerator %) is
> still pretty damn good).)
>
> In general, do you have any hints on how to go about looking for
> useful Clojure functions which work with certain Clojure types ?
>

[CLJ-258] can't recur from case special form

Tue, 24 Aug 2010 17:12:00 -0500

the 'case' special form doesnt't propagate tailcontext.
eg.

; SLIME 2010-02-01
user> (loop [foo "foo"]
        (case foo
          "foo" (recur 'bar)
          'bar (recur :baz)
          :done (do (println "hello"))
          (recur :done)))
; Evaluation aborted.

Can only recur from tail position
  [Thrown class java.lang.UnsupportedOperationException]

This can be easily fixed by making
Compiler.CaseExpr#emit() and Compiler.CaseExpr.Parser#parse() propagate their context instead stetting the context to C.EXPRESSION.

[CLJ-264] Complete interface impls for generic vector

Tue, 24 Aug 2010 06:22:00 -0500

Vec needs several more interface implementations in order to be as complete as persistentvector.
See subtasks

Clojure JIRA

[CLJ-1] Add chunk support to map filter et al

[CLJ-3] Test ticket

[CLJ-9] GC Issue 5: Allow single classes in import

[CLJ-6] GC Issue 1: :validator as keyword arg for ref/atom/agent

[CLJ-12] GC Issue 8: :default as keyword arg to defmulti

[CLJ-13] GC Issue 9: Not all *vars* have doc strings

[CLJ-11] GC Issue 7: Make syntax-quote Classname. aware

[CLJ-7] GC Issue 2: gen-class - :exposes should expose static fields as static methods

[CLJ-4] test ticket 2

[CLJ-10] GC Issue 6: Include condp in clojure.core

[CLJ-14] GC Issue 10: remove all #=()s from non-dup prints

[CLJ-18] GC Issue 14: make RT.ROOT_CLASSLOADER load on demand, possibly never if AOT compiled

[CLJ-16] GC Issue 12: improve doc for contains?

[CLJ-25] GC Issue 21: bigdec truncates rational

[CLJ-24] GC Issue 20: release-pending-sends

[CLJ-26] GC Issue 22: Make sure all integer ops return smallest representation

[CLJ-28] GC Issue 24: Remove hard search for .class files in RT.load

[CLJ-20] GC Issue 16: Pretty printing

[CLJ-30] GC Issue 26: agent error queue

[CLJ-32] GC Issue 28: Substraction sometimes yields wrong result due to IntegerOps.Negate overflow (with patch

[CLJ-29] GC Issue 25: ClassNotFoundException when loading a clojure app under the Android vm

[CLJ-23] GC Issue 19: Unquote not in syntax-quote yield (unquote x)

[CLJ-38] GC Issue 34: A Lisp reader without access to EvalReader()

[CLJ-33] GC Issue 29: Range sometimes yields wrong sequence (with patch)

[CLJ-37] GC Issue 33: resultset-seq breaks when the result set contains duplicate column names (with patch)

[CLJ-34] GC Issue 30: Add doc string to ns macro

[CLJ-40] GC Issue 36: Add Counted marker interface

[CLJ-39] GC Issue 35: Wiki is closed to the public

[CLJ-44] GC Issue 40: Overflow check in Numbers.minus (+ patch)

[CLJ-43] GC Issue 39: Reader metadata fails for empty collection literals

[CLJ-41] GC Issue 37: .hashCode and .equals for Clojure vectors/seqs break Java contract.

[CLJ-45] GC Issue 41: [PATCH] several macros claim to want only 2 binding forms, allow more

[CLJ-46] GC Issue 42: Classes from :methods argument vectors are not resolved before passing to overload-names (+ patch (?))

[CLJ-27] GC Issue 23: mod (modulo) operator

[CLJ-49] GC Issue 45: :post-init option for gen-class

[CLJ-52] GC Issue 48: Per defmulti hierarchies

[CLJ-35] GC Issue 31: Report more incorrect usages of binding vectors

[CLJ-48] GC Issue 44: non-Exception throwables stay wrapped in InvocationTargetException

[CLJ-22] GC Issue 18: with-open allows multiple bindings but silently closes only the first

[CLJ-56] GC Issue 52: Make set/union accept any number of arguments

[CLJ-51] GC Issue 47: format, name and namespace are not hinted {:tag String}

[CLJ-59] GC Issue 55: "repeat" with multiple arities and remove "replicate"

[CLJ-50] GC Issue 46: callable defstruct (PersistentStructMap$Def extends AFn)

[CLJ-62] GC Issue 58: `() gives strange compiler error (i.e. backquote of empty list)

[CLJ-61] GC Issue 57: Compiler internal error when expanding macro: class not found

[CLJ-65] GC Issue 62: Make clojure.main not exit when exception during --init if user requested a repl

[CLJ-60] GC Issue 56: Make printed IRef's more useful

[CLJ-63] GC Issue 60: Ratio to floating point conversion miscalculation

[CLJ-66] GC Issue 63: docstring for refer-clojure is outdated

[CLJ-55] GC Issue 51: defmacro forms return nil when evaled

[CLJ-54] GC Issue 50: Fully qualified/classpath relative filename in a Var's metadata

[CLJ-36] GC Issue 32: Fix stray CPL comments and docstring for 'delay'

[CLJ-70] GC Issue 67: clojure.lang.Compile doesn't provide a way to control *warn-on-reflection*

[CLJ-72] GC Issue 69: Documentation: repl_and_main page should discuss use of java -jar clojure.jar

[CLJ-71] GC Issue 68: every? returns nil instead of false

[CLJ-53] GC Issue 49: Complement ~x => (unquote x) with ~@x => (unquote-splicing x)

[CLJ-57] GC Issue 53: tree-seq arbitrarily requires its root arg to be a branch

[CLJ-76] GC Issue 73: proxy macro allows invalid method declaration

[CLJ-75] CG Issue 72: clojure.main/repl manipulates *in* in the body of the loop rather than in a read hook, can't override that behavior

[CLJ-67] GC Issue 64: Efficient, multi-arg clojure.set/union/difference/intersection

[CLJ-58] GC Issue 54: defn with proxy inside with invalid proxy name gives a strange error

[CLJ-80] GC Issue 77: r1265 causes VerifyError on dalvik

[CLJ-81] GC Issue 78: patch to improve startup time on low end hardware

[CLJ-83] GC Issue 80: Make reference watch notification synchronous (again)

[CLJ-68] GC Issue 65: zip/remove does not return the correct loc

[CLJ-82] GC Issue 79: Allow read to accept readers other than a PushbackReader

[CLJ-85] Double post of #84

[CLJ-90] GC Issue 86: dorun implementation tripping lazy sequence assert logic

[CLJ-91] GC Issue 87: *-seq should return seq/nil

[CLJ-73] GC Issue 70: Maven integration

[CLJ-86] GC Issue 82: read-line bug

[CLJ-94] GC Issue 90: Support metadata on fns

[CLJ-93] GC Issue 89: letrec

[CLJ-95] GC Issue 91: Documentation for rand inaccurate

[CLJ-96] GC Issue 92: Check for key identity in collections

[CLJ-92] GC Issue 88: Add :let support for 'doseq' and 'for'

[CLJ-100] GC Issue 96: In FOR macro the :let clause does not establish a lexical binding

[CLJ-97] GC Issue 93: proxy: inheriting a method from more than one iface

[CLJ-79] GC Issue 76: adding sorted-set-by

[CLJ-13] GC Issue 9: Not all vars have doc strings

[CLJ-70] GC Issue 67: clojure.lang.Compile doesn't provide a way to control warn-on-reflection

[CLJ-75] CG Issue 72: clojure.main/repl manipulates in in the body of the loop rather than in a read hook, can't override that behavior

[CLJ-116] CG Issue 112: Use platform default encoding for in, out, and err

[CLJ-122] GC Issue 118: Patch to add :svn to clojure-version

[CLJ-137] Add math-context to with-bindings so it's set!-able at REPL

[CLJ-176] structs printed with print-dup true cannot be read