Clojure JIRA

[DCSV-4] \return as record separator with unquoted fields is read as part of the field

Wed, 24 Oct 2012 15:00:49 -0500

This regards the gray area of being "more forgiving." If I understand RFC 4180 correctly, I want to suggest substituting one bit of forgiveness for another: rather than supporting unquoted, multi-line cell values, I suggest supporting CSVs with just \return as the record-separator. Would you accept a patch for that?

A file with \return as record-separator is interpreted by read-csv as a single row like (["Header1" "Header2\rval1" "val2"]). I believe the RFC only allows fields to contain CR and LF when they're escaped (i.e., surrounded in double quotes). See the ABNF at the end of section 2.

As far as implementation, I believe this would require wrapping any Reader w/o markSupported in one that does, so that the LF following a CR can be consumed when present.

[I've classified this as a major defect because I ran into a \return-delimited file as soon as I passed a CSV from a Linux machine to a Windows machine, so I'm guessing these files are common. Feel free to reclassify.]

[DCSV-3] Some minor documentation typos

Fri, 15 Jun 2012 08:51:58 -0500

I found a couple minor typos: one in the README, one in a docstring. I've included a patch.

[DCSV-2] \return characters do not trigger value quoting

Tue, 14 Feb 2012 00:36:36 -0600

If the csv file contains \return characters the values are not quoted. A possible patch is attached.

[DCSV-1] pom.xml directives

Fri, 10 Feb 2012 04:59:36 -0600

If you build data.csv alone with the current pom.xml you get a couple of warnings and test are not executed. With the recent versions of Maven, these warnings can break the build.

A fixed (I hope!) version is attached.