http://dev.clojure.org/jira/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+MATCH+AND+updated%3E%3D-1w+ORDER+BY+updated+DESC An XML representation of a search request en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/MATCH-68 core.match <p>This fails with <tt>0.2.0-alpha12</tt>:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">(match [[:x]] [[m n &amp; _]] 1)</pre> </div></div> <p>I expect nil, but an unguarded <tt>subvec</tt> call throws an <tt>IndexOutOfBoundsException</tt>.</p> <p>A WIP patch is attached that fixes this (perhaps incorrectly) but which produced regressions (outside of core.match), e.g.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">(match [[[:x <span class="code-quote">"t"</span>]]] [[[:x &amp; a] &amp; tail]] :a [[[:y &amp; p] [:x &amp; a] &amp; tail]] :b) =&gt; nil</pre> </div></div> <p>The patch also "fixes" this (by changing <tt>pattern-compare</tt> behaviour for rest <tt>VectorPattern</tt> s, but that leads to a regression in the <tt>vector-pattern-rest-2</tt> testcase in core.match.</p> <p>(Original discussion with further background <a href="http://groups.google.com/group/clojure-dev/browse_thread/thread/cc2399f966489c6c?hl=en">here</a>.)</p> MATCH-68

Vector match "underflow" => IndexOutOfBoundsException

Defect Major Open Unresolved David Nolen Chas Emerick Mon, 22 Apr 2013 12:40:00 -0500 Sat, 18 May 2013 15:11:12 -0500 0 1 <p>FWIW, I've been using the patch described <a href="http://dev.clojure.org/jira/browse/MATCH-56">here</a>, and haven't yet run into any problems, though I also haven't used core.match that much. Anyway, with the change to subvec-inline, both of the cases here act as expected (producing nil and :a, respectively).</p> <p>(I note looking at my patch that I'm doubly-evaluating ocr in the second overload; obviously that should be fixed with a let binding).</p> <p>The patch looks like it's going in the right direction. Can you explain why your patch without the pattern-compares case causes the second example to fail?</p> Global Rank Patch Code and Test http://dev.clojure.org/jira/browse/MATCH-57 core.match <p>The following source example:</p> <p><a href="https://github.com/narkisr/match-issue/blob/master/src/match_issue/core.clj">https://github.com/narkisr/match-issue/blob/master/src/match_issue/core.clj</a></p> <p>The defrule macro calls a function called lhs that use the match library, </p> <p>this function calls it self recursively and print out the rest of body left to be matched, </p> <p>When running lein compile two different results appear (in non deterministic fashion):</p> <p>(when $message :&gt; Message (== level 6) :from (entry-point event-stream))<br/> ($message :&gt; Message (== level 6) :from (entry-point event-stream))<br/> (Message (== level 6) :from (entry-point event-stream))<br/> ((== level 6) :from (entry-point event-stream))</p> <p>This is the bug, as (== level 6) should be matched by:</p> <p>[([(<span class="error">&#91;(o :when operator?) f s&#93;</span> :seq) :as c &amp; r] :seq)]</p> <p>In other cases the output is (the correct one):</p> <p>(when $message :&gt; Message (== level 6) :from (entry-point event-stream))<br/> ($message :&gt; Message (== level 6) :from (entry-point event-stream))<br/> (Message (== level 6) :from (entry-point event-stream))<br/> ((== level 6) :from (entry-point event-stream))<br/> (:from (entry-point event-stream))<br/> (entry-point event-stream)<br/> ()<br/> ()</p> Clojure 1.3 <br/> <br/> Leiningen 1.7.1 on Java 1.6.0_26 <br/> <br/> core.match &quot;0.2.0-alpha9&quot; <br/> MATCH-57

Non deterministic match behavior for seqs when AOT

Defect Major Open Unresolved David Nolen Ronen Narkis Thu, 5 Apr 2012 19:47:42 -0500 Sat, 18 May 2013 14:29:42 -0500 0 0 <p>All AOT related issues w/o patches are low priority for the foreseeable future. They are simply too time consuming to track down and I don't have the bandwidth at the moment. I will get to them eventually, but if you want movement on this please submit a patch. I will happily apply it!</p> <p>Hey David, </p> <p>After going through the source code and some more in depth look I managed to understand what was going on, first iv stepped through the different stages</p> <p>(def m (emit-matrix <span class="error">&#91;&#39;body&#93;</span> <br/> '( [(<span class="error">&#91;&#39;when &amp; r&#93;</span> :seq)] (lhs r)<br/> [(<span class="error">&#91;&#39;accumulate &amp; r&#93;</span> :seq)] (&lt;&lt; "accumulate(~(lhs r))")<br/> [(<span class="error">&#91;bind &#39;:&gt; &amp; r&#93;</span> :seq)] (&lt;&lt; "~{bind}:~(lhs r)"); pattern with bind<br/> [(<span class="error">&#91;(t :when is-type?) &amp; r&#93;</span> :seq)] (&lt;&lt; "_{t}(lhs r)"); pattern <br/> [([(<span class="error">&#91;(f :when acc-fn?) &amp; args&#93;</span> :seq) &amp; r] :seq)] (&lt;&lt; ",_{f}{args}~(lhs r)" ); accumulate function<br/> [(<span class="error">&#91;&#39;:from dest &amp; r&#93;</span> :seq)] (&lt;&lt; "from ~(lhs dest) ~(lhs r)")<br/> [(<span class="error">&#91;&#39;:over win &amp; r&#93;</span> :seq)] (&lt;&lt; "over ~(window win) ~(lhs r)")<br/> [([(<span class="error">&#91;(o :when operator?) f s&#93;</span> :seq) :as c &amp; r] :seq)] (&lt;&lt; "(~(reduce str (map pr-str (to-infix c)))) ~(lhs r)")<br/> [(<span class="error">&#91;&#39;entry-point point &amp; r&#93;</span> :seq)] (&lt;&lt; "entry-point \"~{point}\"~(lhs r)")<br/> :else ""<br/> )))</p> <p>(def c (cm/compile m))</p> <p>(pprint c)</p> <p>(pprint (executable-form c))</p> <p>The last pprint failed aot compilation:</p> <p>$ lein compile</p> <p> ...<br/> Caused by: java.lang.ClassCastException: clojure.core.match.WildcardPattern cannot be cast to java.lang.String</p> <p>Which was very weird as I could clearly see that:</p> <p>(deftype WildcardPattern <span class="error">&#91;sym _meta&#93;</span><br/> IWildcardPattern<br/> (sym <span class="error">&#91;_&#93;</span> sym)<br/> clojure.lang.IObj<br/> (meta <span class="error">&#91;_&#93;</span> _meta)<br/> (withMeta <span class="error">&#91;_ new-meta&#93;</span><br/> (WildcardPattern. sym new-meta))<br/> Object<br/> (toString <span class="error">&#91;_&#93;</span><br/> (str sym)))</p> <p>Then iv also tried to enabled trace:</p> <p>(set-trace! true)</p> <p>Which resulted with:</p> <p>$ lein compile</p> <p>... </p> <p>TRACE: DAG: Column 0 : [#&lt;SeqPattern <a href="#&lt;WildcardPattern t&gt; #&lt;WildcardPattern unit&gt;">#&lt;LiteralPattern window&gt; #&lt;LiteralPattern :time&gt; #&lt;WildcardPattern t&gt; #&lt;WildcardPattern unit&gt;</a>&gt;]<br/> TRA at clojure.lang.Compiler.analyzeSeq(Compiler.java:6416)<br/> at clojure.lang.Compiler.analyze(Compiler.java:6216)<br/> at clojure.lang.Compiler.analyze(Compiler.java:6177)<br/> at clojure.lang.Compiler$BodyExpr$Parser.parse(Compiler.java:5572)<br/> at clojure.lang.Compiler$FnMethod.parse(Compiler.java:5008)<br/> at clojure.lang.Compiler$FnExpr.parse(Compiler.java:3629)<br/> at clojure.lang.Compiler.analyzeSeq(Compiler.java:6407)<br/> at clojure.lang.Compiler.analyze(Compiler.java:6216)<br/> at clojure.lang.Compiler.analyzeSeq(Compiler.java:6397)<br/> at clojure.lang.Compiler.analyze(Compiler.java:6216)<br/> at clojure.lang.Compiler.access$100(Compiler.java:37)<br/> at clojure.lang.Compiler$DefExpr$Parser.parse(Compiler.java:492)<br/> at clojure.lang.Compiler.analyzeSeq(Compiler.java:6409)<br/> at clojure.lang.Compiler.analyze(Compiler.java:6216)<br/> at clojure.lang.Compiler.analyze(Compiler.java:6177)<br/> at clojure.lang.Compiler.compile1(Compiler.java:6980)<br/> at clojure.lang.Compiler.compile(Compiler.java:7046)<br/> at clojure.lang.RT.compile(RTCE: DAG: Add switch-node on occurrence exp</p> <p>The most weird thing was that on second compile it all went well, this raised a flag and my suspicion was that the core.match classes got compiled on the first run:</p> <p>$ ls classes/</p> <p>match$analyze_actions$analyze_action__1166.class<br/> match$analyze_actions.class<br/> match$backtrack_expr.class<br/> match$bind_node.class<br/> match$catch_error.class<br/> match$check_matrix_args$check_pattern__1150.class<br/> ...</p> <p>Then iv decided to AOT compile clojure.core match:</p> <p>$ git checkout core.match-0.2.0-alpha9<br/> $ git diff project.clj<br/> -(defproject match "0.2.0-alpha10-SNAPSHOT"<br/> +(defproject match "0.2.0-alpha10-aot"<br/> :description "Optimized pattern matching and predicate dispatch for Clojure"<br/> :source-path "src/main/clojure"</p> <ul class="alternate" type="square"> <li>:test-path "src/test/clojure")<br/> + :test-path "src/test/clojure"<br/> + :aot <span class="error">&#91;clojure.core.match&#93;</span> <br/> + )</li> </ul> <p>After using the aot jar it all went smooth including passing my non deterministic case (which is deterministic but very confusing to track down), </p> <p>In order to reproduce it its important to run:</p> <p>$ lein clean <br/> $ rm -rf lib </p> <p>And only then run </p> <p>$ lein compile</p> <p>Otherwise the classes dir might contain AOT'ed classes and make it seem that even non-aot jar works fine (its enough to run lein compile once to cause the classes to get compiled), </p> <p>The fix in my case is simple, just AOT ns. </p> <p>Im not sure if this Is a bug in the way Clojure AOT its classes but I think that adding the AOT'ed classes to the default core match distro is a reasonable workaround </p> <p>BTW when using master (and not the tag) iv stumbled upon:</p> <p> Exception in thread "main" java.lang.AssertionError: Assert failed: Unknown predicate in <span class="error">&#91;is-type?&#93;</span></p> <p>Which is a pred defined in my ns.</p> Global Rank http://dev.clojure.org/jira/browse/MATCH-53 core.match <p>Code here:</p> <p><a href="https://gist.github.com/35fa11df7d7516abff50">https://gist.github.com/35fa11df7d7516abff50</a></p> <p>Running lein uberjar on source containing the offending function, geo-&gt;svg, results in a non-working application.<br/> However, if match is manually macroexpanded in the repl and the results pasted in, then the JAR works just fine.</p> MATCH-53

Match doesn't work when AOT compiled into a JAR, but manually macroexpanding and JAR'ing works fine.

Defect Major Open Unresolved David Nolen Kevin Lynagh Fri, 24 Feb 2012 14:21:34 -0600 Sat, 18 May 2013 14:25:39 -0500 0 2 <p>"non-working" meaning that the match always drops directly the :else clause.</p> <p>Updated code to minimal example. Problem persists with both Lein 1.7 and cake 0.6.3</p> <p>AOT bugs are a bit tricky to track down. Not sure how soon I'll be able to really dive into this one.</p> Global Rank http://dev.clojure.org/jira/browse/MATCH-51 core.match <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">(match (vector) ([(re :guard string?)] :seq) 4 [] 6)</pre> </div></div> <p>This should evaluate to 6 not nil. </p> MATCH-51

Fail to match empty vector

Defect Major Open Unresolved David Nolen Jason Jackson Sat, 21 Jan 2012 09:29:51 -0600 Sat, 18 May 2013 14:24:24 -0500 0 0 <p>tested on 0.2.0-alpha10-SNAPSHOT</p> Global Rank http://dev.clojure.org/jira/browse/MATCH-54 core.match <p>If you try to AOT this code, you get an exception.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">(defn -main [&amp; args] (println args) (let [x nil] (match x [<span class="code-quote">"="</span> _ _] <span class="code-keyword">true</span> [[:invoke _] _] <span class="code-keyword">true</span>)))</pre> </div></div> <p>Stack Trace:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">Compiling foo.core Exception in thread <span class="code-quote">"main"</span> java.lang.IndexOutOfBoundsException, compiling:(foo/core.clj:8) at clojure.lang.<span class="code-object">Compiler</span>.analyzeSeq(<span class="code-object">Compiler</span>.java:6416) at clojure.lang.<span class="code-object">Compiler</span>.analyze(<span class="code-object">Compiler</span>.java:6216) at clojure.lang.<span class="code-object">Compiler</span>.analyze(<span class="code-object">Compiler</span>.java:6177) at clojure.lang.<span class="code-object">Compiler</span>$BodyExpr$Parser.parse(<span class="code-object">Compiler</span>.java:5572) at clojure.lang.<span class="code-object">Compiler</span>$LetExpr$Parser.parse(<span class="code-object">Compiler</span>.java:5873) at clojure.lang.<span class="code-object">Compiler</span>.analyzeSeq(<span class="code-object">Compiler</span>.java:6409) at clojure.lang.<span class="code-object">Compiler</span>.analyze(<span class="code-object">Compiler</span>.java:6216) at clojure.lang.<span class="code-object">Compiler</span>.analyzeSeq(<span class="code-object">Compiler</span>.java:6397) at clojure.lang.<span class="code-object">Compiler</span>.analyze(<span class="code-object">Compiler</span>.java:6216) at clojure.lang.<span class="code-object">Compiler</span>.analyze(<span class="code-object">Compiler</span>.java:6177) at clojure.lang.<span class="code-object">Compiler</span>$BodyExpr$Parser.parse(<span class="code-object">Compiler</span>.java:5572) at clojure.lang.<span class="code-object">Compiler</span>$FnMethod.parse(<span class="code-object">Compiler</span>.java:5008) at clojure.lang.<span class="code-object">Compiler</span>$FnExpr.parse(<span class="code-object">Compiler</span>.java:3629) at clojure.lang.<span class="code-object">Compiler</span>.analyzeSeq(<span class="code-object">Compiler</span>.java:6407) at clojure.lang.<span class="code-object">Compiler</span>.analyze(<span class="code-object">Compiler</span>.java:6216) at clojure.lang.<span class="code-object">Compiler</span>.analyzeSeq(<span class="code-object">Compiler</span>.java:6397) at clojure.lang.<span class="code-object">Compiler</span>.analyze(<span class="code-object">Compiler</span>.java:6216) at clojure.lang.<span class="code-object">Compiler</span>.access$100(<span class="code-object">Compiler</span>.java:37) at clojure.lang.<span class="code-object">Compiler</span>$DefExpr$Parser.parse(<span class="code-object">Compiler</span>.java:492) at clojure.lang.<span class="code-object">Compiler</span>.analyzeSeq(<span class="code-object">Compiler</span>.java:6409) at clojure.lang.<span class="code-object">Compiler</span>.analyze(<span class="code-object">Compiler</span>.java:6216) at clojure.lang.<span class="code-object">Compiler</span>.analyze(<span class="code-object">Compiler</span>.java:6177) at clojure.lang.<span class="code-object">Compiler</span>.compile1(<span class="code-object">Compiler</span>.java:6980) at clojure.lang.<span class="code-object">Compiler</span>.compile(<span class="code-object">Compiler</span>.java:7046) at clojure.lang.RT.compile(RT.java:385) at clojure.lang.RT.load(RT.java:425) at clojure.lang.RT.load(RT.java:398) at clojure.core$load$fn__4610.invoke(core.clj:5386) at clojure.core$load.doInvoke(core.clj:5385) at clojure.lang.RestFn.invoke(RestFn.java:408) at clojure.core$load_one.invoke(core.clj:5200) at clojure.core$compile$fn__4615.invoke(core.clj:5397) at clojure.core$compile.invoke(core.clj:5396) at user$eval27.invoke(NO_SOURCE_FILE:1) at clojure.lang.<span class="code-object">Compiler</span>.eval(<span class="code-object">Compiler</span>.java:6465) at clojure.lang.<span class="code-object">Compiler</span>.eval(<span class="code-object">Compiler</span>.java:6455) at clojure.lang.<span class="code-object">Compiler</span>.eval(<span class="code-object">Compiler</span>.java:6431) at clojure.core$eval.invoke(core.clj:2795) at clojure.main$eval_opt.invoke(main.clj:296) at clojure.main$initialize.invoke(main.clj:315) at clojure.main$null_opt.invoke(main.clj:348) at clojure.main$main.doInvoke(main.clj:426) at clojure.lang.RestFn.invoke(RestFn.java:421) at clojure.lang.Var.invoke(Var.java:405) at clojure.lang.AFn.applyToHelper(AFn.java:163) at clojure.lang.Var.applyTo(Var.java:518) at clojure.main.main(main.java:37) Caused by: java.lang.IndexOutOfBoundsException at clojure.lang.PersistentVector.arrayFor(PersistentVector.java:106) at clojure.lang.PersistentVector.nth(PersistentVector.java:110) at clojure.lang.RT.nth(RT.java:741) at clojure.core.match.PatternRow.invoke(match.clj:327) at clojure.core.match.PatternMatrix.pattern_at(match.clj:713) at clojure.core.match$useful_p_QMARK_.invoke(match.clj:778) at clojure.core.match.PatternMatrix$iter__832__838$fn__839$iter__834__840$fn__841$fn__842.invoke(match.clj:735) at clojure.core.match.PatternMatrix$iter__832__838$fn__839$iter__834__840$fn__841.invoke(match.clj:733) at clojure.lang.LazySeq.sval(LazySeq.java:42) at clojure.lang.LazySeq.seq(LazySeq.java:60) at clojure.lang.RT.seq(RT.java:466) at clojure.core$seq.invoke(core.clj:133) at clojure.core.match.PatternMatrix$iter__832__838$fn__839.invoke(match.clj:734) at clojure.lang.LazySeq.sval(LazySeq.java:42) at clojure.lang.LazySeq.seq(LazySeq.java:67) at clojure.lang.RT.seq(RT.java:466) at clojure.core$seq.invoke(core.clj:133) at clojure.core$partition$fn__3913.invoke(core.clj:2777) at clojure.lang.LazySeq.sval(LazySeq.java:42) at clojure.lang.LazySeq.seq(LazySeq.java:60) at clojure.lang.RT.seq(RT.java:466) at clojure.core$seq.invoke(core.clj:133) at clojure.core$map$fn__3811.invoke(core.clj:2424) at clojure.lang.LazySeq.sval(LazySeq.java:42) at clojure.lang.LazySeq.seq(LazySeq.java:60) at clojure.lang.Cons.next(Cons.java:39) at clojure.lang.PersistentVector.create(PersistentVector.java:50) at clojure.lang.LazilyPersistentVector.create(LazilyPersistentVector.java:31) at clojure.core$vec.invoke(core.clj:345) at clojure.core.match.PatternMatrix.useful_matrix(match.clj:733) at clojure.core.match.PatternMatrix.necessary_column(match.clj:725) at clojure.core.match.PatternMatrix$choose_column__815.invoke(match.clj:690) at clojure.core.match.PatternMatrix.compile(match.clj:708) at clojure.core.match$first_column_chosen_case$switch_clauses__780$fn__781.invoke(match.clj:613) at clojure.core$map$fn__3815.invoke(core.clj:2437) at clojure.lang.LazySeq.sval(LazySeq.java:42) at clojure.lang.LazySeq.seq(LazySeq.java:60) at clojure.lang.RT.seq(RT.java:466) at clojure.core$seq.invoke(core.clj:133) at clojure.core$reduce.invoke(core.clj:5994) at clojure.core$into.invoke(core.clj:6004) at clojure.core.match$first_column_chosen_case$switch_clauses__780.invoke(match.clj:616) at clojure.core.match$first_column_chosen_case.invoke(match.clj:646) at clojure.core.match.PatternMatrix.compile(match.clj:710) at clojure.core.match$first_column_chosen_case$switch_clauses__780$fn__781.invoke(match.clj:613) at clojure.core$map$fn__3815.invoke(core.clj:2437) at clojure.lang.LazySeq.sval(LazySeq.java:42) at clojure.lang.LazySeq.seq(LazySeq.java:60) at clojure.lang.RT.seq(RT.java:466) at clojure.core$seq.invoke(core.clj:133) at clojure.core$reduce.invoke(core.clj:5994) at clojure.core$into.invoke(core.clj:6004) at clojure.core.match$first_column_chosen_case$switch_clauses__780.invoke(match.clj:616) at clojure.core.match$first_column_chosen_case.invoke(match.clj:646) at clojure.core.match.PatternMatrix.compile(match.clj:710) at clojure.core.match$clj_form.invoke(match.clj:1616) at clojure.core.match$match.doInvoke(match.clj:1645) at clojure.lang.RestFn.invoke(RestFn.java:573) at clojure.lang.Var.invoke(Var.java:426) at clojure.lang.AFn.applyToHelper(AFn.java:193) at clojure.lang.Var.applyTo(Var.java:518) at clojure.lang.<span class="code-object">Compiler</span>.macroexpand1(<span class="code-object">Compiler</span>.java:6320) at clojure.lang.<span class="code-object">Compiler</span>.analyzeSeq(<span class="code-object">Compiler</span>.java:6395) ... 46 more</pre> </div></div> MATCH-54

Cannot AOT with certain match expression.

Defect Major Open Unresolved David Nolen Jason Jackson Sun, 4 Mar 2012 16:42:23 -0600 Sat, 18 May 2013 14:22:38 -0500 0 0 Global Rank http://dev.clojure.org/jira/browse/MATCH-59 core.match <p>I was looking at the code for clojure.core.match.bits, and there seems to be a reference to an example of parsing a dgram. The code looks to be broken or incomplete, or is it my understanding of it that is lacking?</p> <p>If it isn't done, are there any plans to finish it up?</p> MATCH-59

Misleading comment in clojure.core.match.bits

Enhancement Major Resolved Completed David Nolen Thomas Greve Kristensen Sat, 19 May 2012 08:22:21 -0500 Sat, 18 May 2013 14:21:34 -0500 Sat, 18 May 2013 14:21:34 -0500 0 0 <p>The bits and array namespaces are experimental I've left a comment in both namespaces that states that.</p> <p><a href="http://github.com/clojure/core.match/commit/511b786b9545f5c00a629fa27be0ee2a6b01e2ae">http://github.com/clojure/core.match/commit/511b786b9545f5c00a629fa27be0ee2a6b01e2ae</a></p> Global Rank http://dev.clojure.org/jira/browse/MATCH-66 core.match <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">=&gt; (match 3 x x) CompilerException java.lang.RuntimeException: Unable to resolve symbol: ocr-34984 in <span class="code-keyword">this</span> context, compiling:(NO_SOURCE_PATH:1:1) =&gt; (macroexpand '(match 3 x x)) (let* [x ocr-35001] x)</pre> </div></div> <p>(Discussed briefly <a href="http://groups.google.com/group/clojure/msg/50ece364d68e4d74">here</a>.)</p> MATCH-66

Cannot match entire/single value

Defect Major Resolved Completed David Nolen Chas Emerick Sun, 6 Jan 2013 14:42:29 -0600 Sat, 18 May 2013 14:18:33 -0500 Sat, 18 May 2013 14:18:33 -0500 1 0 <p>fixed, <a href="http://github.com/clojure/core.match/commit/02a833efb959e0518f264ded3b98ce4215b5622c">http://github.com/clojure/core.match/commit/02a833efb959e0518f264ded3b98ce4215b5622c</a></p> Global Rank