http://dev.clojure.org/jira/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+TRDR+ORDER+BY+updated+DESC%2C+priority+DESC%2C+created+ASC An XML representation of a search request en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/TRDR-6 tools.reader <p>Attached patch uses type hints to eliminate several instances of reflection in the tools.reader code.</p> <p>FYI, you can run 'lein check' to cause Leiningen to compile the code with <b>warn-on-reflection</b> true, I believe for every source file (not sure about the tests, but reflection isn't such a big deal in them anyway).</p> TRDR-6

Some uses of reflection in tools.reader code slow it down unnecessarily

Enhancement Minor Closed Completed Nicola Mometto Andy Fingerhut Sat, 13 Apr 2013 11:53:13 -0500 Sat, 13 Apr 2013 14:43:14 -0500 Sat, 13 Apr 2013 13:17:25 -0500 0 0 <p>Andy, I don't see any patch attached to this ticket, I think you forgot to attach it.</p> <p>(P.S. thanks, I didn't know about 'lein check')</p> <p>Patch trdr-6-eliminate-reflection-with-type-hints-patch-v1.txt dated Apr 13 2013 eliminates all occurrences of reflection found in latest version of tools.reader. Please check them carefully before committing them, especially the ones in default_data_readers.clj.</p> <p>And I know the reflection warnings in default_data_readers.clj exist in Clojure's code, too, where you copied those from. <a href="http://dev.clojure.org/jira/browse/CLJ-1080" title="Eliminate many uses of reflection in Clojure code">CLJ-1080</a> has a patch addressing those and many other reflections within Clojure's code.</p> <p>Andy, casting to char makes tools.reader crash under clojure-1.3, apparently casting to char is possible only from clojure 1.4.</p> <p>Could you please submit a patch removing reflection in default_data_readers.clj and the docstring fixes only while I try to figure out a way to maintain clojure 1.3 compatibility and remove the reflection? (or if you have an idea on how to do it, you're more than welcome <img class="emoticon" src="http://dev.clojure.org/jira/images/icons/emoticons/smile.gif" height="20" width="20" align="absmiddle" alt="" border="0"/>)</p> <p>EDIT:<br/> I edited your patch manually, and pushed a commit to type hint to char only for &gt;clojure-1.3.0<br/> I don't know if there is a way to avoid the reflection from clojure 1.3.0, but for the all the other versions of clojure all reflection is gone, thanks!</p> <p>Great. I was off-line there for a while, but glad you noticed the 1.3 compatibility issue where I didn't, and glad you found a different way to eliminate reflection with 1.4 and later.</p> Global Rank Patch Code http://dev.clojure.org/jira/browse/TRDR-5 tools.reader <p>Suggested addition to "Differences from LispReader.java" section of README.md:</p> <p>read is capable of reading the symbol / with an explicit namespace, e.g. foo//, whereas clojure.lang.LispReader/read throws an exception. Refer to <a href="http://dev.clojure.org/jira/browse/CLJ-873" title="Allow the function / to be referred to in namespaces other than clojure.core">CLJ-873</a>. Except for this special case, read throws an exception if a symbol contains more than one / character, whereas clojure.lang.LispReader/read allows them, returning a symbol with one or more / characters in its namespace name.</p> TRDR-5

Additional "Differences from LispReader.java" for README

Enhancement Minor Closed Completed Nicola Mometto Andy Fingerhut Mon, 8 Apr 2013 00:05:57 -0500 Wed, 10 Apr 2013 05:20:01 -0500 Wed, 10 Apr 2013 05:20:01 -0500 0 0 <p>Thanks, fixed <a href="https://github.com/clojure/tools.reader/commit/f689cb283d1fb539a6cabbefd4036f620dabe693">https://github.com/clojure/tools.reader/commit/f689cb283d1fb539a6cabbefd4036f620dabe693</a></p> Global Rank http://dev.clojure.org/jira/browse/TRDR-3 tools.reader <p>You mention the enhanced version of read-line that takes a reader argument in the README, but it seems like it is only available in the clojure.tools.reader.reader-types namespace. Is that intentional? Perhaps making it available in the clojure.tools.reader and/or clojure.tools.reader.edn namespace might be more convenient for the user of the library? I understand that the current implementation of read-line is Java-specific, so maybe this is the only reasonable way to expose it.</p> <p>In any case, documenting the namespace in which this enhanced read-line is available in the README would be good.</p> TRDR-3

Make read-line available in clojure.tools.reader and/or clojure.tools.reader.edn namespace?

Enhancement Minor Closed Completed Nicola Mometto Andy Fingerhut Fri, 15 Mar 2013 08:00:15 -0500 Fri, 15 Mar 2013 19:04:43 -0500 Fri, 15 Mar 2013 10:26:29 -0500 0 0 <p>I added more documentation on the readme, making it clear in which namespace read-line is defined.<br/> (<a href="https://github.com/clojure/tools.reader#public-api">https://github.com/clojure/tools.reader#public-api</a>, <a href="https://github.com/clojure/tools.reader#differences-from-lispreaderjava">https://github.com/clojure/tools.reader#differences-from-lispreaderjava</a>)</p> <p>read-line definitely belongs in the c.t.r.reader-types namespace, since it works on reader-types and returns a string, so it's not a reader function.</p> <p>I hope this addresses this ticket, I'm closing it, feel free to reopen it you think the doc needs to be more clear.</p> <p>Looks thoroughly documented to me &#8211; above and beyond what I would have asked for. Thanks.</p> Global Rank http://dev.clojure.org/jira/browse/TRDR-4 tools.reader <p>Just a miniscule typo</p> TRDR-4

Typo: Change 'end' to 'edn' in 'clojure.tools.reader.end/read-string' in README

Enhancement Trivial Closed Completed Nicola Mometto Andy Fingerhut Fri, 15 Mar 2013 08:17:34 -0500 Fri, 15 Mar 2013 09:50:55 -0500 Fri, 15 Mar 2013 09:50:47 -0500 0 0 <p>Fixed, thanks</p> Global Rank http://dev.clojure.org/jira/browse/TRDR-2 tools.reader <p>There are a few typos in the README</p> TRDR-2

Fix a few README typos

Enhancement Minor Resolved Completed Nicola Mometto Andy Fingerhut Thu, 14 Feb 2013 15:15:31 -0600 Fri, 15 Feb 2013 04:19:48 -0600 Fri, 15 Feb 2013 04:19:48 -0600 0 0 <p>Nothing major here. Just a few typo fixes for the README that I found.</p> <p>Thanks, applied</p> Global Rank Patch Code http://dev.clojure.org/jira/browse/TRDR-1 tools.reader <p>The return value from Java's .read method is -1 for EOF. A couple of condition checks in the code appear to be reversed. See the patch.</p> TRDR-1

read-char returns nil for some input types, on first attempt to read a char

Defect Major Resolved Completed Andy Fingerhut Andy Fingerhut Tue, 12 Feb 2013 16:15:57 -0600 Tue, 12 Feb 2013 19:50:05 -0600 Tue, 12 Feb 2013 19:50:05 -0600 0 0 <p>Thanks, tests for reader-types are now on the TODO list </p> Global Rank Patch Code